Re: [PATCH] tcmu: remove useless code and clean up the code style.

2018-06-07 Thread Mike Christie
On 06/07/2018 01:31 AM, xiu...@redhat.com wrote: > From: Xiubo Li > > Since the TCMU_RING_SIZE macro is not using here will discard it > and at the same time clean up the code style. > > Signed-off-by: Xiubo Li > --- > drivers/target/target_core_user.c | 8 ++-- > 1 file changed, 2

Re: mpt3sas heavy I/O load causes kernel BUG at block/blk-core.c:2695

2018-06-07 Thread Douglas Miller
Thanks, Suganath, That commit was introduced with version 12.100.00.00 and the distro version we're running is 15.100.00.01 (RHEL-ALT 7.5) and appears to include this fix - although the code is not identical, probably due to the effects of backporting patches. This driver also does not

[PATCH] scsi: qla2xxx: Recursive spinlock in qla_target

2018-06-07 Thread m.malygin
From: Mikhail Malygin The patch addresses issue causing recursive spinlock in qla_target.c. qlt_handle_login takes vha->hw->tgt.sess_lock, then calls qlt_schedule_sess_for_deletion where it tries to take spinlock again: BUG: spinlock lockup suspected on CPU#0, swapper/0/0 lock:

Possible race in completion with SRP after abort with latest upstream kernel 4.17.0+

2018-06-07 Thread Laurence Oberman
Hello Bart Have not seen this more than twice but during testing of latest upstream kernel with SRP I have had two of these completion races. 4.17.0+ [49945.984133] sd 2:0:0:29: alua: transition timeout set to 60 seconds [49945.984136] sd 2:0:0:29: alua: port group 00 state A non-preferred

Re: Possible race in completion with SRP after abort with latest upstream kernel 4.17.0+

2018-06-07 Thread Laurence Oberman
On Thu, 2018-06-07 at 15:21 +, Bart Van Assche wrote: > On Thu, 2018-06-07 at 09:23 -0400, Laurence Oberman wrote: > > Have you seen this before, let me know what else you want from the > > dump > > while I look further. > > Hello Laurence, > > I haven't seen this before and I can't

Re: Possible race in completion with SRP after abort with latest upstream kernel 4.17.0+

2018-06-07 Thread Bart Van Assche
On Thu, 2018-06-07 at 09:23 -0400, Laurence Oberman wrote: > Have you seen this before, let me know what else you want from the dump > while I look further. Hello Laurence, I haven't seen this before and I can't reproduce this by running srp-tests against Linus' latest master. So it would be

Re: [PATCH] qla2xxx: Mask off Scope bits in retry delay.

2018-06-07 Thread Martin K. Petersen
Himanshu, > Some newer target uses "Status Qualifier" response in a returned "Busy > Status". This new response code of 0x4001, which is "Scope" bits, > translates to "Affects all units accessible by target". Due to this > new value returned in the Scope bits, driver was using that value as >

Re: [PATCH 0/3] scsi: be2iscsi: Deprecate BE3 family adapters

2018-06-07 Thread Martin K. Petersen
Jitendra, > This patch is generated against for-next branch. Applied patches 1 and 3 to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/5] megaraid_sas: Driver updates

2018-06-07 Thread Martin K. Petersen
Shivasharan, > megaraid_sas: Do not do Kill adapter if GET_CTRL_INFO times out > megaraid_sas: Update controller info during resume > megaraid_sas: Return immediately from wait_for_adapter_operational > after kill adapter > megaraid_sas: Support FW provided TM timeout values >

Re: [PATCH 00/12] qla2xxx: Updates for driver

2018-06-07 Thread Martin K. Petersen
Himanshu, > This series contains bug-fixes for driver mainly in the area of > interaction with switch and small patch for N2N link reconnect. Applied to 4.19/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] tcmu: remove useless code and clean up the code style.

2018-06-07 Thread Martin K. Petersen
Xiubo, > Since the TCMU_RING_SIZE macro is not using here will discard it and > at the same time clean up the code style. Applied to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/6] mpt3sas: Enhancements and Defect fixes.

2018-06-07 Thread Martin K. Petersen
Chaitra, > Chaitra P B (6): > mpt3sas: Don't abort I/Os issued to NVMe drives while processing > Async Broadcast primitive event. > mpt3sas: Incorrect command status was set/marked as not used. > mpt3sas: Don't access the structure after decrementing it's > instance reference

Re: [PATCH 0/5] megaraid_sas: Driver updates

2018-06-07 Thread Martin K. Petersen
Shivasharan, >> megaraid_sas: Return immediately from wait_for_adapter_operational >> after kill adapter The comment I made to Chaitra about long patch header lines also applies in this case. Please keep the line length to about 70 chars in the header and

Re: [PATCH] ipr: Format HCAM overlay ID 0x41

2018-06-07 Thread Martin K. Petersen
Wen, > This patch adds formatting error overlay 0x41 to improve debug > capabilities. Applied to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] tcmu: remove useless code and clean up the code style.

2018-06-07 Thread Xiubo Li
On 2018/6/8 9:35, Martin K. Petersen wrote: Xiubo, Since the TCMU_RING_SIZE macro is not using here will discard it and at the same time clean up the code style. Applied to 4.19/scsi-queue. Thanks! Thanks very much. BRs

[PATCH] tcmu: remove useless code and clean up the code style.

2018-06-07 Thread xiubli
From: Xiubo Li Since the TCMU_RING_SIZE macro is not using here will discard it and at the same time clean up the code style. Signed-off-by: Xiubo Li --- drivers/target/target_core_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] qla2xxx: Mask off Scope bits in retry delay.

2018-06-07 Thread Martin Wilck
On Wed, 2018-06-06 at 08:41 -0700, Himanshu Madhani wrote: > From: Anil Gurumurthy > > Some newer target uses "Status Qualifier" response in a returned > "Busy Status". This new response code of 0x4001, which is "Scope" > bits, > translates to "Affects all units accessible by target". > Due to

[PATCH 0/3] scsi: be2iscsi: Deprecate BE3 family adapters

2018-06-07 Thread Jitendra Bhivare
This patch is generated against for-next branch. Jitendra Bhivare (1): scsi: be2iscsi: Include null char in SET_HOST_DATA Ketan Mukadam (2): scsi: be2iscsi: Add warnings for unsupported adapters scsi: be2iscsi: Update copyright drivers/scsi/be2iscsi/be_cmds.c | 2 +-

[PATCH 1/3] scsi: be2iscsi: Include null char in SET_HOST_DATA

2018-06-07 Thread Jitendra Bhivare
FW needs NULL terminated driver version string. Signed-off-by: Ketan Mukadam Reviewed-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index

[PATCH 2/3] scsi: be2iscsi: Add warnings for unsupported adapters

2018-06-07 Thread Jitendra Bhivare
From: Ketan Mukadam Add a warning message to indicate obsolete/unsupported BE3 Adapter Family devices. Signed-off-by: Ketan Mukadam Reviewed-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 3 ++- 2 files changed, 4 insertions(+), 1

[PATCH 3/3] scsi: be2iscsi: Update copyright

2018-06-07 Thread Jitendra Bhivare
From: Ketan Mukadam Update Broadcom copyright markings in all modified files. Signed-off-by: Ketan Mukadam Reviewed-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_iscsi.c | 15 +-- drivers/scsi/be2iscsi/be_main.c | 23 +-- drivers/scsi/be2iscsi/be_mgmt.c

Re: mpt3sas heavy I/O load causes kernel BUG at block/blk-core.c:2695

2018-06-07 Thread Suganath Prabu Subramani
Hi Douglas, Can you check if this patch is already part of driver, If not please try with below patch. This patch is to fix the completion of abort before the IO completion. With this, driver will process IO's reply first followed by TM. authorSuganath prabu Subramani 2016-01-28 12:07:06 +0530

Re: [PATCH 2/3] scsi: be2iscsi: Add warnings for unsupported adapters

2018-06-07 Thread Johannes Thumshirn
On Thu, Jun 07, 2018 at 01:54:42PM +0530, Jitendra Bhivare wrote: > From: Ketan Mukadam > > Add a warning message to indicate obsolete/unsupported > BE3 Adapter Family devices. Ahm no. The upstream Linux kernel doesn't deprecate specific hardware. -- Johannes Thumshirn