Re: [PATCH 2/2] qla2xxx: remove irq save in qla2x00_poll()

2018-06-18 Thread Madhani, Himanshu
> On May 4, 2018, at 7:50 AM, Sebastian Andrzej Siewior > wrote: > > In commit d2ba5675d899 ("[SCSI] qla2xxx: Disable local-interrupts while > polling for RISC status.") added a local_irq_disable() before invoking > the ->intr_handler callback. The function, which was used in this > callback,

[PATCH 3/5] smartpqi: add inspur advantech ids

2018-06-18 Thread Don Brace
From: Kevin Barnett - add support for these new device IDs: Advantech MIC-8312BridgeB INSPUR PM8204-2GB INSPUR PM8204-4GB INSPUR PM8222-SHBA Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 16

[PATCH 4/5] smartpqi: fix critical ARM issue reading PQI index registers

2018-06-18 Thread Don Brace
From: Kevin Barnett - use the readl() kernel function to read all index registers. For ARM systems, this function includes a read memory barrier that eliminates ci/pi corruption. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 0/5] smartpqi updates

2018-06-18 Thread Don Brace
These patches are based on Linus's tree The changes are: - improve handling for sync requests ensure controller is ready for requests - improve-error-checking-for-sync-requests detect rare error cases for synchronous requests - add more supported devices - fix critical ARM issue

[PATCH 1/5] smartpqi: improve handling for sync requests

2018-06-18 Thread Don Brace
From: Kevin Barnett - decrement the active thread count after the synchronous request was submitted to the controller but before the driver blocks to wait for the request to complete. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 5/5] smartpqi: bump driver version to 1.1.4-130

2018-06-18 Thread Don Brace
Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index

[PATCH 2/5] smartpqi: improve error checking for sync requests

2018-06-18 Thread Don Brace
From: Kevin Barnett - detect rare error cases for synchronous requests down the RAID path - retry INQUIRY of VPD page 0 sent to an HBA drive if the command failed due to an abort. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

Re: [PATCH 01/33] TCMU PR: first commit to implement TCMU PR

2018-06-18 Thread Christoph Hellwig
On Sat, Jun 16, 2018 at 02:20:12PM -0500, Mike Christie wrote: > Just wanted to make sure I understood this comment. In Lingshan's > patches I think he was going to end up calling out to > userspace/tcmu-runner and there he was going to make ceph calls which > basically translate PGR operations to

Re: [PATCH 01/33] TCMU PR: first commit to implement TCMU PR

2018-06-18 Thread David Disseldorp
On Mon, 18 Jun 2018 04:12:17 -0700, Christoph Hellwig wrote: > On Sun, Jun 17, 2018 at 12:40:56PM +0800, Zhu Lingshan wrote: > > Hello Mike and Christoph, > > Thanks Mike's comment inspired me, if I understand this correctly, it is > > suggested to implement this whole solution in kernel, avoid >

Re: [PATCH 01/33] TCMU PR: first commit to implement TCMU PR

2018-06-18 Thread Christoph Hellwig
On Sat, Jun 16, 2018 at 02:25:47PM -0500, Mike Christie wrote: > > Just wanted to make sure I understood this comment. In Lingshan's > > patches I think he was going to end up calling out to > > userspace/tcmu-runner and there he was going to make ceph calls which > > basically translate PGR

Re: [PATCH 01/33] TCMU PR: first commit to implement TCMU PR

2018-06-18 Thread Christoph Hellwig
On Sun, Jun 17, 2018 at 12:40:56PM +0800, Zhu Lingshan wrote: > Hello Mike and Christoph, > Thanks Mike's comment inspired me, if I understand this correctly, it is > suggested to implement this whole solution in kernel, avoid >  splitting PRG handling in both kernel and userspace, make it not

Re: Obtain file's inode in ufshcd driver

2018-06-18 Thread Julian Calaby
Hi Roman, On Fri, Jun 1, 2018 at 4:25 AM Roman Storozhenko wrote: > > Hello everybody. > > I am modifying ufshcd driver: > https://elixir.bootlin.com/linux/v3.8/source/drivers/scsi/ufs/ufshcd.c > > I do a read of a file on ext4 filesystem and want to obtain the file's > inode. But it seems that

Re: [PATCH 01/33] TCMU PR: first commit to implement TCMU PR

2018-06-18 Thread Zhu Lingshan
On 2018/6/18 19:12, Christoph Hellwig wrote: On Sun, Jun 17, 2018 at 12:40:56PM +0800, Zhu Lingshan wrote: Hello Mike and Christoph, Thanks Mike's comment inspired me, if I understand this correctly, it is suggested to implement this whole solution in kernel, avoid  splitting PRG handling

Re: [patch] sg: clean up gfp_mask in sg_build_indirect

2018-06-18 Thread Douglas Gilbert
On 2018-06-18 09:57 AM, Jeff Moyer wrote: commit a45b599ad808c ("scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()") changed the call to alloc_pages to always use __GFP_ZERO. Just above that, though, there was this: if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))

[patch] sg: clean up gfp_mask in sg_build_indirect

2018-06-18 Thread Jeff Moyer
commit a45b599ad808c ("scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()") changed the call to alloc_pages to always use __GFP_ZERO. Just above that, though, there was this: if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO)) gfp_mask |= __GFP_ZERO; And there's

Re: [PATCH 2/2] qla2xxx: remove irq save in qla2x00_poll()

2018-06-18 Thread Martin K. Petersen
Himanshu, >> In commit d2ba5675d899 ("[SCSI] qla2xxx: Disable local-interrupts while >> polling for RISC status.") added a local_irq_disable() before invoking >> the ->intr_handler callback. The function, which was used in this >> callback, did not disable interrupts while acquiring the

Re: [patch] sg: clean up gfp_mask in sg_build_indirect

2018-06-18 Thread Martin K. Petersen
Jeff, > And there's only one user of the gfp_mask. Just or in the __GFP_ZERO > flag at the top of the function and be done with it. Applied to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host

2018-06-18 Thread Martin K. Petersen
Jason, > So we have to change this embedded static ata host to a dynamically > allocated ata host and initialize the ->kref member. To use > ata_host_get() and ata_host_put() in libsas, we need to move the > declaration of these functions to the public libata.h and export them. Took a while

Re: [PATCH v2 5/8] mpt3sas: Fix _transport_smp_handler() error path

2018-06-18 Thread Christoph Hellwig
On Fri, Jun 15, 2018 at 02:41:58PM -0700, Bart Van Assche wrote: > This patch avoids that smatch complains about a double unlock on > ioc->transport_cmds.mutex. Looks good, Reviewed-by: Christoph Hellwig