On Fri, Sep 21, 2018 at 12:44:22PM +0300, Avri Altman wrote:
> The UFS host software uses a combination of a host register set,
> and Transfer Request Descriptors in system memory to communicate
> with host controller hardware. In its mmio space, a separate places
> are assigned to UTP Transfer
Hi Avri,
this looks generally good to me, but I'd suggest two small tweaks:
- please split out a new prep patch that creates
include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
- pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
new file
Looks good,
Reviewed-by: Christoph Hellwig
Please send this to linux-nvme and CC the nvme-fc maintainer.
Without an ACK from the latter, I'll have to NACK it with my nvme
maintainer hat on.
Looks good,
Reviewed-by: Christoph Hellwig
> On Sep 26, 2018, at 7:34 AM, Christoph Hellwig wrote:
>
> External Email
>
> Please send this to linux-nvme and CC the nvme-fc maintainer.
>
> Without an ACK from the latter, I'll have to NACK it with my nvme
> maintainer hat on.
Sure. will send series to the requested maintainers.
> On Sep 20, 2018, at 3:02 AM, Dan Carpenter wrote:
>
> External Email
>
> We shouldn't allow negative thresholds. I don't know what it would do
> but it can't be good.
>
> Fixes: 8b4673ba3a1b ("scsi: qla2xxx: Add support for ZIO6 interrupt
> threshold")
> Signed-off-by: Dan Carpenter
>
Avri,
> this looks generally good to me, but I'd suggest two small tweaks:
>
> - please split out a new prep patch that creates
>include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
>new file
Also, when you
From: Anil Gurumurthy
This patch Adds following code in the driver to
support FC-NVMe Target
- Updated ql2xenablenvme to allow FC-NVMe Target operation
- Added Link Serviccce Request handling for NVMe Target
- Added passthru IOCB for LS4 request
- Added CTIO for sending response to FW
- Added
Hi Martin,
This series adds support for FC-NVMe Target.
Patch #1 addes new qla_nvmet files for FC-NVMe Target support.
Patch #2 adds Kconfig and Makefile changes to prepare code compile.
Patch #3, #4 has bulk of changes to handle FC-NVMe Target LS4 processing
via Purex pass through
From: Anil Gurumurthy
This patch adds SysFS node for NVMe Target configuration
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 33 +
drivers/scsi/qla2xxx/qla_gs.c| 2 +-
drivers/scsi/qla2xxx/qla_init.c
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 12bafff71a1a..0d58aa629c08 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
From: Anil Gurumurthy
This patch provides link service pass through feature handling
in the driver. This feature is implemented mainly by the firmware
and the same implementation is handled in the driver via an
IOCB interface.
Signed-off-by: Anil Gurumurthy
Signed-off-by: Giridhar Malavali
From: Anil Gurumurthy
This patch adds initial files to enable NVMe Target Support
Signed-off-by: Anil Gurumurthy
Signed-off-by: Giridhar Malavali
Signed-off-by: Darren Trapp
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/Makefile| 3 +-
drivers/scsi/qla2xxx/qla_nvmet.c |
Hi Anil,
I love your patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.19-rc5 next-20180926]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
Hi Anil,
I love your patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.19-rc5 next-20180926]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Wed, Sep 26, 2018 at 09:52:35AM +0530, Suganath Prabu S wrote:
> Introduce mpt3sas_wait_for_ioc_to_operational.
>
> This section of code "wait for IOC to be operational"
> is used in many places across the driver,
> and hence moved this section of code in to the function
>
On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote:
> The code for getting shost and IOC is redundant so
> moved that to function "scsih_get_shost_and_ioc".
> Also checks for NULL are added to IOC and shost.
>
> Signed-off-by: Suganath Prabu S
> ---
>
Trivial nits/questions. In subject:
s/Introdude/Introduce/
s/ / / (remove double space)
s/\.//(remove trailing period, also appears in patches 4, 5, 6)
On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote:
> The code for getting shost and IOC is redundant so
> moved
From: Giridhar Malavali
This patch fixes issue during switch command query where driver was
freeing SRB resources multiple times
Following stack trace will be seen
[ 853.436234] BUG: unable to handle kernel NULL pointer dereference at
0001
[ 853.436348] IP: []
From: Quinn Tran
Send aborts only when chip is active.
Fixes: 623ee824e579 ("scsi: qla2xxx: Fix FC-NVMe IO abort during driver reset")
Cc: # 4.14
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi Martin,
This series fixes issues found during out last test cycle.
Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver.
Patch 3 fixes issue discovered during BFS test setup resulting into
installation failure and hand because driver could not discover BFS Luns.
Patch
From: Quinn Tran
This patch fixes issue where driver clears Nport ID map
instead of marking handle in use. Once driver clears
NPort ID from the database, it can reuse same NPort ID
resulting in a PLOGI failure.
Fixes: a084fd68e1d2 ("scsi: qla2xxx: Fix re-login for Nport Handle in use")
Cc:
> Hi Avri,
>
> this looks generally good to me, but I'd suggest two small tweaks:
>
> - please split out a new prep patch that creates
>include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
>new file
Done.
> > +
> > +/**
> > + * ufshcd_exec_raw_upiu_cmd - API function for sending raw upiu
> commands
> > + * @hba: per-adapter instance
> > + * @req_upiu: upiu request
> > + * @rsp_upiu: upiu reply - only 8 DW as we do not support scsi
> commands
> > + * @msgcode: message code, one of
>
> Avri,
>
> > this looks generally good to me, but I'd suggest two small tweaks:
> >
> > - please split out a new prep patch that creates
> >include/uapi/scsi/scsi_bsg_ufs.h with the structures move there
> > - pleae keep the copyrights from drivers/scsi/ufs/ufs.h in this
> >new file
From: Quinn Tran
This patch prevents user space mailbox request from doing
chip reset if the mailbox timed out. The chip reset is
only reserved for the DPC thread to ensure all mailbox
requests are flushed properly. The DPC thread is responsible
for the flushing all MBs and chip reset.
Fixes:
This patch fixes multiple call for qla_nvme_unregister_remote_port()
as part of qlt_schedule_session_for_deletion(), Do not call it again
during qla_nvme_delete()
Fixes: e473b3074104 ("scsi: qla2xxx: Add FC-NVMe abort processing")
Cc:
Signed-off-by: Himanshu Madhani
---
From: Quinn Tran
The response data buffer used in switch scan is reused 4 times.
(For example, for commands GPN_FT, GNN_FT for FCP and FC-NVME)
Before driver reuses this buffer, clear it to prevent duplicate
entries in our database.
Fixes: a4239945b8ad1 ("scsi: qla2xxx: Add switch command to
From: Quinn Tran
This patch fixes issue when remoteport registers itself as
both FCP and FC-NVMe with the switch, driver will pick FC-NVMe
personality as default when scanning for targets.
Driver was using comaprative operator instead of bitwise operator
to check for fc4_type for both FCP and
30 matches
Mail list logo
