Re: Looking for some help understanding error handling

2018-10-05 Thread Hannes Reinecke
On 10/2/18 11:04 PM, chris.mo...@microchip.com wrote: I'm working on LLDD for a SAS/SATA host adapter, and trying to understand how the system handles link loss and recovery. Say I have a device that gets recognized and attached as sd 12:0:4:0, at /dev/sdb. The drive goes offline temporarily,

RE: Looking for some help understanding error handling

2018-10-05 Thread Chris.Moore
Thanks Hannes, After some pointers from Shane Seymour I found that the FC and SRP transport layers have a devloss timer, so that when a device disappears they hold on to the target information for a time waiting to see if it comes back. The SAS transport layer doesn't have that feature. The

Re: [PATCH v8 1/8] scsi: ufs: cleanup struct utp_task_req_desc

2018-10-05 Thread Christoph Hellwig
On Thu, Oct 04, 2018 at 08:20:30AM +0300, Avri Altman wrote: > From: Christoph Hellwig > > Remove the pointless task_req_upiu and task_rsp_upiu indirections, > which are __le32 arrays always cast to given structures and just add > the members directly. Also clean up variables names in use in

Re: [PATCH v8 0/8] scsi: Add ufs bsg endpoint

2018-10-05 Thread Avri Altman
hi, Thanks for trying to test it. You need to elaborate not only the ufs driver, but also the bsg driver, and some block layer patches as well. Will reply with the full list on Sunday. Thanks, Avri From: Bean Huo (beanhuo) Sent: Friday, October 5, 2018

Re: [PATCH v8 3/8] uapi: ufs: Make utp_upiu_req visible to user space

2018-10-05 Thread Christoph Hellwig
On Thu, Oct 04, 2018 at 08:20:32AM +0300, Avri Altman wrote: > in preparation to send UPIU requests via bsg. > > Signed-off-by: Avri Altman > Reviewed-by: Bart Van Assche > --- > drivers/scsi/ufs/ufs.h | 61 + > drivers/scsi/ufs/ufshcd.c| 6

Re: [PATCH v8 4/8] scsi: ufs: Add ufs-bsg module

2018-10-05 Thread Christoph Hellwig
On Thu, Oct 04, 2018 at 08:20:33AM +0300, Avri Altman wrote: > Add a bsg endpoint that supports UPIUs. This should probably go into the subject line. > > For now, just provide an API to allocate and remove > ufs-bsg node. We will use this framework to > manage ufs devices by sending UPIU

Re: [PATCH v8 0/8] scsi: Add ufs bsg endpoint

2018-10-05 Thread Bean Huo (beanhuo)
Hi, Avri Having patched them into v4.18 with problem free. I will test it on my own platform. Thanks. >hi, >Thanks for trying to test it. >You need to elaborate not only the ufs driver, but also the bsg driver, and >some block layer patches as well. >Will reply with the full list on Sunday. >