Re: [RFC PATCH 0/3] target: remove some unused stats

On Wed, 17 Oct 2018 17:48:17 +0200, David Disseldorp wrote: > This patchset removes a couple of unused error stat counters and a > redundant cumulative counter. > I've tagged this patchset RFC, as it may be considered a kernel<->user > (configfs) API change. Ping, any thoughts on this patchset?

Re: [PATCH 09/12] lpfc: Correct loss of fc4 type on remote port address change

On 10/23/18 10:41 PM, James Smart wrote: An address change for a remote port cause PRLI for the wrong protocol to be sent. The node copy done in the discovery code skipped copying the fc4 protocols supported as well. Fix the copy logic for the address change. Beefed up log messages in this

Re: [PATCH 08/12] lpfc: Fix odd recovery in duplicate FLOGIs in point-to-point

On 10/23/18 10:41 PM, James Smart wrote: Testing a point-to-point topology and a case of re-FLOGI without intervening link bouncing, showed an odd interaction with firmware and a resulting scenario where the driver no longer probed after accepting the new FLOGI. Work around the firmware issue

Re: [PATCH 03/12] lpfc: Fix LOGO/PLOGI handling when triggerd by ABTS Timeout event

On 10/23/18 10:41 PM, James Smart wrote: After a LOGO in response to an ABTS timeout, a PLOGI wasn't issued to re-establish the login. A nlp_type check in the LOGO completion handler failed to restart discovery for NVME targets. Revised the nlp_type check for NVME as well as SCSI. While

Re: [PATCH 05/12] lpfc: Correct errors accessing fw log

On 10/23/18 10:41 PM, James Smart wrote: This patch corrects two issues: - An oops would occur if reading based on a non-zero offset. Offset calculation was incorrect. - Updates to ras config (logging level) were ignored if change was made while fw logging was enabled. Revise to

Re: [PATCH 04/12] lpfc: Reset link or adapter instead of doing infinite nameserver PLOGI retry

On 10/23/18 10:41 PM, James Smart wrote: Currently, PLOGI failures are infinitely delayed/retried. There have been some fabric situations where the PLOGI's were to the nameserver and it stopped responding. The retries would never clear up. A better resolution in this situation is to retry a

Re: [PATCH 07/12] lpfc: Correct LCB RJT handling

On 10/23/18 10:41 PM, James Smart wrote: When LCB's are rejected, if beaconing was already in progress, the Reason Code Explanation was not being set. Should have been set to command in progress. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 +++

Re: [PATCH 06/12] lpfc: fcoe: Fix link down issue after 1000+ link bounces

On 10/23/18 10:41 PM, James Smart wrote: On FCoE adapters, when running link bounce test in a loop, initiator failed to login with switch switch and required driver reload to recover. Switch reached a point where all subsequent FLOGIs would be LS_RJT'd. Further testing showed the condition to be

Re: [PATCH 02/12] lpfc: Fix lpfc_sli4_read_config return value check

On 10/23/18 10:41 PM, James Smart wrote: An error is an error - but not to the existing return value check. Revise check to handle any failure, not just EIO. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH 01/12] lpfc: Correct speeds on SFP swap

On 10/23/18 10:41 PM, James Smart wrote: Supported speeds is not updated when SFP is removed or replaced Supported speed is obtained from lmt field in READ_CONFIG mailbox response. Driver updates supported speeds only once from PCI probe path. After that it is never updated. So, supported

Re: [PATCH 5/7] qla2xxx: Remove a set-but-not-used variable

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > This patch does not change any functionality. > > Cc: Himanshu Madhani > Signed-off-by: Bart Van Assche > --- > drivers/scsi/qla2xxx/qla_os.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [PATCH 2/7] qla2xxx: Improve several kernel-doc headers

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > This patch avoids that complaints about kernel-doc headers are reported > when building with W=1. > > Cc: Himanshu Madhani > Signed-off-by: Bart Van Assche > --- > drivers/scsi/qla2xxx/qla_iocb.c | 4 ++-- >

Re: [PATCH 1/7] qla2xxx: Modify fall-through annotations

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > This patch avoids that the compiler complains about missing fall-through > annotations when building with W=1. > > Cc: Himanshu Madhani > Signed-off-by: Bart Van Assche > --- > drivers/scsi/qla2xxx/qla_init.c |

Re: [PATCH 7/7] qla2xxx: Remove two arguments from qlafx00_error_entry()

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > Move a debug statement from qlafx00_error_entry() into its caller. Remove > one unused argument from that function. This patch does not change the > behavior of the qla2xxx driver. > > Cc: Himanshu Madhani >

Re: [PATCH 3/7] qla2xxx: Declare local functions 'static'

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > This patch avoids that the compiler complains about missing declarations > when building with W=1. > > Cc: Himanshu Madhani > Signed-off-by: Bart Van Assche > --- > drivers/scsi/qla2xxx/qla_init.c | 5 +++-- > 1

Re: [PATCH 4/7] qla2xxx: Make qla2x00_sysfs_write_nvram() easier to analyze

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > Modify the unlock statement such that it becomes easier for static > analyzers to analyze it. This patch does not change any functionality. > > Cc: Himanshu Madhani > Signed-off-by: Bart Van Assche > --- >

Re: [PATCH 6/7] qla2xxx: Make sure that qlafx00_ioctl_iosb_entry() initializes 'res'

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche wrote: > > External Email > > Only one of the two code paths in qlafx00_ioctl_iosb_entry() initializes > the variable 'res'. Make sure that 'res' is initialized before > sp->done(sp, res) is called. > > Cc: Himanshu Madhani > Signed-off-by:

Re: [PATCH 10/12] lpfc: Implement GID_PT on Nameserver query to support faster failover

On 10/23/18 10:41 PM, James Smart wrote: The switches seem to respond faster to GID_PT vs GID_FT NameServer queries. Add support for GID_PT to be used over GID_FT to enable faster storage failover detection. Includes addition of new module parameter to select between GID_PT and GID_FT (GID_FT