Kiyoshi Ueda wrote:
This patch converts xsysace to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
xsysace is a little bit different from normal drivers.
xsysace driver has a state machine in it.
It calls end_that_request_first() and
On Tue, Dec 11 2007 at 18:33 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote:
OK, thanks. I'll assume that James and Hannes have this in hand (or will
have, by mid-week) and I won't do anything here.
Just to confirm what I think I'm
Hi,
I'd like to let you now that my boxes are running a 32-bit kernel, so
the 64-bit-uncleanliness shouldn't apply to my boxes; however,
http://www.miquels.cistron.nl/linux/dpt_i2o-64bit-2.6.23.patch
fixed the issue on my testbox.
I took a clean 2.6.23, applied patch, recompiled the kernel,
On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Hi,
I'd like to let you now that my boxes are running a 32-bit kernel, so
the 64-bit-uncleanliness shouldn't apply to my boxes; however,
http://www.miquels.cistron.nl/linux/dpt_i2o-64bit-2.6.23.patch
fixed the
On Wed, Dec 12 2007, Boaz Harrosh wrote:
On Tue, Dec 11 2007 at 18:33 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote:
OK, thanks. I'll assume that James and Hannes have this in hand (or will
have, by mid-week) and I won't do anything
On Tue, Dec 11 2007, Kiyoshi Ueda wrote:
Hi Jens, Boaz,
The following is the updated patch-set for blk_end_request().
I have done some interface/implementation changes based on
feedbacks/discussions since the previous version.
(Although this patch-set was made on top of 2.6.24-rc4, I
On Tue, 2007-12-11 at 17:40 -0500, Kiyoshi Ueda wrote:
This patch adds 2 new interfaces for request completion:
o blk_end_request() : called without queue lock
o __blk_end_request() : called with queue lock held
blk_end_request takes 'error' as an argument instead of 'uptodate',
On Tue, 2007-12-11 at 17:52 -0500, Kiyoshi Ueda wrote:
This patch converts scsi mid-layer to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
As a result, the interface of internal function, scsi_end_request(),
is changed.
This looks fine, as far as it
Hi,
below is a patch introducing device recovery, trying to prevent i/o errors
when a DID_NO_CONNECT or SOFT_ERROR does happen.
The patch still needs quite some work:
1.) I still didn't figure out what is the best place to run
sdev-deh.ehandler = kthread_run(scsi_device_error_handler, ...)
On Wed, 2007-12-12 at 03:38 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Hi,
I'd like to let you now that my boxes are running a 32-bit kernel, so
the 64-bit-uncleanliness shouldn't apply to my boxes; however,
ACK, patch looks good. Thanks for composing this patch. Glad to hear of
successful test results.
Sincerely -- Mark Salyzyn
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Miquel
van Smoorenburg
. . .
I just recompiled 2.6.23.9 with the 64 bit
On Wed, Dec 12, 2007 at 01:54:14PM +0100, Bernd Schubert wrote:
below is a patch introducing device recovery, trying to prevent i/o errors
when a DID_NO_CONNECT or SOFT_ERROR does happen.
Why doesn't the regular scsi_eh do what you need?
--
Intel are signing my paycheques ... these opinions
Am 12.12.2007 schrieb Miquel van Smoorenburg:
On Wed, 2007-12-12 at 03:38 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Hi,
I'd like to let you now that my boxes are running a 32-bit kernel, so
the 64-bit-uncleanliness
Am 12.12.2007 schrieb Andrew Morton:
On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Hi,
I'd like to let you now that my boxes are running a 32-bit kernel, so
the 64-bit-uncleanliness shouldn't apply to my boxes; however,
On Wednesday 12 December 2007 14:39:27 Matthew Wilcox wrote:
On Wed, Dec 12, 2007 at 01:54:14PM +0100, Bernd Schubert wrote:
below is a patch introducing device recovery, trying to prevent i/o
errors when a DID_NO_CONNECT or SOFT_ERROR does happen.
Why doesn't the regular scsi_eh do what
-Original Message-
From: Kiyoshi Ueda [mailto:[EMAIL PROTECTED]
Sent: Tuesday, December 11, 2007 4:50 PM
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org;
[EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED]; Miller, Mike (OS Dev)
On Wed, Dec 12, 2007 at 01:03:10PM +0200, Boaz Harrosh wrote:
- BIO flags bio-bi_rw and REQ flags req-cmd_flags no longer match.
Remove comments and do a proper translation between the 2 systems.
I'd rather see them resynchronised ... in a way that makes it obvious
that they should be
This patch converts cciss to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
cciss is a little bit different from normal drivers.
cciss directly calls bio_endio() and disk_stat_add() when
completing request. But those can be replaced with
On Wed, Dec 12, 2007 at 08:18:14AM -0700, Matthew Wilcox wrote:
I don't know whether BIO_RW_BARRIER is __REQ_SOFTBARRIER or
__REQ_HARDBARRIER, so I didn't include that in this patch. There also
doesn't seem to be a __REQ equivalent to BIO_RW_AHEAD, but we can do
the other four bits (and leave
On Wed, Dec 12 2007 at 17:18 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Wed, Dec 12, 2007 at 01:03:10PM +0200, Boaz Harrosh wrote:
- BIO flags bio-bi_rw and REQ flags req-cmd_flags no longer match.
Remove comments and do a proper translation between the 2 systems.
I'd rather see
On Wed, Dec 12, 2007 at 06:06:45PM +0200, Boaz Harrosh wrote:
Thats not enough You still need to fix code in ll_rw_blk(), I would
define a rq_flags_bio_match_mask = 0xf for that.
(and also add what Jens called needed with the
BIO_RW_AHEAD selects REQ_FAILFAST.)
Yes, I appreciate it's not
Hi,
On Wed, 12 Dec 2007 11:09:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
Index: 2.6.24-rc4/drivers/block/xsysace.c
===
--- 2.6.24-rc4.orig/drivers/block/xsysace.c
+++ 2.6.24-rc4/drivers/block/xsysace.c
@@ -703,7 +703,7
Hi Mike,
On Wed, 12 Dec 2007 15:25:10 +, Miller, Mike (OS Dev) [EMAIL PROTECTED]
wrote:
Index: 2.6.24-rc4/drivers/block/cciss.c
===
--- 2.6.24-rc4.orig/drivers/block/cciss.c
+++ 2.6.24-rc4/drivers/block/cciss.c
snip
[Hmm, resending since mail after more than 30min still not on the ML, maybe
the attachment was too large? I have uploaded the log to
http://www.pci.uni-heidelberg.de/tc/usr/bernd/downloads/scsi/kern.log.1]
On Wednesday 12 December 2007 16:59:36 James Bottomley wrote:
On Wed, 2007-12-12 at
On Wed, Dec 12 2007 at 19:06 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
Hi,
On Wed, 12 Dec 2007 11:09:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
Index: 2.6.24-rc4/drivers/block/xsysace.c
===
---
Why is this removed?
Sorry for the less explanation.
Because it is done in __end_that_request_first() called from
blk_end_request().
I'll add the explanation to the patch description when I
update the patch.
Thank you. I've Acked the patch.
-- mikem
-
To unsubscribe from this list:
On Wed, 12 Dec 2007 14:43:42 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Am 12.12.2007 schrieb Miquel van Smoorenburg:
On Wed, 2007-12-12 at 03:38 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Hi,
I'd like to let you
-Original Message-
From: Kiyoshi Ueda [mailto:[EMAIL PROTECTED]
Sent: Tuesday, December 11, 2007 4:50 PM
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org;
[EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED]; Miller, Mike (OS Dev)
On Wed, 2007-12-12 at 11:16 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 14:43:42 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Am 12.12.2007 schrieb Miquel van Smoorenburg:
On Wed, 2007-12-12 at 03:38 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL
Hi Pete,
On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev [EMAIL PROTECTED] wrote:
if (scsi_status == 0) {
- uptodate = 1;
+ error = 0;
} else {
- uptodate = 0;
+ error = -EIO;
rq-errors = scsi_status;
}
-
On Tue, Dec 11, 2007 at 05:42:53PM -0500, Kiyoshi Ueda wrote:
This patch converts um to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
As a result, the interface of internal function, ubd_end_request(),
is changed.
Looks OK to me...
This has already been fixed. It's in our 8.2.3 patches, which were merged into
James's scsi-misc-2.6 tree at the beginning of November, and targeted for
2.6.25.
-- james s
Adrian Bunk wrote:
Commit 2e0fef85e098f6794956b8b80b79fbb4cbb7 added the folowing code
to
On Wed, Dec 12, 2007 at 02:54:54PM -0500, James Bottomley wrote:
On Wed, 2007-12-12 at 11:16 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 14:43:42 +0100 Anders Henke [EMAIL PROTECTED] wrote:
Am 12.12.2007 schrieb Miquel van Smoorenburg:
On Wed, 2007-12-12 at 03:38 -0800, Andrew
On Tuesday 11 December 2007, Kiyoshi Ueda wrote:
This patch converts ide-scsi to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi
Hi James, Jens,
On Wed, 12 Dec 2007 07:53:36 -0500, James Bottomley wrote:
On Tue, 2007-12-11 at 17:40 -0500, Kiyoshi Ueda wrote:
This patch adds 2 new interfaces for request completion:
o blk_end_request() : called without queue lock
o __blk_end_request() : called with queue lock
On Wed, Dec 12, 2007 at 08:54:07AM -0700, Matthew Wilcox wrote:
On Wed, Dec 12, 2007 at 08:18:14AM -0700, Matthew Wilcox wrote:
I don't know whether BIO_RW_BARRIER is __REQ_SOFTBARRIER or
__REQ_HARDBARRIER, so I didn't include that in this patch. There also
doesn't seem to be a __REQ
36 matches
Mail list logo
