[RFC] blktrace interface for sg devices

2007-12-13 Thread Christof Schmitt
I am referring to the discussion of introducing statistics in the SCSI layer and the conclusion that blktrace already provides the data: http://lkml.org/lkml/2006/10/21/72 http://lkml.org/lkml/2006/11/2/141 While blktrace works fine for disk devices, it currently does not provide data for

[PATCH] dpt_i2o: don't set DMA_64BIT_MASK [was: Re: [stable] broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)]

2007-12-13 Thread Miquel van Smoorenburg
According to Greg KH: So, what should be added to 2.6.23-stable then? And, can I get a real changelog entry for it? This is suitable for both 2.6.23.x and 2.6.24-rc5 : linux-2.6-dpt_i2o-no-dma64.patch The dpt_i2o driver can't handle 64 bit DMA addresses, so do not let it set

[0/3 ver2] Last 3 patches for bidi support

2007-12-13 Thread Boaz Harrosh
James hi. Bidi patches just broke again, by a patch that fixes some to-be-dead code. (scsi: BUG_ON() impossible condition) Could it not just be accepted into the tree now. It sat in -mm tree with no reports of breakage or complains. What are we waiting for? the way I see it there is nothing

[PATCH] tgt: Use scsi_init_io instead of scsi_alloc_sgtable

2007-12-13 Thread Boaz Harrosh
- If we export scsi_init_io()/scsi_release_buffers() instead of scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is much more insulated from scsi_lib changes. As a bonus it will also gain bidi capability when it comes. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] Acked-by:

[PATCH] scsi: scsi_data_buffer

2007-12-13 Thread Boaz Harrosh
In preparation for bidi we abstract all IO members of scsi_cmnd, that will need to duplicate, into a substructure. - Group all IO members of scsi_cmnd into a scsi_data_buffer structure. - Adjust accessors to new members. - scsi_{alloc,free}_sgtable receive a scsi_data_buffer

[PATCH] scsi: bidi support

2007-12-13 Thread Boaz Harrosh
At the block level bidi request uses req-next_rq pointer for a second bidi_read request. At Scsi-midlayer a second scsi_data_buffer structure is used for the bidi_read part. This bidi scsi_data_buffer is put on request-next_rq-special. Struct scsi_cmnd is not changed. - Define

[PATCH] sr/sd: Remove simple dead code

2007-12-13 Thread Boaz Harrosh
if (rq_data_dir() == WRITE) else if() else chain had an extra else since the if() is on a value of 1 bit. Also with a bidi request rq_data_dir() == WRITE and blk_bidi_rq() == true. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/sd.c |5 + drivers/scsi/sr.c |

Re: [PATCH] dpt_i2o: don't set DMA_64BIT_MASK [was: Re: [stable] broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)]

2007-12-13 Thread James Bottomley
On Thu, 2007-12-13 at 11:11 +0100, Miquel van Smoorenburg wrote: According to Greg KH: So, what should be added to 2.6.23-stable then? And, can I get a real changelog entry for it? This is suitable for both 2.6.23.x and 2.6.24-rc5 : linux-2.6-dpt_i2o-no-dma64.patch Actually, this

Re: [PATCH] scsi device recovery

2007-12-13 Thread James Bottomley
On Wed, 2007-12-12 at 18:54 +0100, Bernd Schubert wrote: [Hmm, resending since mail after more than 30min still not on the ML, maybe the attachment was too large? I have uploaded the log to http://www.pci.uni-heidelberg.de/tc/usr/bernd/downloads/scsi/kern.log.1] On Wednesday 12 December

Re: [RFC] blktrace interface for sg devices

2007-12-13 Thread Christof Schmitt
On Thu, Dec 13, 2007 at 10:19:42AM +0100, Jens Axboe wrote: [...] I think this approach is the simplest and right way to do it. Tracing is really just tied to the transport (transport here meaning how we transport commands to the device), and even character scsi devices use the block layer

QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Jens, I'm experimenting here with trying to generate large I/O through libata, and not having much luck. The limit seems to be the number of hardware PRD (SG) entries permitted by the driver (libata:ata_piix), which is 128 by default. The problem is, the block layer *never* sends an SG entry

QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
(resending with corrected email address for Jens) Jens, I'm experimenting here with trying to generate large I/O through libata, and not having much luck. The limit seems to be the number of hardware PRD (SG) entries permitted by the driver (libata:ata_piix), which is 128 by default. The

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Matthew Wilcox
On Thu, Dec 13, 2007 at 01:37:59PM -0500, Mark Lord wrote: The problem is, the block layer *never* sends an SG entry larger than 8192 bytes, and even that size is exceptionally rare. Nearly all I/O segments are 4096 bytes, so I never see a single I/O larger than 512KB (128 * 4096). If I

[PATCH 08/24] iscsi class: Use our own workq instead of common system one.

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] There is just too much going on through the common workq and something like a scsi device removal through sysfs affects how long it will take to recover the transport, mark it as failed, or shut it down gracefully. Signed-off-by: Mike Christie [EMAIL

[PATCH 10/24] libiscsi: fix shutdown

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] We were using the device delete sysfs file to remove each device then logout. Now in 2.6.21 this will not work because the sysfs delete file returns immediately and does not wait for the device removal to complete. This causes a hang if a cache sync is needed

[PATCH 13/24] Do not fail commands immediately during logout

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] If the target requests a logout, then we do not want to fail commands to scsi-ml right away. This patch just fails in pending commands for a requeue immediately, and then lets iscsid handle running commands like normal recovery. Signed-off-by: Mike Christie

[PATCH 14/24] clear conn-ctask when task is completed early

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] If the current ctask is failed early, we legt the conn-ctask pointer pointing to a invalid task. When the xmit thread would send data for it, we would then oops. Signed-off-by: Mike Christie [EMAIL PROTECTED] --- drivers/scsi/libiscsi.c |5 - 1

[PATCH 18/24] iscsi_tcp: drop session when itt does not match any command

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] A target should never send us a itt that does not match a running task. If it does we do not really know what is coming down after the header, unless we evaluate the hdr and do some guessing sometimes. However, even if we know what is coming we probably do

[PATCH 19/24] libiscsi, iscsi class: set tmf to a safe default and export in sysfs

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] Older tools will not be setting the tmf time outs since they did not exists, so set them to a safe default. And export abort and lu reset timeout values in sysfs. Signed-off-by: Mike Christie [EMAIL PROTECTED] --- drivers/scsi/libiscsi.c |2

[PATCH 21/24] iscsi_tcp: hold lock during data rsp processing

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] iscsi_data_rsp needs to hold the sesison lock when it calls iscsi_update_cmdsn. Signed-off-by: Mike Christie [EMAIL PROTECTED] --- drivers/scsi/iscsi_tcp.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH 22/24] libiscsi: use is_power_of_2

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] Patch from vignesh babu [EMAIL PROTECTED]: Replacing n (n - 1) for power of 2 check by is_power_of_2(n) Signed-off-by: vignesh babu [EMAIL PROTECTED] Signed-off-by: Mike Christie [EMAIL PROTECTED] --- drivers/scsi/libiscsi.c |3 ++- 1 files changed, 2

[PATCH 23/24] iscsi_tcp: fix setting of r2t

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] If we negotiate for X r2ts we have to use only X r2ts. We cannot round up (we could send less though). It is ok to fail if it is not something the driver can handle, so this patch just does that. Signed-off-by: Mike Christie [EMAIL PROTECTED] ---

[PATCH 17/24] iscsi_tcp: stop leaking r2t_info's when the incoming R2T is bad

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] from [EMAIL PROTECTED]: iscsi_r2t_rsp checks the incoming R2T for sanity, and if it thinks it's fishy, it will drop it silently. In this case, we leaked an r2t_info object. If we do this often enough, we run into a BUG_ON some time later. Removed r2t

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread James Bottomley
On Thu, 2007-12-13 at 11:42 -0700, Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:37:59PM -0500, Mark Lord wrote: The problem is, the block layer *never* sends an SG entry larger than 8192 bytes, and even that size is exceptionally rare. Nearly all I/O segments are 4096 bytes, so

[PATCH 05/24] iser patching for AHS support

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] from Boaz Harrosh [EMAIL PROTECTED] - The default initialization of hdr_max is the minimum - sizeof(struct iscsi_cmd) - Once this patch goes into iser the default initialization at libiscsi can be removed. - This is not yet full support for AHSs

[PATCH 04/24] iscsi_tcp, libiscsi: initial AHS Support

2007-12-13 Thread michaelc
From: Mike Christie [EMAIL PROTECTED] at libiscsi generic code - currently code assumes a storage space of pdu header is allocated at llds ctask and is pointed to by iscsi_cmd_task-hdr. Here I add a hdr_max field pertaining to that storage, and an hdr_len that accumulates the

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Mark Lord wrote: (resending with corrected email address for Jens) Jens, I'm experimenting here with trying to generate large I/O through libata, and not having much luck. The limit seems to be the number of hardware PRD (SG) entries permitted by the driver (libata:ata_piix), which is 128 by

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Matthew Wilcox
On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses only 4KB segments and a *few* 8KB segments. Just a suspicion ... could this be slab vs slub? ie check your configs are the same /

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses only 4KB segments and a *few* 8KB segments. Just a suspicion ... could this be slab vs slub? ie check your

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses only 4KB segments and a *few* 8KB segments. Just a suspicion ... could

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses only 4KB segments and a *few* 8KB segments. Just a

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses only 4KB segments and a *few* 8KB

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed.

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500,

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Jens Axboe wrote: On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500,

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Mark Lord wrote: Jens Axboe wrote: .. OK, it's a vm issue, I have tens of thousand backward pages after a boot - IOW, bvec-bv_page is the page before bvprv-bv_page, not reverse. So it looks like that bug got reintroduced. ... Mmm.. shouldn't one of the front- or back- merge logics work for

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu,

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-13 Thread Pete Zaitcev
On Wed, 12 Dec 2007 15:38:15 -0500 (EST), Kiyoshi Ueda [EMAIL PROTECTED] wrote: On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev [EMAIL PROTECTED] wrote: - end_that_request_first(rq, uptodate, rq-hard_nr_sectors); - end_that_request_last(rq, uptodate); + if (__blk_end_request(rq,

VM allocates pages in reverse order again

2007-12-13 Thread Matthew Wilcox
On Thu, Dec 13, 2007 at 09:09:59PM +0100, Jens Axboe wrote: diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c index e30b1a4..1e34b6f 100644 --- a/block/ll_rw_blk.c +++ b/block/ll_rw_blk.c @@ -1349,6 +1351,8 @@ new_segment: sg = sg_next(sg);

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have tens of thousand backward pages after a boot - IOW, bvec-bv_page is the page before bvprv-bv_page, not reverse. So it looks like that bug got reintroduced.

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread James Bottomley
On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have tens of thousand backward pages after a boot - IOW, bvec-bv_page is the page before

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have tens of thousand backward pages after a boot - IOW, bvec-bv_page is the page before bvprv-bv_page, not

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Andrew Morton wrote: On Thu, 13 Dec 2007 17:15:06 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 17:15:06 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have tens

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Mark Lord wrote: Andrew Morton wrote: On Thu, 13 Dec 2007 17:15:06 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Andrew Morton wrote: On Thu, 13 Dec 2007 17:15:06 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc

[patch 01/30] git-scsi-misc gdth fix

2007-12-13 Thread akpm
From: James Bottomley [EMAIL PROTECTED] On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote: On Sun, 14 Oct 2007 22:45:47 +0400 Dave Milter [EMAIL PROTECTED] wrote: I build linux-2.6.23-mm1 and try to boot it using qemu, and it crashed with trace like this: do_page_fault error_code

[patch 04/30] kill warnings in mptbase.h on parisc64

2007-12-13 Thread akpm
From: Kyle McMartin [EMAIL PROTECTED] Verified all the arches necessary select the CONFIG_64BIT symbol. This also kills the warning (since it was using the 32-bit case) on parisc64 and mips64. Signed-off-by: Kyle McMartin [EMAIL PROTECTED] Cc: Moore, Eric Dean [EMAIL PROTECTED] Cc: James

[patch 02/30] mptbase: reset ioc initiator during PCI resume

2007-12-13 Thread akpm
From: Darrick J. Wong [EMAIL PROTECTED] It appears that the LSI SAS 1064E chip needs to be reset after a suspend/resume cycle before the driver attempts further communications with the chip. Without this patch, resuming the chip results in this error message being printed repeatedly and no more

[patch 03/30] initio: fix conflict when loading driver

2007-12-13 Thread akpm
From: Alan Cox [EMAIL PROTECTED] I have a scanner connected to a Initio INI-950 SCSI card and I recently upgraded from SuSE 10.2 to 10.3. The new kernel doesn't see any of my devices. I get the following in /var/log/messages: ACPI: PCI Interrupt :00:0a.0[A] - GSI 17 (level, low) - IRQ

[patch 14/30] aic94: fix section mismatches

2007-12-13 Thread akpm
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warning: WARNING: vmlinux.o(.init.text+0x23be6): Section mismatch: reference to .exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'qla4xxx_module_init') + WARNING: vmlinux.o(.text+0x1ec8a8): Section mismatch: reference to

[patch 07/30] ips: PCI API cleanups

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] * pass Scsi_Host to ips_remove_device() via pci_set_drvdata(), allowing us to eliminate the ips_ha[] search loop and call ips_release() directly. * call pci_{request,release}_regions() and eliminate individual request/release_[mem_]region() calls * call

[patch 09/30] MegaRAID driver management char device moved to misc

2007-12-13 Thread akpm
From: Thomas Horsten [EMAIL PROTECTED] The MegaRAID driver's common management module (megaraid_mm.c) creates a char device used by the management tool megarc from LSI Logic (and possibly other management tools). In 2.6 with udev, this device doesn't get created because it is not registered in

[patch 13/30] advansys: fix section mismatch warning

2007-12-13 Thread akpm
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warning: WARNING: vmlinux.o(.exit.text+0x152a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and 'advansys_exit') Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL

[patch 12/30] SCSI/NCR5380: minor irq handler cleanups

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] * remove unnecessary cast * remove unnecessary use of 'irq' function arg Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/NCR5380.c |7 --- 1 file

[patch 11/30] SCSI/sym53c416: kill pointless irq handler loop and test

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] - kill pointless irq handler loop to find base address, it is already passed to irq handler via Scsi_Host. - kill now-pointless !base test. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Cc: Matthew Wilcox [EMAIL

[patch 15/30] sym2: fix section mismatch warning

2007-12-13 Thread akpm
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch warning: WARNING: vmlinux.o(.text+0x1ff3a2): Section mismatch: reference to .exit.text:sym2_remove (between 'sym2_io_error_detected' and 'sym_xpt_done') Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED]

[patch 10/30] SCSI/gdth: kill unneeded 'irq' argument

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] Neither gdth_get_status() nor __gdth_interrupt() need their 'irq' argument, so remove it. [EMAIL PROTECTED]: coding style fixes] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Acked-by: Boaz Harrosh [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED]

[patch 06/30] ips: trim trailing whitespace

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] [EMAIL PROTECTED]: coding style fixes] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Acked-by: Salyzyn, Mark [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/ips.c | 49

[patch 08/30] ips: handle scsi_add_host() failure, and other err cleanups

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Acked-by: Salyzyn, Mark [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/ips.c | 18 +- 1 file changed, 13 insertions(+), 5

[patch 05/30] ips: remove ips_ha members that duplicate struct pci_dev members

2007-12-13 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Acked-by: Salyzyn, Mark [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/ips.c | 178 ---

[patch 20/30] drivers/scsi/sgiwd93.c: export sgiwd93_reset()

2007-12-13 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] mips allmodconfig: ERROR: sgiwd93_reset [drivers/scsi/wd33c93.ko] undefined! Cc: Ralf Baechle [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/sgiwd93.c |1 + 1 file changed, 1

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Andrew Morton wrote: On Thu, 13 Dec 2007 19:30:00 -0500 Mark Lord [EMAIL PROTECTED] wrote: Here's the commit that causes the regression: ... --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -760,7 +760,8 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order, struct

[PATCH] fix page_alloc for larger I/O segments

2007-12-13 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Mark Lord wrote: Mark Lord wrote: Andrew Morton wrote: On Thu, 13 Dec 2007 17:15:06 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED]

[patch 16/30] aacraid driver fails with Dell PowerEdge Expandable RAID Controller 3/Di

2007-12-13 Thread akpm
From: Salyzyn, Mark [EMAIL PROTECTED] As reported in http://bugzilla.kernel.org/show_bug.cgi?id=3D9133 it was discovered that the PERC line of controllers lacked a key 64 bit ScatterGather capable SCSI pass-through function. The adapters are still capable of 64 bit ScatterGather I/O commands, but

[patch 28/30] scsi: arm: convert to accessors and !use_sg cleanup

2007-12-13 Thread akpm
From: Boaz Harrosh [EMAIL PROTECTED] - convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/arm/acornscsi.c |

[patch 30/30] libsas: convert ATA bridge to use new EH

2007-12-13 Thread akpm
From: Darrick J. Wong [EMAIL PROTECTED] Migrate the sas_ata bridge to use the new libata EH strategy, and finally implement correct software reset. WARNING WARNING WARNING! This patch is for experimental use only; it is nowhere near complete! Especially the sas_ata_freeze() function. This

[patch 19/30] Dell CERC support for megaraid_mbox

2007-12-13 Thread akpm
From: Hannes Reinecke [EMAIL PROTECTED] Newer Dell CERC firmware (= 6.62) implement a random deletion handling compatible with the legacy megaraid driver. The legacy handling shifted the target ID by 0x80 only for I/O commands (READ/WRITE/etc), whereas megaraid_mbox shifts the target ID always

[patch 22/30] sg: nopage

2007-12-13 Thread akpm
From: Nick Piggin [EMAIL PROTECTED] Convert SG from nopage to fault. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Cc: Douglas Gilbert [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/sg.c | 23 +++ 1

[patch 29/30] scsi: bidi support

2007-12-13 Thread akpm
From: Boaz Harrosh [EMAIL PROTECTED] At the block level bidi request uses req-next_rq pointer for a second bidi_read request. At Scsi-midlayer a second scsi_data_buffer structure is used for the bidi_read part. This bidi scsi_data_buffer is put on request-next_rq-special. Struct

[patch 25/30] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT

2007-12-13 Thread akpm
From: Denis Cheng [EMAIL PROTECTED] Signed-off-by: Denis Cheng [EMAIL PROTECTED] Acked-by: Brian King [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/ipr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN

[patch 21/30] scsi/qla2xxx/qla_os.c section fix

2007-12-13 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] WARNING: vmlinux.o(.text+0x2a4462): Section mismatch: reference to .exit.text:qla2x00_remove_one (between 'qla2xxx_pci_error_detected' and 'qla2x00_stop_timer') qla2x00_remove_one() mustn't be __devexit since it's called from qla2xxx_pci_error_detected().

[patch 23/30] 3W RAID drivers: memset not needed in probe

2007-12-13 Thread akpm
From: Denis Cheng [EMAIL PROTECTED] The memory return from scsi_host_alloc is alloced by kzalloc, which is already zero initilized, so memset not needed. Signed-off-by: Denis Cheng [EMAIL PROTECTED] Cc: Adam Radford [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 18/30] scsi/qla2xxx/: possible cleanups

2007-12-13 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] - make the following needlessly global code static: - qla_attr.c: qla24xx_vport_delete() - qla_attr.c: qla24xx_vport_disable() - qla_mid.c: qla24xx_allocate_vp_id() - qla_mid.c: qla24xx_find_vhost_by_name() - qla_mid.c: qla2x00_do_dpc_vp() -

[patch 26/30] tgt: use scsi_init_io instead of scsi_alloc_sgtable

2007-12-13 Thread akpm
From: Boaz Harrosh [EMAIL PROTECTED] - If we export scsi_init_io()/scsi_release_buffers() instead of scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is much more insulated from scsi_lib changes. As a bonus it will also gain bidi capability when it comes. Signed-off-by: Boaz

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 19:30:00 -0500 Mark Lord [EMAIL PROTECTED] wrote: Here's the commit that causes the regression: ... --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -760,7 +760,8 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order, struct page *page =

[PATCH] fix page_alloc for larger I/O segments (improved)

2007-12-13 Thread Mark Lord
Improved version, more similar to the 2.6.23 code: Fix page allocator to give better chance of larger contiguous segments (again). Signed-off-by: Mark Lord [EMAIL PROTECTED] --- --- old/mm/page_alloc.c 2007-12-13 19:25:15.0 -0500 +++ linux-2.6/mm/page_alloc.c 2007-12-13

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Mark Lord
Mark Lord wrote: Andrew Morton wrote: On Thu, 13 Dec 2007 19:30:00 -0500 Mark Lord [EMAIL PROTECTED] wrote: Here's the commit that causes the regression: ... --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -760,7 +760,8 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order,

Re: [PATCH] fix page_alloc for larger I/O segments

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 19:40:09 -0500 Mark Lord [EMAIL PROTECTED] wrote: And here is a patch that seems to fix it for me here: * * * * Fix page allocator to give better change of larger contiguous segments (again). Signed-off-by: Mark Lord [EMAIL PROTECTED] --- ---

Re: [PATCH] fix page_alloc for larger I/O segments (improved)

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 19:57:29 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 19:46 -0500, Mark Lord wrote: Improved version, more similar to the 2.6.23 code: Fix page allocator to give better chance of larger contiguous segments (again). Signed-off-by: Mark

Re: [PATCH] fix page_alloc for larger I/O segments (improved)

2007-12-13 Thread Mark Lord
Andrew Morton wrote: On Thu, 13 Dec 2007 19:57:29 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 19:46 -0500, Mark Lord wrote: Improved version, more similar to the 2.6.23 code: Fix page allocator to give better chance of larger contiguous segments (again).