Re: [PATCH 1/2] DMA buffer alignment annotations

2007-12-21 Thread Russell King
On Fri, Dec 21, 2007 at 01:30:07PM +1100, Benjamin Herrenschmidt wrote: The current patch only enables such alignment for some PowerPC platforms that do not have coherent caches. Other platforms such as ARM, MIPS, etc... can define ARCH_MIN_DMA_ALIGNMENT if they want to benefit from this, I

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

2007-12-21 Thread Andrew Morton
On Fri, 14 Dec 2007 10:20:04 -0800 Andrew Vasquez [EMAIL PROTECTED] wrote: On Fri, 14 Dec 2007, Andrew Morton wrote: Could you drop this patch from your queue. I'll carry it in my tree (along with additional code removals) for 2.6.25 submission. I'll normally carry patches

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Alan Cox
On Fri, 21 Dec 2007 13:30:08 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level drivers (that typically happens with USB mass storage). Should that not be fixed in USB storage by using pci_alloc_coherent

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Matthew Wilcox
On Fri, Dec 21, 2007 at 10:33:26AM +, Alan Cox wrote: On Fri, 21 Dec 2007 13:30:08 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level drivers (that typically happens with USB mass storage).

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Matthew Wilcox
On Fri, Dec 21, 2007 at 02:30:28PM +0100, Thomas Bogendoerfer wrote: there are SCSI host drivers, which also DMA to the sense buffer like sgiwd93.c for example. Yes ... and there are others which don't, for example qla2xxx and sym53c8xx. -- Intel are signing my paycheques ... these opinions

Re: smp_utils 0.93 beta, adds sgv4 interface

2007-12-21 Thread Douglas Gilbert
James Bottomley wrote: On Wed, 2007-12-19 at 23:46 -0500, Douglas Gilbert wrote: smp_utils is a package of command line utilities for invoking SMP functions to monitor and manage SAS expanders. SMP is the Serial Attached SCSI (SAS) Management Protocol (SMP). A SAS Host Bus Adapter (HBA)

Re: smp_utils 0.93 beta, adds sgv4 interface

2007-12-21 Thread James Bottomley
On Fri, 2007-12-21 at 10:10 -0500, Douglas Gilbert wrote: James Bottomley wrote: On Wed, 2007-12-19 at 23:46 -0500, Douglas Gilbert wrote: smp_utils is a package of command line utilities for invoking SMP functions to monitor and manage SAS expanders. SMP is the Serial Attached SCSI (SAS)

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Thomas Bogendoerfer
On Fri, Dec 21, 2007 at 07:00:25AM -0700, Matthew Wilcox wrote: On Fri, Dec 21, 2007 at 02:30:28PM +0100, Thomas Bogendoerfer wrote: there are SCSI host drivers, which also DMA to the sense buffer like sgiwd93.c for example. Yes ... and there are others which don't, for example qla2xxx and

Re: [PATCH 1/2] DMA buffer alignment annotations

2007-12-21 Thread Roland Dreier
+#define __dma_aligned __attribute__((aligned(ARCH_MIN_DMA_ALIGNMENT))) +#define __dma_buffer __dma_buffer_line(__LINE__) +#define __dma_buffer_line(line) __dma_aligned;\ + char __dma_pad_##line[0] __dma_aligned You introduce

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Roland Dreier
It's also incomplete as a fix because I don't see what guarantees the buffer size will always exceed cache line size There's a macro trick that adds a pad member after the buffer too, so that it gets rounded up to the cacheline size: +#define __dma_aligned

Re: [patch 18/30] scsi/qla2xxx/: possible cleanups

2007-12-21 Thread Andrew Vasquez
On Fri, 21 Dec 2007, Andrew Morton wrote: On Fri, 14 Dec 2007 10:20:04 -0800 Andrew Vasquez [EMAIL PROTECTED] wrote: It is, though, not widely publicized: git://avgit01.qlogic.com/qla2xxx-upstream The repo is torndown and rebased on frequent a basis, and is meant to provide a

Re: INITIO scsi driver fails to work properly

2007-12-21 Thread Chuck Ebbert
On 12/19/2007 03:48 AM, Filippos Papadopoulos wrote: On Dec 17, 2007 2:18 PM, Boaz Harrosh [EMAIL PROTECTED] wrote: I have found one problem. Please try patch [2] below and report. If it still fails try to enable debugging by setting with patch [1] these values at top of drivers/scsi/initio.c.

RE: [PATCH 2/2] qla4xxx: Add target reset functionality

2007-12-21 Thread David Somayajulu
Mike Christie [EMAIL PROTECTED] wrote: This patch adds target reset functionalty. Signed-off-by: Mike Christie [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_fw.h |1 + drivers/scsi/qla4xxx/ql4_glbl.h |2 + drivers/scsi/qla4xxx/ql4_mbx.c | 39

Re: [PATCH 1/2] DMA buffer alignment annotations

2007-12-21 Thread Benjamin Herrenschmidt
On Fri, 2007-12-21 at 09:39 +, Russell King wrote: +#ifndef ARCH_MIN_DMA_ALIGNMENT +#define __dma_aligned +#define __dma_buffer +#else +#define __dma_aligned __attribute__((aligned(ARCH_MIN_DMA_ALIGNMENT))) +#define __dma_buffer

Re: INITIO scsi driver fails to work properly

2007-12-21 Thread James Bottomley
On Fri, 2007-12-21 at 14:30 -0500, Chuck Ebbert wrote: On 12/19/2007 03:48 AM, Filippos Papadopoulos wrote: On Dec 17, 2007 2:18 PM, Boaz Harrosh [EMAIL PROTECTED] wrote: I have found one problem. Please try patch [2] below and report. If it still fails try to enable debugging by setting

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Benjamin Herrenschmidt
On Fri, 2007-12-21 at 10:33 +, Alan Cox wrote: On Fri, 21 Dec 2007 13:30:08 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level drivers (that typically happens with USB mass storage). Should

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2007-12-21 Thread Benjamin Herrenschmidt
On Fri, 2007-12-21 at 06:16 -0700, Matthew Wilcox wrote: On Fri, Dec 21, 2007 at 10:33:26AM +, Alan Cox wrote: On Fri, 21 Dec 2007 13:30:08 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level

Re: INITIO scsi driver fails to work properly

2007-12-21 Thread Chuck Ebbert
On 12/21/2007 04:03 PM, James Bottomley wrote: On Fri, 2007-12-21 at 14:30 -0500, Chuck Ebbert wrote: On 12/19/2007 03:48 AM, Filippos Papadopoulos wrote: On Dec 17, 2007 2:18 PM, Boaz Harrosh [EMAIL PROTECTED] wrote: I have found one problem. Please try patch [2] below and report. If it

Re: [PATCH 1/3] cciss: export more attributes to sysfs (repost)

2007-12-21 Thread Andrew Morton
On Fri, 14 Dec 2007 16:17:44 -0600 Mike Miller [EMAIL PROTECTED] wrote: Patch 1 of 3 Sorry to take so long to repost. This patch exports more attributes to /sys so we can work work better with udev. Some distros use unique_id among other attributes. This patch attempts to provide that

[PATCH 0/2] Series short description

2007-12-21 Thread Vasu Dev
The following series implements... Cleaned up FCoE logging by use of simpler logging macro OFC_DBG. -- Signature - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] Removed unused sa_log functions

2007-12-21 Thread Vasu Dev
Signed-off-by: Vasu Dev [EMAIL PROTECTED] --- drivers/scsi/ofc/libsa/Makefile|1 drivers/scsi/ofc/libsa/sa_cons_linux.c | 37 -- drivers/scsi/ofc/libsa/sa_log.c| 117 3 files changed, 0 insertions(+), 155 deletions(-) diff --git