lpfc build failure in latest git

2008-02-02 Thread maximilian attems
CC [M] drivers/scsi/lpfc/lpfc_init.o drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_pci_probe_one’: drivers/scsi/lpfc/lpfc_init.c:1897: error: implicit declaration of function ‘pci_enable_device_bars’ make[6]: *** [drivers/scsi/lpfc/lpfc_init.o] Error 1 seen on both x86 archs. - To

Re: Integration of SCST in the mainstream Linux kernel

2008-02-02 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Wed, 30 Jan 2008 10:34 -0600: On Wed, 2008-01-30 at 09:38 +0100, Bart Van Assche wrote: On Jan 30, 2008 12:32 AM, FUJITA Tomonori [EMAIL PROTECTED] wrote: iSER has parameters to limit the maximum size of RDMA (it needs to repeat RDMA with a poor

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread Jeff Garzik
Ingo Molnar wrote: === --- linux.orig/drivers/scsi/lpfc/lpfc_init.c +++ linux/drivers/scsi/lpfc/lpfc_init.c @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev, uint16_t iotag; int bars =

Re: lpfc build failure in latest git

2008-02-02 Thread James Bottomley
On Sat, 2008-02-02 at 15:36 +0100, maximilian attems wrote: CC [M] drivers/scsi/lpfc/lpfc_init.o drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_pci_probe_one’: drivers/scsi/lpfc/lpfc_init.c:1897: error: implicit declaration of function ‘pci_enable_device_bars’ make[6]: ***

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread James Bottomley
On Sat, 2008-02-02 at 10:51 -0500, Jeff Garzik wrote: Ingo Molnar wrote: === --- linux.orig/drivers/scsi/lpfc/lpfc_init.c +++ linux/drivers/scsi/lpfc/lpfc_init.c @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread Ingo Molnar
* Jeff Garzik [EMAIL PROTECTED] wrote: Ingo Molnar wrote: === --- linux.orig/drivers/scsi/lpfc/lpfc_init.c +++ linux/drivers/scsi/lpfc/lpfc_init.c @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev, uint16_t

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread Jeff Garzik
Ingo Molnar wrote: it would have been totally appropriate for me to just send a mail to lkml with the proper subject line about the breakage. (I might even have decided to stay completely silent about the issue and fix it for my own build, letting you guys figure it out.) Oh come on... You

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread Ingo Molnar
* Jeff Garzik [EMAIL PROTECTED] wrote: Ingo Molnar wrote: it would have been totally appropriate for me to just send a mail to lkml with the proper subject line about the breakage. (I might even have decided to stay completely silent about the issue and fix it for my own build, letting

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread James Bottomley
On Sat, 2008-02-02 at 18:08 +0100, Ingo Molnar wrote: * Jeff Garzik [EMAIL PROTECTED] wrote: Ingo Molnar wrote: === --- linux.orig/drivers/scsi/lpfc/lpfc_init.c +++ linux/drivers/scsi/lpfc/lpfc_init.c @@ -1894,7 +1894,7

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread Jeff Garzik
Ingo Molnar wrote: * Jeff Garzik [EMAIL PROTECTED] wrote: Ingo Molnar wrote: it would have been totally appropriate for me to just send a mail to lkml with the proper subject line about the breakage. (I might even have decided to stay completely silent about the issue and fix it for my own

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-02 Thread Greg KH
On Fri, Feb 01, 2008 at 07:43:54PM -0500, Mike Snitzer wrote: Hi Greg, Given your recent call for review of the next 2.6.22-stable I'd appreciate it if you and the rest of the stable team would strongly consider this SCSI IO error propagation fix for inclusion in 2.6.22.17 (as well as the

Re: [patch] pci: pci_enable_device_bars() fix

2008-02-02 Thread Jeff Garzik
Ingo Molnar wrote: so please tell me Jeff. If Greg, who is the super-maintainer of your code area, and who deals with your code every day and changes it every minute and hour, simply did not Cc: the SCSI list - how am i, a largely outside party in this matter, supposed to notice that 3

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-02 Thread Greg KH
On Sat, Feb 02, 2008 at 03:56:30PM -0500, Mike Snitzer wrote: On Feb 2, 2008 3:24 PM, Greg KH [EMAIL PROTECTED] wrote: On Fri, Feb 01, 2008 at 07:43:54PM -0500, Mike Snitzer wrote: Hi Greg, Given your recent call for review of the next 2.6.22-stable I'd appreciate it if you and the

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-02 Thread James Bottomley
On Fri, 2008-02-01 at 12:03 -0500, Tony Battersby wrote: This patch fixes a problem with some out-of-spec SCSI disks that report hardware or medium errors incorrectly. Without the patch, the kernel may silently ignore a failed write command or return corrupted data on a failed read command.

Re: [Bug 9734] New: I/O error when inserting a second firewire sata disk

2008-02-02 Thread Stefan Richter
I wrote on 2008-01-13: James Bottomley wrote: Firewire list cc'd Jan 12 16:50:49 x3400 kernel: firewire_sbp2: orb reply timed out, rcode=0x11 Jan 12 16:50:49 x3400 kernel: sd 11:0:0:0: [sdc] Result: hostbyte=DID_BUS_BUSY driverbyte=DRIVER_OK,SUGGEST_OK Best I can tell, this is the source