[PATCH] qla2xxx: Correct loop_id_map allocation-size and usage.

2012-09-20 Thread Saurav Kashyap
From: Andrew Vasquez andrew.vasq...@qlogic.com Original code incorrectly assigned LOOPID_MAP_SIZE to be the allocation size in bytes rather than total bit size. Additionally corrected code to check for bit-allocation failure in qla2x00_find_new_loop_id(). Signed-off-by: Andrew Vasquez

Re: [PATCH] qla2xxx: Correct loop_id_map allocation-size and usage.

2012-09-20 Thread James Bottomley
On Thu, 2012-09-20 at 03:39 -0400, Saurav Kashyap wrote: From: Andrew Vasquez andrew.vasq...@qlogic.com Original code incorrectly assigned LOOPID_MAP_SIZE to be the allocation size in bytes rather than total bit size. Additionally corrected code to check for bit-allocation failure in

bfa_ioc.c:3407 code aligned with following code on line 3409

2012-09-20 Thread Fengguang Wu
Hi Krishna, According to these (old) coccinelle warnings, bfa_cb_sfp_state_query() has very weird indents and if blocks: drivers/scsi/bfa/bfa_ioc.c:3407:3-18: code aligned with following code on line 3409 drivers/scsi/bfa/bfa_ioc.c:3415:4-19: code aligned with following code on line 3417

[PATCH 04/13] qla4xxx: Fix double IDC locking in qla4_8xxx_error_recovery

2012-09-20 Thread vikas . chaudhary
From: Poornima Vonti poornima.vo...@qlogic.com Issue: In qla4_8xxx_error_recovery() IDC lock recovery is initiated as IDC lock is held while enabling the interrupts Fix: Correctly handle IDC locking mechanism in qla4_8xxx_error_recovery(). Signed-off-by: Poornima Vonti poornima.vo...@qlogic.com

[PATCH 00/13] qla4xxx: Updates for scsi misc branch

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Manish Dusane (2): qla4xxx: Added new mbox cmd to pass driver version to FW qla4xxx: Fix double clearing of risc_intr for ISP83XX

[PATCH 01/13] qla4xxx: Added new mbox cmd to pass driver version to FW

2012-09-20 Thread vikas . chaudhary
From: Manish Dusane manish.dus...@qlogic.com Signed-off-by: Manish Dusane manish.dus...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_fw.h |3 +++ drivers/scsi/qla4xxx/ql4_glbl.h |1 + drivers/scsi/qla4xxx/ql4_mbx.c | 37

[PATCH 03/13] qla4xxx: Clear interrupt while unloading driver for ISP83XX

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index

[PATCH 02/13] qla4xxx: Print correct IDC version

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_nx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index

[PATCH 13/13] qla4xxx: Update driver version to 5.03.00-k1

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h

[PATCH 09/13] qla4xxx: update LICENSE.qla4xxx

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- Documentation/scsi/LICENSE.qla4xxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/scsi/LICENSE.qla4xxx b/Documentation/scsi/LICENSE.qla4xxx

[PATCH 10/13] qla4xxx: IDC implementation for Loopback

2012-09-20 Thread vikas . chaudhary
From: Nilesh Javali nilesh.jav...@qlogic.com Handle IDC Request Notify AEN and post IDC Acknowledgement while participating in Loopback IDC. Signed-off-by: Nilesh Javali nilesh.jav...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_83xx.h |8

[PATCH 11/13] qla4xxx: Fix double clearing of risc_intr for ISP83XX

2012-09-20 Thread vikas . chaudhary
From: Manish Dusane manish.dus...@qlogic.com Issue: For ISP83XX risc_intr getting clear two times in case of polling mode. risc_intr getting clear from interrupt_service_routine() as well from process_mbox_intr() because of this driver may clear risc_intr without processing interrupt. Fix: Do

[PATCH 12/13] qla4xxx: Disable generating pause frames for ISP83XX

2012-09-20 Thread vikas . chaudhary
From: Tej Parkash tej.park...@qlogic.com In case of FW hung ISP83XX generates continuous pause frames which causes switch to disable port. Added fix to disable generating pause frames in case of FW hung Signed-off-by: Tej Parkash tej.park...@qlogic.com Signed-off-by: Vikas Chaudhary

[PATCH 08/13] qla4xxx: Fix panic while rmmod

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Issue: System panic on rmmod if probe_adapter had failed during driver load. Call Trace: [a071aa5a] qla4xxx_abort_active_cmds+0x4a/0xa0 [qla4xxx] [a07224db] qla4xxx_free_adapter+0x1b/0x1b0 [qla4xxx] [a073991f]

[PATCH 06/13] qla4xxx: Prevent MSI/MSI-X falling back to INTx for ISP82XX

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com For ISP82xx mixed interrupt mode is not supported. Hence prevent MSI/MSI-x from falling back to INTx mode. Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_isr.c | 13 ++--- 1 files changed, 10

[PATCH 05/13] qla4xxx: Update idc reg in case of PCI AER

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Camram is reset by FW to default values after reboot/cold boot/pci reset. In case of AER, PCI may need to reset so we need to set correct idc reg value after PCIE error. Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com ---

[PATCH 07/13] qla4xxx: Fail probe_adapter if IRQ allocation fails

2012-09-20 Thread vikas . chaudhary
From: Poornima Vonti poornima.vo...@qlogic.com If IRQ allocation fails, it means system has run out of interrupt vectors, so fail probe_adapter in case of IRQ allocation failure and dont retry adapter initialization. Signed-off-by: Poornima Vonti poornima.vo...@qlogic.com Signed-off-by: Vikas

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-20 Thread Yijing Wang
On 2012/9/20 9:47, Yijing Wang wrote: We compared the two situations after BIOS initialization, and found Max Payload Size in DEVCTRL is 256B if FC card had been installed, if the slot is empty, Max Payload Size is 128B. We force it to be 128B when FC card installed when system boot up.

Re: Discard merging / Write same support v5

2012-09-20 Thread Jens Axboe
On 09/18/2012 06:19 PM, Martin K. Petersen wrote: I've been beating on this patch kit for the last few weeks with a bunch of different devices. I have also tested extensively with Shaohua Li's MD RAID0 discard support. The only functional change is support for discard and write same

Re: Discard merging / Write same support v5

2012-09-20 Thread James Bottomley
On Thu, 2012-09-20 at 14:33 +0200, Jens Axboe wrote: On 09/18/2012 06:19 PM, Martin K. Petersen wrote: I've been beating on this patch kit for the last few weeks with a bunch of different devices. I have also tested extensively with Shaohua Li's MD RAID0 discard support. The only

Re: Discard merging / Write same support v5

2012-09-20 Thread Jens Axboe
On 09/20/2012 02:43 PM, James Bottomley wrote: On Thu, 2012-09-20 at 14:33 +0200, Jens Axboe wrote: On 09/18/2012 06:19 PM, Martin K. Petersen wrote: I've been beating on this patch kit for the last few weeks with a bunch of different devices. I have also tested extensively with Shaohua Li's

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-20 Thread Bjorn Helgaas
On Thu, Sep 20, 2012 at 6:26 AM, Yijing Wang wangyij...@huawei.com wrote: On 2012/9/20 9:47, Yijing Wang wrote: We compared the two situations after BIOS initialization, and found Max Payload Size in DEVCTRL is 256B if FC card had been installed, if the slot is empty, Max Payload Size is

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-20 Thread Jiang Liu
Hi Bjorn, We will try to work out a patch for this issue, won't silently ignore it. We also found another issue related to ARI. The steps to reproduce the bug is: 1) Boot with a ARI-capable device connected to ARI-capable port, so ARI will be enabled. 2) Hot-remove the ARI-capable

Re: Kernel crash with unsupported DIF protection type

2012-09-20 Thread Martin K. Petersen
Hannes == Hannes Reinecke h...@suse.de writes: Hannes I recently got my hands on some weird drives, insisting on Hannes having been formatted with protection type 7: Lovely :| Hannes I've attached a tentative patch, which allows the system to Hannes boot. However, I'm not completely happy

Re: [PATCH v7 0/6] ZPODD patches

2012-09-20 Thread Rafael J. Wysocki
On Wednesday, September 19, 2012, Aaron Lu wrote: On 09/19/2012 08:50 PM, Rafael J. Wysocki wrote: On Wednesday, September 19, 2012, James Bottomley wrote: On Wed, 2012-09-19 at 16:03 +0800, Aaron Lu wrote: Hi James, May I know if this patchset will enter v3.7? Sigh, well, I was

Re: [PATCH v7 1/6] block: genhd: add an interface to set disk poll interval

2012-09-20 Thread Rafael J. Wysocki
Please add a changelog explaining who's going to use the new interface, in addition to the original user of that code, and why it is exported. Thanks, Rafael On Wednesday, September 12, 2012, Aaron Lu wrote: Signed-off-by: Aaron Lu aaron...@intel.com --- block/genhd.c | 23

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-20 Thread Rafael J. Wysocki
On Wednesday, September 12, 2012, Aaron Lu wrote: Place the ODD into runtime suspend state as soon as there is nobody using it. OK, so how is ODD related to the sr driver? The only exception is, if we just find that a new medium is inserted, we wait for the next events checking to idle it.

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-20 Thread Alan Stern
On Thu, 20 Sep 2012, Rafael J. Wysocki wrote: On Wednesday, September 12, 2012, Aaron Lu wrote: Place the ODD into runtime suspend state as soon as there is nobody using it. OK, so how is ODD related to the sr driver? Aaron did not make it clear in this patch description, although it may

[PATCH 1/2] hpsa: gen8plus Smart Array IDs

2012-09-20 Thread Mike Miller
hpsa: add PCI ID's for next gen Smart Array From: Mike Miller mike.mil...@hp.com No marketing names yet available for the next generation of Smart Array. --- drivers/scsi/hpsa.c | 18 ++ include/linux/pci_ids.h |1 + 2 files changed, 19 insertions(+), 0 deletions(-)

[PATCH 2/2] hpsa: Smart Array Gen8 marketing names

2012-09-20 Thread Mike Miller
hpsa: add marketing names for Gen8 controllers From: Mike Miller mike.mil...@hp.com Now that the controllers have announced I can add the marketing names for the Proliant Gen8 server controllers. --- drivers/scsi/hpsa.c | 16 1 files changed, 8 insertions(+), 8 deletions(-)

Re: [PATCH v7 0/6] ZPODD patches

2012-09-20 Thread Rafael J. Wysocki
On Wednesday, September 19, 2012, James Bottomley wrote: On Wed, 2012-09-19 at 14:50 +0200, Rafael J. Wysocki wrote: On Wednesday, September 19, 2012, James Bottomley wrote: On Wed, 2012-09-19 at 16:03 +0800, Aaron Lu wrote: Hi James, May I know if this patchset will enter v3.7?

Re: [PATCH v7 3/6] scsi: sr: support zero power ODD(ZPODD)

2012-09-20 Thread Rafael J. Wysocki
On Wednesday, September 12, 2012, Aaron Lu wrote: When ODD is runtime suspended, we will check if it is OK to remove its power: 1 For tray type, no medium inside and tray closed; 2 For slot type, no medium inside. And if yes, we will set the ready_to_power_off flag as an indication to ATA

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-20 Thread Aaron Lu
On Thu, Sep 20, 2012 at 10:48:10PM +0200, Rafael J. Wysocki wrote: On Wednesday, September 12, 2012, Aaron Lu wrote: Place the ODD into runtime suspend state as soon as there is nobody using it. OK, so how is ODD related to the sr driver? As Alan has explained, ODD(optical disk drive) is

Re: [PATCH v7 3/6] scsi: sr: support zero power ODD(ZPODD)

2012-09-20 Thread Aaron Lu
On Fri, Sep 21, 2012 at 12:07:23AM +0200, Rafael J. Wysocki wrote: On Wednesday, September 12, 2012, Aaron Lu wrote: static struct scsi_driver sr_template = { .owner = THIS_MODULE, @@ -87,6 +89,8 @@ static struct scsi_driver sr_template = { .name

Re: [PATCH v7 0/6] ZPODD patches

2012-09-20 Thread Aaron Lu
On Thu, Sep 20, 2012 at 10:00:51PM +0200, Rafael J. Wysocki wrote: On Wednesday, September 19, 2012, Aaron Lu wrote: Thanks Rafael, and if there is any question/problem, please kindly let me know. Well, unfortunately my initial review indicates that the patchset is not quite ready to go

[PATCH] target: fix return value check in sbp_register_configfs()

2012-09-20 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function target_fabric_configfs_init() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch.