Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread Stefan Richter
On Nov 11 Stefan Richter wrote: On Nov 09 Elliott, Robert (Server Storage) wrote: I recommend broadening this patch. T10 is discussing making READ (10), WRITE (10), etc. obsolete in SBC-4 in favor of their 16-byte CDB counterparts. The algorithm should be: 1. During discovery,

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Fri, 2012-11-09 at 16:33 +, Elliott, Robert (Server Storage) wrote: I recommend broadening this patch. T10 is discussing making READ (10), WRITE (10), etc. obsolete in SBC-4 in favor of their 16-byte CDB counterparts. The algorithm should be: 1. During discovery, determine if

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 13b8bcd..6ff785e 100644 --- a/drivers/usb/storage/scsiglue.c +++ b/drivers/usb/storage/scsiglue.c @@ -251,6 +251,11 @@ static int slave_configure(struct

Re: scsi target, likely GPL violation

2012-11-12 Thread Theodore Ts'o
On Sun, Nov 11, 2012 at 10:15:02AM -0500, Bradley M. Kuhn wrote: Andy's initial email ended with the request: Please explain. Thus, Andy's email seemed designed to seek facts, which I think is a reasonable and good thing to do here. Meanwhile, the facts *still* aren't clear here yet. ...

Re: scsi target, likely GPL violation

2012-11-12 Thread Alan Cox
On Mon, 12 Nov 2012 09:08:43 -0500 Theodore Ts'o ty...@mit.edu wrote: On Sun, Nov 11, 2012 at 10:15:02AM -0500, Bradley M. Kuhn wrote: Andy's initial email ended with the request: Please explain. Thus, Andy's email seemed designed to seek facts, which I think is a reasonable and good

Re: scsi target, likely GPL violation

2012-11-12 Thread Bradley M. Kuhn
Lawrence Rosen wrote at 17:13 (EST) on Sunday: First, I hope that we can tone down the arguments about whether the use of Linux APIs and headers automatically turns a program into a derivative work of Linux. I think that argument has been largely debunked in the U.S. in the recent decision in

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 12:33, James Bottomley ha scritto: On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 13b8bcd..6ff785e 100644 --- a/drivers/usb/storage/scsiglue.c +++ b/drivers/usb/storage/scsiglue.c @@

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread Jason J. Herne
On Mon, Nov 12, 2012 at 9:31 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/11/2012 12:33, James Bottomley ha scritto: On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 13b8bcd..6ff785e 100644 ---

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Mon, 2012-11-12 at 15:31 +0100, Paolo Bonzini wrote: Il 12/11/2012 12:33, James Bottomley ha scritto: On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 13b8bcd..6ff785e 100644 ---

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread Jason J. Herne
On Mon, Nov 12, 2012 at 10:10 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2012-11-12 at 15:31 +0100, Paolo Bonzini wrote: Il 12/11/2012 12:33, James Bottomley ha scritto: On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Mon, 2012-11-12 at 10:01 -0500, Jason J. Herne wrote: Any reason not to do this always on 2TB drives, which basically means changing this: - } else if (block 0x) { + } else if (sdkp-capacity 0x) { and nothing else? This was the intent of my patch,

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 16:10, James Bottomley ha scritto: Actually it only turns it on for large capacity drives, as said in the comment. sdp-force_read_16 only matters for 2TB drives: If you follow the discussion, we'll need to turn it on for some drives regardless of size. Even if the two

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread Alan Stern
On Mon, 12 Nov 2012, Paolo Bonzini wrote: Il 12/11/2012 16:10, James Bottomley ha scritto: Actually it only turns it on for large capacity drives, as said in the comment. sdp-force_read_16 only matters for 2TB drives: If you follow the discussion, we'll need to turn it on for some

Re: [PATCH v9 03/10] ata: zpodd: identify and init ZPODD devices

2012-11-12 Thread Tejun Heo
Hello, On Fri, Nov 09, 2012 at 02:51:55PM +0800, Aaron Lu wrote: void ata_acpi_unbind(struct ata_device *dev) { + if (zpodd_dev_enabled(dev)) + zpodd_deinit(dev); Maybe zpodd_exit() instead? +void zpodd_init(struct ata_device *dev) +{ + int ret; + struct zpodd

Re: [PATCH v9 04/10] libata: acpi: move acpi notification code to zpodd

2012-11-12 Thread Tejun Heo
On Fri, Nov 09, 2012 at 02:51:56PM +0800, Aaron Lu wrote: Since the ata acpi notification code introduced in commit 3bd46600a7a7e938c54df8cdbac9910668c7dfb0 is solely for ZPODD, and we now have a dedicated place for it, move these code there. And the add/remove_pm_notifier code is simplified

Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-12 Thread Tejun Heo
On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD code, so separate them out to a file named libata-atapi.c, and the Makefile is modified accordingly. No functional changes should result from this commit. Why is this

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-12 Thread Tejun Heo
Hello, On Fri, Nov 09, 2012 at 02:51:58PM +0800, Aaron Lu wrote: @@ -784,7 +784,13 @@ static int ata_acpi_push_id(struct ata_device *dev) */ int ata_acpi_on_suspend(struct ata_port *ap) { - /* nada */ + struct ata_device *dev; + + ata_for_each_dev(dev, ap-link, ENABLED) {

Re: [PATCH v9 07/10] block: add a new interface to block events

2012-11-12 Thread Tejun Heo
On Fri, Nov 09, 2012 at 02:51:59PM +0800, Aaron Lu wrote: A new interface to block disk events is added, this interface is meant to eliminate a race between PM runtime callback and disk events checking. Suppose the following device tree: device_sata_port (the parent) device_ODD

Re: [PATCH v9 07/10] block: add a new interface to block events

2012-11-12 Thread Alan Stern
On Mon, 12 Nov 2012, Tejun Heo wrote: On Fri, Nov 09, 2012 at 02:51:59PM +0800, Aaron Lu wrote: A new interface to block disk events is added, this interface is meant to eliminate a race between PM runtime callback and disk events checking. Suppose the following device tree:

Re: [PATCH v9 07/10] block: add a new interface to block events

2012-11-12 Thread Tejun Heo
Hello, Alan. On Mon, Nov 12, 2012 at 02:18:11PM -0500, Alan Stern wrote: Weren't you gonna do something different about this? I mean, if sr knows that autopm kicked in, it can simply tell the block layer that nothing is going on. Wouldn't that be simpler? It wouldn't work for non-ZP

Re: [PATCH v9 07/10] block: add a new interface to block events

2012-11-12 Thread Alan Stern
On Mon, 12 Nov 2012, Tejun Heo wrote: Hello, Alan. On Mon, Nov 12, 2012 at 02:18:11PM -0500, Alan Stern wrote: Weren't you gonna do something different about this? I mean, if sr knows that autopm kicked in, it can simply tell the block layer that nothing is going on. Wouldn't that

Re: [patch,v2 00/10] make I/O path allocations more numa-friendly

2012-11-12 Thread Jeff Moyer
Bart Van Assche bvanass...@acm.org writes: On 11/09/12 21:46, Jeff Moyer wrote: On 11/06/12 16:41, Elliott, Robert (Server Storage) wrote: It's certainly better to tie them all to one node then let them be randomly scattered across nodes; your 6% observation may simply be from that. How do

RE: [patch,v2 00/10] make I/O path allocations more numa-friendly

2012-11-12 Thread Elliott, Robert (Server Storage)
What do these commands report about the NUMA and non-uniform IO topology on the test system? numactl --hardware lspci -t -Original Message- From: Jeff Moyer [mailto:jmo...@redhat.com] Sent: Monday, 12 November, 2012 3:27 PM To: Bart Van Assche Cc: Elliott, Robert