Re: [PATCH v9 05/10] libata: separate ATAPI code

2012-11-13 Thread Aaron Lu
On Mon, Nov 12, 2012 at 10:57:10AM -0800, Tejun Heo wrote: On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD code, so separate them out to a file named libata-atapi.c, and the Makefile is modified accordingly. No

re: [SCSI] qla4xxx: fix flash/ddb support

2012-11-13 Thread Dan Carpenter
Hello Mike Christie, The patch 13483730a13b: [SCSI] qla4xxx: fix flash/ddb support from Dec 1, 2011, leads to the following warning: drivers/scsi/qla4xxx/ql4_os.c:714 qla4xxx_ep_connect() error: memcpy() 'dst_addr' too small (16 vs 28) I've sort of reported this bug before because it

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-13 Thread Aaron Lu
On Mon, Nov 12, 2012 at 11:13:03AM -0800, Tejun Heo wrote: Hello, On Fri, Nov 09, 2012 at 02:51:58PM +0800, Aaron Lu wrote: +/* + * Check ODD's zero power ready status. + * + * This function is called during ATA port's suspend path, + * when the port is not frozen yet, so that we can

Re: [patch,v2 00/10] make I/O path allocations more numa-friendly

2012-11-13 Thread Jeff Moyer
Elliott, Robert (Server Storage) elli...@hp.com writes: What do these commands report about the NUMA and non-uniform IO topology on the test system? This is a DELL PowerEdge R715. See chapter 7 of this document for details on how the I/O bridges are connected:

[PATCH v3 0/2] add per-device sysfs knob to enable unrestricted, unprivileged SG_IO

2012-11-13 Thread Paolo Bonzini
Privilege restrictions for SG_IO right now apply without distinction to all devices, based on the single capability CAP_SYS_RAWIO. This is a very broad capability, and makes it difficult to give SG_IO access to trusted clients that need access to persistent reservations, trim/discard, or

[PATCH v3 2/2] sg_io: introduce unpriv_sgio queue flag

2012-11-13 Thread Paolo Bonzini
This queue flag will let unprivileged users send any SG_IO command to the device, without any filtering. This makes it possible to run a program where you want to access the full range of SCSI commands, while still running as confined as possible. With this patch, such a program will not need

[PATCH v3 1/2] sg_io: pass request_queue to blk_verify_command

2012-11-13 Thread Paolo Bonzini
Adjust the blk_verify_command function to let it look at per-queue data. This will be done in the next patch. Cc: linux-scsi@vger.kernel.org Cc: Alan Cox a...@lxorguk.ukuu.org.uk Cc: James Bottomley james.bottom...@hansenpartnership.com Cc: Jens Axboe ax...@kernel.dk Cc: Ric Wheeler

Re: [PATCH v3 1/2] sg_io: pass request_queue to blk_verify_command

2012-11-13 Thread Tejun Heo
On Tue, Nov 13, 2012 at 06:25:12PM +0100, Paolo Bonzini wrote: Adjust the blk_verify_command function to let it look at per-queue data. This will be done in the next patch. Cc: linux-scsi@vger.kernel.org Cc: Alan Cox a...@lxorguk.ukuu.org.uk Cc: James Bottomley

Re: [PATCH v3 2/2] sg_io: introduce unpriv_sgio queue flag

2012-11-13 Thread Tejun Heo
On Tue, Nov 13, 2012 at 06:25:13PM +0100, Paolo Bonzini wrote: This queue flag will let unprivileged users send any SG_IO command to the device, without any filtering. This makes it possible to run a program where you want to access the full range of SCSI commands, while still running as

[PATCH] Use SCSI read/write(16) with 2TB drives

2012-11-13 Thread Jason J. Herne
From: Jason J. Herne hern...@gmail.com Force large capacity ( 2TB) drives to use READ/WRITE(16) instead of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands when a large capacity drive is installed. Signed-off-by: Jason J. Herne hern...@gmail.com --- drivers/scsi/sd.c

Re: [PATCH] Use SCSI read/write(16) with 2TB drives

2012-11-13 Thread Paolo Bonzini
Il 14/11/2012 01:54, Jason J. Herne ha scritto: blk_queue_physical_block_size(sdp-request_queue, sdkp-physical_block_size); sdkp-device-sector_size = sector_size; + + /* Use read/write(16) for 2TB disks */ + sdp-use_16_for_rw =

Re: [PATCH v9 03/10] ata: zpodd: identify and init ZPODD devices

2012-11-13 Thread Aaron Lu
On 11/13/2012 02:53 AM, Tejun Heo wrote: Hello, On Fri, Nov 09, 2012 at 02:51:55PM +0800, Aaron Lu wrote: void ata_acpi_unbind(struct ata_device *dev) { +if (zpodd_dev_enabled(dev)) +zpodd_deinit(dev); Maybe zpodd_exit() instead? OK. +void zpodd_init(struct

Re: [PATCH v9 04/10] libata: acpi: move acpi notification code to zpodd

2012-11-13 Thread Aaron Lu
On 11/13/2012 02:55 AM, Tejun Heo wrote: On Fri, Nov 09, 2012 at 02:51:56PM +0800, Aaron Lu wrote: Since the ata acpi notification code introduced in commit 3bd46600a7a7e938c54df8cdbac9910668c7dfb0 is solely for ZPODD, and we now have a dedicated place for it, move these code there. And the

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-13 Thread Aaron Lu
On 11/13/2012 03:13 AM, Tejun Heo wrote: Hello, On Fri, Nov 09, 2012 at 02:51:58PM +0800, Aaron Lu wrote: +#define POWEROFF_DELAY (30 * 1000) /* 30 seconds for power off delay */ + struct zpodd { bool slot:1; bool drawer:1; bool from_notify:1; /* resumed as a

[PATCH] Try #2: Use SCSI read/write(16) with 2TB drives

2012-11-13 Thread Jason J. Herne
From: Jason J. Herne hern...@gmail.com Force large capacity ( 2TB) drives to use READ/WRITE(16) instead of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands when a large capacity drive is installed. Signed-off-by: Jason J. Herne hern...@gmail.com --- drivers/scsi/sd.c

Re: [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue

2012-11-13 Thread James Bottomley
On Wed, 2012-10-24 at 01:45 -0500, Mike Christie wrote: On 10/19/2012 06:15 PM, John Soni Jose wrote: @@ -763,26 +750,14 @@ static int beiscsi_get_port_speed(struct Scsi_Host *shost) BS_%d : Getting Port Speed Failed\n); return -EBUSY; -}

Re: [PATCH 0/7] qla4xxx: Updates for scsi misc branch

2012-11-13 Thread James Bottomley
On Wed, 2012-10-10 at 11:08 -0500, Michael Christie wrote: On Oct 10, 2012, at 6:24 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas.

Re: [PATCH 1/1] aacraid: SCSI dma mapping failure case handling

2012-11-13 Thread James Bottomley
On Tue, 2012-10-16 at 23:34 +0200, Tomas Henzl wrote: On 10/16/2012 10:59 PM, Mahesh Rajashekhara wrote: This patch handles SCSI dma mapping failure case. Reporting error code to the upper layer instead of BUG_ON(). This patch is created against current upstream kernel.

Re: [PATCH v2 01/19] be2iscsi: Fix the issue with soft reset.

2012-11-13 Thread James Bottomley
On Sat, 2012-10-20 at 04:41 +0530, John Soni Jose wrote: From: Minh Tran minhduc.t...@emulex.com Fixed soft_reset problem which driver modified all 32bit before a write on second pass. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by: Jayamohan Kallickal

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-13 Thread James Bottomley
On Fri, 2012-10-12 at 17:05 +0800, NickCheng wrote: -#define ARCMSR_HBCMU_OUTBOUND_DOORBELL_ISR_MASK0x0004 /* When clear, the General Outbound Doorbell interrupt routes to the host.*/ The patch is still linebroken here. It is a massively long line (like about 200 characters). I

Re: [v6 PATCH 1/8] cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates).

2012-11-13 Thread James Bottomley
On Thu, 2012-10-25 at 15:20 +0530, Naresh Kumar Inna wrote: This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4/cxgb4vf source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com ---

Re: [PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-11-13 Thread James Bottomley
On Thu, 2012-10-18 at 17:37 +0530, vinayak holikatti wrote: I am Vacation will look into it when i am back to work. This doesn't apply on 3.7-rc1. Am I missing any patches in between ? OK, so it doesn't apply for me either: patching file drivers/scsi/ufs/ufshcd.c Hunk #11 FAILED at 902. Hunk