Re: [PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-09 Thread Dolev Raviv
+ */ +int ufshcd_query_request(struct ufs_hba *hba, + struct ufs_query_req *query, + u8 *descriptor, + struct ufs_query_res *response, + int timeout, + int retries) +{ +

RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread Seungwon Jeon
On Thursday, May 09, 2013 Santosh wrote: There are two patches remained. These are applied with your final comments. Do you have any idea? [PATCH v4 5/6] scsi: ufs: add dme configuration primitives [PATCH v4 6/6] scsi: ufs: add dme control primitives Since there is no use case for

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread Santosh Y
On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon tgih@samsung.com wrote: On Thursday, May 09, 2013 Santosh wrote: There are two patches remained. These are applied with your final comments. Do you have any idea? [PATCH v4 5/6] scsi: ufs: add dme configuration primitives [PATCH v4 6/6]

Re: [PATCH v4 5/6] scsi: ufs: add dme configuration primitives

2013-05-09 Thread Santosh Y
On Wed, May 8, 2013 at 2:12 PM, Seungwon Jeon tgih@samsung.com wrote: Implements to support Get and Set operation of the DME. These operations are used to configure the behavior of the UNIPRO. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org

Re: [PATCH v4 6/6] scsi: ufs: add dme control primitives

2013-05-09 Thread Santosh Y
On Wed, May 8, 2013 at 2:13 PM, Seungwon Jeon tgih@samsung.com wrote: Implements to support the following operations. Currently, this patch doesn't introduce DME_ENABLE and DME_RESET because host controller's HCE enable contains these roles. DME_POWERON{OFF}, DME_HIBERNATE_ENTER{EXIT},

[PATCH 01/21] [SCSI] libiscsi: remove inline marking of EXPORT_SYMBOL functions

2013-05-09 Thread Denis Efremov
EXPORT_SYMBOL and inline directives are contradictory to each other. The patch fixes this inconsistency. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov yefremov.de...@gmail.com --- drivers/scsi/libiscsi.c | 2 +- drivers/scsi/libiscsi_tcp.c | 8

[PATCH V4] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-05-09 Thread Dolev Raviv
Allow UFS device to complete its initialization and accept SCSI commands by setting fDeviceInit flag. The device may take time for this operation and hence the host should poll until fDeviceInit flag is toggled to zero. This step is mandated by UFS device specification for device initialization

[PATCH 1/8] iscsi_transport: Remove net param enum numbers

2013-05-09 Thread vikas.chaudhary
From: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- include/scsi/iscsi_if.h | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-)

[PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-05-09 Thread vikas.chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Exporting new iSCSI Session and Connection parameters to sysfs Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/scsi_transport_iscsi.c | 135

[PATCH 0/8] qla4xxx: Updates for scsi misc branch

2013-05-09 Thread vikas.chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Following patches are to display additional iSCSI connection and session parameters to sysfs as well allow setting and display of additional Network parameter for iSCSI interface. Please apply these patches to the scsi tree misc branch at

[PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-09 Thread vikas.chaudhary
From: Harish Zunjarrao harish.zunjar...@qlogic.com Added support to display and update additional network parameters through iscsiadm Signed-off-by: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/scsi_transport_iscsi.c |

[PATCH 3/8] qla4xxx: Additional parameters for net settings

2013-05-09 Thread vikas.chaudhary
From: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_def.h | 31 ++ drivers/scsi/qla4xxx/ql4_fw.h | 53 +- drivers/scsi/qla4xxx/ql4_glbl.h |

[PATCH 8/8] qla4xxx: Update driver version to 5.03.00-k10

2013-05-09 Thread vikas.chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index

[PATCH 5/8] libiscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-05-09 Thread vikas.chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/libiscsi.c | 113 include/scsi/libiscsi.h |

[PATCH 6/8] qla4xxx: Exporting new attrs for iscsi session and connection in sysfs

2013-05-09 Thread vikas.chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_os.c | 222 +++--- 1 file changed, 165

[PATCH 7/8] qla4xxx: Add support to allow flashnode multi-session login.

2013-05-09 Thread vikas.chaudhary
From: Manish Rangankar manish.rangan...@qlogic.com Signed-off-by: Manish Rangankar manish.rangan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_os.c | 69 ++- 1 file changed, 62 insertions(+), 7

[patch] [SCSI] pm80xx: remove unneeded NULL check

2013-05-09 Thread Dan Carpenter
Coccinelle complains about the inconsistent NULL checking on t. It turns out the check isn't needed because we verified that t is non-NULL at the start of the function. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/scsi/pm8001/pm8001_hwi.c

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread James Bottomley
On Thu, 2013-05-09 at 12:22 +0530, Santosh Y wrote: On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon tgih@samsung.com wrote: On Thursday, May 09, 2013 Santosh wrote: There are two patches remained. These are applied with your final comments. Do you have any idea? [PATCH v4 5/6]

Re: [PATCH 3/3] ipr: Avoid target_destroy accessing memory after it was freed

2013-05-09 Thread wenxiong
Hi James, Patch 1 and Patch 2 merged into next-scsi and 3.9.0 on 4/6/13 but Patch3 is missed in both of next-scsi and 3.9.0 tree. Can you merge Patch 3 or I need to re-send the Patch3? Thanks for your help! Wendy Quoting wenxi...@linux.vnet.ibm.com: Defined target_ids,array_ids and

[PATCH 02/12] [SCSI] SCSI_UFSHCD should depend on SCSI_DMA

2013-05-09 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `ufshcd_transfer_req_compl': drivers/scsi/ufs/ufshcd.c:1182: undefined reference to `scsi_dma_unmap' drivers/built-in.o: In function `ufshcd_map_sg': drivers/scsi/ufs/ufshcd.c:377: undefined reference to `scsi_dma_map' drivers/built-in.o: In function

RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread Seungwon Jeon
On Thursday, May 09, 2013, James Bottomley wrote: On Thu, 2013-05-09 at 12:22 +0530, Santosh Y wrote: On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon tgih@samsung.com wrote: On Thursday, May 09, 2013 Santosh wrote: There are two patches remained. These are applied with your final

Re: SCSI testing/USB devices are amazing

2013-05-09 Thread Martin K. Petersen
Ronnie == ronnie sahlberg ronniesahlb...@gmail.com writes: Ronnie * please have a look at the tests and the test results I linked Ronnie to above. I currently have quite a few tests but am happy to Ronnie add more. Aside from issuing commands with various bits set, I'd like to see some more

[PATCH] scsi: Allow error handling timeout to be specified

2013-05-09 Thread Martin K. Petersen
Introduce eh_timeout which can be used for error handling purposes. This was previously hardcoded to 10 seconds in the SCSI error handling code. However, for some fast-fail scenarios it is necessary to be able to tune this as it can take several iterations (bus device, target, bus, controller)

[PATCH 1/2] Documentation: devicetree: Add DT bindings for UFS host controller

2013-05-09 Thread Sujit Reddy Thumma
Compatible list is used in commit 03b1781 but is not documented. Add necessary device tree bindings to describe on-chip UFS host controllers. Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org --- .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 16 1 files changed,

[PATCH 2/2] scsi: ufs: Fix the response UPIU length setting

2013-05-09 Thread Sujit Reddy Thumma
The response UPIU length should be in DWORD and not in bytes. Signed-off-by: Maya Erez me...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org --- drivers/scsi/ufs/ufshcd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c