> "Bernd" == Bernd Schubert writes:
Bernd,
Bernd> Once I noticed that scsi_get_vpd_page() works fine from other
Bernd> function calls and that it is not 0x89, but already 0x0 that
Bernd> fails fixing it became easy.
Bernd> Nix, any chance you could verify it also works for you?
Do we get a
From: Meelis Roos
Date: Tue, 30 Jul 2013 12:58:44 +0300 (EEST)
>> > Therefore I think the fix is going to involve adding a member to
>> > "struct esp_cmd_entry" called "->orig_tag[]" so that we can see what
>> > the original tag[] values were at esp_alloc_lun_tag() time.
>>
>> Please try this pa
This patch is a potential way to reduce the S3 resume time for SATA drives.
Essentially this patch removes the hard disk resume time from the total system
resume time, with the disks still taking as long to come back online but in the
background.
The major bottleneck is in the ata port resume w
DMA bounce limit is the maximum direct DMA'able memory beyond which
bounce buffers has to be used to perform dma operations. SCSI driver
relies on dma_mask but its calculation is based on max_*pfn which
don't have uniform meaning across architectures. So make use of
dma_max_pfn() which is expected
So, this patch set is a preview of the DMA mask changes which I currently
have in my tree.
This started out as a request to look at the DMA mask situation, and how
to solve the issues which we have on ARM. One of those issues is how to
deal with the DT side of things, which I haven't yet addresse
From: "Ewan D. Milne"
Generate a uevent when the following Unit Attention ASC/ASCQ
codes are received:
2A/01 MODE PARAMETERS CHANGED
2A/09 CAPACITY DATA HAS CHANGED
38/07 THIN PROVISIONING SOFT THRESHOLD REACHED
3F/03 INQUIRY DATA HAS CHANGED
3F/0E REPORTED LUNS DATA HAS
From: "Ewan D. Milne"
The scsi_evt_thread() function is not actually a thread, it is
a work function. So it should be named scsi_evt_work() instead.
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_lib.c | 4 ++--
drivers/scsi/scsi_priv.h | 1 +
drivers/scsi/scsi_scan.c | 3 +--
3 files ch
From: "Ewan D. Milne"
If a device does not report a unit attention as expected,
clear the expecting_cc_ua flag so that we will not suppress
a future unit attention condition that is *not* expected.
INQUIRY and REPORT LUNS commands should not do this, however,
because they do not report pending un
From: "Ewan D. Milne"
Add a "rescan" attribute to sysfs for scsi_target objects,
to permit them to be scanned for LUN changes (e.g. from udev).
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_priv.h | 4 +++-
drivers/scsi/scsi_scan.c | 30 +++
drivers/scsi/scsi_sysfs.
From: "Ewan D. Milne"
The call to schedule_work() in sdev_evt_send() should
not be made while the sdev->list_lock is held.
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_li
From: "Ewan D. Milne"
Added "report_ua" module parameter to control reporting
of unit attention conditions when the number of LUNs is
changed, or the virtual_gb size of the device is changed.
Also added capability to generate unit attention conditions:
38 07 - THIN PROVISIONING SOFT THRESHOL
From: "Ewan D. Milne"
The function name is "scsi_evt_emit", not "sdev_evt_emit".
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 6dfb978..f6499db 100644
--- a/dr
From: "Ewan D. Milne"
scsi_device_dev_release_usercontext() should be using
"list_for_each_entry_safe" instead of "list_for_each_safe".
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_sysfs.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/scsi_sysfs.
From: "Ewan D. Milne"
show_iostat_counterbits() is obviously missing a newline in
the function declaration.
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
ind
From: "Ewan D. Milne"
The envp[] array in scsi_evt_emit() only needs to have 2 entries.
Signed-off-by: Ewan D. Milne
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f6499db..6585049 100644
-
From: "Ewan D. Milne"
This patch set adds changes to the SCSI mid-layer, sysfs and scsi_debug
to provide enhanced support for Unit Attention conditions.
There was some discussion about this a couple of years ago on the linux-scsi
mailing list: http://marc.info/?l=linux-scsi&m=129702506514742&w=
On 08/01/2013 06:04 PM, Nix wrote:
On 1 Aug 2013, Bernd Schubert verbalised:
On 07/30/2013 11:20 PM, Nix wrote:
On 30 Jul 2013, Bernd Schubert told this:
On 07/30/2013 02:56 AM, Nix wrote:
On 30 Jul 2013, Douglas Gilbert outgrape:
Please supply the information that Martin Petersen asked
f
On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote:
> On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote:
[...]
> >> Btw. on line 1284 - isn't it similar to patch 2/3 ?
^^^ Oh, missed this the first time around, the sop driver uses the
make_request_fn()
interface, and it's not a
On 1 Aug 2013, Bernd Schubert verbalised:
> On 07/30/2013 11:20 PM, Nix wrote:
>> On 30 Jul 2013, Bernd Schubert told this:
>>
>>> On 07/30/2013 02:56 AM, Nix wrote:
On 30 Jul 2013, Douglas Gilbert outgrape:
> Please supply the information that Martin Petersen asked
> for.
>
On Thu, 1 Aug 2013, Oliver Neukum wrote:
> On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote:
>
> > More importantly, if we already know that the medium is not present or
> > has been changed since it was last used, then there's no reason to call
> > sd_sync_cache() at all.
>
> Like this?
Yes
On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote:
> On Thu, Aug 01, 2013 at 04:59:45PM +0200, Tomas Henzl wrote:
>> On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote:
>>> On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote:
On 08/01/2013 03:39 PM, scame...@beardog.cce.
On Thu, Aug 01, 2013 at 04:59:45PM +0200, Tomas Henzl wrote:
> On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote:
> > On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote:
> >> On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote:
> >>> On Thu, Aug 01, 2013 at 03:11:22PM +0200,
On 08/01/2013 04:21 PM, scame...@beardog.cce.hp.com wrote:
> On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote:
>> On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote:
>>> On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote:
From: Tomas Henzl
The cmd_pool_bit
On 07/30/2013 11:20 PM, Nix wrote:
On 30 Jul 2013, Bernd Schubert told this:
On 07/30/2013 02:56 AM, Nix wrote:
On 30 Jul 2013, Douglas Gilbert outgrape:
Please supply the information that Martin Petersen asked
for.
Did it in private IRC (the advantage of working for the same division of
t
Whoops, the title is wrong, it should have been:
[PATCH] scsi disk: Limit get_vpd_page buf size
On 08/01/2013 04:34 PM, Bernd Schubert wrote:
Once I noticed that scsi_get_vpd_page() works fine from other function
calls and that it is not 0x89, but already 0x0 that fails fixing it became
easy.
Once I noticed that scsi_get_vpd_page() works fine from other function
calls and that it is not 0x89, but already 0x0 that fails fixing it became
easy.
Nix, any chance you could verify it also works for you?
From: Bernd Schubert
Somehow older areca firmware versions have issues with
scsi_get_v
https://bugzilla.kernel.org/show_bug.cgi?id=60644
--- Comment #16 from livea...@live.com ---
Hello .
The thing is that I'm using SATA drives and not SAS drives . The motherboard
exposes the LSI controller as 8 SATA ports .
This wasn't an issue under Windows 2012 , so I think that hardware issues
https://bugzilla.kernel.org/show_bug.cgi?id=60644
--- Comment #15 from Sreekanth Reddy ---
(In reply to liveaxle from comment #14)
> Hi .
> Any updates regarding this bug ?
I tried to reproduce this issue locally, but for me this issue is not
reproduced.
Here are the steps which I followed to
On Thu, Aug 01, 2013 at 04:05:20PM +0200, Tomas Henzl wrote:
> On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote:
> > On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote:
> >> From: Tomas Henzl
> >>
> >> The cmd_pool_bits is protected everywhere with a spinlock,
> >> we don't need
On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote:
> More importantly, if we already know that the medium is not present or
> has been changed since it was last used, then there's no reason to call
> sd_sync_cache() at all.
Like this?
Regards
Oliver
>From 8c90d860652
On 08/01/2013 03:39 PM, scame...@beardog.cce.hp.com wrote:
> On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote:
>> From: Tomas Henzl
>>
>> The cmd_pool_bits is protected everywhere with a spinlock,
>> we don't need the test_and_set_bit, set_bit is enough and the loop
>> can be removed t
On Thu, Aug 01, 2013 at 03:14:00PM +0200, Tomas Henzl wrote:
> From: Tomas Henzl
>
> When the driver calls scsi_done and after that frees it's internal
> preallocated memory it can happen that a new job is enqueud before
> the memory is freed. The allocation fails and the message
> "cmd_alloc ret
On Thu, Aug 01, 2013 at 03:14:52PM +0200, Tomas Henzl wrote:
> From: Tomas Henzl
>
> Remove unneeded variables.
>
> Signed-off-by: Tomas Henzl
>
> ---
> drivers/scsi/hpsa.c | 2 --
> drivers/scsi/hpsa.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/
On Thu, Aug 01, 2013 at 03:11:22PM +0200, Tomas Henzl wrote:
> From: Tomas Henzl
>
> The cmd_pool_bits is protected everywhere with a spinlock,
> we don't need the test_and_set_bit, set_bit is enough and the loop
> can be removed too.
>
> Signed-off-by: Tomas Henzl
> ---
> drivers/scsi/hpsa.c
https://bugzilla.kernel.org/show_bug.cgi?id=60644
--- Comment #14 from livea...@live.com ---
Hi .
Any updates regarding this bug ?
--
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bo
From: Tomas Henzl
Remove unneeded variables.
Signed-off-by: Tomas Henzl
---
drivers/scsi/hpsa.c | 2 --
drivers/scsi/hpsa.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 48fa81e..e0f6b00 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scs
From: Tomas Henzl
When the driver calls scsi_done and after that frees it's internal
preallocated memory it can happen that a new job is enqueud before
the memory is freed. The allocation fails and the message
"cmd_alloc returned NULL" is shown.
Patch below fixes it by moving cmd->scsi_done after
From: Tomas Henzl
The cmd_pool_bits is protected everywhere with a spinlock,
we don't need the test_and_set_bit, set_bit is enough and the loop
can be removed too.
Signed-off-by: Tomas Henzl
---
drivers/scsi/hpsa.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --
From: Jan Vesely
CC: Nagalakshmi Nandigama
CC: Sreekanth Reddy
CC: Tomas Henzl
Signed-off-by: Jan Vesely
---
drivers/scsi/mpt2sas/mpt2sas_transport.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c
b/drivers/scsi/mpt2sas/
From: Jan Vesely
CC: Nagalakshmi Nandigama
CC: Sreekanth Reddy
CC: Tomas Henzl
Signed-off-by: Jan Vesely
---
drivers/scsi/mpt3sas/mpt3sas_transport.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c
b/drivers/scsi/mpt3sas/
From: Jan Vesely
These two patches add phy removal on link loss. This change keeps sysfs
up-to-date with actually connected phys. Without these patches,
disconnected phys remain listed under their former ports.
tested on both mpt2sas and mpt3sas hw.
CC: Nagalakshmi Nandigama
CC: Sreekanth Red
On Mon 25 Mar 2013 20:40:09 CET, Jens Axboe wrote:
> On Mon, Mar 25 2013, Jan Vesely wrote:
>> 51506edc5741209311913
>>
>> On Mon 25 Mar 2013 15:24:57 CET, Jens Axboe wrote:
>>> On Mon, Mar 25 2013, Jan Vesely wrote:
v2: changed a comment
The original behavior was to refuse all page
> vscsi->num_queues counts the number of request virtqueue which does not
> include the control and event virtqueue. It is wrong to subtract
> VIRTIO_SCSI_VQ_BASE from vscsi->num_queues.
Reviewed-by: Paolo Bonzini
> This patch fixes the following panic.
>
> (qemu) device_del scsi0
>
> BUG: un
43 matches
Mail list logo
