[PATCH] IB/mlx5: Fix smatch warnings

2014-01-19 Thread Sagi Grimberg
Possible double free on in-mailbox. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/mr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index bc27f6b..f023711 100644 ---

[PATCH] IB/mlx5: Fix siganture rule constants according to FW specifications

2014-01-19 Thread Sagi Grimberg
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/qp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c

Re: [GIT PULL] target fixes for v3.13

2014-01-19 Thread Nicholas A. Bellinger
On Fri, 2014-01-17 at 17:29 -0800, Linus Torvalds wrote: On Thu, Jan 16, 2014 at 4:09 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: This change allows the percpu_ida tag allocator to optionally use interruptible sleep that iscsi-target expects, while still leaving the

[PATCH] IB/mlx5: Fix signature rule constants according to FW specifications

2014-01-19 Thread Sagi Grimberg
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/qp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds sbc_check_prot() for performing various DIF related CDB sanity checks, along with setting cmd-prot_type once sanity checks have passed. Also, add calls in sbc_parse_cdb() for

Re: [PATCH-v2 10/17] target: Add protection SGLs to target_submit_cmd_map_sgls

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support to target_submit_cmd_map_sgls() for accepting 'sgl_prot' + 'sgl_prot_count' parameters for DIF protection information. Note the passed parameters are stored at

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2014-01-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 Konstantin ktrac...@gmail.com changed: What|Removed |Added CC||ktrac...@gmail.com ---

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2014-01-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #42 from Konstantin ktrac...@gmail.com --- Created attachment 122581 -- https://bugzilla.kernel.org/attachment.cgi?id=122581action=edit zpool status output zpool status showing the disks configured as a raidz3 vdev. -- You are

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2014-01-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #43 from Konstantin ktrac...@gmail.com --- Hello all, enabling Above 4G encoding in the bios did not help in my case. I enabled PERR and SERR as well. PCIe ASPM is forced on by the bios and the kernel. When I scrub my zpool, the

Re: [PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds blk_integrity passthrough support for block_device backends using IBLOCK. Nice! This includes iblock_alloc_bip() + setup of bio_integrity_payload information that attaches to the

Re: [PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF protection init/format support into the FILEIO backend. It involves using a seperate $FILE.protection for storing PI that is opened via fd_init_prot() using the

Re: [PATCH-v2 13/17] target/file: Add DIF protection support to fd_execute_rw

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF protection into fd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It adds fd_do_prot_rw() for handling interface with FILEIO PI, and

Re: [PATCH] IB/mlx5: Fix signature rule constants according to FW specifications

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 12:37 PM, Sagi Grimberg wrote: Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/qp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 2/7] scsi_debug: make pseudo_primary static

2014-01-19 Thread Akinobu Mita
As pseudo_primary is only used in scsi_debug.c, it should be static. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Douglas Gilbert dgilb...@interlog.com Cc: linux-scsi@vger.kernel.org --- No change from previous version

[PATCH v2 3/7] scsi_debug: fix duplicate dif_errors increment

2014-01-19 Thread Akinobu Mita
It is unnecessary to increase dif_errors in dif_verify(), because the caller will increment it when dif_verify() detects failure. This bug was introduced by commit beb40ea42bd6 ([SCSI] scsi_debug: reduce duplication between prot_verify_read and prot_verify_write) Signed-off-by: Akinobu Mita

[PATCH v2 7/7] scsi_debug: add ability to enable clustering

2014-01-19 Thread Akinobu Mita
This adds a module parameter to enable clustering. Without enabling clustering support, the transfer length for read and write scsi commands is limited upto 8MB when page size is 4KB and sg_tablesize is 2048 (= SCSI_MAX_SG_CHAIN_SEGMENTS). I would like to test commands with more than that

[PATCH v2 6/7] scsi_debug: protect device access with atomic_rw lock

2014-01-19 Thread Akinobu Mita
This change ensures that concurrent device access including ramdisk storage, protection info, and provisioning map by read, write, and unmap commands are protected with atomic_rw spinlock. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc:

[PATCH v2 4/7] scsi_debug: fix resp_xdwriteread() return value when running out of memory

2014-01-19 Thread Akinobu Mita
When resp_xdwriteread() can't allocate temporary buffer, it returns -1. But the return value is used as scsi status code and -1 is not interpreted as correct code. target_core_mod has similar xdwriteread emulation code. So this mimics what target_core_mod does for xdwriteread when running out of

[PATCH v2 0/7] scsi_debug: several bug fixes and enable clustering support

2014-01-19 Thread Akinobu Mita
This patch set includes several bug fixes and patches for enabling clustering support for scsi_debug. The reason why I would like to enable clustering is to test commands with huge transfer length. Without enabling clustering support, the transfer length for read and write scsi commands is

[PATCH v2 1/7] scsi_debug: fix false positive logical block reference tag check fail

2014-01-19 Thread Akinobu Mita
Reading partially unwritten sectors generates a false positive logical block reference tag check failure when DIF is enabled. This bug is caused by missing ei_lba increment in loop of dif_verify() when unwritten sector is skipped. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Acked-by:

[PATCH v2 5/7] scsi_debug: prepare to enable clustering

2014-01-19 Thread Akinobu Mita
Currently, clustering support for scsi_debug is disabled. This is because there are for_each_sg() loops which assume that each sg list element is consisted with a single page. But enabling clustering support, each sg list element for scsi commands can be consisted with multiple pages. This

Re: [PATCH] scsi-sg: pass flag to inhibit setting LUN

2014-01-19 Thread Douglas Gilbert
On 14-01-03 03:10 PM, Douglas Gilbert wrote: On 14-01-02 08:19 AM, Jiří Pinkava wrote: Hi, This patch implements support for inhibiting setting LUN number for SCSI custom command send via /dev/sgX with ioctl(.., SG_IO, ...) call. This solves problems with some devices which claim support of

Re: [PATCH v2 0/7] scsi_debug: several bug fixes and enable clustering support

2014-01-19 Thread Douglas Gilbert
On 14-01-19 08:51 AM, Akinobu Mita wrote: This patch set includes several bug fixes and patches for enabling clustering support for scsi_debug. The reason why I would like to enable clustering is to test commands with huge transfer length. Without enabling clustering support, the transfer

Re: [PATCH] scsi-sg: pass flag to inhibit setting LUN

2014-01-19 Thread James Bottomley
On Sun, 2014-01-19 at 10:56 -0500, Douglas Gilbert wrote: On 14-01-03 03:10 PM, Douglas Gilbert wrote: On 14-01-02 08:19 AM, Jiří Pinkava wrote: Hi, This patch implements support for inhibiting setting LUN number for SCSI custom command send via /dev/sgX with ioctl(.., SG_IO, ...) call.