Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-12 Thread Michael Schmitz
Finn, nothings' been merged yet, still pending review from the SCSI team. Comments below. This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can be

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-12 Thread Michael Schmitz
Bugger - forgot to CC Sammy as well. My only comment of substance is that the reset handling doesn't need to be done the same way as on Atari, as there's no special locking to account for. Cheers, Michael Am 11.03.2014 um 21:28 schrieb Geert Uytterhoeven: CC Sammy On Tue, Mar

[Bug 71941] New: LSI SAS2116 does not detect disks

2014-03-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71941 Bug ID: 71941 Summary: LSI SAS2116 does not detect disks Product: SCSI Drivers Version: 2.5 Kernel Version: 3.13.6 Hardware: All OS: Linux Tree: Mainline

Re: [PATCH 3/5] Add EVPD page 0x83 to sysfs

2014-03-12 Thread h...@infradead.org
On Mon, Mar 10, 2014 at 09:52:03PM +0100, Hannes Reinecke wrote: Yes, I thought of that, too. I thought to remember that binary attributes are reserved for firmware/hardware-dependent interfaces. That's what we're dealing with here, aren't we? What should happen with the first patch in the

[PATCH 1/2] scsi: explicitly release bidi buffers

2014-03-12 Thread Christoph Hellwig
Instead of trying to guess when we have a BIDI buffer in scsi_release_buffers add a function to explicitly free the BIDI ressoures in the one place that handles them. This avoids needing a special __scsi_release_buffers for the case where we already have freed the request as well. Signed-off-by:

Re: [PATCH 2/3] m68k/atari - atari_scsi: change abort/reset return codes

2014-03-12 Thread Finn Thain
This is a larger version of Michael's patch. It takes care of the header files and comments and it addresses sun3_NCR5380 as well as atari_NCR5380. This means that the initio.h include (!) can be dropped from sun3_scsi.h. Signed-off-by: Finn Thain fth...@telegraphics.com.au --- This version

Re: [PATCH v15 3/3] arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

2014-03-12 Thread Loc Ho
Hi, Kishon didn't applied the PHY DTS patch. Did you first apply the PHY DTS patch? We agreed that you will first pull in the PHY DTS as well as the host controller patches. I don't see any reason why it wouldn't apply if both DTS is applied. I will pull libata/for-3.15 and check out. Can

blk_iopoll_enabled

2014-03-12 Thread Sagi Grimberg
Hey Jens, So I'm looking at blk_iopoll for iSER SRP and I have one gap I would like to get your input on. In blk-iopoll.c I see: int blk_iopoll_enabled = 1; EXPORT_SYMBOL(blk_iopoll_enabled); This is set to 1 and exported for everyone to condition and *modify* it. The documentation says the

Re: [PATCH v16 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-12 Thread Bartlomiej Zolnierkiewicz
Hi, Thanks for updating this patch, there are still some issue left though (please see below). On Tuesday, March 11, 2014 04:11:34 PM Loc Ho wrote: This patch adds support for the APM X-Gene SoC AHCI SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. This

Re: [PATCH 5/6] target: Allocate se_luns only when used

2014-03-12 Thread Nicholas A. Bellinger
On Fri, 2014-03-07 at 10:22 -0800, Christoph Hellwig wrote: On Fri, Mar 07, 2014 at 10:12:09AM -0800, Andy Grover wrote: I can't see how the synchronization can work without refcounting the lun structure. The lock just protectes the assignment, but you free it right after. What happens to

[Bug 71981] New: Writing session to CD does not update some important cached information

2014-03-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71981 Bug ID: 71981 Summary: Writing session to CD does not update some important cached information Product: SCSI Drivers Version: 2.5 Kernel Version: 3.13.5-101 Hardware:

Re: [PATCH v16 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-12 Thread Loc Ho
Hi, +MODULE_DEVICE_TABLE(of, xgene_ahci_of_match); + +static struct platform_driver xgene_ahci_driver = { + .probe = xgene_ahci_probe, + .remove = ata_platform_remove_one, It is good to use ata_platform_remove_one() here but some code still needs to callback

[PATCH v17 0/4] ata: Add APM X-Gene SoC AHCI SATA host controller support

2014-03-12 Thread Loc Ho
This patch adds support for the APM X-Gene SoC AHCI SATA host controller. In order for the host controller to work, the corresponding PHY driver musts also be available. Currently, only Gen3 disk is supported with this initial version. v17: * Add comment on no support for PM currently * Add

[PATCH v17 1/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-03-12 Thread Loc Ho
This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose PHY driver. The PHY for SATA controller 2 and 3 are enabled by default. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com ---

[PATCH v17 2/4] Documentation: Add documentation for the APM X-Gene SoC SATA host controller DTS binding

2014-03-12 Thread Loc Ho
This patch adds documentation for the APM X-Gene SoC SATA host controller DTS binding. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- .../devicetree/bindings/ata/apm-xgene.txt | 70 1

[PATCH v17 4/4] arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

2014-03-12 Thread Loc Ho
This patch adds APM X-Gene SoC AHCI SATA host controller DTS entries. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- arch/arm64/boot/dts/apm-storm.dtsi | 75 1 files changed, 75

[PATCH v17 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-12 Thread Loc Ho
This patch adds support for the APM X-Gene SoC AHCI SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. This initial version only supports Gen3 speed. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan Phan tp...@apm.com Signed-off-by: Suman Tripathi

[PATCH RESEND 1/7] ipr: Remove extended delay bit on GSCSI reads/writes ops

2014-03-12 Thread wenxiong
This patch removes extended delay bit on GSCSI reads/writes ops, the performance will be significanly better. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c |6 +- drivers/scsi/ipr.h |1 + 2 files changed, 6 insertions(+), 1 deletion(-) Index:

[PATCH RESEND 0/7] New CCINs and several patches for new improvement

2014-03-12 Thread wenxiong
Hi James, I re-submitted the following patches for ipr device driver. I have re-tested these patches with our latest adapters. These patches are: (1)Remove extended delay bit on GSCSI reads/writes ops. (2)Add new device id to support Z06 LTD new adapter. (3)Handle early EEH. Above 3 patches

[PATCH RESEND 5/7] ipr: Use pci_enable_msi_range() and pci_enable_msix_range()

2014-03-12 Thread wenxiong
From: Alexander Gordeev agord...@redhat.com As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by:

[PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix()

2014-03-12 Thread wenxiong
From: Alexander Gordeev agord...@redhat.com There is no need to call pci_disable_msi() or pci_disable_msix() in case the call to pci_enable_msi() or pci_enable_msix() failed. Signed-off-by: Alexander Gordeev agord...@redhat.com Acked-by: Brian King brk...@linux.vnet.ibm.com ---

[PATCH RESEND 3/7] ipr: Handle early EEH

2014-03-12 Thread wenxiong
From: Brian King brk...@linux.vnet.ibm.com If, when the ipr driver loads, the adapter is in an EEH error state, it will currently oops and not be able to recover, as it attempts to access memory that has not yet been allocated. We've seen this occur in some kexec scenarios. The following patch

[PATCH RESEND 7/7] ipr: Add new CCIN definition for Grand Canyon support

2014-03-12 Thread wenxiong
Add the appropriate definition and table entry for new hardware support. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c |6 ++ drivers/scsi/ipr.h |3 +++ 2 files changed, 9 insertions(+) Index: b/drivers/scsi/ipr.c

[PATCH RESEND 6/7] ipr: Format HCAM overlay ID 0x21

2014-03-12 Thread wenxiong
This patch adds formatting error overlay 0x21 to improve debug capabilities. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 39 +++ drivers/scsi/ipr.h | 14 ++ 2 files changed, 53 insertions(+) Index:

Re: [PATCH 2/5] scsi: Return VPD page length in scsi_vpd_inquiry()

2014-03-12 Thread Muthukumar R
On Mon, Mar 10, 2014 at 7:28 AM, Hannes Reinecke h...@suse.de wrote: We should be returning the number of bytes of the requested VPD page in scsi_vpd_inquiry. This makes it easier for the caller to verify the required space. Signed-off-by: Hannes Reinecke h...@suse.de ---

[PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value

2014-03-12 Thread Matei Oprea
Remove useless casting value returned by k[cmz]alloc to (struct lpfc_sli_ring *). Found using coccinelle Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c |3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH 2/5] scsi: Return VPD page length in scsi_vpd_inquiry()

2014-03-12 Thread Douglas Gilbert
On 14-03-12 10:14 PM, Muthukumar R wrote: On Mon, Mar 10, 2014 at 7:28 AM, Hannes Reinecke h...@suse.de wrote: We should be returning the number of bytes of the requested VPD page in scsi_vpd_inquiry. This makes it easier for the caller to verify the required space. Signed-off-by: Hannes

Re: [PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value

2014-03-12 Thread Joe Perches
On Wed, 2014-03-12 at 23:20 +0200, Matei Oprea wrote: Remove useless casting value returned by k[cmz]alloc to (struct lpfc_sli_ring *). Found using coccinelle trivial note: diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c [] @@ -4731,8 +4731,7 @@

Re: [PATCH 2/5] scsi: Return VPD page length in scsi_vpd_inquiry()

2014-03-12 Thread Muthukumar R
On Wed, Mar 12, 2014 at 2:43 PM, Douglas Gilbert dgilb...@interlog.com wrote: On 14-03-12 10:14 PM, Muthukumar R wrote: On Mon, Mar 10, 2014 at 7:28 AM, Hannes Reinecke h...@suse.de wrote: We should be returning the number of bytes of the requested VPD page in scsi_vpd_inquiry. This makes

Re: [PATCH 3/5] Add EVPD page 0x83 to sysfs

2014-03-12 Thread Martin K. Petersen
James == James Bottomley jbottom...@parallels.com writes: James What we do under the covers is up to us. What's the reason for James not wanting to do I/O every time? Getting VPD data isn't a time James critical operation is it? so what's the benefit of caching it? XCopy. Want us to do a VPD

Re: [PATCH 3/5] Add EVPD page 0x83 to sysfs

2014-03-12 Thread James Bottomley
On Wed, 2014-03-12 at 21:53 -0400, Martin K. Petersen wrote: James == James Bottomley jbottom...@parallels.com writes: James What we do under the covers is up to us. What's the reason for James not wanting to do I/O every time? Getting VPD data isn't a time James critical operation is it?

Re: blk_iopoll_enabled

2014-03-12 Thread Jens Axboe
On 2014-03-12 11:35, Sagi Grimberg wrote: Hey Jens, So I'm looking at blk_iopoll for iSER SRP and I have one gap I would like to get your input on. In blk-iopoll.c I see: int blk_iopoll_enabled = 1; EXPORT_SYMBOL(blk_iopoll_enabled); This is set to 1 and exported for everyone to condition

Re: [PATCH v2 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-03-12 Thread Bjorn Helgaas
On Mon, Feb 24, 2014 at 09:02:00AM +0100, Alexander Gordeev wrote: Hello! This series is against James Bottomley's SCSI tree [1], but it needs commit f7fc32c (PCI/MSI: Add pci_enable_msi_exact() and pci_enable_msix_exact()) from from Bjorn Helgaas's PCI tree [2]: 1.