Re: [scsi:for-next 200/200] drivers/scsi/scsi_sysfs.c:778: warning: comparison is always false due to limited range of data type

2014-03-20 Thread Hannes Reinecke
On 03/20/2014 06:07 AM, James Bottomley wrote: [correct cc to linux-scsi added] On Thu, 2014-03-20 at 12:48 +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next head: c6b7d7a684ef39be73f06c14aca4aadad77f42dc commit:

[PATCH] Fixup vpd page length calculation

2014-03-20 Thread Hannes Reinecke
The VPD page length parameter is not only used for the length, but also to hold any error code. So it needs to be moved to an integer. And we should be resetting the default VPD page length after each iteration so that we do not allocate overly large buffers. Signed-off-by: Hannes Reinecke

[Bug 71881] Disabling wifi by radio killswitch leads to remounting external USB HDD and stack trace in kernel log

2014-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71881 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added CC||a...@lxorguk.ukuu.org.uk

[Bug 72541] New: CentOS 6.5 -- mpt2sas0: _base_fault_reset_work : SAS host is non-operational !!!!

2014-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=72541 Bug ID: 72541 Summary: CentOS 6.5 -- mpt2sas0: _base_fault_reset_work : SAS host is non-operational Product: SCSI Drivers Version: 2.5 Kernel Version: 2.6.32-431

Re: [PATCH] Fixup vpd page length calculation

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 08:19 +0100, Hannes Reinecke wrote: The VPD page length parameter is not only used for the length, but also to hold any error code. So it needs to be moved to an integer. And we should be resetting the default VPD page length after each iteration so that we do not

Re: [PATCH 6/6] Invalidate VPD page data

2014-03-20 Thread James Bottomley
On Sat, 2014-03-15 at 09:51 +0100, Hannes Reinecke wrote: Add a flag 'vpd_invalid' to the SCSI device to indicate that the VPD data needs to be refreshed. This is required if either a manual rescan is triggered or if the sense code INQUIRY DATA HAS CHANGED has been received. Signed-off-by:

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Wed, 19 Mar 2014, James Bottomley wrote: Basically, usb-storage deadlocks when the SCSI error handler invokes the eh_device_reset_handler callback while a command is running. The command has timed out and will never complete normally, because the device's firmware has crashed. But

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 11:36 -0400, Alan Stern wrote: On Wed, 19 Mar 2014, James Bottomley wrote: Basically, usb-storage deadlocks when the SCSI error handler invokes the eh_device_reset_handler callback while a command is running. The command has timed out and will never complete

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix usb-storage to fail a reset it can't do (i.e. device reset

[PATCH] hpsa: fix bug in figure_lunaddrbytes()

2014-03-20 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Depending on whether we use extended or normal CISS_REPORT_LUNS command, the returned data is either 8 or 24 bytes per LUN, and the code needs to take this into account instead of just always assuming 24 bytes per LUN. This would cause

Re: please fix FUSION (Was: [v3.13][v3.14][Regression] kthread:makekthread_create()killable)

2014-03-20 Thread Joseph Salisbury
On 03/19/2014 03:42 PM, Oleg Nesterov wrote: On 03/19, Oleg Nesterov wrote: On 03/19, Oleg Nesterov wrote: But please do not forget that the kernel crashes. Whatever else we do, this should be fixed anyway. And this should be fixed in driver. drivers/message/fusion/ is obviously buggy.

Re: [PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter disable_eedp to Disable EEDP Support

2014-03-20 Thread Bernd Schubert
u8 scsi_io_cb_idx; diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index 7f0af4f..d502728 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c @@ -127,6 +127,11 @@ static int disable_discovery =

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix

Re: please fix FUSION (Was: [v3.13][v3.14][Regression] kthread:makekthread_create()killable)

2014-03-20 Thread Oleg Nesterov
On 03/20, Joseph Salisbury wrote: On 03/19/2014 03:42 PM, Oleg Nesterov wrote: On 03/19, Oleg Nesterov wrote: On 03/19, Oleg Nesterov wrote: But please do not forget that the kernel crashes. Whatever else we do, this should be fixed anyway. And this should be fixed in driver.

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, James Bottomley wrote: On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, James Bottomley wrote: On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix usb-storage to fail a reset it can't do (i.e. device reset

Re: [LSF/MM TOPIC] atomic block device

2014-03-20 Thread Jeff Moyer
James Bottomley james.bottom...@hansenpartnership.com writes: OK, so what the Database people are currently fretting about is how the Linux cache fights with the WAL. Pretty much all DBs sit on filesystems these days, so the first question is are block operations even relevant Yes, they are

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 15:48 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 15:59 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, James Bottomley wrote: I tried this patch first, because fixing the earlier bug would mask this one. The patch sort of worked. But the first time I tried it, it failed in a rather amusing way. While the second retry was running and hung, scmd-result _was_ equal

Re: Deadlock in usb-storage error handling

2014-03-20 Thread Alan Stern
On Thu, 20 Mar 2014, James Bottomley wrote: On Thu, 2014-03-20 at 15:59 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-20 Thread Dan Williams
On Mon, 2014-03-17 at 11:20 -0700, Dan Williams wrote: On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote: On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley Hm, OK, if this is tied at the hip to async scanning, why do you need

Re: [PATCH 13/39] megaraid: simplify internal command handling

2014-03-20 Thread adam radford
On Mon, Mar 17, 2014 at 6:27 AM, Christoph Hellwig h...@infradead.org wrote: We don't use the passed in scsi command for anything, so just add a adapter- wide internal status to go along with the internal scb that is used unter int_mtx to pass back the return value and get rid of all the

[PATCH 5/5] blk-integrity: refactor various routines

2014-03-20 Thread Darrick J. Wong
Refactor blk-integrity.c to avoid duplicating similar functions, and remove all users of pi_buf, since it's really only there to handle the (common) case where the kernel auto-generates all the PI data. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- fs/bio-integrity.c | 120

[RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

2014-03-20 Thread Darrick J. Wong
This RFC provides a rough implementation of a mechanism to allow userspace to attach protection information (e.g. T10 DIF) data to a disk write and to receive the information alongside a disk read. The interface is an extension to the AIO interface: two new commands (IOCB_CMD_P{READ,WRITE}VM) are

[PATCH 1/5] fs/bio-integrity: remove duplicate code

2014-03-20 Thread Darrick J. Wong
Frøm: Gu Zheng guz.f...@cn.fujitsu.com Most code of function bio_integrity_verify and bio_integrity_generate is the same, so introduce a help function bio_integrity_generate_verify() to remove the duplicate code. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- fs/bio-integrity.c | 83

[PATCH 2/5] aio/dio: enable DIX passthrough

2014-03-20 Thread Darrick J. Wong
Provide a set of new AIO commands (IOCB_CMD_P{READ,WRITE}VM) that utilize the last iovec of the iovec array to convey protection information to and from userspace. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- Documentation/block/data-integrity.txt | 11 ++ fs/aio.c

[PATCH 3/5] aio/dio: allow user to ask kernel to fill in parts of the protection info

2014-03-20 Thread Darrick J. Wong
Since userspace can now pass PI buffers through to the block integrity provider, provide a means for userspace to specify a flags argument with the PI buffer. The initial user for this will be sd_dif, which will enable user programs to ask the kernel to fill in whichever fields they don't want to

[PATCH 4/5] aio/dio: advertise possible userspace flags

2014-03-20 Thread Darrick J. Wong
Expose possible userland flags to the new AIO/DIO PI interface so that userspace can discover what flags exist. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- Documentation/ABI/testing/sysfs-block | 14 ++ Documentation/block/data-integrity.txt | 26

SCSI: race condition between scsi_remove_target and scsi_probe_and_add_lun

2014-03-20 Thread Andrey Zonov
Hi, I've got kernel panic on my box which works as FibreChannel initiator. I was able to reproduce this panic by setting dev_loss_tmo=2 and enabling/disabling ports every 5 seconds on the switch in 5 minutes. I added some debug points in the kernel code and that's what I've got so far: 1.