On 06/24/14 17:07, Maurizio Lombardi wrote:
I've a question regarding the asynchronous scsi abort handler,
look at the scsi_put_command() function:
void scsi_put_command(struct scsi_cmnd *cmd)
{
unsigned long flags;
[...]
cancel_delayed_work(cmd-abort_work);
Hi Bart,
On 06/25/2014 08:52 AM, Bart Van Assche wrote:
Hello Maurizio,
I agree that that cancel_delayed_work() call is confusing. Hence
[PATCH] Remove two cancel_delayed_work() calls from the mid-layer
(http://thread.gmane.org/gmane.linux.scsi/91027). Had you already
noticed that patch ?
On 06/25/14 09:03, Maurizio Lombardi wrote:
On 06/25/2014 08:52 AM, Bart Van Assche wrote:
I agree that that cancel_delayed_work() call is confusing. Hence
[PATCH] Remove two cancel_delayed_work() calls from the mid-layer
(http://thread.gmane.org/gmane.linux.scsi/91027). Had you already
On 6/25/2014 6:32 AM, Mike Christie wrote:
On 06/24/2014 12:08 PM, Mike Christie wrote:
On 06/24/2014 12:00 PM, Mike Christie wrote:
On 06/24/2014 11:30 AM, Christoph Hellwig wrote:
On Tue, Jun 24, 2014 at 07:27:46PM +0300, Sagi Grimberg wrote:
This condition only matters in the bidi case,
On Wed, Jun 25, 2014 at 09:45:07AM +0200, Bart Van Assche wrote:
Hello James and Christoph,
Is it correct that the patch mentioned above has not yet been queued up
? Has it already been decided in which kernel version that patch should
be included ?
I've got it in my local pending queue for
Mike, I'd prefer a fix on top of the core-for-3.16 branch in my
scsi-queue tree, which already has the fix from Martin.
I also really don't like these three confusing helpers:
+static inline unsigned scsi_transfer_length(struct scsi_cmnd *scmd)
+{
+ return
Sagi's patch was not correct because scsi_in was hardcoded to the transfer
len when bidi was used.
Right, should have condition that in the direction. something like:
transfer_length = sc-sc_data_direction == DMA_TO_DEVICE ?
scsi_out(sc)-length : scsi_in(sc)-length;
would probably hit
Hi James,
This Patch set seems to be fine. Please consider this patch set as
Acked-by: Sreekanth Reddy sreekanth.re...@avagotech.com
Regards,
Sreekanth
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Martin K. Petersen
James,
This Patch set seems to be fine. Please consider this patch set as
Acked-by: Sreekanth Reddy sreekanth.re...@avagotech.com
Regards,
Sreekanth
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Joe Lawrence
Sent:
On Tue, Jun 24, 2014 at 07:11:47PM -0400, Martin K. Petersen wrote:
Lars == Lars Ellenberg lars.ellenb...@linbit.com writes:
Lars We are receiving (from network) and submitting (to lower level IO
Lars stack) in the same context and would like the submit to be async.
Lars Do you intend to
On Wed, Jun 11, 2014 at 09:30:34PM -0400, Martin K. Petersen wrote:
/sys/block/foo/integrity/disk_is_formatted_with_pi
/sys/block/foo/integrity/disk_is_integrity_capable
/sys/block/foo/integrity/disk_supports_storing_pi
Or would you prefer something other than disk? target? storage_device?
Just resending below set of patches which I have sent on 14th March 2014.
And I have removed below subjected patch since we have already have the
module parameter port_mask to disable EEDP support.
[PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter disable_eedp to
Disable EEDP Support.
Added driver module parameter max_msix_vectors. Using this
module parameter the maximum number of MSI-X vectors could be set.
The number of MSI-X vectors used would be the minimum of MSI-X vectors
supported by the HBA, the number of CPU cores and the value set to
max_msix_vectors module
There was a down casting of the volume max LBA from a U64 to a U32,
which is taken out and now the max LBA is set appropriately to U64.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 14 ++
1 files changed, 10 insertions(+),
Bump mpt2sas driver version to 17.100.00.00.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt2sas/mpt2sas_base.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h
b/drivers/scsi/mpt2sas/mpt2sas_base.h
Up to now, Driver allocates a single contiguous block of memory
pool for all reply queues and passes down a single address in the
ReplyDescriptorPostQueueAddress field of the IOC Init Request
Message to the firmware.
When firmware receives this address, it will program each of the
Reply
During hot-plugging of a disk(having a flaky link) the disk addition
stops and any further disk addition or removal doesn't happen on that
controller.
This is because, when driver receives DELAY_NOT_RESPONDING for a disk when it
is undergoing
addition in the SCSI Mid layer, the driver would
The driver would send IOC facts only if HBA is in operational or ready
state. If it is in fault state, a diagnostic reset would be issued. It
would wait for 10 seconds to exit out of reset state. If the HBA continues
to be in reset state, then the HBA wouldn't be claimed by the driver.
Bump mpt2sas driver version to 18.100.00.00.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt2sas/mpt2sas_base.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h
b/drivers/scsi/mpt2sas/mpt2sas_base.h
Just resending below set of patches which I have sent on 14th March 2014.
And I have removed below subjected patch since we have already have the
module parameter port_mask to disable EEDP support.
[PATCH 1/9][SCSI]mpt3sas: Added new driver module Parameter disable_eedp to
Disable EEDP Support.
Below is the change set in MPI2.5 Rev G specification and 2.00.31 header files
1) Added SCSIStatusQualifier to SCSI IO Error Reply message.
2) Added ATA Security Freeze Lock to IO Unit Page 1 Flags field.
3) Added Allow Protection Information bit for IR Volume Create.
Signed-off-by: Sreekanth
Added code to send an SEP message that turns off the Predictive
Failure LED when a drive is removed (if Predictive Failure LED was turned on).
Added a new flag 'pfa_led_on' per device that tracks the status of Predictive
Failure LED. When the drive is removed, this flag is checked and
sends an
Below is the change set in MPI2.5 Rev H specification and 2.00.32 header files
1) Added reserved fields to IO Unit Page 7 for future use.
2) Added optional functionality to IOCInit Request so that
the host may specify a separate base address for each
Reply Descriptor Post Queue. IOC support
Added following branding Strings for Intel custom HBAs support.
Driver String: Vendor ID Device ID
SubSystemVendor ID SubSystemDevice ID
Intel(R) Integrated RAID Module RMS3JC080 0x1000 0x0097
0x8086
Copyright in driver sources is updated for year the 2014.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt3sas/Kconfig|2 +-
drivers/scsi/mpt3sas/mpi/mpi2.h |2 +-
drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h|2 +-
Bump mpt3sas driver version to 03.100.00.00.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt3sas/mpt3sas_base.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
Bump mpt3sas driver version to 04.100.00.00.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt3sas/mpt3sas_base.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
Up to now, Driver allocates a single contiguous block of memory
pool for all reply queues and passes down a single address in the
ReplyDescriptorPostQueueAddress field of the IOC Init Request
Message to the firmware.
When firmware receives this address, it will program each of the
Reply
Copyright in driver sources is updated for year the 2014.
Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com
---
drivers/scsi/mpt2sas/Kconfig |2 +-
drivers/scsi/mpt2sas/mpt2sas_base.c |2 +-
drivers/scsi/mpt2sas/mpt2sas_base.h |2 +-
Below is the change set in MPI2 Rev Y specification and in 2.00.17 header files
1) Added SCSIStatusQualifier to SCSI IO Error Reply message.
2) Added ATA Security Freeze Lock to IO Unit Page 1 Flags field.
Below is the change set in MPI2 Rev Z specification and in 2.00.19 header files
1) Added
Added code to send a SEP message that turns off the Predictive
Failure LED when a drive is removed (if Predictive Failure LED was turned on).
Added a new flag 'pfa_led_on' per device that tracks the status of Predictive
Failure LED. When the drive is removed, this flag is checked and
sends the
Can I get another review for this one?
On Fri, Jun 13, 2014 at 04:40:36PM +, Dick Kennedy wrote:
These speeds are to support the next generation of FCoE port speeds.
Signed-off-by: rkenn...@emulex.com
---
drivers/scsi/scsi_transport_fc.c |4
include/scsi/scsi_transport_fc.h |
Can I get another review for this series?
On Wed, Jun 04, 2014 at 12:49:42PM -0400, Joe Lawrence wrote:
While reviewing the mpt2/mpt3 static checker fixup patchset, Christoph
inquired about mptfusion. None of the sparse / smatch warnings from the
earlier patchset directly apply to fusion, but
On Thu, Jun 05, 2014 at 03:44:18PM +0300, Dolev Raviv wrote:
Resending patch 4, to fix the author.
Please resend the whole series, and include all the existing reviewed-by or
acked-by tags. Thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
Can I get another set of reviews for these?
On Thu, Jun 05, 2014 at 11:29:45PM +0200, Arnd Bergmann wrote:
Hi James,
These are some fixes for ancient randconfig build bugs I
ran into on ARM. Clearly none of these are urgent, but it
would be nice to have them merged for 3.17 if they look
Can I get another review for this one?
On Fri, Jun 06, 2014 at 10:10:35AM +0200, Maurizio Lombardi wrote:
During IO with fabric faults, one generally sees several Unhandled error
code messages in the syslog as shown below:
sd 4:0:6:2: [sdbw] Unhandled error code
sd 4:0:6:2: [sdbw] Result:
On Sun, Jun 08, 2014 at 11:37:44PM +0100, Ben Hutchings wrote:
asd_process_ctrl_a_user() attempts to find user settings in flash, and
if they are missing it prepares a substitute structure containing
default values for PHY settings. But having done so, it will still
try to read user settings
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
Can I get another review, too please?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
scsilun_to_int() has an error which prevents it from generating
correct LUN numbers for 64bit values.
Also we should remove the misleading comment about portions of
the LUN being ignored; the initiator should treat the LUN as
an opaque value.
And, finally, the example given should use the correct
On Wed, Jun 25, 2014 at 02:40:32PM +0530, Sreekanth Reddy wrote:
Hi James,
This Patch set seems to be fine. Please consider this patch set as
Acked-by: Sreekanth Reddy sreekanth.re...@avagotech.com
Any reason you didn't simply include them in your resent driver
update series?
Also any
Christoph == Christoph Hellwig h...@infradead.org writes:
Christoph So here we use blk_rq_bytes still, which is incorrect for
Christoph WRITE SAME.
Yeah, scsi_transfer_length() needs to go away completely if we go with
the in and out variants.
Christoph I think the easiest fix is to just pass
On Wed, Jun 25, 2014 at 01:32:39PM +0300, Sagi Grimberg wrote:
So I tested a bidirectional command using:
$ sg_raw --infile=/root/filex --send=1024 --request=1024
--outfile=/root/filex /dev/bsg/7:0:0:0 53 00 00 00 00 00 00 00 02 00
And I see:
kernel: session1: iscsi_prep_scsi_cmd_pdu iscsi
Christoph == Christoph Hellwig h...@infradead.org writes:
Christoph On Wed, Jun 11, 2014 at 09:30:34PM -0400, Martin K. Petersen wrote:
/sys/block/foo/integrity/disk_is_formatted_with_pi
/sys/block/foo/integrity/disk_is_integrity_capable
/sys/block/foo/integrity/disk_supports_storing_pi
Or
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/advansys.c |2 --
1 file changed, 2 deletions(-)
diff --git
On Tue, Jun 03, 2014 at 10:58:56AM +0200, Hannes Reinecke wrote:
Now that we're using 64-bit LUNs internally we need to increase
the size of max_luns to 64 bits, too.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Christoph Hellwig h...@infradead.org
Reviewed-by: Ewan Milne
On 06/25/2014 02:28 PM, Christoph Hellwig wrote:
On Tue, Jun 03, 2014 at 10:58:56AM +0200, Hannes Reinecke wrote:
Now that we're using 64-bit LUNs internally we need to increase
the size of max_luns to 64 bits, too.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Christoph Hellwig
On Wed, Jun 25, 2014 at 02:31:31PM +0200, Hannes Reinecke wrote:
Guess I need to redo the patchset yet again ...
If you plan to resend it please also include these fixes for the
mptfusion driver:
diff --git a/drivers/message/fusion/mptfc.c b/drivers/message/fusion/mptfc.c
index
And here are the for-3.16 driver changes:
Brian King (2):
ibmvscsi: Abort init sequence during error recovery
ibmvscsi: Add memory barriers for send / receive
Maurizio Lombardi (2):
pm8001: Fix potential null
On Fri, 2014-06-13 at 16:40 +, Dick Kennedy wrote:
These speeds are to support the next generation of FCoE port speeds.
Signed-off-by: rkenn...@emulex.com
---
drivers/scsi/scsi_transport_fc.c |4
include/scsi/scsi_transport_fc.h |4
2 files changed, 8 insertions(+), 0
On Thu, Jun 19, 2014 at 11:05:59AM -0700, James Bottomley wrote:
That's not really a good idea either ... I did think of it. We'll end
up with a cmd_type of REQ_TYPE_FS which because of REQ_FLUSH (or REQ_FUA
or REQ_DISCARD or any number of other things) we have to treat as though
it were
scsilun_to_int() has an error which prevents it from generating
correct LUN numbers for 64bit values.
Also we should remove the misleading comment about portions of
the LUN being ignored; the initiator should treat the LUN as
an opaque value.
And, finally, the example given should use the correct
Hi all,
this patchset updates the SCSI stack to support full 64-bit LUNs.
The first patche update the SCSI stack and all drivers
to use 64-bit LUNs where appropriate.
The second patch updates the kernel module parameter
functions to accept a new 'ullong' parameter.
The third the updates the
Now that we're using 64-bit LUNs internally we need to increase
the size of max_luns to 64 bits, too.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Christoph Hellwig h...@infradead.org
Reviewed-by: Ewan Milne emi...@redhat.com
---
drivers/message/i2o/i2o_scsi.c | 2 +-
Some driver might want to pass in an 64-bit value, so introduce
a module param type 'ullong'.
Cc: Rusty Russel ru...@rustcorp.com.au
Cc: Linux Kernel linux-ker...@vger.kernel.org
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Christoph Hellwig h...@infradead.org
Reviewed-by: Ewan Milne
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/pm8001/pm80xx_hwi.c |1 -
1 file changed, 1
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/bnx2i/bnx2i_iscsi.c |1 -
1 file changed, 1
Hi Christoph, Sreekanth,
Would it be easier to combine this set with the mpt2/mpt3 changes and
repost a V2? There were a few changes Christoph request in each set,
so I can post those up later today.
-- Joe
On Wed, 25 Jun 2014 13:01:50 +0200
Christoph Hellwig h...@infradead.org wrote:
Can I
On Wed, Jun 25, 2014 at 10:18:11AM -0400, Joe Lawrence wrote:
Hi Christoph, Sreekanth,
Would it be easier to combine this set with the mpt2/mpt3 changes and
repost a V2? There were a few changes Christoph request in each set,
so I can post those up later today.
Fine with me.
--
To
Hi,
On 06/25/2014 04:04 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
Using dev_printk variants prefixes the logging message with
the originating device, which makes debugging easier.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/hosts.c | 15
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi_ioctl.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi_ioctl.c
Hi all,
this is the first patch of my SCSI logging cleanup.
The basic idea here is to use dev_printk() and friends
throughout the midlayer, so that any logging messages
are attached with the correct device information.
This patchset is relative to the core-for-3.17 git
tree from hch + my 64-bit
Update the ch driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
Update the sr driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
Update the st driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
Update the sg driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by: Doug Gilbert dgilb...@interlog.com
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Thanks Hannes,
I've applied this and the logging series to the core-for-3.17 branch.
Note that I will still rebase this branch to deal with whatever feedback
Rusty might have on the modparam changes.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
This one looks good to me,
Reviewed-by: Maurizio Lombardi mlomb...@redhat.com
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
https://bugzilla.kernel.org/show_bug.cgi?id=34422
xerofo...@gmail.com changed:
What|Removed |Added
CC||xerofo...@gmail.com
--- Comment #1
On Jun 25, 2014, at 6:35 AM, Christoph Hellwig h...@infradead.org wrote:
On Wed, Jun 25, 2014 at 01:32:39PM +0300, Sagi Grimberg wrote:
So I tested a bidirectional command using:
$ sg_raw --infile=/root/filex --send=1024 --request=1024
--outfile=/root/filex /dev/bsg/7:0:0:0 53 00 00 00 00 00
Hi,
On 06/25/2014 05:41 PM, Purush Gupta wrote:
Its possible HW may require programming those fields?
I'm looking at the code and it doesn't look so, did you see something
suspicious?
May be original
contributor of the driver should review...No offense!
I believe it requires the maintainer
This saves us an atomic operation for each I/O submission and completion
for the usual case where the driver doesn't set a per-target can_queue
value. Only a few iscsi hardware offload drivers set the per-target
can_queue value at the moment.
Signed-off-by: Christoph Hellwig h...@lst.de
---
This is the second post of the scsi-mq series.
At this point the code is ready for merging and use by developers and early
adopters. The core blk-mq code isn't that suitable for slow devices
yet, mostly due to the lack of an I/O scheduler, but Jens is working on it.
Similarly there is no
Prepare for not taking a host-wide lock in the dispatch path by pushing
the lock down into the places that actually need it. Note that this
patch is just a preparation step, as it will actually increase lock
roundtrips and thus decrease performance on its own.
Signed-off-by: Christoph Hellwig
Current the midlayer fakes up a struct request for the explicit reset
ioctls, and those don't have a tag allocated to them. The fnic driver pokes
into midlayer structures to paper over this design issue, but that won't
work for the blk-mq case.
Either someone who can actually test the hardware
This patch adds support for an alternate I/O path in the scsi midlayer
which uses the blk-mq infrastructure instead of the legacy request code.
Use of blk-mq is fully transparent to drivers, although for now a host
template field is provided to opt out of blk-mq usage in case any unforseen
Avoid taking the host-wide host_lock to check the per-host queue limit.
Instead we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/advansys.c |4
Blk-mq drivers usually preallocate their S/G list as part of the request,
but if we want to support the very large S/G lists currently supported by
the SCSI code that would tie up a lot of memory in the preallocated request
pool. Add support to the scatterlist code so that it can initialize a
S/G
Seems like these counters are missing any sort of synchronization for
updates, as a over 10 year old comment from me noted. Fix this by
using atomic counters, and while we're at it also make sure they are
in the same cacheline as the _busy counters and not needlessly stored
to in every I/O
Replace the calls to the various blk_end_request variants with opencode
equivalents. Blk-mq is using a model that gives the driver control
between the bio updates and the actual completion, and making the old
code follow that same model allows us to keep the code more similar for
both pathes.
Make sure we only have the logic for requeing commands in one place.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi.c | 35 ---
drivers/scsi/scsi_lib.c |9 ++---
2 files changed, 18 insertions(+), 26 deletions(-)
diff --git
The blk-mq code path will set this to a different function, so make the
code simpler by setting it up in a legacy-request specific place.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi.c | 23 +--
drivers/scsi/scsi_lib.c | 20
Factor out a helper to set the _blocked values, which we'll reuse for the
blk-mq code path.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi_lib.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git
Avoid taking the host-wide host_lock to check the per-target queue limit.
Instead we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi_lib.c| 52
Avoid taking the queue_lock to check the per-device queue limit. Instead
we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Unlike the host and target busy counters this doesn't allow us to avoid the
queue_lock in the
Unlike the old request code blk-mq doesn't initialize cmd_len with a
default value, so don't rely on it being set in sd_setup_write_same_cmnd.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/sd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Al,
just checking - did you expect me to take this from the email, or are
you preparing a pull request?
Linus
On Mon, Jun 23, 2014 at 12:44 AM, Al Viro v...@zeniv.linux.org.uk wrote:
OK, here it is, hopefully with sufficient comments:
--
To unsubscribe from this list: send the
Boaz Harrosh commented on the [PATCH v5] sg: relax 16
byte cdb restriction thread that SCSI variable length
commands (which are all SCSI commands greater than 16
bytes long) must themselves be a multiple of 4 bytes
long.
ChangeLog
- limit the maximum cdb size permitted by the sg
v3
On Wed, 2014-06-25 at 16:26 +0200, Maurizio Lombardi wrote:
Hi,
On 06/25/2014 04:04 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
On 06/06/2014 03:10 AM, Maurizio Lombardi wrote:
During IO with fabric faults, one generally sees several Unhandled error
code messages in the syslog as shown below:
sd 4:0:6:2: [sdbw] Unhandled error code
sd 4:0:6:2: [sdbw] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
sd 4:0:6:2:
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote:
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel.
Done with a simple cocci script and some typing.
Joe Perches
On 14-06-25 10:39 AM, Hannes Reinecke wrote:
Update the sg driver to use dev_printk() variants instead of
plain printk(); this will prefix logging messages with the
appropriate device.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by: Doug Gilbert dgilb...@interlog.com
^^^
A
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Christoph Hellwig
Sent: Wednesday, 25 June, 2014 6:07 AM
To: Maurizio Lombardi
Cc: james.bottom...@hansenpartnership.com; linux-scsi@vger.kernel.org;
v2:
Combined the mptfusion and mpt{2,3}sas static checker patches,
re-ordering them by driver. Updated Reviewed-by and Acked-by tags as
well as Sreekanth's email address. Based off v3.16-rc2, compile tested.
patches dropped:
* mpt3sas: fix possible memory leak in
In _scsih_{slave,target}_alloc, an incorrect structure type is passed
to sizeof() when allocating storage for hostdata. Luckily larger
structure types were used, so at least the wrong sizes were safe:
struct scsi_device (1784 bytes) struct MPT2SAS_DEVICE (24 bytes)
struct scsi_target (760
In _scsih_{slave,target}_alloc, an incorrect structure type is passed
to sizeof() when allocating storage for hostdata. Luckily larger
structure types were used, so at least the wrong sizes were safe:
struct scsi_device (1784 bytes) struct MPT3SAS_DEVICE (24 bytes)
struct scsi_target (760
The MPT2SAS_ADAPTER reply_post_host_index[] holds calculated addresses
in memory mapped register space. Add an __iomem annotation to silence
the following sparse warnings:
drivers/scsi/mpt2sas/mpt2sas_base.c:1006:43:
warning: incorrect type in argument 2 (different address spaces)
Tack the firmware reply event_data payload to the end of its
corresponding struct fw_event_work allocation. This matches the
convention in the mptfusion driver and simplifies the code.
This avoids the following smatch warning:
drivers/scsi/mpt3sas/mpt3sas_scsih.c:2519
Fixes the following sparse warnings:
drivers/message/fusion/mptbase.c:7011:1: warning: symbol
'mpt_SoftResetHandler' was not declared. Should it be static?
drivers/message/fusion/mptsas.c:1578:23: warning: symbol
'mptsas_refreshing_device_handles' was not declared. Should it be
The struct _MPT_ADAPTER doesn't need a full copy of the product string,
so prod_name can point to the string literal storage that the driver
already provides.
Avoids the following smatch warning:
drivers/message/fusion/mptbase.c:2858 MptDisplayIocCapabilities()
warn: this array is probably
1 - 100 of 118 matches
Mail list logo
