Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Mike Qiu
On 07/17/2014 10:15 PM, Joe Lawrence wrote: [ +cc linux-pci and Bjorn, comments inline/below ... ] On Thu, 17 Jul 2014 02:32:31 -0400 Mike Qiu wrote: In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected interface, which will call

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-17 Thread Elliott, Robert (Server Storage)
In sd_sync_cache: rq->timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER; Regardless of the baseline for the multiplication, a magic number of 2 is too arbitrary. That might work for an individual drive, but could be far too short for a RAID controller that runs into worst case error handling for th

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-17 Thread KY Srinivasan
> -Original Message- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- > devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Friday, June 20, 2014 2:37 PM > To: Jens Axboe; James Bottomley; micha...@cs.wisc.edu > Cc: linux-scsi@vger.kernel.org;

Re: [PATCH net-next v2 0/4] cxgb4i: Add ipv6 support

2014-07-17 Thread David Miller
From: Anish Bhatt Date: Thu, 17 Jul 2014 00:18:14 -0700 >The following patchset add ipv6 support for the cxgb4i(iscsi) driver. > > Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, > as it is used by cxgb4i and iw_cxgb4 both. > Patch 2 exports symbols needed by

Re: [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-07-17 Thread Christoph Hellwig
Can I get reviews for the patches still missing one, maybe from the Distro folks? I'd like to pull in the whole things in favor of cherry picking the reviewed patches. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kern

[PATCH 1/3] blk-mq: cleanup after blk_mq_init_rq_map failures

2014-07-17 Thread Robert Elliott
In blk-mq.c blk_mq_alloc_tag_set, if: set->tags = kmalloc_node() succeeds, but one of the blk_mq_init_rq_map() calls fails, goto out_unwind; needs to free set->tags so the caller is not obligated to do so. None of the current callers (null_blk, virtio_blk, virtio_blk, or the forthc

[PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag_set return values

2014-07-17 Thread Robert Elliott
Two of the blk-mq based drivers do not pass back the return value from blk_mq_alloc_tag_set, instead just returning -ENOMEM. blk_mq_alloc_tag_set returns -EINVAL if the number of queues or queue depth is bad. -ENOMEM implies that retrying after freeing some memory might be more successful, but th

[PATCH 3/3] mpt3sas, mpt2sas: fix scsi_add_host error handling problems in _scsih_probe

2014-07-17 Thread Robert Elliott
In _scsih_probe, propagate the return value from scsi_add_host. In mpt3sas, avoid calling list_del twice if that returns an error, which causes list_del corruption warnings if an error is returned. Tested with blk-mq and scsi-mq patches to properly cleanup from and propagate blk_mq_init_rq_map err

[PATCH 0/3] blk-mq: blk_mq_init_rq_map error handling

2014-07-17 Thread Robert Elliott
The following series cleans up blk_mq_init_rq_map failures properly. --- Robert Elliott (3): blk-mq: cleanup after blk_mq_init_rq_map failures blk-mq: pass along blk_mq_alloc_tag_set return values mpt3sas,mpt2sas: fix scsi_add_host error handling problems in _scsih_probe bloc

megasas: failed to get PD list

2014-07-17 Thread Peter Andersson
Hi. I'm having major problems with my "MegaRAID SAS 9240-81" raid controller. Basically the kernel doesn't find my raid drives. Bios version: 4.38.02.0 (January 16 2014) The bios of the raid controller shows a fully working (and initialized) raid 0. Kernel: 3.15.1-031501-generic (ubuntu serv

[PATCH] ahci_xgene: add errata workaround for ATA_CMD_SMART

2014-07-17 Thread Mark Salter
commit 2a0bdff6b958d1b2: ahci_xgene: fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command. added a workaround for X-Gene AHCI controller errata. This was done for all ATA_CMD_ID_ATA commands. The errata also appears to affect ATA_CMD_SMART commands as well. This was discove

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-07-17 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> Sorry for the late reply but it's only now that I noticed this Bart> patch. Are you sure that presence of a NAA descriptor is Bart> mandatory ? This is what I found in SPC-4 r37 paragraph 7.8.6.2.1: Bart> At least one designation descriptor should

Re: [PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-17 Thread Christoph Hellwig
Can I get a second review in addition to the one from Martin for this one? This is the last blocker for merging the series and pushing an updated branch out! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordo

Re: SCSI eats error from flush failure during hot plug

2014-07-17 Thread Martin K. Petersen
> "James" == James Bottomley writes: >> Below is James' patch with a trivial comment fix and a proper >> changelog. James, can I get your signoff for this one? I'll throw >> it into the core-for-3.16 tree then. James> OK, here it is. I tweaked the comment to be accurate. Reviewed-by: Mart

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-17 Thread Joe Lawrence
[ +cc linux-pci and Bjorn, comments inline/below ... ] On Thu, 17 Jul 2014 02:32:31 -0400 Mike Qiu wrote: > In IBM Power servers, when hardware error occurs during probe > state, EEH subsystem will call driver's error_detected interface, > which will call pci_disable_device(). But driver's probe

Re: [PATCH] bnx2i: Update driver version to 2.7.10.1

2014-07-17 Thread Christoph Hellwig
On Thu, Jul 17, 2014 at 05:19:49AM -0400, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > Signed-off-by: Vikas Chaudhary Thanks, applied - no need for a second review on a simple version bump. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-17 Thread Martin K. Petersen
> "Christoph" == hch@infradead org writes: Christoph> That's mostly because we don't support larger than 512 byte Christoph> TRIM payloads yet.. I did add support for that a few years back but all hell broke loose and we had to revert it. There were several drives that failed with more than

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-07-17 Thread Bart Van Assche
On 05/29/14 05:52, Martin K. Petersen wrote: > Copy offloading requires us to know the NAA descriptor for both source > target device. This descriptor is mandatory in the Device Identification > VPD page. Locate this descriptor in the returned VPD data so we don't > have to do lookups for every cop

[PATCH] tgt: remove SCSI_TGT and SCSI_FC_TGT_ATTRS

2014-07-17 Thread Paul Bolle
The Kconfig symbols SCSI_TGT and SCSI_FC_TGT_ATTRS are unused since commit 73685a458f2e ("tgt: removal"). Setting them has no effect. Remove these symbols. Signed-off-by: Paul Bolle --- Tested by running "make oldconfig" on a Fedora 20 based .config. That .config has CONFIG_SCSI_TGT set to 'm' an

[PATCH] bnx2i: Update driver version to 2.7.10.1

2014-07-17 Thread vikas.chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/bnx2i/bnx2i_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 748ff8e..c8b410c 100644 --- a/drivers/scsi/bnx2i/bnx2i_init.c

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-17 Thread h...@infradead.org
On Wed, Jul 16, 2014 at 03:20:00PM -0400, Martin K. Petersen wrote: > The block layer can only describe one contiguous block range in a > request. My copy offload patches introduces the bi_special field that > allows us to attach additional information to an I/O. I have > experimented with doing th

[PATCH net-next v2 3/4] libcxgbi: Add ipv6 api to driver

2014-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt Signed-off-by: Karen Xie Signed-off-by: Manoj Malviya --- drivers/scsi/cxgbi/libcxgbi.c | 237 ++ drivers/scsi/cxgbi/libcxgbi.h | 21 +++- 2 files changed, 237 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/cxgbi/lib

[PATCH net-next v2 1/4] cxgb4/iw_cxgb4: Move common defines to cxgb4

2014-07-17 Thread Anish Bhatt
This define is used by cxgb4i and iw_cxgb4, moving to avoid code duplication Signed-off-by: Anish Bhatt Acked-by: Steve Wise --- drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 1 - drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH net-next v2 0/4] cxgb4i: Add ipv6 support

2014-07-17 Thread Anish Bhatt
Hi, The following patchset add ipv6 support for the cxgb4i(iscsi) driver. Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, as it is used by cxgb4i and iw_cxgb4 both. Patch 2 exports symbols needed by cxgb4i for ipv6 support from cxgb4. Patch 3 & 4 deal with actual

[PATCH net-next v2 2/4] cxgb4: Export symbols required by cxgb4i for ipv6 support and required defines

2014-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 4 drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 2 ++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/

[PATCH net-next v2 4/4] cxgb4i: Add ipv6 code to driver, call into libcxgbi ipv6 api

2014-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt Signed-off-by: Karen Xie Signed-off-by: Manoj Malviya --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 353 + 1 file changed, 314 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/c