[PATCH v4 2/4] arm64: Remove the clock and PHY reference from the APM X-Gene SoC AHCI SATA Host controller dts node.

2014-07-28 Thread Suman Tripathi
This patch removes all clocks and PHY references from the APM X-Gene SoC AHCI SATA host controller and PHY DTS nodes. The clock and PHY are no longer needed as they are handled by the firmware. By removing only the reference is not enough as any un-used clock entry will get disabled by the clock fr

[PATCH v4 4/4] ata: Removing NCQ support from the APM X-Gene SoC AHCI SATA Host Controller driver.

2014-07-28 Thread Suman Tripathi
This patch removes the NCQ support from the APM X-Gene SoC AHCI Host Controller driver as it doesn't support it. Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- drivers/ata/ahci_xgene.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci_xgene.c b/dr

[PATCH v4 1/4] ata: Fix the watermark threshold for the APM X-Gene SATA host controller driver.

2014-07-28 Thread Suman Tripathi
As per SATA IO specification, when Host sends HOLD, the device takes about 20DW latency to reply to HOLDA. In some case, device doesn't response to HOLDA over 20DW and causes FIFO goes into over flow condition. Due to this condition, device enumerations fails with those devices. This patch adjust t

[PATCH v4 3/4] ata: Use correct OOB tunning parameters for APM X-Gene SoC AHCI SATA Host controller driver.

2014-07-28 Thread Suman Tripathi
APM X-Gene SoC AHCI SATA Host controller driver requires some correction of Phy Control OOB timing for the COMINIT/COMWAKE parameters to correctly interoperate with different kinds of disks. Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- drivers/ata/ahci_xgene.c | 6 +++--- 1 file chan

[PATCH v4 0/4]ata: Fixes related to APM X-Gene SATA host controller driver.

2014-07-28 Thread Suman Tripathi
This patch set contains a couple of fixes related to APM X-Gene SATA controller driver. v2 Change: 1. Drop the Link down retry patch from this patch set. v4 Change: 1. Drop the patch to fix the csr-mask in dts for PHY clock node of SATA Host Controller 1. 2. Add the patch to correct

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Hannes Reinecke
On 07/29/2014 03:13 AM, Luis R. Rodriguez wrote: On Mon, Jul 28, 2014 at 5:35 PM, Greg KH wrote: On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: On Mon, Jul

Re: Write cache and surface error behaviour

2014-07-28 Thread Douglas Gilbert
On 14-07-28 04:57 PM, Jeremy Linton wrote: On 7/20/2014 4:54 PM, joystick wrote: So what happens when the disk tries to write it to the platter and discovers that there is a media error on that sector? (suppose relocation does not happen ; maybe sectors exhausted) Does Linux receive the write er

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 5:35 PM, Greg KH wrote: > On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: >> > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: >> >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: > > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: > >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez > >> wrote: > >> > On Mon, Jul 28, 2014 at 11:55 AM,

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez >> wrote: >> > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH >> > wrote: >> >> So, what drivers are having problems in their in

[PATCH] [SCSI] Remove reference to scsi_wait_scan module in SCSI_SCAN_ASYNC doc

2014-07-28 Thread Yannick Brosseau
The module was removed in c6072609d9bb91ff54aee3ef29304bd5b4fc88aae Author: James Bottomley Date: Sun May 27 10:13:46 2012 +0100 [SCSI] Remove scsi_wait_scan module Signed-off-by: Yannick Brosseau --- drivers/scsi/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) dif

Re: Write cache and surface error behaviour

2014-07-28 Thread Jeremy Linton
On 7/20/2014 4:54 PM, joystick wrote: > So what happens when the disk tries to write it to the platter and > discovers that there is a media error on that sector? (suppose relocation > does not happen ; maybe sectors exhausted) Does Linux receive the write > error upon the next flush it issues?

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez > wrote: > > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH > > wrote: > >> So, what drivers are having problems in their init sequence, and why > >> aren't they using async firmwa

Re: Write cache and surface error behaviour

2014-07-28 Thread Dale R. Worley
> From: joystick > > I don't really understand this disk cache thing. > Suppose a disk with write cache enabled of writeback type: Linux > receives a write completed notification (a message from the disk) when > the data has reached the cache of the disk. Correct? At that point it is > not con

[PATCH 4/5] ipr: Set scsi_level correctly for disk arrays

2014-07-28 Thread Brian King
Set the scsi_level correctly for disk arrays such that things like the rotational field get set properly by sd.c. Signed-off-by: Brian King --- drivers/scsi/ipr.c |1 + 1 file changed, 1 insertion(+) diff -puN drivers/scsi/ipr.c~ipr_array_scsi_level drivers/scsi/ipr.c --- linux/drivers/sc

[PATCH 3/5]: ipr: kexec boot speed improvements

2014-07-28 Thread Brian King
Currently when performing a kexec boot with an ipr adapter, the adapter gets shutdown completely, flushing all write cache, as well as performing a full hardware reset of the card during the shutdown phase of the old kernel. This forces the new kernel to then wait for the adapter firmware to reini

[PATCH 5/5] ipr: Driver version 2.6.1

2014-07-28 Thread Brian King
Bump driver version. Signed-off-by: Brian King --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/ipr.h~ipr_version_2_6_1 drivers/scsi/ipr.h --- linux/drivers/scsi/ipr.h~ipr_version_2_6_1 2014-07-25 11:27:33.840128017 -0500 +++ linux-b

[PATCH 2/5] kexec: Export kexec_in_progress

2014-07-28 Thread Brian King
Export kexec_in_progress for use by device drivers and other modules to optimize kexec boot. Signed-off-by: Brian King --- kernel/kexec.c |2 ++ 1 file changed, 2 insertions(+) diff -puN kernel/kexec.c~kexec_export_in_prog kernel/kexec.c --- linux/kernel/kexec.c~kexec_export_in_prog 201

[PATCH 1/5] ipr: Add support for async scanning to speed up boot

2014-07-28 Thread Brian King
Switch device scanning logic in the ipr driver to use the async scan API. This speeds up boot times, particularly on large systems. Signed-off-by: Brian King --- drivers/scsi/ipr.c | 88 + drivers/scsi/ipr.h |4 -- 2 files changed, 44 i

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Monday, July 28, 2014 1:03 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; sits...@gmail.com; > de...@linuxdriverproject.org; a...@canonical.com; > martin.peter...@oracle.

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread James Bottomley
On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote: > > > -Original Message- > > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > > Sent: Monday, July 28, 2014 12:03 PM > > To: KY Srinivasan > > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; > > gre...@linuxf

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH wrote: >> So, what drivers are having problems in their init sequence, and why >> aren't they using async firmware loading? > > Fixing drivers is one thing, fixing drivers *now* because *now* >

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread KY Srinivasan
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Monday, July 28, 2014 12:03 PM > To: KY Srinivasan > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproje

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 11:55 AM, Greg KH wrote: > So, what drivers are having problems in their init sequence, and why > aren't they using async firmware loading? Fixing drivers is one thing, fixing drivers *now* because *now* drivers are failing due to a regression is another thing and that's w

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: KY, KY> "At the time thin-provisioning was defined, the discovery KY> information was first proposed in READ CAPACITY 16 command. And then KY> moved into the new dedicated VPD page - B2h. You can see the KY> information reported in this VPD page is richer than

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 11:28:28AM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Tetsuo bisected and found that commit 786235ee "kthread: make > kthread_create() killable" modified kthread_create() to bail as > soon as SIGKILL is received. This is causing some issues with > some

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread KY Srinivasan
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Saturday, July 26, 2014 12:25 PM > To: KY Srinivasan > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverpro

Re: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 06:30:29PM +, Yuval Mintz wrote: > > On Mon, Jul 28, 2014 at 06:52:48PM +0200, Luis R. Rodriguez wrote: > > > On Mon, Jul 28, 2014 at 03:46:32PM +, Yuval Mintz wrote: > > > > Sorry for not being clear, but I didn't meant 'what guarantees that the > > > > device > >

[PATCH v2 1/4] driver core: move deferred probe add / remove helpers down a bit

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We need to do this if we want to use the trigger at a later point. This change has introduces no functional changes. Cc: Tetsuo Handa Cc: Joseph Salisbury Cc: One Thousand Gnomes Cc: Tim Gardner Cc: Pierre Fersing Cc: Andrew Morton Cc: Oleg Nesterov Cc: Benjamin

RE: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Yuval Mintz
> On Mon, Jul 28, 2014 at 06:52:48PM +0200, Luis R. Rodriguez wrote: > > On Mon, Jul 28, 2014 at 03:46:32PM +, Yuval Mintz wrote: > > > Sorry for not being clear, but I didn't meant 'what guarantees that the > > > device > > > will be added to the deferred probe', but rather what guarantees th

[PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Tetsuo bisected and found that commit 786235ee "kthread: make kthread_create() killable" modified kthread_create() to bail as soon as SIGKILL is received. This is causing some issues with some drivers and at times boot. Joseph then found that failures occur as the system

[PATCH v2 4/4] mptsas: ask for deferred probe

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Its reported that mptsas can at times take over 30 seconds to recognize SCSI storage devices [0], this is done on the driver's probe path. Use the the deferred probe workqueue to allow long init sequences to complete. [0] https://bugs.launchpad.net/ubuntu/+source/linux/

[PATCH v2 3/4] cxgb4: ask for deferred probe

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" cxgb4 probe can take up to over 1 minute when the firmware is is written and installed on the device. Use the new delayed probe preference so that cxgb4 gets probed on the deferred workqueue. Without this devices that require the update on firmware will fail on probe. C

Re: [PATCH 0/6] qla2xxx device removal fixups

2014-07-28 Thread Chad Dupuis
Ack the series. Acked-by: Chad Dupuis On Wed, 18 Jun 2014, Joe Lawrence wrote: Hi Chad, Giri, et al. Stratus has been testing the upstream qla2xxx driver against surprise device removal and has found a few minor issues along the way. With this patchset, results have been good. Although the

Re: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 03:46:32PM +, Yuval Mintz wrote: > > Subject: Re: [PATCH 1/3] driver core: enable drivers to use deferred probe > > from > > init > > > > On Mon, Jul 28, 2014 at 03:12:11PM +, Yuval Mintz wrote: > > > Perhaps this is a silly question, but what guarantees that the >

Re: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 06:52:48PM +0200, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 03:46:32PM +, Yuval Mintz wrote: > > > Subject: Re: [PATCH 1/3] driver core: enable drivers to use deferred > > > probe from > > > init > > > > > > On Mon, Jul 28, 2014 at 03:12:11PM +, Yuval Mint

RE: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Yuval Mintz
> Subject: Re: [PATCH 1/3] driver core: enable drivers to use deferred probe > from > init > > On Mon, Jul 28, 2014 at 03:12:11PM +, Yuval Mintz wrote: > > Perhaps this is a silly question, but what guarantees that the > > deferred probe list will actually be triggered, e.g., in case the > >

Re: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 03:12:11PM +, Yuval Mintz wrote: > > +static int __driver_probe_device(struct device_driver *drv, struct > > +device *dev) { > > + if (drv->delay_probe && !dev->init_delayed_probe) { > > + dev_info(dev, "Driver %s requests probe deferral on init\n", > > +

RE: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Yuval Mintz
> +static int __driver_probe_device(struct device_driver *drv, struct > +device *dev) { > + if (drv->delay_probe && !dev->init_delayed_probe) { > + dev_info(dev, "Driver %s requests probe deferral on init\n", > + drv->name); > + dev->init_delayed_pro

Re: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 7:51 AM, Takashi Iwai wrote: > > This field isn't used anywhere actually in the patch...? Yeah sorry that is not needed, I avoided that by adding the simple bool on the struct device, forgot to nuke that. Will spin v2 unless I hear otherwise. Luis -- To unsubscribe from

Re: [PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Takashi Iwai
At Mon, 28 Jul 2014 07:34:25 -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > Tetsuo bisected and found that commit 786235ee "kthread: make > kthread_create() killable" modified kthread_create() to bail as > soon as SIGKILL is received. This is causing some issues with > some dr

[PATCH 2/3] cxgb4: ask for deferred probe

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" cxgb4 probe can take up to over 1 minute when the firmware is is written and installed on the device. Use the new delayed probe preference so that cxgb4 gets probed on the deferred workqueue. Without this devices that require the update on firmware will fail on probe. C

[PATCH 3/3] mptsas: ask for deferred probe

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Its reported that mptsas can at times take over 30 seconds to recognize SCSI storage devices [0], this is done on the driver's probe path. Use the the deferred probe workqueue to allow long init sequences to complete. [0] https://bugs.launchpad.net/ubuntu/+source/linux/

[PATCH 1/3] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Tetsuo bisected and found that commit 786235ee "kthread: make kthread_create() killable" modified kthread_create() to bail as soon as SIGKILL is received. This is causing some issues with some drivers and at times boot. Joseph then found that failures occur as the system

Re: [PATCH] block: bsg.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-28 Thread Jeff Moyer
Rickard Strandqvist writes: > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > > Signed-off-by: Rickard Strandqvist > --- > block/bsg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/bsg.c b/block/bsg.c > index ff46add..b2688c5 1006

Re: [Xen-devel] [PATCH V2 1/4] Add XEN pvSCSI protocol description

2014-07-28 Thread David Vrabel
On 25/07/14 12:37, jgr...@suse.com wrote: > From: Juergen Gross > > Add the definition of pvSCSI protocol used between the pvSCSI frontend in a > XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). > > This header was originally provided by Fujitsu for XEN based on Linux 2.6.1

[PATCH] qla4xxx: check the return value of dma_alloc_coherent()

2014-07-28 Thread Maurizio Lombardi
the qla4xxx_alloc_fw_dump() calls dma_alloc_coherent() but does not check its return value. Signed-off-by: Maurizio Lombardi --- drivers/scsi/qla4xxx/ql4_init.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c index 6f12f

Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-28 Thread Vikas Chaudhary
Acked-By: Vikas Chaudhary On 26/07/14 2:11 pm, "Alexander Gordeev" wrote: >On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interface

Re: [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-28 Thread Suma Ramars (sramars)
Acked-by: "Suma Ramars (sramars)" On 26/07/14 1:45 pm, "Alexander Gordeev" wrote: >On Wed, Jul 16, 2014 at 08:05:11PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two int

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-28 Thread James Bottomley
On Sat, 2014-07-26 at 18:21 +0200, Christoph Hellwig wrote: > Here's a formal one. > > James, can I get your signoff for it? Sure: Signed-off-by: James Bottomley > Vladimir, can I get a reviewed-by from you (or anyone else)? > > --- > >From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17