re: scsi_debug: support scsi-mq, queues and locks

2014-07-31 Thread Dan Carpenter
[ This is not really a new bug, it's just that renaming the function made it show up as a new bug and I figured maybe you know what's going on since you are working with related code. -dan ] Hello Douglas Gilbert, This is a semi-automatic email about new static checker warnings. The patch

Re: scsi_debug: support scsi-mq, queues and locks

2014-07-31 Thread James Bottomley
On Thu, 2014-07-31 at 12:10 +0300, Dan Carpenter wrote: [ This is not really a new bug, it's just that renaming the function made it show up as a new bug and I figured maybe you know what's going on since you are working with related code. -dan ] Hello Douglas Gilbert, This is a

RE: [PATCH 3/3] pm8001: Update MAINTAINERS list

2014-07-31 Thread Suresh Thiagarajan
On Wed, Jul 30, 2014 at 5:42 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2014-07-30 at 17:37 +0530, Suresh Thiagarajan wrote: From: Suresh Thiagarajan suresh.thiagara...@pmcs.com Update pmcs mail list for pm8001 driver support Signed-off-by: Suresh Thiagarajan

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-31 Thread James Bottomley
On Wed, 2014-07-30 at 19:59 +0200, Christoph Hellwig wrote: On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote: Some drivers like qla2xxx do not set proc_name. I think if 2 drivers like that are loaded then you will hit some other warns/bugs in the kmem cache setup code right?

Re: [PATCH 3/3] pm8001: Update MAINTAINERS list

2014-07-31 Thread Jack Wang
If it works, then I'm fine with this, thanks. Please add my ack if needed: Acked-by: Jack Wang xjtu...@gmail.com 2014-07-31 14:53 GMT+02:00 Suresh Thiagarajan suresh.thiagara...@pmcs.com: On Wed, Jul 30, 2014 at 5:42 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed,

[GIT PULL] SCSI fixes for 3.16-rc7

2014-07-31 Thread James Bottomley
This is a potential data corruption fix: If we get an error sending down a barrier, we simply ignore it meaning the barrier semantics get violated without anyone being any the wiser. If the system crashes at this point, the filesystem potentially becomes corrupt. Fix is to report errors on

Re: [PATCH] scsi: hpsa.c: Cleaning up code clarification using strlcpy

2014-07-31 Thread scameron
On Wed, Jul 30, 2014 at 11:46:52PM +0200, Rickard Strandqvist wrote: Code clarification using strlcpy instead of strncpy. And removed unnecessary memset Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/scsi/hpsa.c | 16 +++- 1 file

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread Tomas Henzl
Hi Steve, Webb, let me start with the part most important for me - from my previous mail And please have a look at [PATCH] hpsa: refine the pci enble/disable handling I posted in June and add it to your series or review in the list. Thanks. other comments see below Hi Tomas, Thanks for

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread scameron
On Thu, Jul 31, 2014 at 03:56:13PM +0200, Tomas Henzl wrote: Hi Steve, Webb, let me start with the part most important for me - from my previous mail And please have a look at [PATCH] hpsa: refine the pci enble/disable handling I posted in June and add it to your series or review in the

Re: [PATCH -next] scsi: fix u14-34f printk format warnings

2014-07-31 Thread Randy Dunlap
any comments? Thanks. On 07/24/14 11:07, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix printk format warnings (seen on i386 builds): ../drivers/scsi/u14-34f.c: In function 'port_detect': ../drivers/scsi/u14-34f.c:630:28: warning: format '%u' expects argument of type

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-31 Thread scameron
On Sun, Jul 27, 2014 at 05:24:46PM +0200, Hannes Reinecke wrote: On 07/25/2014 09:28 PM, scame...@beardog.cce.hp.com wrote: hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph

Re: [PATCH -next] scsi: fix u14-34f printk format warnings

2014-07-31 Thread Christoph Hellwig
Thanks, Randy. I'll merge it. I usually want a second review for scsi patches, but I guess this one is trivial enough to waive that requirement. That being said is anyone still using the u14-34f driver? From looking at the commit history it doesn't really look either maintained or used.. --

Re: [PATCH] eata: remove driver_lock

2014-07-31 Thread Christoph Hellwig
Can I also get a second review? On Sat, Jul 26, 2014 at 09:25:59AM -0700, Christoph Hellwig wrote: Can I get a quick review for this one? On Mon, Jul 14, 2014 at 10:26:33AM +0200, Christoph Hellwig wrote: port_detect is only called from the module_init routine and thus implicitly

[scsi/net-next] Pulling in net-next changes

2014-07-31 Thread Anish Bhatt
Christoph/James/Mike Is there a timeline for pulling in the cxgb4i changes from net-next, or a specific way to ask for it ? We have more changes in queue for cxgb4i libiscsi, and I would rather have the cxgb4i up to date in the scsi tree before we do that to avoid any potentil issues in

Re: [PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-31 Thread adam radford
On Sun, Jul 27, 2014 at 8:11 AM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And use the sizeof on the to string rather than strlen on the from string. Signed-off-by: Rickard Strandqvist

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

2014-07-31 Thread Mike Christie
On 07/30/2014 07:50 AM, Hannes Reinecke wrote: On 07/12/2014 10:51 PM, micha...@cs.wisc.edu wrote: From: Mike Christie micha...@cs.wisc.edu iscsi_get_host_stats was dropping the error code returned by drivers like qla4xxx. Signed-off-by: Mike Christie micha...@cs.wisc.edu ---

Re: [PATCH] lpfc: Avoid to disable pci_dev twice

2014-07-31 Thread Mike Qiu
On 07/17/2014 02:32 PM, Mike Qiu wrote: Hi, all How about this patch ? Any idea ? In IBM Power servers, when hardware error occurs during probe state, EEH subsystem will call driver's error_detected interface, which will call pci_disable_device(). But driver's probe function also call

Oops in scsi_put_host_cmd_pool

2014-07-31 Thread Juergen Gross
During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed. When calling the final scsi_host_put() from the driver an Oops is happening: [ 219.816292] (file=drivers/scsi/xen-scsifront.c, line=808)