Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-15 Thread Oleg Nesterov
On 08/15, Luis R. Rodriguez wrote: On Wed, Aug 13, 2014 at 07:51:01PM +0200, Oleg Nesterov wrote: On 08/12, Luis R. Rodriguez wrote: +/* To be used by modules which can take over 30 seconds at probe */ Probably the comment should explain that this hack should only be used if the

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: All bytes in CDB should be output after linebuf is filled because [%s] CDB: %s\n message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug

Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: Unrecognized sense data should be output after linebuf is filled because [%s] Unrecognized sense data (in hex): %s message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes

Re: [RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert

Re: [RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: sd_print_sense_hdr() calls scsi_show_extd_sense(), but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). We can get same result, so we delete it. Note: Calling scsi_show_extd_sense() is introduced in fdd8b297.

Re: [PATCH v2 RESEND 09/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-15 Thread scameron
On Wed, Jul 16, 2014 at 08:05:13PM +0200, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact()

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Guenter Roeck
ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). Guenter On 08/10/2014 05:54 AM, Guenter Roeck wrote: The latest kernel fails to boot qemu arm images when using scsi for disk access. Boot gets stuck after

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Jens Axboe
On 2014-08-15 12:22, Guenter Roeck wrote: ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). James, could you upstream this one in time for -rc1? -- Jens Axboe -- To unsubscribe from this list: send the line

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Webb Scales
On 8/10/14 8:54 AM, Guenter Roeck wrote: The latest kernel fails to boot qemu arm images when using scsi for disk access. Boot gets stuck after the following messages. brd: module loaded sym53c8xx :00:0c.0: enabling device (0100 - 0103) sym0: 895a rev 0x0 at pci :00:0c.0 irq 93 sym0: No

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Christoph Hellwig
On Fri, Aug 15, 2014 at 12:34:22PM -0600, Jens Axboe wrote: On 2014-08-15 12:22, Guenter Roeck wrote: ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). James, could you upstream this one in time for -rc1? It's

Re: [ANNOUNCE] scsi patch queue tree updated

2014-08-15 Thread Christoph Hellwig
On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote: So this is a bit late to get through linux-next and into a pull request. I was planning on sending the final pull tomorrow (in case Linus planned a surprise early release). Can we redo some of these as bug fixes and send them in

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Guenter Roeck
On 08/15/2014 12:22 PM, Christoph Hellwig wrote: On Fri, Aug 15, 2014 at 12:34:22PM -0600, Jens Axboe wrote: On 2014-08-15 12:22, Guenter Roeck wrote: ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). James, could

Re: [ANNOUNCE] scsi patch queue tree updated

2014-08-15 Thread James Bottomley
On Fri, 2014-08-15 at 12:25 -0700, Christoph Hellwig wrote: On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote: So this is a bit late to get through linux-next and into a pull request. I was planning on sending the final pull tomorrow (in case Linus planned a surprise early

[GIT PULL] Final round of SCSI updates for the 3.16+ merge window

2014-08-15 Thread James Bottomley
Just a note, we do have a couple of bug fixes coming under separate cover, but they don't have to be part of the merge window This is a small set of updates which missed the first pull. It's more msix updates, some iscsi and qla4xxx fixes, we also have some string null termination fixes a return

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-15 Thread Luis R. Rodriguez
On Fri, Aug 15, 2014 at 04:39:02PM +0200, Oleg Nesterov wrote: On 08/15, Luis R. Rodriguez wrote: On Wed, Aug 13, 2014 at 07:51:01PM +0200, Oleg Nesterov wrote: On 08/12, Luis R. Rodriguez wrote: +/* To be used by modules which can take over 30 seconds at probe */ Probably