From: Luis R. Rodriguez mcg...@suse.com
Joseph bisected and found that Tetsuo Handa's commit 786235ee
kthread: make kthread_create() killable modified kthread_create()
to bail as soon as SIGKILL is received [0] [1]. This is causing some
issues with some drivers and at times boot. There are other
On 08/31/2014 01:14 AM, Douglas Gilbert wrote:
On 14-08-30 04:56 PM, Milan Broz wrote:
Hi,
I am using scsi_debug in cryptsetup testsuite and with recent 3.17-rc kernel
it deadlocks on rmmod of scsi_debug module.
For me even this simple reproducer causes deadlock:
modprobe scsi_debug
On Sat, 30 Aug 2014, Douglas Gilbert wrote:
On 14-08-30 05:15 PM, Alan Stern wrote:
On Fri, 29 Aug 2014, Matthew Dharm wrote:
Is there an 'easy' way to override the detected size of a storage
device from userspace? If we had that, someone could write a helper
application which looked
On 14-08-31 05:49 AM, Milan Broz wrote:
On 08/31/2014 01:14 AM, Douglas Gilbert wrote:
On 14-08-30 04:56 PM, Milan Broz wrote:
Hi,
I am using scsi_debug in cryptsetup testsuite and with recent 3.17-rc kernel
it deadlocks on rmmod of scsi_debug module.
For me even this simple reproducer
Hi Linus,
Here are the target pending updates for v3.17-rc3. Please go ahead and
pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
Note that these patches where originally intended for -rc1, but missed
the merge window. They are mostly iser-target
On 08/30/2014 10:35 AM, Richard W.M. Jones wrote:
On Tue, Jul 01, 2014 at 12:11:14PM -0700, Andy Grover wrote:
Describes the driver and its interface to make it possible for user
programs to back a LIO-exported LUN.
Signed-off-by: Andy Grover agro...@redhat.com
---
On 8/28/2014 10:31 PM, Martin K. Petersen wrote:
A set of flags introduced in the block layer enable better control over
how protection information is handled. These flags are useful for both
error injection and data recovery purposes. Checking can be enabled and
disabled for controller and
On Sun, Aug 31, 2014 at 12:49:26PM -0700, Andy Grover wrote:
Thanks for the feedback. I am undoubtedly too close to the details,
because I thought I *was* explaining things :)
Yeah, sorry it came across as a bit harsh.
Benoit did explain it to me so I understood it in the end (I think!)
This
On Thu, Aug 28, 2014 at 07:33:17PM +0200, Hannes Reinecke wrote:
sd_done() was calling scsi_print_sense() for a sense code
of 'NO_SENSE'.
Signed-off-by: Hannes Reinecke h...@suse.de
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line
On Thu, Aug 28, 2014 at 07:33:15PM +0200, Hannes Reinecke wrote:
Unused.
Signed-off-by: Hannes Reinecke h...@suse.de
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
On Thu, Aug 28, 2014 at 07:33:16PM +0200, Hannes Reinecke wrote:
Signed-off-by: Hannes Reinecke h...@suse.de
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
Needs a bit more description in the patch body and preferable also
in a comment next to the macro. What's the benefit of it over simply
using sdev_printk with another argument?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
-scsi_extd_sense_format(unsigned char asc, unsigned char ascq) {
+scsi_extd_sense_format(unsigned char asc, unsigned char ascq,
+const char **fmt) {
please move the opening brace to a new line per normal Linux style.
Otherwise looks good,
Reviewed-by: Christoph Hellwig
On Thu, Aug 28, 2014 at 07:33:20PM +0200, Hannes Reinecke wrote:
If scsi_normalize_sense() fails we couldn't decode the sense
buffer, so we should not try to interpret the result.
We should rather dump the sense buffer instead and stop decoding.
as far as I can tell the old code doesn't
On Thu, Aug 28, 2014 at 07:33:21PM +0200, Hannes Reinecke wrote:
Currently we're only decoding sense extras for tape devices.
And even there only for fixed format sense formats.
As this is of rather limited use in the general case we should
be stop trying to decode things here and rather dump
On Thu, Aug 28, 2014 at 07:33:22PM +0200, Hannes Reinecke wrote:
Dumping the entire sense buffer might overwhelm the logging functions,
so suppress it per default.
Call me dumb, but I don't see anything in here that limits the dumps
to debug output.
Also if you return boolean-like values
Please also remove the now useless sd_print_result wrapper.
Otherwise looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
#if defined(AHA152X_DEBUG)
- if (HOSTDATA(shpnt)-debug debug_status) {
- printk(DEBUG_LEAD inbound status %02x , CMDINFO(CURRENT_SC),
CURRENT_SC-SCp.Status);
- scsi_print_status(CURRENT_SC-SCp.Status);
- printk(\n);
- }
+ if
+ if ((cdb_len 0) (len != cdb_len))
+ printk(, in_cdb_len=%d, ext_len=%d, len, cdb_len);
not need for both sets of inner braces here.
Otherwise looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe
Can you change the subject a bit? There's nothing obsolete in
__scsi_print_command, you're just moving it to a higher level helper.
#if defined(AHA152X_DEBUG)
if (HOSTDATA(shpnt)-debug debug_queue) {
- printk(INFO_LEAD queue: %p; cmd_len=%d pieces=%d size=%u
cmnd=,
-
On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote:
SCSI opcode printing is tricky and needs to take into account
several different corner cases. So instead of trying to come
up with an elaborate printk() statement we should be printing
it into a local buffer.
scsi_print_command
+const char *
+scsi_disposition_string(unsigned int disposition) {
The brace placement will need a fix.
+void scsi_print_result(struct scsi_cmnd *cmd, int disposition)
{
const char *devname = cmd-request-rq_disk ?
cmd-request-rq_disk-disk_name : NULL;
-
What's the point? eh_abort_handler is only supposed to return SUCCESS
or FAILURE, so I'd rather remove printing of rtn entirely.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Thu, Aug 28, 2014 at 07:33:34PM +0200, Hannes Reinecke wrote:
Always use 'scmd 0x%p' when logging a command pointer.
Is there any good reason to print the address of a command pointer?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
On Thu, Aug 28, 2014 at 07:33:35PM +0200, Hannes Reinecke wrote:
When devices fail they can generate quite a lot of error
messages, possibly overloading the logging system.
So we should be putting these messages under logging control
to be able to silence them if requested.
And we should
On Thu, Aug 28, 2014 at 07:33:36PM +0200, Hannes Reinecke wrote:
There is no need to print out the command result verbatim;
that will be done by the scsi stack if required.
Here we just should log the result in short if requested.
Is there any good reason to keep this logging in sd at all?
--
Looks good to me from the SCSI POV. As discussed earlier I'm fine with
picking this up via the Xen tree. If you really want it to go through
the SCSI tree and I'd be happy to pick it up once I get another full
review.
Acked-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list:
--
Lieber Freund,
Wie geht es Ihnen heute? Ich hoffe, fein, ich bin Dr. Martin Dustin aus
Harlesden , North West London, hier in England. Ich arbeite für NatWest
Bank London (National Westminster Bank Plc. ) . Ich schreibe Ihnen aus
meinem Büro , die von einer großen immensen Nutzen für
A deadlock has been reported when the completion
of SCSI commands (simulated by a timer) was surprised
by a module removal. This patch removes one half of
the offending locks around timer deletions. This fix
is applied both to stop_all_queued() which is were
the deadlock was discovered and
--
Lieber Freund,
Wie geht es Ihnen heute? Ich hoffe, fein, ich bin Dr. Martin Dustin aus
Harlesden , North West London, hier in England. Ich arbeite für NatWest
Bank London (National Westminster Bank Plc. ) . Ich schreibe Ihnen aus
meinem Büro , die von einer großen immensen Nutzen für
On Sun, Aug 31, 2014 at 11:59 AM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
Note that these patches where originally intended for -rc1, but missed
the merge window. They are mostly iser-target related bug-fixes, along
with a few other very minor cleanups.
So this pull request was
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Christoph Hellwig
Sent: Sunday, 31 August, 2014 5:26 PM
...
On Thu, Aug 28, 2014 at 07:33:34PM +0200, Hannes Reinecke wrote:
Always use 'scmd 0x%p' when logging a
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Christoph Hellwig
Sent: Sunday, 31 August, 2014 5:29 PM
To: Hannes Reinecke
Cc: James Bottomley; Ewan Milne; Christoph Hellwig; linux-
s...@vger.kernel.org; Hoffmann,
33 matches
Mail list logo
