Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-30 Thread Luis R. Rodriguez
On Sun, Sep 28, 2014 at 12:22:47PM -0700, Dmitry Torokhov wrote: Hi Luis, On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote: +static bool drv_enable_async_probe(struct device_driver *drv, + struct bus_type *bus) +{ + struct module *mod;

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-30 Thread Luis R. Rodriguez
On Mon, Sep 29, 2014 at 05:26:01PM -0400, Tejun Heo wrote: Hello, Luis. On Mon, Sep 29, 2014 at 11:22:08PM +0200, Luis R. Rodriguez wrote: + /* For now lets avoid stupid bug reports */ + if (!strcmp(bus-name, pci) || + !strcmp(bus-name, pci_express) || +

Re: [PATCH] megaraid_sas: Enable shared tag map

2014-09-30 Thread Christoph Hellwig
On Mon, Sep 29, 2014 at 01:47:52PM +0200, Hannes Reinecke wrote: Megaraid_sas uses a shared pool of commands per HBA, so we should be enabling a shared tag map. This will allow the I/O scheduler to make better scheduling decisions and will avoid BUSY states in the driver. What exact problem

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-30 Thread Luis R. Rodriguez
On Tue, Sep 30, 2014 at 04:27:51AM +0200, Luis R. Rodriguez wrote: On Sun, Sep 28, 2014 at 07:07:24PM +0200, Tom Gundersen wrote: On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: From: Luis R. Rodriguez mcg...@suse.com 0) Not all drivers are killed, the

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-30 Thread Chen Gang
On 9/29/14 22:02, Konrad Rzeszutek Wilk wrote: On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote: When xenbus_switch_state() fails, it will call xenbus_switch_fatal() Only on the first depth, not on the subsequent ones (as in if the first xenbus_switch_fail fails, it won't try to

targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
hi everybody, I write to you for a problem that sound as my simple mistake but I can't really find a solution after googling and reading official doc. I'm trying to configure a iscsi target on a centos 6.5 box with a custom kernel compiled from vanilla 3.16.3. I have compile:

Re: targetcli do not show iscsi

2014-09-30 Thread Jerome Martin
Hi Luigi, I am not 100% sure of that, as you are using the -fb branch, but it seems to me you haven't got the /sys/kernel/config/target/iscsi/ directory. Normally this is created by the initscript. Can you either try creating it manually, and/or starting the target service susing the

Re: targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
Hi Jerome, thanks for the promptly reply. I'm not using the -fb branch. I have installed targetcli from centos rpm: # rpm -qi fcoe-target-utils-2.0rc1.fb16-5.el6.noarch Name: fcoe-target-utilsRelocations: (not relocatable) Version : 2.0rc1.fb16

Re: [PATCH] megaraid_sas: Enable shared tag map

2014-09-30 Thread Hannes Reinecke
On 09/30/2014 09:43 AM, Christoph Hellwig wrote: On Mon, Sep 29, 2014 at 01:47:52PM +0200, Hannes Reinecke wrote: Megaraid_sas uses a shared pool of commands per HBA, so we should be enabling a shared tag map. This will allow the I/O scheduler to make better scheduling decisions and will

Re: targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
I have installed targetcli from centos rpm: # rpm -qi fcoe-target-utils-2.0rc1.fb16-5.el6.noarch See the version here? fb16... oh ok. I'm not sure what is the initscript you mention. I have in /etc/init.d/: # ls fcoe-target iscsi* fcoe-target iscsi iscsid but afaik those are for the

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-30 Thread Tom Gundersen
On Tue, Sep 30, 2014 at 4:27 AM, Luis R. Rodriguez mcg...@suse.com wrote: On Sun, Sep 28, 2014 at 07:07:24PM +0200, Tom Gundersen wrote: On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: From: Luis R. Rodriguez mcg...@suse.com Systemd has a general timeout

Re: targetcli do not show iscsi

2014-09-30 Thread Jerome Martin
Luigi, Out of curiosity, does it work as expected with the stock fedora packaged kernel ? Best, -- Jerome On 09/30/2014 11:20 AM, Luigi Tarenga wrote: I have installed targetcli from centos rpm: # rpm -qi fcoe-target-utils-2.0rc1.fb16-5.el6.noarch See the version here? fb16... oh

Re: targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
On 09/30/2014 11:28 AM, Jerome Martin wrote: Luigi, Out of curiosity, does it work as expected with the stock fedora packaged kernel ? Best, -- Jerome didn't test that configuration and since I can't find module iscsi_target_mod in stock kernel I would have to recompile it against

Re: targetcli do not show iscsi

2014-09-30 Thread Jerome Martin
On 09/30/2014 11:41 AM, Luigi Tarenga wrote: On 09/30/2014 11:28 AM, Jerome Martin wrote: Luigi, Out of curiosity, does it work as expected with the stock fedora packaged kernel ? Best, -- Jerome didn't test that configuration and since I can't find module iscsi_target_mod in stock ok

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-30 Thread David Vrabel
On 26/09/14 17:36, Chen Gang wrote: When xenbus_switch_state() fails, it will call xenbus_switch_fatal() internally, so need not return any status value, then use 'void' instead of 'int' for xenbus_switch_state() and __xenbus_switch_state(). Also need be sure that all callers which check the

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-30 Thread Chen Gang
On 9/30/14 17:55, David Vrabel wrote: On 26/09/14 17:36, Chen Gang wrote: When xenbus_switch_state() fails, it will call xenbus_switch_fatal() internally, so need not return any status value, then use 'void' instead of 'int' for xenbus_switch_state() and __xenbus_switch_state(). Also need be

[Bug 85151] pm80xx + 7805H + HP SAS port expander = mpi_smp_completion 2604:smp IO status 0x2 and sas: expander ... discovery failed(0xffffffa6)

2014-09-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=85151 --- Comment #10 from linux-...@crashplan.pro --- After splitting module loading and connecting the expander, and enabling verbose pm80xx logging in between: 1. disconnect cable 2. modprobe pm80xx 3. # echo 0xfff $(find /sys -iname logging_level)

Re: [PATCH] scsi_host: fix comment

2014-09-30 Thread Bart Van Assche
On 09/20/14 13:37, Sebastian Herbszt wrote: Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the order of Scsi_Host members. Update the comment to reflect this. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index

Re: [PATCH] scsi_host: fix comment

2014-09-30 Thread Hannes Reinecke
On 09/30/2014 01:13 PM, Bart Van Assche wrote: On 09/20/14 13:37, Sebastian Herbszt wrote: Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the order of Scsi_Host members. Update the comment to reflect this. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff --git

[PATCH 02/23] sd: Remove scsi_print_sense() in sd_done()

2014-09-30 Thread Hannes Reinecke
sd_done() was calling scsi_print_sense() for a sense code of 'NO_SENSE'. Reviewed-by: Christoph Hellwig h...@infradead.org Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/sd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index

[PATCH 14/23] scsi: merge print_opcode_name()

2014-09-30 Thread Hannes Reinecke
Instead of having two versions of print_opcode_name() we should be consolidating them into one version. Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 90 ++-- 1 file changed, 34

[PATCH 07/23] fas216: Update logging messages

2014-09-30 Thread Hannes Reinecke
Update logging messages to use dev_printk() variants for correct device annotations. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/arm/fas216.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/arm/fas216.c

[PATCH 21/23] scsi: fixup logging messages in scsi_error.c

2014-09-30 Thread Hannes Reinecke
Use the matching scope for logging messages to allow for better command tracing. Suggested-by: Robert Elliott elli...@hp.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/hosts.c | 4 +-- drivers/scsi/scsi_error.c | 82 +-- 2 files

[PATCH 01/23] Remove scsi_cmd_print_sense_hdr()

2014-09-30 Thread Hannes Reinecke
Unused. Reviewed-by: Christoph Hellwig h...@infradead.org Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 14 -- include/scsi/scsi_dbg.h | 2 -- 2 files changed, 16 deletions(-) diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c index

[PATCH 18/23] scsi: separate out scsi_(host|driver)byte_string()

2014-09-30 Thread Hannes Reinecke
Export functions for later use. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 58 include/scsi/scsi_dbg.h | 2 ++ 2 files changed, 46 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/constants.c

[PATCH 08/23] 53c700: remove scsi_print_sense() usage

2014-09-30 Thread Hannes Reinecke
The 53c700 driver would be using scsi_print_sense() in a debug statement, which was never compiled in. Plus the same information can get retrieved with logging. So remove it. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/53c700.c | 9 ++--- 1 file changed, 2 insertions(+), 7

[PATCH 16/23] scsi: remove last argument from print_opcode_name()

2014-09-30 Thread Hannes Reinecke
print_opcode_name() was only ever called with a '0' argument from LLDDs and ULDs which were _not_ supporting variable length CDBs, so the 'if' clause was never triggered. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 21 +++-- 1 file changed, 7

[PATCH 15/23] scsi: consolidate opcode lookup in scsi_opcode_sa_name()

2014-09-30 Thread Hannes Reinecke
Consolidate the CDB opcode lookup in scsi_opcode_sa_name(), so that we don't have to call several functions to figure out the CDB opcode string. Reviewed-by: Christoph Hellweg h...@lst.de Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 37

[PATCH 09/23] scsi: stop decoding if scsi_normalize_sense() fails

2014-09-30 Thread Hannes Reinecke
If scsi_normalize_sense() fails we couldn't decode the sense buffer, and the scsi_sense_hdr fields are invalid. For those cases we should rather dump the sense buffer and not try to decode invalid fields. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 34

[PATCH 17/23] scsi: Remove scsi_print_command when calling abort

2014-09-30 Thread Hannes Reinecke
Calling scsi_print_command should not be necessary during abort; if the information is required one should enable scsi logging. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/53c700.c| 4 +--- drivers/scsi/NCR5380.c | 5 ++--- drivers/scsi/arm/fas216.c| 10

[PATCH 04/23] scsi: introduce sdev_prefix_printk()

2014-09-30 Thread Hannes Reinecke
Like scmd_printk(), but the device name is passed in as a string. Can be used by eg ULDs which do not have access to the scsi_cmnd structure. Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/ch.c | 3 +-- drivers/scsi/sd.h

[PATCH 06/23] acornscsi: use scsi_print_command()

2014-09-30 Thread Hannes Reinecke
Update acornscsi to use scsi_print_command() instead of the underscore version. This will add correct device annotations in the resulting message. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/arm/acornscsi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 05/23] scsi: Use sdev as argument for sense code printing

2014-09-30 Thread Hannes Reinecke
We should be using the standard dev_printk() variants for sense code printing. Reviewed-by: Christoph Hellwig h...@infradead.org Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/53c700.c | 2 +- drivers/scsi/ch.c | 2 +- drivers/scsi/constants.c | 117

[PATCH 03/23] aha152x: Debug output update and whitespace cleanup

2014-09-30 Thread Hannes Reinecke
Remove all uncommented debugging code and move all printk() statements over to dev_printk(). And while we're at it we should be doing a whitespace cleanup, too. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/aha152x.c | 994 +++-- 1 file

[PATCH 10/23] scsi: do not decode sense extras

2014-09-30 Thread Hannes Reinecke
Currently we're only decoding sense extras for tape devices. And even there only for fixed format sense formats. As this is of rather limited use in the general case we should be stop trying to decode sense extras; the tape driver does its own decoding anyway. Reviewed-by: Christoph Hellwig

[PATCH 23/23] scsi_trace: add tracepoint for completion

2014-09-30 Thread Hannes Reinecke
A tracepoint should be inserted upon completion to make tracing equivalent to logging. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 1 + drivers/scsi/scsi_trace.c | 16 include/trace/events/scsi.h | 31 +++ 3 files

[PATCH 19/23] sd: Cleanup logging

2014-09-30 Thread Hannes Reinecke
Open-code scsi_print_result in sd.c, and cleanup logging to not print duplicate informations. With that we can remove scsi_show_result in constants.c Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 16 drivers/scsi/sd.c| 45

[PATCHv4 00/23] scsi logging update (the boring part)

2014-09-30 Thread Hannes Reinecke
Hi all, after the feedback from v3 I've decided to split off the printk changes to a second patchset, to be applied on top of this. So this patchset just contains some logging updates, code reshuffling and sanity fixes. Nothing major. Most of it has already been reviewed. Hannes Reinecke (23):

[PATCH 22/23] scsi: use shost argument in scsi_eh_prt_fail_stats

2014-09-30 Thread Hannes Reinecke
The EH statistics are per host, so we should be using shost_printk() here. Suggested-by: Robert Elliott elli...@hp.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_error.c

[PATCH 12/23] scsi: remove scsi_print_status()

2014-09-30 Thread Hannes Reinecke
Last caller is gone, so we can remove it. Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 35 --- include/scsi/scsi_dbg.h | 1 - 2 files changed, 36 deletions(-) diff --git

[PATCH 13/23] Implement scsi_opcode_sa_name

2014-09-30 Thread Hannes Reinecke
Implement a lookup array for SERVICE ACTION commands instead of hardcoding it in a large switch statement. Reviewed-by: Christoph Hellwig h...@infradead.org Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/constants.c | 131 +++ 1 file

Re: [PATCH] fcoe: extend ethtool to FC port speed mapping

2014-09-30 Thread Christoph Hellwig
On Thu, Sep 25, 2014 at 11:55:42AM -0700, Vasu Dev wrote: From: Chris Leech cle...@redhat.com add support for 20 Gbit and 40 Gbit links Signed-off-by: Chris Leech cle...@redhat.com Signed-off-by: Vasu Dev vasu@intel.com Thanks, applied. -- To unsubscribe from this list: send the line

Re: [PATCH] scsi_host: fix comment

2014-09-30 Thread Christoph Hellwig
Thanks, applied to the core-for-3.18 tree. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: I/O path cleanup

2014-09-30 Thread Bart Van Assche
On 09/08/14 17:13, Christoph Hellwig wrote: On Mon, Sep 08, 2014 at 09:22:40AM +0200, Bart Van Assche wrote: On 09/07/14 18:31, Christoph Hellwig wrote: This series cleans up a couple of lose ends I noticed during the scsi-mq work, but which weren't important enough to address during the last

Re: [PATCH 0/2] be2iscsi : Update to 10.4.114.0

2014-09-30 Thread Christoph Hellwig
Thanks, applied both patches to drivers-for-3.18. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: I/O path cleanup

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 03:31:25PM +0200, Bart Van Assche wrote: At least in the tests I ran myself these patches are working fine in combination with scsi-mq and the SRP initiator. The tree I have been testing with has commit ID ec8af1eb08f2 - this is the tree on top of v3.17-rc4. Thanks.

Re: [PATCH 0/2] iscsi patches for 3.18

2014-09-30 Thread Christoph Hellwig
On Mon, Sep 29, 2014 at 01:55:40PM -0500, micha...@cs.wisc.edu wrote: A couple patches made over the scsi-queue drivers-for-3.18 branch. They just fix a possible bug with be2iscsi that Dan reported and also export the iscsi port being used. Thanks, applied both patches to drivers-for-3.18. --

Re: [PATCH/RESEND V6 00/18] UFS: Power management support

2014-09-30 Thread Christoph Hellwig
I've had the series in a ufs-for-3.18 branch for a while, and the two issues pointed out by the buildbot were quickly fixed. Unless I get a loud complaint I will merge the entire series including the two core patches into drivers-for-3.18 tomorrow. -- To unsubscribe from this list: send the line

Re: [PATCH 03/23] aha152x: Debug output update and whitespace cleanup

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:32PM +0200, Hannes Reinecke wrote: Remove all uncommented debugging code and move all printk() statements over to dev_printk(). And while we're at it we should be doing a whitespace cleanup, too. Looks good, Reviewed-by: Christoph Hellwig h...@lst.de -- To

Re: [PATCH 06/23] acornscsi: use scsi_print_command()

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:35PM +0200, Hannes Reinecke wrote: Update acornscsi to use scsi_print_command() instead of the underscore version. This will add correct device annotations in the resulting message. Signed-off-by: Hannes Reinecke h...@suse.de Also includes a few scmd_printk

Re: [PATCH 07/23] fas216: Update logging messages

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:36PM +0200, Hannes Reinecke wrote: Update logging messages to use dev_printk() variants for correct device annotations. - printk( CDB: ); - __scsi_print_command(SCpnt-cmnd); + scsi_print_command(SCpnt); And a __scsi_print_command -

Re: [PATCH 08/23] 53c700: remove scsi_print_sense() usage

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:37PM +0200, Hannes Reinecke wrote: The 53c700 driver would be using scsi_print_sense() in a debug statement, which was never compiled in. Plus the same information can get retrieved with logging. So remove it. Signed-off-by: Hannes Reinecke h...@suse.de Looks

Re: [PATCH 09/23] scsi: stop decoding if scsi_normalize_sense() fails

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:38PM +0200, Hannes Reinecke wrote: If scsi_normalize_sense() fails we couldn't decode the sense buffer, and the scsi_sense_hdr fields are invalid. For those cases we should rather dump the sense buffer and not try to decode invalid fields. Signed-off-by: Hannes

Re: [PATCH 16/23] scsi: remove last argument from print_opcode_name()

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:45PM +0200, Hannes Reinecke wrote: print_opcode_name() was only ever called with a '0' argument from LLDDs and ULDs which were _not_ supporting variable length CDBs, so the 'if' clause was never triggered. Signed-off-by: Hannes Reinecke h...@suse.de Looks good,

Re: [PATCH 18/23] scsi: separate out scsi_(host|driver)byte_string()

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:47PM +0200, Hannes Reinecke wrote: Export functions for later use. Signed-off-by: Hannes Reinecke h...@suse.de Looks good, Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

[PATCH 2/2] scsi: add a CONFIG_SCSI_MQ_DEFAULT option

2014-09-30 Thread Christoph Hellwig
Add a Kconfig option to enable the blk-mq path for SCSI by default to ease testing and deployment in setups that know they benefit from blk-mq. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/Kconfig | 11 +++ drivers/scsi/scsi.c | 4 2 files changed, 15

[PATCH 1/2] sg: fix sparse __user annotation warning

2014-09-30 Thread Christoph Hellwig
blk_trace_setup takes a __user pointer, so use the local void __user * pointer instead of casting the argument to char * for it in the sg ioctl handler. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] scsi: add a CONFIG_SCSI_MQ_DEFAULT option

2014-09-30 Thread Christoph Hellwig
Add a Kconfig option to enable the blk-mq path for SCSI by default to ease testing and deployment in setups that know they benefit from blk-mq. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/Kconfig | 11 +++ drivers/scsi/scsi.c | 4 2 files changed, 15

Re: [PATCH 20/23] scsi: simplify scsi_log_(send|completion)

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:49PM +0200, Hannes Reinecke wrote: Simplify scsi_log_(send|completion) by externalizing scsi_mlreturn_string() and always print the command address. Signed-off-by: Hannes Reinecke h...@suse.de Looks, Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe

Re: [PATCH 21/23] scsi: fixup logging messages in scsi_error.c

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:50PM +0200, Hannes Reinecke wrote: Use the matching scope for logging messages to allow for better command tracing. Suggested-by: Robert Elliott elli...@hp.com Signed-off-by: Hannes Reinecke h...@suse.de Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [PATCH 22/23] scsi: use shost argument in scsi_eh_prt_fail_stats

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:51PM +0200, Hannes Reinecke wrote: The EH statistics are per host, so we should be using shost_printk() here. Suggested-by: Robert Elliott elli...@hp.com Signed-off-by: Hannes Reinecke h...@suse.de Looks good, Reviewed-by: Christoph Hellwig h...@lst.de -- To

Re: targetcli do not show iscsi

2014-09-30 Thread Andy Grover
On 09/30/2014 02:45 AM, Jerome Martin wrote: On 09/30/2014 11:41 AM, Luigi Tarenga wrote: On 09/30/2014 11:28 AM, Jerome Martin wrote: Luigi, Out of curiosity, does it work as expected with the stock fedora packaged kernel ? Best, -- Jerome didn't test that configuration and since I

Re: [PATCH 23/23] scsi_trace: add tracepoint for completion

2014-09-30 Thread Christoph Hellwig
On Tue, Sep 30, 2014 at 01:50:52PM +0200, Hannes Reinecke wrote: A tracepoint should be inserted upon completion to make tracing equivalent to logging. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 1 + drivers/scsi/scsi_trace.c | 16

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-30 Thread Luis R. Rodriguez
On Tue, Sep 30, 2014 at 11:22:14AM +0200, Tom Gundersen wrote: On Tue, Sep 30, 2014 at 4:27 AM, Luis R. Rodriguez mcg...@suse.com wrote: On Sun, Sep 28, 2014 at 07:07:24PM +0200, Tom Gundersen wrote: On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: From:

Re: targetcli do not show iscsi

2014-09-30 Thread Jerome Martin
On 09/30/2014 05:21 PM, Andy Grover wrote: iscsi is not a supported fabric on rhel/centos 6. Only FCoE uses LIO. scsi-target-utils (tgt) is the supported iscsi target on rhel6. rhel7 uses LIO for both, as does Fedora. Ha, that explains it then. Thanks Andy. -- To unsubscribe from this list:

Re: targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
On 09/30/2014 05:21 PM, Andy Grover wrote: On 09/30/2014 02:45 AM, Jerome Martin wrote: On 09/30/2014 11:41 AM, Luigi Tarenga wrote: On 09/30/2014 11:28 AM, Jerome Martin wrote: Luigi, Out of curiosity, does it work as expected with the stock fedora packaged kernel ? Best, -- Jerome

Re: [PATCH] libfs: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2014-09-30 Thread Christoph Hellwig
Thanks, applied to drivers-for-3.18 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
On 09/30/2014 05:35 PM, Luigi Tarenga wrote: On 09/30/2014 05:21 PM, Andy Grover wrote: On 09/30/2014 02:45 AM, Jerome Martin wrote: On 09/30/2014 11:41 AM, Luigi Tarenga wrote: On 09/30/2014 11:28 AM, Jerome Martin wrote: Luigi, Out of curiosity, does it work as expected with the

Re: [PATCH 1/2] sg: fix sparse __user annotation warning

2014-09-30 Thread Douglas Gilbert
On 14-09-30 11:20 AM, Christoph Hellwig wrote: blk_trace_setup takes a __user pointer, so use the local void __user * pointer instead of casting the argument to char * for it in the sg ioctl handler. Signed-off-by: Christoph Hellwig h...@lst.de Acked-by: Douglas Gilbert dgilb...@interlog.com

Re: [PATCH 27/38] Rearrange buffer formatting in printk()

2014-09-30 Thread Petr Mladek
On Mon 29-09-14 13:58:56, Hannes Reinecke wrote: Move buffer formatting to the start of the function as it doesn't require to be done under any locks. No functional change, required by the next patch. Cc: Steven Rostedt rost...@goodmis.org Cc: LKML linux-ker...@vger.kernel.org printk stuff

Re: [PATCH 28/38] Externalize string buffer for printk

2014-09-30 Thread Petr Mladek
On Mon 29-09-14 13:58:57, Hannes Reinecke wrote: This patch splits off the actual logging from vprintk_emit() into printk_emit_string(), with vprintk_emit() just being a simple wrapper for formatting the message into a static buffer. With that the caller can pass in a local buffer for

Re: targetcli do not show iscsi

2014-09-30 Thread Luigi Tarenga
iscsi is not a supported fabric on rhel/centos 6. Only FCoE uses LIO. scsi-target-utils (tgt) is the supported iscsi target on rhel6. rhel7 uses LIO for both, as does Fedora. Regards -- Andy Hi Andy, I see LIO is a technology preview on rhel 6 but I'm not looking for official support,

Re: targetcli do not show iscsi

2014-09-30 Thread Jerome Martin
On 09/30/2014 06:49 PM, Luigi Tarenga wrote: Thanks Andy for your hint and excuse me if I seemed stubborn :) Thank to Martin too for his support! The first name's Jerome :-) Just a quick note, as you are apparently doing some RD, may I suggest that you test v3.x instead ? I can use all

Re: targetcli do not show iscsi

2014-09-30 Thread Jerome Martin
On 09/30/2014 07:01 PM, Luigi Tarenga wrote: On 09/30/2014 06:52 PM, Jerome Martin wrote: oops... ok Jerome I'll be happy to help doing some tests. Just forgive me, I'm very new to LIO: what do you mean for v3.x? I mean targetcli version 3.x or the targetcli branch from Datera? OK, as you

Re: [dm-devel] [PATCH 1/1] multipath-tools: Change path checker for IBM IPR devices

2014-09-30 Thread wenxiong
Quoting Christoph Hellwig h...@infradead.org: On Thu, Sep 25, 2014 at 11:47:42AM -0500, Brian King wrote: The issue we've run into started when this patch started making its way into distros:

Re: [PATCH 23/23] scsi_trace: add tracepoint for completion

2014-09-30 Thread Hannes Reinecke
On 09/30/2014 05:21 PM, Christoph Hellwig wrote: On Tue, Sep 30, 2014 at 01:50:52PM +0200, Hannes Reinecke wrote: A tracepoint should be inserted upon completion to make tracing equivalent to logging. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 1 +

Re: [PATCH 27/38] Rearrange buffer formatting in printk()

2014-09-30 Thread Petr Mladek
On Tue 30-09-14 18:16:20, Petr Mladek wrote: On Mon 29-09-14 13:58:56, Hannes Reinecke wrote: Move buffer formatting to the start of the function as it doesn't require to be done under any locks. No functional change, required by the next patch. Cc: Steven Rostedt rost...@goodmis.org

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-30 Thread Pavel Machek
On Mon 2014-09-22 13:23:54, Dmitry Torokhov wrote: On Monday, September 22, 2014 09:49:06 PM Pavel Machek wrote: On Thu 2014-09-11 13:23:54, Dmitry Torokhov wrote: On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley wrote: Yes, but we mostly do this anyway. SCSI for instance

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-30 Thread Dmitry Torokhov
On Tue, Sep 30, 2014 at 11:06:34PM +0200, Pavel Machek wrote: On Mon 2014-09-22 13:23:54, Dmitry Torokhov wrote: On Monday, September 22, 2014 09:49:06 PM Pavel Machek wrote: On Thu 2014-09-11 13:23:54, Dmitry Torokhov wrote: On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley

Re: [PATCH V6 02/18] scsi: sysfs: don't add scsi_device if its already added

2014-09-30 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: If LLD has added scsi device (by calling scsi_add_device) before scheduling async scsi_scan_host then scsi_finish_async_scan() will end up calling scsi_sysfs_add_sdev for scsi device which was already added by LLD. This patch fixes

Re: [PATCH] scsi: add a CONFIG_SCSI_MQ_DEFAULT option

2014-09-30 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph Add a Kconfig option to enable the blk-mq path for SCSI by Christoph default to ease testing and deployment in setups that know Christoph they benefit from blk-mq. Looks OK to me. Reviewed-by: Martin K. Petersen

RE: [PATCH] scsi: add a CONFIG_SCSI_MQ_DEFAULT option

2014-09-30 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Christoph Hellwig ... Add a Kconfig option to enable the blk-mq path for SCSI by default to ease testing and deployment in setups that know they benefit from blk-mq.

RE: [PATCH scsi] cxgb4i : Avoid holding mutex in interrupt context

2014-09-30 Thread Anish Bhatt
Little late, but I was hoping this would be pushed as part of fixes to 3.17. Is it too late for that ? -Anish From: Christoph Hellwig [h...@infradead.org] Sent: Monday, September 22, 2014 7:45 AM To: Anish Bhatt Cc: linux-scsi@vger.kernel.org;