On 10/02/2014 08:53 PM, Elliott, Robert (Server Storage) wrote:
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Wednesday, 01 October, 2014 1:23 AM
To: James Bottomley
Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server
Storage); Hannes
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
--- linux.orig/drivers/scsi/NCR5380.h 2014-10-02 16:55:55.0 +1000
+++ linux/drivers/scsi/NCR5380.h2014-10-02 16:55:57.0 +1000
@@ -224,14 +224,11 @@
#define DISCONNECT_LONG2
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
Oak scsi doesn't use any IRQ, but it sets irq = IRQ_NONE rather than
SCSI_IRQ_NONE. Problem is, the core NCR5380 driver expects SCSI_IRQ_NONE
if it is to issue IDENTIFY commands that prevent target disconnection.
On Thu, Oct 2, 2014 at 10:06 PM, Luis R. Rodriguez mcg...@suse.com wrote:
On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote:
Making kmod a special case is of course possible. However, as long as
there is no fundamental reason why kmod should get this special
treatment, this just
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
+static void prepare_info(struct Scsi_Host *instance)
+{
+ struct NCR5380_hostdata *hostdata = shost_priv(instance);
+
+ snprintf(hostdata-info, sizeof(hostdata-info),
[...]
+);
+
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
Testing shows that the Domex 3191D card never asserts its IRQ. Hence it is
non-functional with Linux (worse, the EH bugs in the core driver are fatal but
that's a problem for another patch). Perhaps the DT-536 chip
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
Allow mac_scsi to be built as a module. Replace the old validation of
__setup options with code that validates both module and __setup options.
--- linux.orig/drivers/scsi/mac_scsi.c 2014-10-02 16:56:17.0
On Thu, Oct 02, 2014 at 09:25:50AM -0400, James Bottomley wrote:
OK, so 3.17 should be on sunday giving three days or so to sort this
out. If you're happy with blk-mq being disabled so the bug never
triggers unless the user activates it, doing nothing is my preferred
outcome ... but that also
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
Convert mac_scsi to platform device and eliminate scsi_register().
Platform resources for chip registers now follow the documentation. This
should fix issues with the Mac IIci (and possibly other models too).
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
--- linux.orig/arch/m68k/atari/stdma.c 2014-10-02 16:55:28.0 +1000
+++ linux/arch/m68k/atari/stdma.c 2014-10-02 16:56:20.0 +1000
-int stdma_others_waiting(void)
+int
Hi,
On 10/03/2014 10:47 AM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 09:25:50AM -0400, James Bottomley wrote:
OK, so 3.17 should be on sunday giving three days or so to sort this
out. If you're happy with blk-mq being disabled so the bug never
triggers unless the user activates it,
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
Convert atari_scsi to platform device and eliminate scsi_register().
Validate __setup options later on so that module options are checked as well.
Remove the comment about the scsi mid-layer disabling the host irq as
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14
With uas over usb-3 the tags inside the uas iu-s must match the usb-3 stream
ids, and those go from 1 - qdepth.
Before blk-mq calling scsi_activate_tcq(sdev, qdepth) guaranteed that we would
only get cmnd-request-tag from 0 - (qdepth - 1), and we used those as
uas-tags / stream-ids.
With blk-mq
On Fri, 3 Oct 2014, Geert Uytterhoeven wrote:
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
--- linux.orig/drivers/scsi/NCR5380.h 2014-10-02 16:55:55.0 +1000
+++ linux/drivers/scsi/NCR5380.h2014-10-02 16:55:57.0 +1000
@@ -224,14
On Fri, 3 Oct 2014, Geert Uytterhoeven wrote:
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au
wrote:
Oak scsi doesn't use any IRQ, but it sets irq = IRQ_NONE rather than
SCSI_IRQ_NONE. Problem is, the core NCR5380 driver expects SCSI_IRQ_NONE
if it is to issue
On Fri, 3 Oct 2014, Geert Uytterhoeven wrote:
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au wrote:
Allow mac_scsi to be built as a module. Replace the old validation of
__setup options with code that validates both module and __setup options.
---
On Fri, Oct 3, 2014 at 12:49 PM, Finn Thain fth...@telegraphics.com.au wrote:
On Fri, 3 Oct 2014, Geert Uytterhoeven wrote:
On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain fth...@telegraphics.com.au
wrote:
Allow mac_scsi to be built as a module. Replace the old validation of
__setup options
On 10/02/14 18:55, Jens Axboe wrote:
Sure, that's fine as well, but the function needs a more descriptive
name. I try to think of it like I have never looked at the code and need
to write a driver, it's a lot easier if the functions are named
appropriately. Seeing blk_mq_rq_tag() and even with
On 2014-10-03 07:01, Bart Van Assche wrote:
On 10/02/14 18:55, Jens Axboe wrote:
Sure, that's fine as well, but the function needs a more descriptive
name. I try to think of it like I have never looked at the code and need
to write a driver, it's a lot easier if the functions are named
On 14-10-02 09:43 PM, Finn Thain wrote:
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Acked-by: Douglas Gilbert dgilb...@interlog.com
---
drivers/scsi/scsi_debug.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/scsi/scsi_debug.c
2014-09-25 21:32 GMT+09:00 Dolev Raviv dra...@codeaurora.org:
+static int ufshcd_scsi_add_wlus(struct ufs_hba *hba)
+{
+ int ret = 0;
+
+ hba-sdev_ufs_device = __scsi_add_device(hba-host, 0, 0,
+ ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_UFS_DEVICE_WLUN),
NULL);
+
2014-09-25 21:32 GMT+09:00 Dolev Raviv dra...@codeaurora.org:
+int ufshcd_change_power_mode(struct ufs_hba *hba,
+struct ufs_pa_layer_attr *pwr_mode)
+{
+ int ret;
+
+ /* if already configured to the requested pwr_mode */
+ if (pwr_mode-gear_rx
On Thu, 2014-10-02 at 18:37 +, Elliott, Robert (Server Storage)
wrote:
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
...
diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
index 4c3ab83..c01dc89 100644
--- a/drivers/scsi/sd.h
+++ b/drivers/scsi/sd.h
@@
I could fix this issue by putting scsi_device_put() just after each
__scsi_add_device() call. I'll prepare a patch if I haven't missed something.
Thanks Akinobu for fixing it. We were always compiling the driver statically in
kernel so didn't notice this. Yes, I would be happy to ACK your
On Sat, Oct 04, 2014 at 01:16:16AM +0900, Akinobu Mita wrote:
These __scsi_add_device() calls for W-LUs increase the module reference
count of ufshcd.ko by three. But no one calls scsi_device_put() for
these W-LUs, so it is impossible to unload ufshcd.ko.
There are scsi_remove_device()
If the UFS Power management level 5 is chosen, the UIC link is down during
suspend. And the power mode should be configured during resume again.
Unfortunately, it will not be configured because the above condition hits
unintentionally.
Yes, it seems a bug.
I would like to propose a fix
On Fri, Oct 3, 2014 at 1:23 AM, Tom Gundersen t...@jklm.no wrote:
On Thu, Oct 2, 2014 at 10:06 PM, Luis R. Rodriguez mcg...@suse.com wrote:
On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote:
Making kmod a special case is of course possible. However, as long as
there is no
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Christoph Hellwig
Sent: Thursday, 25 September, 2014 7:13 AM
To: Douglas Gilbert
Cc: SCSI development list; linux-kernel; James Bottomley; Christoph Hellwig;
Milan
-Original Message-
From: Christoph Hellwig [mailto:h...@infradead.org]
Sent: Friday, 26 September, 2014 3:14 AM
To: Dolev Raviv
Cc: james.bottom...@hansenpartnership.com; h...@infradead.org; linux-
s...@vger.kernel.org; linux-scsi-ow...@vger.kernel.org; linux-arm-
On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote:
+ queue_work(system_unbound_wq, priv-attach_work-work);
Tejun,
based on my testing so far using system_highpri_wq instead of
system_unbound_wq yields close to par / better boot times
than synchronous probe support for all
On Fri, Oct 03, 2014 at 10:11:26PM +0200, Luis R. Rodriguez wrote:
On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote:
+ queue_work(system_unbound_wq, priv-attach_work-work);
Tejun,
based on my testing so far using system_highpri_wq instead of
system_unbound_wq yields
From: Luis R. Rodriguez mcg...@suse.com
At times we may wish to express the desire to prefer to have
a device driver probe asynchronously by default. We cannot
simply enable all device drivers to do this without vetting
that userspace is prepared for this though given that some
old userspace is
From: Luis R. Rodriguez mcg...@suse.com
Some init systems may wish to express the desire to have
device drivers run their device driver's bus probe() run
asynchronously. This implements support for this and
allows userspace to request async probe as a preference
through a generic shared device
On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
With uas over usb-3 the tags inside the uas iu-s must match the usb-3 stream
ids, and those go from 1 - qdepth.
Before blk-mq calling scsi_activate_tcq(sdev, qdepth) guaranteed that we would
only get cmnd-request-tag from 0 -
From: Nicholas Bellinger n...@linux-iscsi.org
This patch fixes a bug in handling of SPC-3 PR Activate Persistence
across Target Power Loss (APTPL) logic where re-creation of state for
MappedLUNs from dynamically generated NodeACLs did not occur during
I_T Nexus establishment.
It adds the missing
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a force_pr_aptpl device attribute used to force SPC-3 PR
Activate Persistence across Target Power Loss (APTPL) operation. This
makes PR metadata write-out occur during state change regardless if new
PERSISTENT_RESERVE_OUT CDBs have
37 matches
Mail list logo