Re: [GIT PULL] osd: Boaz Harrosh - change of email

2014-10-21 Thread J. Bruce Fields
On Tue, Oct 21, 2014 at 11:04:12PM +0200, James Bottomley wrote: > On Tue, 2014-10-21 at 17:05 +0300, Boaz Harrosh wrote: > > Hi Sir Linus > > > > A small administrative stuff, was on vacation and the old email bounced on > > me. > > I was hoping to still make the 3 weeks merge window, but it was

Re: virtio_blk - kernel BUG at drivers/virtio/virtio_ring.c:160!

2014-10-21 Thread Ming Lei
On Wed, Oct 22, 2014 at 4:05 AM, Jens Axboe wrote: > On 10/17/2014 07:27 AM, Christoph Hellwig wrote: >> On Thu, Oct 16, 2014 at 11:17:39AM -0400, Brian Foster wrote: >>> Hi all, >>> >>> Hopefully this is the right list for this report... >>> >>> I hit the following kernel bug reliably by running

[PATCH] ips: Remove unnecessary METHOD_TRACE

2014-10-21 Thread Joe Perches
METHOD_TRACE is a poorman's function tracer. Use the actual function tracer instead (ftrace) Signed-off-by: Joe Perches --- drivers/scsi/ips.c | 177 - 1 file changed, 177 deletions(-) diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index

Re: [PATCH] vhost-scsi: Take configfs group dependency during VHOST_SCSI_SET_ENDPOINT

2014-10-21 Thread Michael S. Tsirkin
On Tue, Oct 21, 2014 at 12:05:31PM -0700, Nicholas A. Bellinger wrote: > Hey Paolo, > > On Thu, 2014-10-09 at 12:49 +0200, Paolo Bonzini wrote: > > Il 09/10/2014 10:49, Paolo Bonzini ha scritto: > > > > > > It does not happen if you close QEMU with SIGTERM, ctrl-c, or with the > > > "quit" comman

Re: [GIT PULL] osd: Boaz Harrosh - change of email

2014-10-21 Thread James Bottomley
On Tue, 2014-10-21 at 17:05 +0300, Boaz Harrosh wrote: > Hi Sir Linus > > A small administrative stuff, was on vacation and the old email bounced on me. > I was hoping to still make the 3 weeks merge window, but it was 2 weeks at the > end. > Your call if to make this wait for next window. Needles

Re: virtio_blk - kernel BUG at drivers/virtio/virtio_ring.c:160!

2014-10-21 Thread Jens Axboe
On 10/17/2014 07:27 AM, Christoph Hellwig wrote: > On Thu, Oct 16, 2014 at 11:17:39AM -0400, Brian Foster wrote: >> Hi all, >> >> Hopefully this is the right list for this report... >> >> I hit the following kernel bug reliably by running xfstests test >> generic/234 against XFS using 10GB LVM test

Re: [PATCH] block: remove artifical max_hw_sectors cap

2014-10-21 Thread Jens Axboe
On 10/17/2014 07:12 AM, Christoph Hellwig wrote: > On Wed, Oct 01, 2014 at 02:12:58PM -0700, Christoph Hellwig wrote: >> On Wed, Oct 01, 2014 at 06:59:34PM +, Elliott, Robert (Server Storage) >> wrote: >>> One supporting example: A low limit interferes with creation of >>> full stripe writes f

Re: [PATCH scsi] libcxgbi : support ipv6 address host_param

2014-10-21 Thread Mike Christie
On 10/16/2014 05:59 PM, Anish Bhatt wrote: > libcxgbi was always returning an ipv4 address for ISCSI_HOST_PARAM_IPADDRESS, > return appropriate address based on address family > > Signed-off-by: Anish Bhatt > Signed-off-by: Karen Xie > --- > drivers/scsi/cxgbi/libcxgbi.c | 42 ++

Re: [PATCH] vhost-scsi: Take configfs group dependency during VHOST_SCSI_SET_ENDPOINT

2014-10-21 Thread Nicholas A. Bellinger
Hey Paolo, On Thu, 2014-10-09 at 12:49 +0200, Paolo Bonzini wrote: > Il 09/10/2014 10:49, Paolo Bonzini ha scritto: > > > > It does not happen if you close QEMU with SIGTERM, ctrl-c, or with the > > "quit" command, because no attempt is done to bring down the VM data > > structures (or free memor

RE: [PATCH 1/1] ufs: scsi: fix sparse errors in ufshcd_system_suspend

2014-10-21 Thread Subhash Jadavani
> Are you going to prepare a set of fixups for 3.18, or should I try to cram them together? I supect you'd do a much better job than I could. Agreed. There are 3 patches already posted for sparse warning fixes but then there were 5 new reports of sparse warning. So we (Dolev Raviv and myself) wou

RE: [PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

2014-10-21 Thread KY Srinivasan
> -Original Message- > From: Jeff Leung [mailto:jle...@v10networks.ca] > Sent: Monday, October 20, 2014 10:39 PM > To: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: KY Srinivasan; james.bottom...@hansenpartnership.com; Jeff Leung > Subject:

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-21 Thread KY Srinivasan
> -Original Message- > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > Sent: Monday, October 20, 2014 9:46 PM > To: KY Srinivasan > Cc: Jeff Leung; James Bottomley; Christoph Hellwig; Haiyang Zhang; Christoph > Hellwig; Hannes Reinecke; linux-scsi@vger.kernel.org; linux- > ker...@vger.

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

2014-10-21 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Elliott, Robert (Server Storage) ... > With scsi_logging_level --set --error=5, there are: > * 10 "FAILED Result" prints > * the first has no CDB > * at the end, the

Re: [GIT PULL] target updates for v3.18-rc2

2014-10-21 Thread Nicholas A. Bellinger
On Tue, 2014-10-21 at 12:24 +0300, Sagi Grimberg wrote: > On 10/21/2014 2:39 AM, Nicholas A. Bellinger wrote: > > Hi Linus, > > > > Here are the target updates for v3.18-rc2 code. These where originally > > destined for -rc1, but due to the combination of travel last week for > > KVM Forum and my

RE: [PATCH 27/27] scsi: ratelimit I/O error messages

2014-10-21 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Monday, 20 October, 2014 1:53 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; Elliott, Robert (Server > Storage); Hannes Reinecke > Subject: [PATCH 27/27] scsi: ratelimit I/O error mes

[GIT PULL] osd: Boaz Harrosh - change of email

2014-10-21 Thread Boaz Harrosh
Hi Sir Linus A small administrative stuff, was on vacation and the old email bounced on me. I was hoping to still make the 3 weeks merge window, but it was 2 weeks at the end. Your call if to make this wait for next window. Needless to say that it is ZERO risk, just change of email. Based on comm

Re: [PATCH 1/1] ufs: scsi: fix sparse errors in ufshcd_system_suspend

2014-10-21 Thread Christoph Hellwig
On Sat, Oct 11, 2014 at 04:06:29AM -0700, Christoph Hellwig wrote: > On Sun, Oct 05, 2014 at 03:44:16PM -0700, Subhash Jadavani wrote: > > Looks good, Reviewed-by: Subhash Jadavani > > I'm getting a bit lost with all the UFS fixes, can you prepared a series > with all the fixups required for 3.18

Re: [PATCH] Fix comment typo in Scsi_Host struct definition

2014-10-21 Thread Christoph Hellwig
On Thu, Oct 09, 2014 at 12:40:07PM +0100, Mark Knibbs wrote: > Hi, > > The comment for the max_channel, max_id and max_lun parameters > refers to the first two, but actually means the last two. > > Signed-off-by: Mark Knibbs I just noticed that I have already applied an equal patch from Sebasti

Re: [PATCHv7 00/27] scsi logging update (the boring part)

2014-10-21 Thread Christoph Hellwig
On Tue, Oct 21, 2014 at 01:02:48PM +0200, Hannes Reinecke wrote: > > What tree is this against? This doesn't seem to touch the ufs driver, > > which in 3.18-rc has grown calls to some of the functions you remove. > > > Hmm. I _thought_ to have it done against core-for-3.18; but I'll > double chec

Re: [dm-devel] [PATCH 1/1] multipath-tools: Change path checker for IBM IPR devices

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 06, 2014 at 05:50:32PM -0400, wenxi...@linux.vnet.ibm.com wrote: > Sorry it took some time since we need to re-config the systems for this test. > > With Christoph's new patch only, still saw the failure. > With Christoph's new patch + Brian's patch, works fine, didn't see the > failur

Re: [PATCHv7 00/27] scsi logging update (the boring part)

2014-10-21 Thread Hannes Reinecke
On 10/21/2014 12:55 PM, Christoph Hellwig wrote: > On Mon, Oct 20, 2014 at 08:52:03AM +0200, Hannes Reinecke wrote: >> here is now the seventh iteration of my scsi logging update. >> With this I've included another patch for ratelimiting >> I/O error messages, which resolves the outstanding issue >

Re: [PATCH 1/2] ipr: Convert to generic DMA API

2014-10-21 Thread Christoph Hellwig
Wendy, Brian, can you give me an ACK for this series? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv7 00/27] scsi logging update (the boring part)

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 08:52:03AM +0200, Hannes Reinecke wrote: > here is now the seventh iteration of my scsi logging update. > With this I've included another patch for ratelimiting > I/O error messages, which resolves the outstanding issue > noted by Robert Elliot. What tree is this against?

Re: [GIT PULL] target updates for v3.18-rc2

2014-10-21 Thread Sagi Grimberg
On 10/21/2014 2:39 AM, Nicholas A. Bellinger wrote: Hi Linus, Here are the target updates for v3.18-rc2 code. These where originally destined for -rc1, but due to the combination of travel last week for KVM Forum and my mistake of taking the three week merge window literally, the pull request s

Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-21 Thread Sagi Grimberg
On 10/7/2014 4:07 PM, Bart Van Assche wrote: Improve performance by using multiple RDMA/RC channels per SCSI host for communication with an SRP target. About the implementation: - Introduce a loop over all channels in the code that uses target->ch. - Set the SRP_MULTICHAN_MULTI flag during log

Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-21 Thread Sagi Grimberg
On 10/20/2014 3:56 PM, Bart Van Assche wrote: On 10/19/14 19:36, Sagi Grimberg wrote: On 10/7/2014 4:07 PM, Bart Van Assche wrote: * comp_vector, a number in the range 0..n-1 specifying the - MSI-X completion vector. Some HCA's allocate multiple (n) - MSI-X vectors p

Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-21 Thread Sagi Grimberg
On 10/21/2014 11:49 AM, Christoph Hellwig wrote: On Mon, Oct 20, 2014 at 02:01:25PM +0200, Bart Van Assche wrote: On 10/19/14 18:12, Sagi Grimberg wrote: On 10/7/2014 4:04 PM, Bart Van Assche wrote: -req = blk_queue_find_tag(sdev->request_queue, tag); +req = blk_queue_find_

Re: EH action after scsi_remove_host, was: Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 03:53:38PM +0200, Bart Van Assche wrote: > The above assignment statement has been reported to fix a kernel oops that > could be triggered by cable pulling. Regarding fixing the root cause: some > time ago I had posted a patch series that makes scsi_remove_host() wait > unti

Re: [PATCH v2 07/12] IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanning

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 02:15:07PM +0200, Bart Van Assche wrote: > How about renaming this function into shost_sdev_count() and moving its > declaration to and its implementation to > drivers/scsi/scsi_lib.c ? I'd prefer to defer this until we have an actual need for it elsewhere. -- To unsubscr

Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 02:01:25PM +0200, Bart Van Assche wrote: > On 10/19/14 18:12, Sagi Grimberg wrote: > >On 10/7/2014 4:04 PM, Bart Van Assche wrote: > >>-req = blk_queue_find_tag(sdev->request_queue, tag); > >>+req = blk_queue_find_tag(sdev->request_queue, tag); > > > >Why

Re: [PATCH v2 11/12] IB/srp: Eliminate free_reqs list

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 01:47:53PM +0200, Bart Van Assche wrote: > The only reason why patches 10/12 and 11/12 are separate patches > is to reduce the size of individual patches and hence to make it > easier to review these patches. If everyone agrees I'm fine with > folding patch 11/12 into patch

Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 01:57:21PM +0200, Bart Van Assche wrote: > That pr_err() statement was convenient while debugging the multiqueue code > in the SRP initiator driver but can be left out. Would you agree with > leaving the above three lines of debug code out instead of adding an > additional a