Re: [PATCH v3 0/4] scsi: ufs ums-* esp_scsi: fix module reference counting

2015-01-12 Thread Christoph Hellwig
On Sun, Jan 11, 2015 at 10:50:02PM +0900, Akinobu Mita wrote: While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD

Re: [PATCH] scsi: Allow retry on UNIT_ATTENTION media changed if not CDROM drive

2015-01-12 Thread Christoph Hellwig
On Thu, Jan 08, 2015 at 05:33:53PM -0500, Al Cooper wrote: Previous commit dfcf7775815504d13a1d273073810058caf84b9d added a workaround for CD-ROM drives that were out of spec. This is causing scsi_check_sense() to return an error instead of NEEDS_RETRY on some USB thumb drives that return

Re: [PATCH v3 4/4] scsi: esp_scsi: adjust module reference for scsi host

2015-01-12 Thread Hannes Reinecke
On 01/11/2015 02:50 PM, Akinobu Mita wrote: While accessing a scsi device on host adapter supported by sub driver for the ESP chip (mac_esp, am53c974, sun_esp, jazz_esp, sun3x_esp), the module reference count is not incremented. Because these drivers allocate scsi hosts with scsi_esp_template

Re: [PATCH v3 1/4] scsi: add ability to adjust module reference for scsi host

2015-01-12 Thread Hannes Reinecke
On 01/11/2015 02:50 PM, Akinobu Mita wrote: While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-12 Thread Bart Van Assche
On 01/11/15 10:40, Sagi Grimberg wrote: I would say there is no need for specific coordination from iSCSI PoV. This is exactly what flow steering is designed for. As I see it, in order to get the TX/RX to match rings, the user can attach 5-tuple rules (using standard ethtool) to steer packets

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

2015-01-12 Thread Hannes Reinecke
On 01/12/2015 02:12 PM, Ewan Milne wrote: On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs, and it doesn't display any additional information. And as we know have block-layer assigned tags we can use them to

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

2015-01-12 Thread Ewan Milne
On Mon, 2015-01-12 at 14:29 +0100, Hannes Reinecke wrote: On 01/12/2015 02:12 PM, Ewan Milne wrote: On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs, and it doesn't display any additional information. And

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

2015-01-12 Thread Ewan Milne
On Mon, 2015-01-12 at 09:57 -0500, Ewan Milne wrote: On Mon, 2015-01-12 at 14:29 +0100, Hannes Reinecke wrote: On 01/12/2015 02:12 PM, Ewan Milne wrote: On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs,

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

2015-01-12 Thread Ewan Milne
On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs, and it doesn't display any additional information. And as we know have block-layer assigned tags we can use them to differentiate the messages. So remove any

[PATCH] uas: Add no-report-opcodes quirk for Simpletech devices with id 4971:8017

2015-01-12 Thread Hans de Goede
Like some other uas devices these devices hang when a report-opcodes scsi command is send to them. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1124119 Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/unusual_uas.h | 7 +++ 1

[PATCH] [SCSI] mpt2sas, mpt3sas: fix sparse warings restricted __le16 degrades to integer

2015-01-12 Thread Sreekanth Reddy
Fixed sparse warings 'restricted __le16 degrades to integer' generated from below titled patch [PATCH v2 02/22] [SCSI] mpt2sas, mpt3sas: Added support to log message when Temperature Threshold exceeds for any Sensor Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com ---

Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning

2015-01-12 Thread Alan Stern
On Thu, 8 Jan 2015, Christoph Hellwig wrote: On Wed, Jan 07, 2015 at 02:03:22PM +0100, Bart Van Assche wrote: Since kernel v3.19-rc1 module_refcount() returns 1 instead of 0 when called from inside module_exit(). This breaks the module_refcount() test in scsi_device_put() and hence causes

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-12 Thread Mike Christie
On 01/11/2015 03:40 AM, Sagi Grimberg wrote: On 1/9/2015 10:19 PM, Mike Christie wrote: On 01/09/2015 12:28 PM, Hannes Reinecke wrote: On 01/09/2015 07:00 PM, Michael Christie wrote: On Jan 8, 2015, at 11:03 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Thu, 2015-01-08 at 15:22

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-12 Thread Mike Christie
On 01/11/2015 03:23 AM, Sagi Grimberg wrote: On 1/9/2015 8:00 PM, Michael Christie wrote: SNIP Session wide command sequence number synchronization isn't something to be removed as part of the MQ work. It's a iSCSI/iSER protocol requirement. That is, the expected + maximum sequence

Re: [PATCH net-next 0/2] All Chelsio drivers : Cleanup CPL messages macros

2015-01-12 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Thu, 8 Jan 2015 21:38:14 -0800 This patch series cleans up all register defines/MACROS defined in t4_msg.h and affected files as part of the continuing cleanup effort The patches series is created against 'net-next' tree and includes patches to

RE: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

2015-01-12 Thread Minh Duc Tran
From: Minh Duc Tran Sent: Sunday, November 09, 2014 10:52 PM To: 'linux-scsi@vger.kernel.org' Cc: Mike Christie (micha...@cs.wisc.edu); Jayamohan Kallickal Subject: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag From: Minh Tran minhduc.t...@emulex.com We are starting to

[PATCH 2/2] MAINTAINERS: ibmvfc driver maintainer change

2015-01-12 Thread Tyrel Datwyler
Change maintainer of ibmvfc driver to Tyrel Datwyler. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

[PATCH 1/2] MAINTAINERS: ibmvscsi driver maintainer change

2015-01-12 Thread Tyrel Datwyler
Change maintainer of ibmvscsi driver to Tyrel Datwyler. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

[PATCH] st: implement sysfs based tape statistics v2

2015-01-12 Thread Seymour, Shane M
Some small changes since the last version - this version removes two files from sysfs compared to the last version (read and write block counts since they're derived from the byte counts they can be calculated in user space) but that's the only change. This version has been rebased to

RE: [PATCH 02/10] megaraid_sas: add missing __iomem annotations

2015-01-12 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Saturday, January 10, 2015 10:41 PM To: sumit.sax...@avagotech.com; kashyap.de...@avagotech.com Cc: martin.peter...@oracle.com; linux-scsi@vger.kernel.org Subject: [PATCH 02/10] megaraid_sas: add missing __iomem

RE: [PATCH 03/10] megaraid_sas: add endianess annotations

2015-01-12 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Saturday, January 10, 2015 10:41 PM To: sumit.sax...@avagotech.com; kashyap.de...@avagotech.com Cc: martin.peter...@oracle.com; linux-scsi@vger.kernel.org Subject: [PATCH 03/10] megaraid_sas: add endianess annotations

RE: [PATCH 01/10] megaraid_sas: megasas_complete_outstanding_ioctls() can be static

2015-01-12 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Saturday, January 10, 2015 10:41 PM To: sumit.sax...@avagotech.com; kashyap.de...@avagotech.com Cc: martin.peter...@oracle.com; linux-scsi@vger.kernel.org; kbuild test robot Subject: [PATCH 01/10] megaraid_sas:

RE: [PATCH 05/10] megaraid_sas: move endianess conversion into caller of megasas_get_seq_num

2015-01-12 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Saturday, January 10, 2015 10:41 PM To: sumit.sax...@avagotech.com; kashyap.de...@avagotech.com Cc: martin.peter...@oracle.com; linux-scsi@vger.kernel.org Subject: [PATCH 05/10] megaraid_sas: move endianess conversion

RE: [PATCH 04/10] megaraid_sas: add endianess conversions for all ones

2015-01-12 Thread Sumit Saxena
-Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Saturday, January 10, 2015 10:41 PM To: sumit.sax...@avagotech.com; kashyap.de...@avagotech.com Cc: martin.peter...@oracle.com; linux-scsi@vger.kernel.org Subject: [PATCH 04/10] megaraid_sas: add endianess conversions