Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-02-28 Thread Bart Van Assche
On 02/27/15 22:58, Nicholas A. Bellinger wrote: Looking at how your attempting to drive creation + removal of struct config_group from within kernel code here: target: Add target port registration API https://github.com/bvanassche/linux/commit/dbb8bf32db3428ede6ecc688ede1e5e01fc59d88 is

[PATCH 7/9] target: Add internal READ_INSERT support

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds READ_INSERT support in target_check_read_prot() that invokes sbc_dif_generate() when LIO is responsible for generating the outgoing T10-PI. Required for supporting fabrics that exchange protection information, and would like to

[PATCH 8/9] target/file: Add checks for backend DIF emulation

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Make sure that FILEIO only attempts to use backend DIF emulation when it's actually enabled at device level. Cc: Martin Petersen martin.peter...@oracle.com Cc: Sagi Grimberg sa...@mellanox.com Cc: Christoph Hellwig h...@lst.de Signed-off-by: Nicholas

[PATCH 5/9] target: Add internal WRITE_STRIP support

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds WRITE_STRIP support in target_check_write_prot() that invokes sbc_dif_verify_write() for checking T10-PI metadata before submitting the I/O to a backend driver. Upon verify failure, the specific sense code is propigated up the failure

[PATCH 3/9] target: Update SPC/SBC emulation for sess_prot_type

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates standard INQUIRY, INQUIRY EVPD=0x86, READ_CAPACITY_16 and control mode pages to use se_sess-sess_prot_type when determing which type of T10-PI related feature bits can be exposed. This is required for fabric sessions supporting

[PATCH 4/9] target: Move cmd-prot_op check into target_check_write_prot

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch moves the existing target_execute_cmd() check for cmd-prot_op into it's own function, so it's easier to add future support for WRITE STRIP. Cc: Martin Petersen martin.peter...@oracle.com Cc: Sagi Grimberg sa...@mellanox.com Cc: Christoph

[PATCH 0/9] target: Add WRITE_STRIP + READ_INSERT support

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi MKP, Sagi, Co, This series adds support for internal WRITE_STRIP + READ_INSERT DIX operations using existing target_core_sbc.c DIF emulation. It's useful in order for T10-PI fabrics to interoperate between backend devices that don't have

[PATCH 6/9] target: Move cmd-prot_op check into target_check_read_prot

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch moves the existing target_complete_ok_work() check for cmd-prot_op into it's own function, so it's easier to add future support for READ INSERT. Cc: Martin Petersen martin.peter...@oracle.com Cc: Sagi Grimberg sa...@mellanox.com Cc:

[PATCH 9/9] loopback: Add fabric_prot_type attribute support

2015-02-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates loopback to add a new fabric_prot_type TPG attribute, used for controlling LLD level protection into LIO when the backend device does not support T10-PI. Also, go ahead and set DIN_PASS + DOUT_PASS so target-core knows that it will

[PATCH v5 1/4] scsi: add ability to adjust module reference for scsi host

2015-02-28 Thread Akinobu Mita
While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well except ufs, unusual usb storage drivers, and sub

[PATCH v5 4/4] scsi: esp_scsi: adjust module reference for scsi host

2015-02-28 Thread Akinobu Mita
While accessing a scsi device on host adapter supported by sub driver for the ESP chip (mac_esp, am53c974, sun_esp, jazz_esp, sun3x_esp), the module reference count is not incremented. Because these drivers allocate scsi hosts with scsi_esp_template defined in ESP SCSI driver core module. So

[PATCH v5 0/4] scsi: ufs ums-* esp_scsi: fix module reference counting

2015-02-28 Thread Akinobu Mita
While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well except ufs, unusual usb storage drivers, and sub

Re: [PATCH V2 1/4] be2iscsi : Fix the retry count for boot targets

2015-02-28 Thread Mike Christie
On 12/19/14, 6:51 PM, John Soni Jose wrote: Increment the retry count to get the boot target info when port async event is received by the driver. Update sysfs enteries with the boot target parameters. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by: John Soni Jose

[PATCH v5 3/4] usb: storage: adjust module reference for scsi host

2015-02-28 Thread Akinobu Mita
While accessing a unusual usb storage (ums-alauda, ums-cypress, ...), the module reference count is not incremented. Because these drivers allocate scsi hosts with usb_stor_host_template defined in usb-storage module. So these drivers always can be unloaded. This fixes it by passing correct

[PATCH v5 2/4] scsi: ufs: adjust module reference for scsi host

2015-02-28 Thread Akinobu Mita
While accessing a UFS device, the module reference count for core driver (ufshcd) is incremented but not incremented for the actual glue driver (ufshcd-pci or ufshcd-pltfrm). Because these drivers allocate scsi hosts with scsi_host_template defined in ufshcd module. So these drivers always can

Re: [PATCH V2 3/4] be2iscsi : Fix memory leak in the unload path

2015-02-28 Thread Mike Christie
On 12/19/14, 6:53 PM, John Soni Jose wrote: Driver was not freeing the DMA memory allocated for EQ/CQ in the unload path. This patch frees the DMA memory during the driver unload. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal

[PATCH] scsi: ufs: fix typo in dev_err error message

2015-02-28 Thread Colin King
From: Colin Ian King colin.k...@canonical.com Fix typo, Intialization - Initialization Signed-off-by: Colin Ian King colin.k...@canonical.com --- drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c