Reviewed-by: Murthy Bhat murthy.b...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 04, 2015 2:09 PM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono; Mahesh
Reviewed-by: Murthy Bhat murthy.b...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 04, 2015 2:08 PM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono; Mahesh
Reviewed-by: Murthy Bhat murthy.b...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 04, 2015 2:09 PM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono; Mahesh
Reviewed-by: Murthy Bhat murthy.b...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 04, 2015 2:09 PM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono; Mahesh
Reviewed-by: Murthy Bhat murthy.b...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 04, 2015 2:08 PM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono; Mahesh
Reviewed-by: Murthy Bhat murthy.b...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 04, 2015 2:08 PM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono; Mahesh
On Mon, Mar 16, 2015 at 08:12:16PM -0500, Alireza Haghdoost wrote:
On Mon, Mar 16, 2015 at 3:32 PM, Dave Chinner da...@fromorbit.com wrote:
On Mon, Mar 16, 2015 at 11:28:53AM -0400, James Bottomley wrote:
Probably need to cc dm-devel here. However, I think we're all agreed
this is RAID
These patches are based on Linus's tree
The changes are:
- make function names consistent
- refactor functions
- cleanup driver messages
- cleanup error handling
- clean up abort management
- enhance sense data reporting
- enhance ioaccel command support
- add in block layer tag support
From: Stephen Cameron stephenmcame...@gmail.com
Do not send aborts to logical devices that do not support aborts
Instead of relying on what the Smart Array claims for supporting logical
drives, simply try an abort and see how it responds at device discovery
time. This way devices that do
From: Stephen Cameron stephenmcame...@gmail.com
In hba mode, we could get sense data in descriptor format so
we need to handle that.
It's possible for CommandStatus to have value 0x0D
TMF Function Status, which we should handle. We will get
this from a P1224 when aborting a non-existent tag,
From: Stephen Cameron stephenmcame...@gmail.com
Cache the ioaccel handle so that when we need to abort commands sent
down the ioaccel2 path, we can look up the LUN ID in h-dev[] instead of
having to do I/O to the controller.
Add a field to elements in h-dev[] to keep track of how the device is
From: Stephen Cameron stephenmcame...@gmail.com
make tracking of outstanding commands more robust
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1
From: Webb Scales web...@hp.com
We had a mix of formats used for specifying controller, bus, target,
and lun address of devices.
change to the format used by the scsi midlayer and upper layer (2:3:0:0)
so you can easily follow the information from hpsa to scsi midlayer
to sd upper layer.
Also
From: Webb Scales web...@hp.com
Rework slave allocation:
- separate the tagging support setup from the hostdata setup
- make the hostdata setup act consistently when the lookup fails
- make the hostdata setup act consistently when the device is not added
- set up the queue depth
update driver version
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
need to add PMC to copyright notice and update the Hewlett-Packard
copyright notification.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Reviewed-by: Justin Lindley justin.lind...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Robert Elliott elli...@hp.com
Rather than numbering the hpsa controllers with an
incrementing 0..n value (e.g., that shows up in
/proc/interrupts), use the scsi midlayer
host_no (e.g. matching /sys/class/scsi_host/hostNN).
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin
This patch provides a sysfs interface allowing users to override the
capacity of a SCSI disk. This will help in situations where a buggy
USB-SATA adapter fails to support READ CAPACITY(16) and reports only
the low 32 bits of the capacity in its READ CAPACITY(10) reply. For
an example, see this
hyvää päivää
Hanki laina tänään Loan Engine, jonka korko on 3%. täyttää
Lomake jos kiinnostaa:
Sukupuoli:
Maa:
Tarvittava määrä:
Kesto:
Mission:
On monia syitä, miksi lainan voi auttaa
terveiset
Ana Paula
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
On 03/11/2015 12:25 AM, Stanisław Pitucha wrote:
Hi linux-scsi,
I've got another case of reproducible crash when unplugging western
digital passport drives. This was mentioned before in
http://www.spinics.net/lists/linux-scsi/msg82603.html
Is there any way I can get a more correct
Currently exchange is not aborted in case underrun, so this patch
fixes this by issuing exchange abort along FC_DATA_UNDRUN error since
such error-ed exchange must be aborted first before same can be re-used.
Tested-By: Jack Morganjack.mor...@intel.com
Signed-off-by: Vasu Dev vasu@intel.com
From: Stephen Cameron stephenmcame...@gmail.com
add error handling for failure when registering with SCSI subsystem.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |4 +++-
1
From: Stephen Cameron stephenmcame...@gmail.com
Factor out hpsa_cmd_init from cmd_alloc(). We also need
this for resubmitting commands down the default RAID path
when they have returned from the ioaccel paths with errors.
In particular, reinitialize the cmd_type and busaddr fields as these
will
From: Robert Elliott elli...@hp.com
make function names more consistent and meaningful
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |
From: Joe Handzik joseph.t.hand...@hp.com
use ioaccel2 path to submit I/O to physical drives in HBA mode
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
From: Stephen Cameron stephenmcame...@gmail.com
expose a detected lockup via sysfs
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 17 +
1 file changed, 17
From: Robert Elliott elli...@hp.com
In hpsa_undo_allocations_after_kdump_soft_reset,
the things allocated in hpsa_init_one step 2 -
h-resubmit_wq and h-lockup_detected need to
be freed, in the right order.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett
From: Stephen Cameron stephenmcame...@gmail.com
add support for tmf when in ioaccel2 mode
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Robert Elliott elli...@hp.com
If registering the special interrupt handlers in hpsa_init_one
before a soft reset fails, the error exit needs to deallocate
everything that was allocated before.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
From: Webb Scales web...@hp.com
Don't return from the abort request until the target command is complete.
Mark outstanding commands which have a pending abort, and do not send them
to the host if we can avoid it.
If the current command has been aborted, do not call the SCSI command
completion
From: Robert Elliott elli...@hp.com
Don't create the resubmit workqueue in hpsa_init_one until everything else
is ready to use, so everything can be freed in reverse order of when they
were allocated without risking freeing things while workqueue items are
still active.
Destroy the workqueue in
From: Robert Elliott elli...@hp.com
Add the interrupt number to the interrupt names that
appear in /proc/interrupts, so they are unique
Also, delete the IRQ and DAC prints. Other parts of the kernel
already print the IRQ assignments, and dual-address-cycle support
has not been interesting since
From: Robert Elliott elli...@hp.com
If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset
should propagate its return value (e.g., -ENODEV) rather
than just returning -1.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert
From: Robert Elliott elli...@hp.com
correct return codes for error conditions
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 10
From: Robert Elliott elli...@hp.com
offload_enabled changes are deferred until after the
added/updated prints occur, so the values are incorrect.
defer printing SSD Smart Path Enabled status information until the
information is correct
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by:
From: Robert Elliott elli...@hp.com
report more useful information on aborts
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 29
From: Joe Handzik joseph.t.hand...@hp.com
get drive queue depth to help avoid task set full conditions.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Stephen Cameron stephenmcame...@gmail.com
allow the controller firmware to queue up commands when the ioaccel device
queue is full.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Webb Scales web...@hp.com
clean up command submission
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Webb Scales web...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 91
From: Webb Scales web...@hp.com
Increase the request size for ioaccel2 path.
The error, if any, returned by hpsa_allocate_ioaccel2_sg_chain_blocks
to hpsa_alloc_ioaccel2_cmd_and_bft should be returned upstream rather
than assumed to be -ENOMEM.
This differs slightly from
From: Webb Scales web...@hp.com
Divide the loop in hpsa_scatter_gather() into two, one for the initial SG list
and a second one for the chained list, if any. This allows the conditional
check which resets the indicies for the chained list to be performed outside
the loop instead of being done on
From: Robert Elliott elli...@hp.com
Improve initialization error handling in hpsa_init_one
Clean up style and indent issues
Rename functions for consistency
Improve error messaging on allocations
Fix return status from hpsa_put_ctlr_into_performant_mode
Correct free order in hpsa_init_one using
From: Robert Elliott elli...@hp.com
refactor error cleanup and shutdown
disable interrupts and pci_disable_device on critical failures
add hpsa_free_cfgtables function
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott
From: Joe Handzik joseph.t.hand...@hp.com
improve ioaccel2 error handling, including better handling of
underrun statuses
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace
From: Webb Scales web...@hp.com
cleanup command completions
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Webb Scales web...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 78
From: Webb Scales web...@hp.com
Factor out the code which sends the TEST_UNIT_READY from
wait_for_device_to_become_ready() into its own function.
Move the code which waits for the TEST_UNIT_READY from
wait_for_device_to_become_ready() into its own function.
If a logical drive has failed,
From: Robert Elliott elli...@hp.com
The SCSI midlayer already prints more detail about completions,
and has logging level options to filter them if not wanted.
These just slow down the system if a lot of errors occur,
stressing error handling even more.
Reviewed-by: Scott Teel
From: Robert Elliott elli...@hp.com
If try_soft_reset fails to re-allocate irqs, the error exit
starts with free_irq calls, which generate kernel WARN
messages since they were already freed a few lines earlier.
Jump to the next exit label to skip the free_irq calls.
Reviewed-by: Scott Teel
From: Robert Elliott elli...@hp.com
refactor freeing of resources into more logical functions
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Robert Elliott elli...@hp.com
replace calls to hpsa_free_irqs_and_disable_msix with
hpsa_free_irqs and hpsa_disable_interrupt_mode
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don
From: Robert Elliott elli...@hp.com
Despite the fact that PCI devices are enabled in this order:
1. pci_enable_device
2. pci_request_regions
Documentation/PCI/pci.txt specifies that they be undone
in this order
1. pci_disable_device
2. pci_release_regions
Tested by
From: Webb Scales web...@hp.com
Synchronize completion the reset with completion of outstanding commands
Extending the newly-added synchronous abort functionality,
now also synchronize resets with the completion of outstanding commands.
Rename the wait queue to reflect the fact that it's being
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:38 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:38 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:38 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:39 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:39 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:39 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
Reviewed-by: Achim Leubner achim.leub...@pmcs.com
-Original Message-
From: Mahesh Rajashekhara
Sent: Wednesday, March 4, 2015 9:39 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: aacr...@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan;
Rich Bono;
I see the same problem. Would this help?
Mar 17 21:13:00 storage1 kernel: [119260.960821] TARGET_CORE[iSCSI]:
Detected NON_EXISTENT_LUN Access for 0x0090
Mar 17 21:13:00 storage1 kernel: [119260.963752] ABORT_TASK: Sending
TMR_TASK_DOES_NOT_EXIST for ref_tag: 18170949
Mar 17 21:13:00
60 matches
Mail list logo