RE: [scsi:misc 14/106] drivers/scsi/storvsc_drv.c:1658 storvsc_queuecommand() warn: curly braces intended?

2015-04-13 Thread KY Srinivasan
-Original Message- From: James Bottomley [mailto:jbottom...@odin.com] Sent: Monday, April 13, 2015 7:26 AM To: dan.carpen...@oracle.com Cc: linux-scsi@vger.kernel.org; kbu...@01.org; KY Srinivasan Subject: Re: [scsi:misc 14/106] drivers/scsi/storvsc_drv.c:1658

Re: [PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions

2015-04-13 Thread Steve Wise
Acked-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: BUG: unable to handle kernel NULL pointer deref, bisected to 746650160

2015-04-13 Thread Torsten Luettgert
On Mon, 13 Apr 2015 19:41:05 +0200 Christoph Hellwig h...@lst.de wrote: Can you run gdb on your vmlinux file and send the output of the following command in gdb l *(scsi_dma_unmap+0x54) Thanks for looking into it! Here is what gdb says: Reading symbols from

Re: BUG: unable to handle kernel NULL pointer deref, bisected to 746650160

2015-04-13 Thread Christoph Hellwig
On Wed, Apr 08, 2015 at 06:33:33PM +0200, Torsten Luettgert wrote: Hello, I'm getting NULL pointer deref BUGs on a Supermicro machine of mine since 3.17. It occurs at random uptimes, often a few hours after booting (max uptime was 2 days yet). I bisected the problem (took a while); the

Re: [PATCH] [SCSI] bnx2fc: Fix debug messasges in bnx2fc_io.c

2015-04-13 Thread Chad Dupuis
Looks ok. Acked-by: Chad Dupuis chad.dup...@qlogic.com On Sun, 12 Apr 2015, Masanari Iida wrote: The debug messages in bnx2fc_process_seq_cleanup_compl() doesn't match its function name. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/scsi/bnx2fc/bnx2fc_io.c | 4 ++-- 1 file

Re: [PATCH 0/4] cxgbi: driver update

2015-04-13 Thread Mike Christie
On 04/10/2015 03:57 PM, Karen Xie wrote: This patch set contains fixes and updates for the cxgbi drivers. It updates the driver copyrights and versions, added logic to adjust the send/recv window based on the link speed and the initial sequence number. Karen Xie (4): cxgbi: use

Re: [PATCH 3/3] target/file: Fix UNMAP with DIF protection support

2015-04-13 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu When UNMAP command is issued with DIF protection support Akinobu enabled, the protection info for the unmapped region is remain Akinobu unchanged. So READ command for the region causes data Akinobu integrity failure. Akinobu This

Re: [PATCH 1/5] megaraid_sas : Code optimization and refactoring

2015-04-13 Thread Martin K. Petersen
Sumit == Sumit Saxena sumit.sax...@avagotech.com writes: Sumit Ok, I will spilt this patch in 7 patches. Do you have any Sumit feedback/comments for other patches of this series? IF you are ok Sumit with other patches, I will resend the series with patch#1 Sumit splitted in 7 patches and rest of

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-13 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi This set follows the patchset from Akinobu Mita that addresses DIF Sagi bounce buffer sgl construction. Instead of trying to fix these Sagi bugs, this removes it altogether and work with cmd-t_prot_sg Sagi directly. Sagi The first patch is a

Re: [PATCH-v2 02/15] target: Add protected fabric + unprotected device support

2015-04-13 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@linux-iscsi.org writes: nab The following incremental patch saves the current sess_prot_type nab into se_node_acl, and will always reset sess_prot_type if a nab previous saved value exists. So the PI setting for the fabric's nab session with backend devices not

Re: [PATCH 1/5] megaraid_sas : Code optimization and refactoring

2015-04-13 Thread Christoph Hellwig
On Mon, Apr 13, 2015 at 09:17:27PM -0400, Martin K. Petersen wrote: Sumit == Sumit Saxena sumit.sax...@avagotech.com writes: Sumit Ok, I will spilt this patch in 7 patches. Do you have any Sumit feedback/comments for other patches of this series? IF you are ok Sumit with other patches, I

Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

2015-04-13 Thread David Miller
From: Varun Prakash va...@chelsio.com Date: Mon, 13 Apr 2015 19:34:25 +0530 diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c index 6c8a62e..f78d632 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c +++

[PATCH RFC 2/2] target/file: Remove fd_prot bounce buffer

2015-04-13 Thread Sagi Grimberg
The reason this bounce buffer exists is to allow code reuse between rd_mcp and fileio in DIF mode. But the fact is, that this bounce is really not needed at all, we can simply call sbc_dif_verify on cmd-t_prot_sg and use it for file IO. This also removes fd_do_prot_rw as fd_do_rw was generalised

[RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-13 Thread Sagi Grimberg
Hey All, This set follows the patchset from Akinobu Mita that addresses DIF bounce buffer sgl construction. Instead of trying to fix these bugs, this removes it altogether and work with cmd-t_prot_sg directly. The first patch is a simplification of the DIF verify varius routines leaving a single

[PATCH RFC 1/2] target: Merge sbc_verify_dif_read|write

2015-04-13 Thread Sagi Grimberg
Instead of providing DIF verify routines for read/write that are almost identical and conditionally copy protection information, just let the caller do the right thing. Have a single sbc_dif_verify that handles an sgl (that does NOT copy any data) and a protection information copy routine used by

[PATCH v2 0/1] ata: ahci_xgene: Enable native NCQ and FBS for second generation of X-Gene SoC.

2015-04-13 Thread Suman Tripathi
V2 change: * Drop the MIDR based implementation as it is wrong. Signed-off-by: Suman Tripathi stripa...@apm.com --- Suman Tripathi (1): ata: ahci_xgene: Add AHCI Support for second generation of APM X-Gene SoC drivers/ata/ahci_xgene.c | 96

Re: [PATCH 4/6] mpt2sas: store scsi io tracker data in the scsi request

2015-04-13 Thread Christoph Hellwig
On Tue, Apr 07, 2015 at 11:18:38AM -0600, Jens Axboe wrote: Instead of storing the IO tracker structure in a separate list that we need to pop/push to on every submit and complete (and lock), store it in the pdu associated with a request. This is possible on scsi-mq only, and further cuts the

Re: [PATCH RFC v2] mpt2/mpt3sas lock reduction for scsi-mq

2015-04-13 Thread Christoph Hellwig
This looks good modulo my minor comments and using and testing the new code path for the !mq case as well. Please also Cc the Avago people on your next submission. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

MDaemon Notification -- Attachment Removed

2015-04-13 Thread Postmaster
--- MDaemon has detected restricted attachments within an email message --- From : asadul...@forbespak.com To: linux-scsi@vger.kernel.org Subject :

re: ufs: add ioctl interface for query request

2015-04-13 Thread Gilad Broner
copy_to/from_user() returns the number of bytes not copied and not an error code. Printing these error messages in the ioctl means the user can trigger a DoS by filling up /var/log/messages. They make the code uglier. We should stop here if the copy fails and goto out_release_mem otherwise

Re: [PATCH -next v3] target/rd: Don't pass imcomplete scatterlist entries to sbc_dif_verify_*

2015-04-13 Thread Akinobu Mita
2015-04-13 13:59 GMT+09:00 Nicholas A. Bellinger n...@linux-iscsi.org: On Sat, 2015-04-11 at 13:17 +0900, Akinobu Mita wrote: The scatterlist for protection information which is passed to sbc_dif_verify_read() or sbc_dif_verify_write() requires that neighboring scatterlist entries are

RE: [PATCH 1/5] megaraid_sas : Code optimization and refactoring

2015-04-13 Thread Sumit Saxena
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Wednesday, April 08, 2015 4:45 AM To: sumit.sax...@avagotech.com Cc: linux-scsi@vger.kernel.org; the...@redhat.com; martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com;

Re: [PATCH 2/6] scsi: ensure that a request is valid when returning it from scsi_find_tag()

2015-04-13 Thread Christoph Hellwig
On Tue, Apr 07, 2015 at 11:18:36AM -0600, Jens Axboe wrote: For the scsi-mq case, ensure that the request has been started before returning it from scsi_find_tag(). This is akin to the -special check for the non-mq case, it ensures that the request has been setup and issued. Signed-off-by:

Re: [PATCH-v2 02/15] target: Add protected fabric + unprotected device support

2015-04-13 Thread Sagi Grimberg
On 4/10/2015 9:59 PM, Nicholas A. Bellinger wrote: On Thu, 2015-04-09 at 17:45 -0400, Martin K. Petersen wrote: nab == Nicholas A Bellinger n...@linux-iscsi.org writes: How do you handle RDPROTECT/WRPROTECT values of 3 if the PI is not persistent? nab AFAICT, this would result in

RE: [PATCH scsi] aacraid: aac_src_intr_message() can be static

2015-04-13 Thread Mahesh Rajashekhara
Acked-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com -Original Message- From: kbuild test robot [mailto:fengguang...@intel.com] Sent: Friday, April 10, 2015 2:24 PM To: Mahesh Rajashekhara Cc: kbuild-...@01.org; James Bottomley; Adaptec OEM Raid Solutions; James E.J. Bottomley;

Re: [PATCH 3/6] mpt2sas: get rid of MPI2_FUNCTION_SCSI_TASK_MGMT

2015-04-13 Thread Christoph Hellwig
This should also mention that you now allocate the hdr for the normal pass through from a different pool. Actually that change probably should really be a separate patch.. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

Re: ufs: add ioctl interface for query request

2015-04-13 Thread Dan Carpenter
On Mon, Apr 13, 2015 at 10:55:58AM -, Gilad Broner wrote: copy_to/from_user() returns the number of bytes not copied and not an error code. Printing these error messages in the ioctl means the user can trigger a DoS by filling up /var/log/messages. They make the code uglier. We

Re: [PATCH v4 4/9] snic:Add snic target discovery

2015-04-13 Thread Hannes Reinecke
On 04/13/2015 07:25 AM, Narsimhulu Musini (nmusini) wrote: Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 09/04/15 6:29 pm, Hannes Reinecke h...@suse.de wrote: On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: [ .. ] +/* snic_tgt_create: checks for

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-13 Thread Tomas Henzl
On 04/11/2015 12:45 AM, Vinson Lee wrote: On Tue, Jan 27, 2015 at 4:18 PM, Greg KH g...@kroah.com wrote: On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote: On 01/05/2015 07:41 PM, Masoud Sharbiani wrote: Dear stable maintainers, Can you please backport commitid

[PATCH net-next v2 2/4] cxgb4: add structure and macro definitions for FCoE DDP

2015-04-13 Thread Varun Prakash
This patch adds new header file t4_tcb.h and structure, macro definitions for FCoE DDP support in cxgb4 driver. Signed-off-by: Varun Prakash va...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.h | 54 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h |7 ++

[PATCH 1/3] target/file: Fix BUG() when CONFIG_DEBUG_SG=y and DIF protection enabled

2015-04-13 Thread Akinobu Mita
When CONFIG_DEBUG_SG=y and DIF protection support enabled, kernel BUG()s are triggered due to the following two issues: 1) prot_sg is not initialized by sg_init_table(). When CONFIG_DEBUG_SG=y, scatterlist helpers check sg entry has a correct magic value. 2) vmalloc'ed buffer is passed to

Re: [scsi:misc 14/106] drivers/scsi/storvsc_drv.c:1658 storvsc_queuecommand() warn: curly braces intended?

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 14:56 +0300, Dan Carpenter wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 0351b8f81392c6d036e5c8f73ceff68726e9 commit: be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 [14/106] scsi: storvsc: Set the tablesize based on the information

[PATCH net-next v2 0/4] cxgb4: add FCoE DDP and RSS

2015-04-13 Thread Varun Prakash
This patch series enables RSS for FCoE frames and adds DDP support for FCoE target. v2: add patch 1/4 to fix build error redefinition of struct ulptx_idata. Varun Prakash (4): cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions cxgb4: add structure and macro definitions for FCoE DDP

[PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions

2015-04-13 Thread Varun Prakash
define struct ulptx_idata in common header file t4_msg.h to remove duplicate definitions. Signed-off-by: Varun Prakash va...@chelsio.com --- drivers/infiniband/hw/cxgb4/t4fw_ri_api.h |9 - drivers/net/ethernet/chelsio/cxgb4/t4_msg.h |5 + drivers/scsi/cxgbi/cxgb4i/cxgb4i.h

[PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

2015-04-13 Thread Varun Prakash
This patch adds code for ndo_fcoe_ddp_target and ndo_fcoe_ddp_done. Signed-off-by: Varun Prakash va...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c | 600 +++

[PATCH net-next v2 4/4] cxgb4: enable RSS for FCoE frames

2015-04-13 Thread Varun Prakash
Signed-off-by: Varun Prakash va...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |8 drivers/net/ethernet/chelsio/cxgb4/t4_regs.h|8 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread Joe Lawrence
On 04/12/2015 08:54 PM, James Bottomley wrote: On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: On 12/30/2014 09:07 AM, Joe Lawrence wrote: A colleague noticed that the mpt2 and mpt3sas drivers do not correctly check the PCI master abort pattern in _base_wait_for_doorbell_ack. This

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 10:06 -0400, Joe Lawrence wrote: On 04/12/2015 08:54 PM, James Bottomley wrote: On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: On 12/30/2014 09:07 AM, Joe Lawrence wrote: A colleague noticed that the mpt2 and mpt3sas drivers do not correctly check the PCI

Re: [PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions

2015-04-13 Thread Jason Gunthorpe
On Mon, Apr 13, 2015 at 07:34:23PM +0530, Varun Prakash wrote: define struct ulptx_idata in common header file t4_msg.h to remove duplicate definitions. The Infiniband side of this patch looks OK. Reviewed-By: Jason Gunthorpe jguntho...@obsidianresearch.com Just some random thoughts on the

mvsas panics and dies when attached to a port extender on newer kernels

2015-04-13 Thread Adam Talbot
To make a very long debugging story short, I think there is an issues/bug with the mvsas driver. It works, with older kernels, and breaks on newer kernels. My Debian Jessie system was running great on a 3.18 kernel. Changed cases to a newer supermicro case with a SAS expander backplane

[Bug 90601] panic on write to 3ware raid array

2015-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #16 from mer...@liao.homelinux.org --- Created attachment 173931 -- https://bugzilla.kernel.org/attachment.cgi?id=173931action=edit panic_screenshot screenshot of kernel panic -- You are receiving this mail because: You are the

[Bug 90601] panic on write to 3ware raid array

2015-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #17 from mer...@liao.homelinux.org --- I am unable to get a dmesg output since the system crashes on boot. It looks like it's happening when udev is initialized. Sorry for the screenshot but the system crashed before any network came

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-13 Thread Zach Brown
Could we perhaps instead of a length, define a 'pos_in_start' and a 'pos_in_end' offset (with the latter being -1 for a full-file copy) and then return an 'loff_t' value stating where the copy ended? Well, the resulting offset will be set if the caller provided it. So they could

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread Joe Lawrence
On 04/13/2015 10:38 AM, James Bottomley wrote: On Mon, 2015-04-13 at 10:06 -0400, Joe Lawrence wrote: On 04/12/2015 08:54 PM, James Bottomley wrote: On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: On 12/30/2014 09:07 AM, Joe Lawrence wrote: A colleague noticed that the mpt2 and mpt3sas

Re: [PATCH 1/3] target/file: Fix BUG() when CONFIG_DEBUG_SG=y and DIF protection enabled

2015-04-13 Thread Sagi Grimberg
On 4/13/2015 5:21 PM, Akinobu Mita wrote: When CONFIG_DEBUG_SG=y and DIF protection support enabled, kernel BUG()s are triggered due to the following two issues: 1) prot_sg is not initialized by sg_init_table(). When CONFIG_DEBUG_SG=y, scatterlist helpers check sg entry has a correct magic

Re: [PATCH 3/3] target/file: Fix UNMAP with DIF protection support

2015-04-13 Thread Sagi Grimberg
On 4/13/2015 5:21 PM, Akinobu Mita wrote: When UNMAP command is issued with DIF protection support enabled, the protection info for the unmapped region is remain unchanged. So READ command for the region causes data integrity failure. This fixes it by invalidating protection info for the