On 4/15/2015 7:10 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
By the commit 436f4a0a (loopback: Add fabric_prot_type attribute
support), When WRITE_SAME command with WRPROTECT=0 is executed,
sbc_dif_generate() is called but cmd-t_prot_sg is NULL as
https://bugzilla.kernel.org/show_bug.cgi?id=90601
--- Comment #18 from mer...@liao.homelinux.org ---
Created attachment 174171
-- https://bugzilla.kernel.org/attachment.cgi?id=174171action=edit
dmesg
I finally managed to get a dmesg output with the crashing kernel.
Especially this part might
https://bugzilla.kernel.org/show_bug.cgi?id=90601
mer...@liao.homelinux.org changed:
What|Removed |Added
Attachment #162291|0 |1
is obsolete|
uas_use_uas_driver may set some US_FL_foo flags during detection, currently
these are stored in a local variable and then throw away, but these may be
of interest to the caller, so add an extra parameter to (optionally) return
the detected flags, and use this in the uas driver.
Signed-off-by:
Testing has shown that ASM1053 devices do not work properly with transfers
larger than 240 sectors, so set max_sectors to 240 on these.
Reported-by: Steve Bangert sbang...@frontier.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 5 -
1 file
The usb-storage driver sets max_sectors = 240 in its scsi-host template, for
uas we do not want to do that for all devices, but testing has shown that
some devices need it.
This commit adds a US_FL_MAX_SECTORS_240 flag for such devices, and implements
support for it in uas.c, while at it it also
https://bugzilla.kernel.org/show_bug.cgi?id=90601
--- Comment #19 from mer...@liao.homelinux.org ---
Created attachment 174181
-- https://bugzilla.kernel.org/attachment.cgi?id=174181action=edit
crash-backtrace
--
You are receiving this mail because:
You are the assignee for the bug.
--
To
On 04/14/2015 04:32 PM, Dan Carpenter wrote:
We should return -ENOMEM if kzalloc() fails here instead of returning
success.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
index 2e66f34..622bdab 100644
---
On 01/19/2015 03:41 PM, Dan Carpenter wrote:
If device_add() fails then it should return the error code but instead
the current code returns success.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index ebf35cb6..75a0b55 100644
---
These patches are based on Linus's tree
The changes are:
- make function names consistent
- refactor functions
- cleanup driver messages
- cleanup error handling
- clean up abort management
- enhance sense data reporting
- enhance ioaccel command support
- add in block layer tag support
From: Robert Elliott elli...@hp.com
The SCSI midlayer already prints more detail about completions,
and has logging level options to filter them if not wanted.
These just slow down the system if a lot of errors occur,
stressing error handling even more.
Reviewed-by: Scott Teel
From: Stephen Cameron stephenmcame...@gmail.com
add support for tmf when in ioaccel2 mode
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
On Thu, 2015-04-16 at 14:17 +0200, Hans de Goede wrote:
uas_use_uas_driver may set some US_FL_foo flags during detection, currently
these are stored in a local variable and then throw away, but these may be
of interest to the caller, so add an extra parameter to (optionally) return
the
On Thu, 16 Apr 2015, Hans de Goede wrote:
The usb-storage driver sets max_sectors = 240 in its scsi-host template, for
uas we do not want to do that for all devices, but testing has shown that
some devices need it.
This commit adds a US_FL_MAX_SECTORS_240 flag for such devices, and
On 4/16/2015 4:46 PM, Akinobu Mita wrote:
2015-04-16 17:52 GMT+09:00 Sagi Grimberg sa...@dev.mellanox.co.il:
On 4/15/2015 7:10 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
By the commit 436f4a0a (loopback: Add fabric_prot_type attribute
support),
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes:
We don't issue WRITE SAME with PI so there is no prot SGL.
Is there a specific reason why we don't?
There really isn't much of a benefit when all you're doing is
replicating zeroes. So it hasn't been very high on my list.
Akinobu It is
On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote:
On 04/11/2015 12:45 AM, Vinson Lee wrote:
On Tue, Jan 27, 2015 at 4:18 PM, Greg KH g...@kroah.com wrote:
On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote:
On 01/05/2015 07:41 PM, Masoud Sharbiani wrote:
Dear stable
On 4/16/2015 6:58 PM, Sagi Grimberg wrote:
On 4/16/2015 4:46 PM, Akinobu Mita wrote:
2015-04-16 17:52 GMT+09:00 Sagi Grimberg sa...@dev.mellanox.co.il:
On 4/15/2015 7:10 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
By the commit 436f4a0a (loopback:
Driver was not freeing the DMA memory allocated for EQ/CQ in the
unload path. This patch frees the DMA memory during the driver unload.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be_main.c |
Reserve device PCI I/O and Memory resources.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be_main.c | 22 ++
1 files changed, 18 insertions(+), 4 deletions(-)
diff --git
Check DMA memory before it is unmapped.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be_main.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git
Bump the driver version
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be_main.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be.h |2 +-
drivers/scsi/be2iscsi/be_cmds.c |2 +-
drivers/scsi/be2iscsi/be_cmds.h |2 +-
drivers/scsi/be2iscsi/be_iscsi.c |2 +-
Increment the retry count to get the boot target info when
port async event is received by the driver. Update sysfs enteries
with the boot target parameters.
Signed-off-by: Minh Tran minhduc.t...@emulex.com
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan
Once be2iscsi driver is loaded and operational close Boot
session established by FW.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be_cmds.h | 12 ++
drivers/scsi/be2iscsi/be_iscsi.c |
The patchset updates be2iscsi driver to 10.6.0.0 version.
These patches are generated aganist scsi for-next branch
John Soni Jose (7):
be2iscsi : Fix the retry count for boot targets
be2iscsi : Fix the PCI request region reserving.
be2iscsi : Fix memory leak in the unload path
be2iscsi
2015-04-16 17:52 GMT+09:00 Sagi Grimberg sa...@dev.mellanox.co.il:
On 4/15/2015 7:10 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
By the commit 436f4a0a (loopback: Add fabric_prot_type attribute
support), When WRITE_SAME command with WRPROTECT=0 is
From: Robert Elliott elli...@hp.com
Add the interrupt number to the interrupt names that
appear in /proc/interrupts, so they are unique
Also, delete the IRQ and DAC prints. Other parts of the kernel
already print the IRQ assignments, and dual-address-cycle support
has not been interesting since
From: Robert Elliott elli...@hp.com
If registering the special interrupt handlers in hpsa_init_one
before a soft reset fails, the error exit needs to deallocate
everything that was allocated before.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
From: Robert Elliott elli...@hp.com
Don't create the resubmit workqueue in hpsa_init_one until everything else
is ready to use, so everything can be freed in reverse order of when they
were allocated without risking freeing things while workqueue items are
still active.
Destroy the workqueue in
From: Webb Scales web...@hp.com
Factor out the code which sends the TEST_UNIT_READY from
wait_for_device_to_become_ready() into its own function.
Move the code which waits for the TEST_UNIT_READY from
wait_for_device_to_become_ready() into its own function.
If a logical drive has failed,
From: Robert Elliott elli...@hp.com
If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset
should propagate its return value (e.g., -ENODEV) rather
than just returning -1.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert
From: Robert Elliott elli...@hp.com
Despite the fact that PCI devices are enabled in this order:
1. pci_enable_device
2. pci_request_regions
Documentation/PCI/pci.txt specifies that they be undone
in this order
1. pci_disable_device
2. pci_release_regions
Tested by
From: Webb Scales web...@hp.com
cleanup command completions
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Webb Scales web...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 78
From: Robert Elliott elli...@hp.com
Rather than numbering the hpsa controllers with an
incrementing 0..n value (e.g., that shows up in
/proc/interrupts), use the scsi midlayer
host_no (e.g. matching /sys/class/scsi_host/hostNN).
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin
update driver version
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
From: Webb Scales web...@hp.com
Divide the loop in hpsa_scatter_gather() into two, one for the initial SG list
and a second one for the chained list, if any. This allows the conditional
check which resets the indicies for the chained list to be performed outside
the loop instead of being done on
add in support for latest PMC controller
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 5fc4118..910d748 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@
From: Webb Scales web...@hp.com
Synchronize completion the reset with completion of outstanding commands
Extending the newly-added synchronous abort functionality,
now also synchronize resets with the completion of outstanding commands.
Rename the wait queue to reflect the fact that it's being
need to add PMC to copyright notice and update the Hewlett-Packard
copyright notification.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Reviewed-by: Justin Lindley justin.lind...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Webb Scales web...@hp.com
Don't return from the abort request until the target command is complete.
Mark outstanding commands which have a pending abort, and do not send them
to the host if we can avoid it.
If the current command has been aborted, do not call the SCSI command
completion
From: Webb Scales web...@hp.com
Rework slave allocation:
- separate the tagging support setup from the hostdata setup
- make the hostdata setup act consistently when the lookup fails
- make the hostdata setup act consistently when the device is not added
- set up the queue depth
From: Robert Elliott elli...@hp.com
In hpsa_undo_allocations_after_kdump_soft_reset,
the things allocated in hpsa_init_one step 2 -
h-resubmit_wq and h-lockup_detected need to
be freed, in the right order.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett
From: Robert Elliott elli...@hp.com
If try_soft_reset fails to re-allocate irqs, the error exit
starts with free_irq calls, which generate kernel WARN
messages since they were already freed a few lines earlier.
Jump to the next exit label to skip the free_irq calls.
Reviewed-by: Scott Teel
From: Stephen Cameron stephenmcame...@gmail.com
expose a detected lockup via sysfs
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 17 +
1 file changed, 17
From: Stephen Cameron stephenmcame...@gmail.com
Do not send aborts to logical devices that do not support aborts
Instead of relying on what the Smart Array claims for supporting logical
drives, simply try an abort and see how it responds at device discovery
time. This way devices that do
From: Webb Scales web...@hp.com
Increase the request size for ioaccel2 path.
The error, if any, returned by hpsa_allocate_ioaccel2_sg_chain_blocks
to hpsa_alloc_ioaccel2_cmd_and_bft should be returned upstream rather
than assumed to be -ENOMEM.
This differs slightly from
From: Joe Handzik joseph.t.hand...@hp.com
improve ioaccel2 error handling, including better handling of
underrun statuses
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace
From: Robert Elliott elli...@hp.com
cmd_alloc can no longer return NULL, so don't check for NULL any more
(which is unreachable code).
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don
From: Robert Elliott elli...@hp.com
offload_enabled changes are deferred until after the
added/updated prints occur, so the values are incorrect.
defer printing SSD Smart Path Enabled status information until the
information is correct
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by:
From: Robert Elliott elli...@hp.com
correct return codes for error conditions
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 10
From: Joe Handzik joseph.t.hand...@hp.com
get drive queue depth to help avoid task set full conditions.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Robert Elliott elli...@hp.com
Improve initialization error handling in hpsa_init_one
Clean up style and indent issues
Rename functions for consistency
Improve error messaging on allocations
Fix return status from hpsa_put_ctlr_into_performant_mode
Correct free order in hpsa_init_one using
From: Webb Scales webb.sca...@hp.com
Allow driver initiated commands to have a timeout. It does not
yet try to do anything with timeouts on such commands.
We are sending a reset in order to get rid of a command we want to abort.
If we make it return on the same reply queue as the command we
From: Robert Elliott elli...@hp.com
refactor freeing of resources into more logical functions
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
From: Stephen Cameron stephenmcame...@gmail.com
Factor out hpsa_cmd_init from cmd_alloc(). We also need
this for resubmitting commands down the default RAID path
when they have returned from the ioaccel paths with errors.
In particular, reinitialize the cmd_type and busaddr fields as these
will
From: Webb Scales web...@hp.com
We had a mix of formats used for specifying controller, bus, target,
and lun address of devices.
change to the format used by the scsi midlayer and upper layer (2:3:0:0)
so you can easily follow the information from hpsa to scsi midlayer
to sd upper layer.
Also
From: Joe Handzik joseph.t.hand...@hp.com
use ioaccel2 path to submit I/O to physical drives in HBA mode
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Joe Handzik joseph.t.hand...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
From: Stephen Cameron stephenmcame...@gmail.com
In hba mode, we could get sense data in descriptor format so
we need to handle that.
It's possible for CommandStatus to have value 0x0D
TMF Function Status, which we should handle. We will get
this from a P1224 when aborting a non-existent tag,
From: Stephen Cameron stephenmcame...@gmail.com
Cache the ioaccel handle so that when we need to abort commands sent
down the ioaccel2 path, we can look up the LUN ID in h-dev[] instead of
having to do I/O to the controller.
Add a field to elements in h-dev[] to keep track of how the device is
From: Webb Scales web...@hp.com
clean up command submission
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Webb Scales web...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 91
From: Robert Elliott elli...@hp.com
make function names more consistent and meaningful
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |
From: Robert Elliott elli...@hp.com
report more useful information on aborts
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c | 29
From: Robert Elliott elli...@hp.com
refactor error cleanup and shutdown
disable interrupts and pci_disable_device on critical failures
add hpsa_free_cfgtables function
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott
From: Stephen Cameron stephenmcame...@gmail.com
make tracking of outstanding commands more robust
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
drivers/scsi/hpsa.c |1 +
1 file changed, 1
From: Robert Elliott elli...@hp.com
replace calls to hpsa_free_irqs_and_disable_msix with
hpsa_free_irqs and hpsa_disable_interrupt_mode
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Robert Elliott elli...@hp.com
Signed-off-by: Don
From: Stephen Cameron stephenmcame...@gmail.com
allow the controller firmware to queue up commands when the ioaccel device
queue is full.
Reviewed-by: Scott Teel scott.t...@pmcs.com
Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com
Signed-off-by: Don Brace don.br...@pmcs.com
---
Wow, I forgot how long it takes to compile a full kernel. Glad I ran
Gentoo for a few years and knew how to compile and apply patches. I
will admit I had to dust off some mental cobwebs.
Pre-patched 4.0.0 kernel tree: Oops, as expected
Patched 4.0.0 kernel tree: IT WORKED! Basic mount, and
This is the usual grab bag of driver updates (lpfc, qla2xxx, storvsc,
aacraid, ipr) plus an assortment of minor updates. There's also a major
update to aic1542 which moves the driver into this millenium.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
On Thu, 2015-04-16 at 10:26 -0700, Adam Talbot wrote:
Wow, I forgot how long it takes to compile a full kernel. Glad I ran
Gentoo for a few years and knew how to compile and apply patches. I
will admit I had to dust off some mental cobwebs.
Pre-patched 4.0.0 kernel tree: Oops, as expected
Oh! Good idea. ;-)
I will test it in 6~8 hours, once the raid check finishes.
On Thu, Apr 16, 2015 at 10:28 AM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Thu, 2015-04-16 at 10:26 -0700, Adam Talbot wrote:
Wow, I forgot how long it takes to compile a full kernel. Glad I
On 04/17/2015 04:34 AM, John Soni Jose wrote:
Once be2iscsi driver is loaded and operational close Boot
session established by FW.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
drivers/scsi/be2iscsi/be_cmds.h
On 04/16/2015 02:52 PM, Mike Christie wrote:
On 04/17/2015 04:34 AM, John Soni Jose wrote:
Once be2iscsi driver is loaded and operational close Boot
session established by FW.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Don Brace
Sent: Thursday, April 16, 2015 8:51 AM
Subject: [PATCH v4 42/43] hpsa: add PMC to copyright
need to add PMC to copyright notice and update the Hewlett-Packard
Tested against main RAID6, 7 disk array, with sas extender and work
with out error.
Tested against 2X mirror of SSD's, direct attached, and worked with out error.
Check was a simple RAID check. echo check /sys/block/md126/md/sync_action
Patched against:
root@nas:~# uname -a
Linux nas 4.0.0 #1
75 matches
Mail list logo