Re: [GIT PULL] SCSI updates for the 4.0+ merge window

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 07:34 PM, James Bottomley wrote: This is the usual grab bag of driver updates (lpfc, qla2xxx, storvsc, aacraid, ipr) plus an assortment of minor updates. There's also a major update to aic1542 which moves the driver into this millenium. The patch is available here:

Re: [PATCH v4 04/43] hpsa: clean up aborts

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com Do not send aborts to logical devices that do not support aborts Instead of relying on what the Smart Array claims for supporting logical drives, simply try an abort and see how it responds at device

Re: [PATCH v4 06/43] hpsa: hpsa decode sense data for io and tmf

2015-04-17 Thread Hannes Reinecke
Hid Don, some comments at the end. On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com In hba mode, we could get sense data in descriptor format so we need to handle that. It's possible for CommandStatus to have value 0x0D TMF Function Status, which

Re: [PATCH v4 12/43] hpsa: factor out hpsa_ioaccel_submit function

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Webb Scales web...@hp.com clean up command submission Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com

Re: [PATCH v4 11/43] hpsa: try resubmitting down raid path on task set full

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com allow the controller firmware to queue up commands when the ioaccel device queue is full. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by:

Re: [PATCH v4 13/43] hpsa: print accurate SSD Smart Path Enabled status

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com offload_enabled changes are deferred until after the added/updated prints occur, so the values are incorrect. defer printing SSD Smart Path Enabled status information until the information is correct

Re: [PATCH v4 01/43] hpsa: add masked physical devices into h-dev[] array

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:46 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com Cache the ioaccel handle so that when we need to abort commands sent down the ioaccel2 path, we can look up the LUN ID in h-dev[] instead of having to do I/O to the controller. Add a field to elements

Re: [PATCH v4 03/43] hpsa: rework controller command submission

2015-04-17 Thread Hannes Reinecke
Hi Don, some comments inline. On 04/16/2015 03:46 PM, Don Brace wrote: From: Webb Scales webb.sca...@hp.com Allow driver initiated commands to have a timeout. It does not yet try to do anything with timeouts on such commands. We are sending a reset in order to get rid of a command we

Re: [PATCH v4 08/43] hpsa: make function names consistent

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com make function names more consistent and meaningful Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don

Re: [PATCH v4 09/43] hpsa: factor out hpsa_init_cmd function

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com Factor out hpsa_cmd_init from cmd_alloc(). We also need this for resubmitting commands down the default RAID path when they have returned from the ioaccel paths with errors. In particular,

Re: [PATCH v4 10/43] hpsa: do not ignore return value of hpsa_register_scsi

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com add error handling for failure when registering with SCSI subsystem. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace

Re: [PATCH v4 16/43] hpsa: break hpsa_free_irqs_and_disable_msix into two functions

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com replace calls to hpsa_free_irqs_and_disable_msix with hpsa_free_irqs and hpsa_disable_interrupt_mode Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by:

Re: [PATCH v4 15/43] hpsa: Get queue depth from identify physical bmic for physical disks.

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Joe Handzik joseph.t.hand...@hp.com get drive queue depth to help avoid task set full conditions. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com

Re: [PATCH v4 14/43] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode.

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:47 PM, Don Brace wrote: From: Joe Handzik joseph.t.hand...@hp.com use ioaccel2 path to submit I/O to physical drives in HBA mode Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik

Re: [PATCH v4 18/43] hpsa: refactor freeing of resources into more logical functions

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com refactor freeing of resources into more logical functions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by:

Re: [PATCH v4 17/43] hpsa: clean up error handling

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com refactor error cleanup and shutdown disable interrupts and pci_disable_device on critical failures add hpsa_free_cfgtables function Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett

Re: [PATCH v4 20/43] hpsa: add more ioaccel2 error handling, including underrun statuses.

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Joe Handzik joseph.t.hand...@hp.com improve ioaccel2 error handling, including better handling of underrun statuses Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik

Re: [PATCH v4 01/43] hpsa: add masked physical devices into h-dev[] array

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:46 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com Cache the ioaccel handle so that when we need to abort commands sent down the ioaccel2 path, we can look up the LUN ID in h-dev[] instead of having to do I/O to the controller. Add a field to elements

Re: [PATCH v4 19/43] hpsa: add ioaccel sg chaining for the ioaccel2 path

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Webb Scales web...@hp.com Increase the request size for ioaccel2 path. The error, if any, returned by hpsa_allocate_ioaccel2_sg_chain_blocks to hpsa_alloc_ioaccel2_cmd_and_bft should be returned upstream rather than assumed to be -ENOMEM.

Re: [PATCH v4 36/43] hpsa: add interrupt number to /proc/interrupts interrupt name

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Add the interrupt number to the interrupt names that appear in /proc/interrupts, so they are unique Also, delete the IRQ and DAC prints. Other parts of the kernel already print the IRQ assignments, and

Re: BUG: unable to handle kernel NULL pointer deref, bisected to 746650160

2015-04-17 Thread Torsten Luettgert
On Mon, 13 Apr 2015 20:28:29 +0200 Torsten Luettgert ml-l...@enda.eu wrote: On Mon, 13 Apr 2015 19:41:05 +0200 Christoph Hellwig h...@lst.de wrote: Can you run gdb on your vmlinux file and send the output of the following command in gdb l *(scsi_dma_unmap+0x54) Thanks for looking

Re: ahci Port to Host interrupt as edge trigger

2015-04-17 Thread Tejun Heo
On Fri, Apr 17, 2015 at 04:22:17PM +0530, Suman Tripathi wrote: Hi , I need some suggestion . From the below interrupt handler in libahci.c it explains that the interrupt from port to Host is level triggered. Do we have any existing implementation that handles the port to Host as Edge

Re: [PATCH v4 22/43] hpsa: correct return values from driver functions.

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com correct return codes for error conditions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace

Re: [PATCH v4 24/43] hpsa: clean up some error reporting output in abort handler

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com report more useful information on aborts Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace

Re: [PATCH v4 11/43] hpsa: try resubmitting down raid path on task set full

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com allow the controller firmware to queue up commands when the ioaccel device queue is full. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by:

Re: [PATCH v4 29/43] hpsa: refactor and rework support for sending TEST_UNIT_READY

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com Factor out the code which sends the TEST_UNIT_READY from wait_for_device_to_become_ready() into its own function. Move the code which waits for the TEST_UNIT_READY from wait_for_device_to_become_ready() into its own

Re: [PATCH v4 30/43] hpsa: performance tweak for hpsa_scatter_gather()

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com Divide the loop in hpsa_scatter_gather() into two, one for the initial SG list and a second one for the chained list, if any. This allows the conditional check which resets the indicies for the chained list to be

Re: [PATCH v4 10/43] hpsa: do not ignore return value of hpsa_register_scsi

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com add error handling for failure when registering with SCSI subsystem. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace

Re: [PATCH v4 31/43] hpsa: call pci_release_regions after pci_disable_device

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Despite the fact that PCI devices are enabled in this order: 1. pci_enable_device 2. pci_request_regions Documentation/PCI/pci.txt specifies that they be undone in this order 1.

Re: [PATCH v4 12/43] hpsa: factor out hpsa_ioaccel_submit function

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Webb Scales web...@hp.com clean up command submission Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com

Re: [PATCH v4 27/43] hpsa: use helper routines for finishing commands

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com cleanup command completions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com

Re: [PATCH v4 26/43] hpsa: add support sending aborts to physical devices via the ioaccel2 path

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com add support for tmf when in ioaccel2 mode Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com Signed-off-by:

Re: [PATCH v4 31/43] hpsa: call pci_release_regions after pci_disable_device

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Despite the fact that PCI devices are enabled in this order: 1. pci_enable_device 2. pci_request_regions Documentation/PCI/pci.txt specifies that they be undone in this order 1.

Re: [PATCH v4 23/43] hpsa: clean up driver init

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Improve initialization error handling in hpsa_init_one Clean up style and indent issues Rename functions for consistency Improve error messaging on allocations Fix return status from

Re: [PATCH v4 24/43] hpsa: clean up some error reporting output in abort handler

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com report more useful information on aborts Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace

Re: [PATCH v4 30/43] hpsa: performance tweak for hpsa_scatter_gather()

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com Divide the loop in hpsa_scatter_gather() into two, one for the initial SG list and a second one for the chained list, if any. This allows the conditional check which resets the indicies for the chained list to be

Re: [PATCH v4 28/43] hpsa: don't return abort request until target is complete

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com Don't return from the abort request until the target command is complete. Mark outstanding commands which have a pending abort, and do not send them to the host if we can avoid it. If the current command has been

Re: [PATCH v4 33/43] hpsa: cleanup for init_one step 2 in kdump

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com In hpsa_undo_allocations_after_kdump_soft_reset, the things allocated in hpsa_init_one step 2 - h-resubmit_wq and h-lockup_detected need to be freed, in the right order. Reviewed-by: Scott Teel

Re: [PATCH v4 29/43] hpsa: refactor and rework support for sending TEST_UNIT_READY

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com Factor out the code which sends the TEST_UNIT_READY from wait_for_device_to_become_ready() into its own function. Move the code which waits for the TEST_UNIT_READY from wait_for_device_to_become_ready() into its own

Re: [PATCH v4 25/43] hpsa: do not print ioaccel2 warning messages about unusual completions.

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com The SCSI midlayer already prints more detail about completions, and has logging level options to filter them if not wanted. These just slow down the system if a lot of errors occur, stressing error handling even

Re: [PATCH v4 22/43] hpsa: correct return values from driver functions.

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com correct return codes for error conditions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace

Re: [PATCH v4 41/43] hpsa: change driver version

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: update driver version Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: BUG: unable to handle kernel NULL pointer deref, bisected to 746650160

2015-04-17 Thread Torsten Luettgert
On Fri, 17 Apr 2015 15:31:16 +0200 Torsten Luettgert ml-l...@enda.eu wrote: On Mon, 13 Apr 2015 20:28:29 +0200 Torsten Luettgert ml-l...@enda.eu wrote: Right now, I'm trying the problematic release, compiled with a newer gcc (4.9.2-6 from Fedora, while using 4.4.7-11 from rhel6 before). It

Re: [PATCH v4 02/43] hpsa: clean up host, channel, target, lun prints

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:46 PM, Don Brace wrote: From: Webb Scales web...@hp.com We had a mix of formats used for specifying controller, bus, target, and lun address of devices. change to the format used by the scsi midlayer and upper layer (2:3:0:0) so you can easily follow the information from

Re: [PATCH v4 21/43] hpsa: do not check cmd_alloc return value - it cannnot return NULL

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com cmd_alloc can no longer return NULL, so don't check for NULL any more (which is unreachable code). Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by:

Re: [PATCH v4 05/43] hpsa: decrement h-commands_outstanding in fail_all_outstanding_cmds

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com make tracking of outstanding commands more robust Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com ---

Re: [PATCH v4 25/43] hpsa: do not print ioaccel2 warning messages about unusual completions.

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com The SCSI midlayer already prints more detail about completions, and has logging level options to filter them if not wanted. These just slow down the system if a lot of errors occur, stressing error handling even

Re: [PATCH v4 04/43] hpsa: clean up aborts

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com Do not send aborts to logical devices that do not support aborts Instead of relying on what the Smart Array claims for supporting logical drives, simply try an abort and see how it responds at device

Re: [PATCH v4 23/43] hpsa: clean up driver init

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Improve initialization error handling in hpsa_init_one Clean up style and indent issues Rename functions for consistency Improve error messaging on allocations Fix return status from

Re: [PATCH v4 06/43] hpsa: hpsa decode sense data for io and tmf

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com In hba mode, we could get sense data in descriptor format so we need to handle that. It's possible for CommandStatus to have value 0x0D TMF Function Status, which we should handle. We will get this

Re: [PATCH v4 07/43] hpsa: allow lockup detected to be viewed via sysfs

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com expose a detected lockup via sysfs Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl

Re: [PATCH v4 08/43] hpsa: make function names consistent

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com make function names more consistent and meaningful Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don

Re: [PATCH v4 27/43] hpsa: use helper routines for finishing commands

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com cleanup command completions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com ---

Re: [PATCH v4 28/43] hpsa: don't return abort request until target is complete

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Webb Scales web...@hp.com Don't return from the abort request until the target command is complete. Mark outstanding commands which have a pending abort, and do not send them to the host if we can avoid it. If the current command has been

Re: [PATCH v4 14/43] hpsa: use ioaccel2 path to submit IOs to physical drives in HBA mode.

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Joe Handzik joseph.t.hand...@hp.com use ioaccel2 path to submit I/O to physical drives in HBA mode Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com

Re: [PATCH v4 34/43] hpsa: fix try_soft_reset error handling

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com If registering the special interrupt handlers in hpsa_init_one before a soft reset fails, the error exit needs to deallocate everything that was allocated before. Reviewed-by: Scott Teel scott.t...@pmcs.com

Re: [PATCH v4 15/43] hpsa: Get queue depth from identify physical bmic for physical disks.

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Joe Handzik joseph.t.hand...@hp.com get drive queue depth to help avoid task set full conditions. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com

Re: [PATCH v4 33/43] hpsa: cleanup for init_one step 2 in kdump

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com In hpsa_undo_allocations_after_kdump_soft_reset, the things allocated in hpsa_init_one step 2 - h-resubmit_wq and h-lockup_detected need to be freed, in the right order. Reviewed-by: Scott Teel

Re: [PATCH v4 32/43] hpsa: skip free_irq calls if irqs are not allocated

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com If try_soft_reset fails to re-allocate irqs, the error exit starts with free_irq calls, which generate kernel WARN messages since they were already freed a few lines earlier. Jump to the next exit label to skip

Re: [PATCH v4 16/43] hpsa: break hpsa_free_irqs_and_disable_msix into two functions

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com replace calls to hpsa_free_irqs_and_disable_msix with hpsa_free_irqs and hpsa_disable_interrupt_mode Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by:

Re: [PATCH v4 17/43] hpsa: clean up error handling

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com refactor error cleanup and shutdown disable interrupts and pci_disable_device on critical failures add hpsa_free_cfgtables function Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett

Re: [PATCH v4 35/43] hpsa: create workqueue after the driver is ready for use

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Don't create the resubmit workqueue in hpsa_init_one until everything else is ready to use, so everything can be freed in reverse order of when they were allocated without risking freeing things while workqueue

Re: [PATCH v4 34/43] hpsa: fix try_soft_reset error handling

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com If registering the special interrupt handlers in hpsa_init_one before a soft reset fails, the error exit needs to deallocate everything that was allocated before. Reviewed-by: Scott Teel scott.t...@pmcs.com

Re: [PATCH v4 41/43] hpsa: change driver version

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:50 PM, Don Brace wrote: update driver version Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list: send

Re: [PATCH v4 32/43] hpsa: skip free_irq calls if irqs are not allocated

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com If try_soft_reset fails to re-allocate irqs, the error exit starts with free_irq calls, which generate kernel WARN messages since they were already freed a few lines earlier. Jump to the next exit label to skip the

Re: [PATCH v4 39/43] hpsa: propagate the error code in hpsa_kdump_soft_reset

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:50 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset should propagate its return value (e.g., -ENODEV) rather than just returning -1. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett

Re: [PATCH v4 43/43] hpsa: add in new controller id

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:50 PM, Don Brace wrote: add in support for latest PMC controller Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

Re: [PATCH v4 43/43] hpsa: add in new controller id

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: add in support for latest PMC controller Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5fc4118..910d748 100644 ---

Re: [PATCH v4 40/43] hpsa: cleanup reset

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:50 PM, Don Brace wrote: From: Webb Scales web...@hp.com Synchronize completion the reset with completion of outstanding commands Extending the newly-added synchronous abort functionality, now also synchronize resets with the completion of outstanding commands. Rename the

Re: [PATCH v4 09/43] hpsa: factor out hpsa_init_cmd function

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com Factor out hpsa_cmd_init from cmd_alloc(). We also need this for resubmitting commands down the default RAID path when they have returned from the ioaccel paths with errors. In particular, reinitialize

Re: [PATCH v4 13/43] hpsa: print accurate SSD Smart Path Enabled status

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:47 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com offload_enabled changes are deferred until after the added/updated prints occur, so the values are incorrect. defer printing SSD Smart Path Enabled status information until the information is correct Reviewed-by:

Re: [PATCH v4 38/43] hpsa: use scsi host_no as hpsa controller number

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:50 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Rather than numbering the hpsa controllers with an incrementing 0..n value (e.g., that shows up in /proc/interrupts), use the scsi midlayer host_no (e.g. matching /sys/class/scsi_host/hostNN). Reviewed-by: Scott

Re: [PATCH v4 36/43] hpsa: add interrupt number to /proc/interrupts interrupt name

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Add the interrupt number to the interrupt names that appear in /proc/interrupts, so they are unique Also, delete the IRQ and DAC prints. Other parts of the kernel already print the IRQ assignments, and

Re: [PATCH v4 37/43] hpsa: use block layer tag for command allocation

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:50 PM, Don Brace wrote: From: Webb Scales web...@hp.com Rework slave allocation: - separate the tagging support setup from the hostdata setup - make the hostdata setup act consistently when the lookup fails - make the hostdata setup act consistently when the device is

Re: [PATCH v4 42/43] hpsa: add PMC to copyright

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: need to add PMC to copyright notice and update the Hewlett-Packard copyright notification. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Justin Lindley justin.lind...@pmcs.com

Re: [PATCH v4 26/43] hpsa: add support sending aborts to physical devices via the ioaccel2 path

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:49 PM, Don Brace wrote: From: Stephen Cameron stephenmcame...@gmail.com add support for tmf when in ioaccel2 mode Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com

Re: [PATCH v4 35/43] hpsa: create workqueue after the driver is ready for use

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:49 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Don't create the resubmit workqueue in hpsa_init_one until everything else is ready to use, so everything can be freed in reverse order of when they were allocated without risking freeing things while workqueue items

Re: [PATCH v4 40/43] hpsa: cleanup reset

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: From: Webb Scales web...@hp.com Synchronize completion the reset with completion of outstanding commands Extending the newly-added synchronous abort functionality, now also synchronize resets with the completion of outstanding commands. Rename the

ahci Port to Host interrupt as edge trigger

2015-04-17 Thread Suman Tripathi
Hi , I need some suggestion . From the below interrupt handler in libahci.c it explains that the interrupt from port to Host is level triggered. Do we have any existing implementation that handles the port to Host as Edge triggered. static irqreturn_t ahci_single_irq_intr(int irq, void

RE: [PATCH 6/7] be2iscsi: Logout of FW Boot Session

2015-04-17 Thread Sony John-N
-Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Friday, April 17, 2015 1:39 AM To: Sony John-N; linux-scsi@vger.kernel.org Cc: Jayamohan Kallickal Subject: Re: [PATCH 6/7] be2iscsi: Logout of FW Boot Session On 04/16/2015 02:52 PM, Mike Christie wrote: On

Re: [PATCH v4 38/43] hpsa: use scsi host_no as hpsa controller number

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com Rather than numbering the hpsa controllers with an incrementing 0..n value (e.g., that shows up in /proc/interrupts), use the scsi midlayer host_no (e.g. matching /sys/class/scsi_host/hostNN). Reviewed-by: Scott

Re: [PATCH v4 39/43] hpsa: propagate the error code in hpsa_kdump_soft_reset

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset should propagate its return value (e.g., -ENODEV) rather than just returning -1. Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett

Re: [PATCH v4 37/43] hpsa: use block layer tag for command allocation

2015-04-17 Thread Hannes Reinecke
On 04/16/2015 03:50 PM, Don Brace wrote: From: Webb Scales web...@hp.com Rework slave allocation: - separate the tagging support setup from the hostdata setup - make the hostdata setup act consistently when the lookup fails - make the hostdata setup act consistently when the device is

Re: [PATCH v4 21/43] hpsa: do not check cmd_alloc return value - it cannnot return NULL

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com cmd_alloc can no longer return NULL, so don't check for NULL any more (which is unreachable code). Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by:

Re: [PATCH v4 22/43] hpsa: correct return values from driver functions.

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com correct return codes for error conditions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace

Re: [PATCH v4 18/43] hpsa: refactor freeing of resources into more logical functions

2015-04-17 Thread Tomas Henzl
On 04/16/2015 03:48 PM, Don Brace wrote: From: Robert Elliott elli...@hp.com refactor freeing of resources into more logical functions Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by:

Re: ahci Port to Host interrupt as edge trigger

2015-04-17 Thread Suman Tripathi
Hi , I need some suggestion . From the below interrupt handler in libahci.c it explains that the interrupt from port to Host is level triggered. Do we have any existing implementation that handles the port to Host as Edge triggered. Not that I know of but if it works as a edge triggered

[PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread Christoph Hellwig
This patch changes the !blk-mq path to the same defaults as the blk-mq I/O path by always enabling block tagging, and always using host wide tags. We've had blk-mq available for a few releases so bugs with this mode should have been ironed out, and this ensures we get better coverage of over

RFC: struct request cleanups

2015-04-17 Thread Christoph Hellwig
The first 5 patches move the magic IDE request types into the old IDE driver to keep the core block code clean of them. Those are basically ready to merge, just like the 6th one which is a cleanup on it's own. The real RFC is the last one which allocates the block_pc specific data separately in

[PATCH 1/7] block: rename REQ_TYPE_SPECIAL to REQ_TYPE_DRV_PRIV

2015-04-17 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/block/nbd.c| 2 +- drivers/block/paride/pd.c | 4 ++-- drivers/block/sx8.c| 4 ++-- drivers/block/virtio_blk.c | 6 +++--- drivers/ide/ide-atapi.c| 4 ++-- drivers/ide/ide-cd.c | 2 +- drivers/ide/ide-cd_ioctl.c |

[PATCH 7/7] block: allocate block_pc data separate from struct request

2015-04-17 Thread Christoph Hellwig
Don't bloat struct request with BLOCK_PC specific fields. WIP, breaks dm BLOCK_PC passthrough and the old IDE driver for now. --- block/blk-core.c| 23 ++--- block/blk-exec.c| 17 --- block/blk-mq.c | 4

[PATCH 4/7] block: remove REQ_TYPE_PM_SHUTDOWN

2015-04-17 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- include/linux/blkdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 6076b9e..c2829ba 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -77,7 +77,6 @@ enum

[PATCH 5/7] block: move PM request support to IDE

2015-04-17 Thread Christoph Hellwig
This removes the request types and hacks from the block code and into the old IDE driver. There is a small amunt of code duplication due to this, but it's not too bad. Signed-off-by: Christoph Hellwig h...@lst.de --- block/blk-core.c | 1 + block/blk-exec.c | 10 -

[PATCH 3/7] block: move REQ_TYPE_SENSE to the ide driver

2015-04-17 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/ide/ide-atapi.c | 6 +++--- drivers/ide/ide-cd.c | 8 drivers/ide/ide-floppy.c | 2 +- drivers/ide/ide-tape.c | 2 +- include/linux/blkdev.h | 1 - include/linux/ide.h | 1 + 6 files changed, 10 insertions(+), 10

[PATCH 6/7] nbd: stop using req-cmd

2015-04-17 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/block/nbd.c | 48 +++- include/uapi/linux/nbd.h | 2 -- 2 files changed, 23 insertions(+), 27 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 9cf52ac..83a7ba4

[PATCH 2/7] block: move REQ_TYPE_ATA_TASKFILE and REQ_TYPE_ATA_PC to ide.h

2015-04-17 Thread Christoph Hellwig
These values are only used by the IDE driver, so move them into it by allowing drivers to take cmd_type values after the first private one. Note that we have to turn cmd_type into a plain unsigned integer so that gcc doesn't complain about mismatching enum types. Signed-off-by: Christoph Hellwig

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread Jens Axboe
On 04/17/2015 03:57 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: On 04/17/2015 03:46 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: On 04/17/2015 03:42 PM, James Bottomley wrote: @@ -662,32 +662,14 @@ void

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 22:11 +0200, Christoph Hellwig wrote: diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index 82abfce..941a424 100644 --- a/drivers/scsi/53c700.c +++ b/drivers/scsi/53c700.c @@ -325,7 +325,6 @@ NCR_700_detect(struct scsi_host_template *tpnt,

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: On 04/17/2015 03:46 PM, James Bottomley wrote: On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: On 04/17/2015 03:42 PM, James Bottomley wrote: @@ -662,32 +662,14 @@ void scsi_finish_command(struct scsi_cmnd *cmd) */ int

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread Jens Axboe
On 04/17/2015 02:11 PM, Christoph Hellwig wrote: This patch changes the !blk-mq path to the same defaults as the blk-mq I/O path by always enabling block tagging, and always using host wide tags. We've had blk-mq available for a few releases so bugs with this mode should have been ironed out,

  1   2   >