>-Original Message-
>From: Tomas Henzl [mailto:the...@redhat.com]
>Sent: Thursday, June 11, 2015 7:26 PM
>To: sumit.sax...@avagotech.com; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; h...@infradead.org;
>jbottom...@parallels.com; kashyap.de...@avagotech.com
>Subject: Re: [PAT
On 05/22/2015 11:15 AM, Johannes Thumshirn wrote:
> In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap
> returns without doing an iounmap() of mvi->regs_ex.
>
> Found by the cocinelle tool.
>
> Signed-off-by: Johannes Thumshirn
> ---
> drivers/scsi/mvsas/mv_init.c | 5 ++
On 06/11/2015 05:07 PM, Ewan Milne wrote:
> On Thu, 2015-06-11 at 13:01 +0200, Hannes Reinecke wrote:
>> The 'sd' driver is calling scsi_mode_sense() to figure out
>> internal details. But scsi_mode_sense() never checks for
>> any pending unit attentions, so we're getting annoying error
>> messages
Make sure we have the host lock held when calling scsi_report_bus_reset. Fixes
a crash seen as the __devices list in the scsi host was changing as we were
iterating through it.
Cc:
Signed-off-by: Brian King
---
drivers/scsi/ipr.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletio
From: Wen Xiong
On LE system, users see the wrong device_id attribute. This patch
does necessary byte swapping for device_id attribute and works on
both of LE and BE systems.
Signed-off-by: Wen Xiong
Signed-off-by: Brian King
---
drivers/scsi/ipr.c |2 +-
1 file changed, 1 insertion(+),
Bump driver version.
Signed-off-by: Brian King
---
drivers/scsi/ipr.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/scsi/ipr.h~ipr_version_2_6_2 drivers/scsi/ipr.h
--- linux/drivers/scsi/ipr.h~ipr_version_2_6_2 2015-06-11 20:11:35.110136508
-0500
+++ linux-b
Some misc fixes for endianness checking with sparse so sparse with
endian checking now runs clean. Fixes a minor bug in the process
which was uncovered by sparse which would result in unnecessary
error recovery for check conditions.
Signed-off-by: Brian King
---
drivers/scsi/ipr.c | 13 +
Resources allocated within bfad_im_port_index idr are not deallocated
on module unload. The patch adds idr_destroy() in exit function.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/scsi/bfa/bfad_im.c | 2 ++
1 file changed, 2 insert
On 06/09/2015 05:15 PM, Matthew R. Ochs wrote:
> SCSI device driver to support filesystem access on the IBM CXL Flash adapter.
>
> Supported-by: Stephen Bates
> Reviewed-by: Michael Neuling
> Signed-off-by: Matthew R. Ochs
> Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Hi James,
Th
On 06/11/2015 02:32 PM, Josh Boyer wrote:
> On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar wrote:
>> The driver is missing calls to pci_dma_mapping_error() after
>> performing the DMA mapping, which caused DMA-API warning to
>> show up in dmesg's output. Though that happens only when
>> DMA_API_DEB
Hello Johannes,
My comments are inline.
Thanks,
-Raj P.
-Original Message-
From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
Sent: Thursday, June 11, 2015 3:02 AM
To: Rajinikanth Pandurangan
Cc: jbottom...@parallels.com; linux-scsi@vger.kernel.org;
aacr...@pmc-sierra.com; Harry Yang
On Thu, 2015-06-11 at 13:01 +0200, Hannes Reinecke wrote:
> The 'sd' driver is calling scsi_mode_sense() to figure out
> internal details. But scsi_mode_sense() never checks for
> any pending unit attentions, so we're getting annoying error
> messages like:
>
> MODE SENSE: unimplemented page/subpa
On Thu, 2015-06-11 at 13:07 +0200, Hannes Reinecke wrote:
> Log the ALUA state change unit attention correctly with
> the message log and emit an event to allow user-space
> tools to react to it.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/scsi_error.c | 4
> drivers/scsi/scsi_
On 06/10/15 22:56, Hannes Reinecke wrote:
Actually, I've been thinking about this. Currently I'm not sure if
we should fully embrace this route; after all, 'scsilun_to_int' is
meant to be a conversion from the (abstract) LUN number into our
internal representation.
And as it's internal we're free
On 06/10/2015 12:22 PM, sumit.sax...@avagotech.com wrote:
Here should be an explanation why is this needed.
The driver knows the fw version and can adapt to it.
When sending the version to firmware fails, the driver
just logs it and is able to continue.
Why is the information needed for the fw ?
On Thu, 2015-06-11 at 08:32 -0400, Josh Boyer wrote:
> On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar wrote:
> > The driver is missing calls to pci_dma_mapping_error() after
> > performing the DMA mapping, which caused DMA-API warning to
> > show up in dmesg's output. Though that happens only when
On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar wrote:
> The driver is missing calls to pci_dma_mapping_error() after
> performing the DMA mapping, which caused DMA-API warning to
> show up in dmesg's output. Though that happens only when
> DMA_API_DEBUG option is enabled. This change fixes the issu
Log the ALUA state change unit attention correctly with
the message log and emit an event to allow user-space
tools to react to it.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 4
drivers/scsi/scsi_lib.c| 4
include/scsi/scsi_device.h | 1 +
3 files changed, 9 in
The 'sd' driver is calling scsi_mode_sense() to figure out
internal details. But scsi_mode_sense() never checks for
any pending unit attentions, so we're getting annoying error
messages like:
MODE SENSE: unimplemented page/subpage: 0x00/0x00
and a possible wrong decision for device cache handling
On Wed, Jun 10, 2015 at 06:42:26PM -0700, rajinikanth.panduran...@pmcs.com
wrote:
> From: Rajinikanth Pandurangan
>
> Description:
> If writeq() not supported, then do atomic two 32bit write
>
> Signed-off-by: Rajinikanth Pandurangan
> ---
> drivers/scsi/aacraid/aacraid.h | 9 ++
We need to use 'se_dev_entry' as argument when allocating
UAs, otherwise we'll never see any UAs for an implicit
ALUA state transition triggered from userspace.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_alua.c | 27 ++-
drivers/target/target_core_
When switching target port group ALUA states we need to send
one UA when setting the ALUA state to 'transitioning', and
another one once the final state has been set.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_alua.c | 22 --
1 file changed, 16 insertions(+
SAM mandates that an BUS DEVICE RESET FUNCTION OCCURRED
UA needs to be send after a LUN RESET tmr has completed.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_transport.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/target/target_core_transport.c
b/dr
When the ALUA target port group changes an INQUIRY DATA CHANGE
UA needs to be sent.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_alua.c | 7 +++
drivers/target/target_core_ua.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/target/target_core_alua.c
b/driv
Unused.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_ua.c | 1 -
include/target/target_core_base.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/target/target_core_ua.c b/drivers/target/target_core_ua.c
index e53d4ee..e506224 100644
--- a/drivers/target/target_c
Hi Nic,
lio-target is very minimalistic when it comes to generate UAs;
primarily they are generated for persistent reservations, but
generic changes tend to be ignored.
This patchset updates the UA handling and generates UA for internal
state changes (REPORTED LUNS DATA CHANGED, INQUIRY DATA CHAN
When changind the LUN inventory via core_enable_device_list_for_node()
or core_disable_device_list_for_node() a REPORTED LUNS DATA HAS CHANGED
UA should be send.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_device.c | 26 +-
drivers/target/target_core_ua.
27 matches
Mail list logo
