Re: [PATCHv2] sd: retry READ CAPACITY for ALUA state transition

2015-07-07 Thread Hannes Reinecke
On 07/06/2015 10:57 PM, James Bottomley wrote: On Mon, 2015-07-06 at 08:13 -0700, Bart Van Assche wrote: On 07/06/2015 04:12 AM, Hannes Reinecke wrote: During ALUA state transitions the device might return a sense code 02/04/0a (Logical unit not accessible, asymmetric access state

Re: [PATCH v3 0/5] Target sense data handling modifications

2015-07-07 Thread Sagi Grimberg
On 7/7/2015 1:51 AM, Nicholas A. Bellinger wrote: On Mon, 2015-07-06 at 16:15 +0300, Sagi Grimberg wrote: This patch set modifies the target sense data handling. First, cleanup transport_send_check_condition_and_sense() by splitting the sense translation to a separate function. Second, convert

Re: [PATCH 0/8] tcm_loop updates

2015-07-07 Thread Nicholas A. Bellinger
On Tue, 2015-07-07 at 07:50 +0200, Hannes Reinecke wrote: On 07/07/2015 02:25 AM, Nicholas A. Bellinger wrote: On Tue, 2015-06-23 at 11:05 +0200, Hannes Reinecke wrote: On 06/23/2015 10:29 AM, Nicholas A. Bellinger wrote: SNIP How different do you expect sas, fc, and iscsi transports to

Re: [PATCH 0/8] tcm_loop updates

2015-07-07 Thread Hannes Reinecke
On 07/07/2015 08:26 AM, Nicholas A. Bellinger wrote: On Tue, 2015-07-07 at 07:50 +0200, Hannes Reinecke wrote: On 07/07/2015 02:25 AM, Nicholas A. Bellinger wrote: On Tue, 2015-06-23 at 11:05 +0200, Hannes Reinecke wrote: On 06/23/2015 10:29 AM, Nicholas A. Bellinger wrote: SNIP How

[PATCH RESEND] mvsas: always iounmap resources

2015-07-07 Thread Johannes Thumshirn
In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap returns without doing an iounmap() of mvi-regs_ex. Found by the cocinelle tool. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de Reviewed-by: Hannes Reinecke h...@suse.de --- drivers/scsi/mvsas/mv_init.c | 5 - 1

[PATCH] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-07-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a regression introduced with the following commit in v4.0-rc1 code: commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca Author: Nicholas Bellinger n...@linux-iscsi.org Date: Thu Feb 26 22:19:15 2015 -0800

Re: [PATCH] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-07-07 Thread Nicholas A. Bellinger
Hey Sagi, This addresses a regression with traditional iscsi-target that I noticed recently, but has not been tested with iser-target yet. Would you mind taking a quick spin with iser-target to verify, and try to intentionally fail iscsit_start_kthreads() into the two out_bitmap + out_tx error

Re: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-07 Thread Jean Delvare
Hi Kashyap, On Thu, 28 May 2015 19:05:35 +0530, Kashyap Desai wrote: Bjorn/Robin, Apologies for delay. Here is one quick suggestion as we have seen similar issue (not exactly similar, but high probably to have same issue) while controller is configured on VM as pass-through and VM reboot

[PATCH] hpsa: non-zero LUNs of multi-LUN devices missing on some Smart Arrays

2015-07-07 Thread Seymour, Shane M
A regression was introduced into the hpsa driver a while back so non-zero LUNs of multi-LUN devices may no longer be presented via a SAS based Smart Array. I have not done a bisection to discover the change that caused it. The CISS firmware specification (available on sourceforge) defines an 8

Re: [PATCH] [SCSI] FlashPoint: optimize string comparison

2015-07-07 Thread Frans Klaver
On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Stop comparing the strings as soon as we know that they don't match. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr --- drivers/scsi/FlashPoint.c | 4 +++- 1 file changed, 3

lockdep complains on possible circular locking dependency when deleting an iscsi device

2015-07-07 Thread Sagi Grimberg
Hi, I recently came across a lockdep complaint on a possible deadlock that I don't understand yet (log output below). Has anyone seen this? Any insights on why exactly is lockdep complaining? The reproducer is very easy (reproduced both with tcp and iser): - login to a target with one or more

RE: [PATCH] megaraid:Remove no longer required variable ret from the function megasas_sync_map_info

2015-07-07 Thread Sumit Saxena
-Original Message- From: Nicholas Krause [mailto:xerofo...@gmail.com] Sent: Monday, July 06, 2015 9:43 PM To: kashyap.de...@avagotech.com Cc: sumit.sax...@avagotech.com; uday.ling...@avagotech.com; jbottom...@odin.com; megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org;

Re: [PATCH 0/8] tcm_loop updates

2015-07-07 Thread Nicholas A. Bellinger
On Tue, 2015-07-07 at 08:29 +0200, Hannes Reinecke wrote: On 07/07/2015 08:26 AM, Nicholas A. Bellinger wrote: On Tue, 2015-07-07 at 07:50 +0200, Hannes Reinecke wrote: On 07/07/2015 02:25 AM, Nicholas A. Bellinger wrote: On Tue, 2015-06-23 at 11:05 +0200, Hannes Reinecke wrote: On

Re: [PATCH 09/11] qla2xxx: Added interface to send ELS commands from driver.

2015-07-07 Thread James Bottomley
On Fri, 2015-07-03 at 09:14 -0700, Christoph Hellwig wrote: Why is this a binary attribute? Needs an interface specific in Documentation/ABI/ to start with, and a Ccto stable seems very aggressive. Right, adding an interface isn't a bug fix. Can you separate this into patches which are

Re: [PATCH v3 0/5] Target sense data handling modifications

2015-07-07 Thread Nicholas A. Bellinger
On Tue, 2015-07-07 at 09:18 +0300, Sagi Grimberg wrote: On 7/7/2015 1:51 AM, Nicholas A. Bellinger wrote: On Mon, 2015-07-06 at 16:15 +0300, Sagi Grimberg wrote: This patch set modifies the target sense data handling. First, cleanup transport_send_check_condition_and_sense() by splitting

Re: [PATCH] [SCSI] FlashPoint: optimize string comparison

2015-07-07 Thread Khalid Aziz
On 07/07/2015 02:45 AM, Frans Klaver wrote: On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Stop comparing the strings as soon as we know that they don't match. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr ---

Re: [PATCHv2] sd: retry READ CAPACITY for ALUA state transition

2015-07-07 Thread Bart Van Assche
On 07/06/2015 11:18 PM, Hannes Reinecke wrote: However, to handle the above case correctly we would need to keep track of the entire multipath topology, to figure out which devices belong to that relative target port and might need to be updated (there might be several paths in standby, and we

RE: [Pv-drivers] [PATCH] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-07-07 Thread Arvind Kumar
Hi James, Can you help get this patch in now as it has got a review? Thanks! Arvind From: Thomas Hellstrom Sent: Thursday, June 11, 2015 11:11 AM To: Josh Boyer; Arvind Kumar; James Bottomley Cc: VMware PV-Drivers; Linus Torvalds;

[PATCH v3 3/3] megaraid_sas : fix whitespace errors

2015-07-07 Thread Bjorn Helgaas
Fix whitespace and indentation errors. No code change. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/scsi/megaraid/megaraid_sas_base.c | 244 ++--- 1 file changed, 118 insertions(+), 126 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH v3 2/3] megaraid_sas : use dev_printk when possible

2015-07-07 Thread Bjorn Helgaas
Use dev_printk() when possible to make messages more useful. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/scsi/megaraid/megaraid_sas_base.c | 304 +-- drivers/scsi/megaraid/megaraid_sas_fusion.c | 95 2 files changed, 196 insertions(+), 203

[PATCH V3 07/10] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: Driver blocks ioctls once it received shutdown/suspend request during suspend/hybernation. This patch unblocks ioctls on resume path. Changes from V2: None Reviewed by: Mahesh Rajashekhara

[PATCH V3 05/10] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: If 'IsFastPath' bit is set, then response path assumes no error and skips error check. Changes from V2: None Reviewed By: Tomas Henzl the...@redhat.com, Mahesh Rajashekhara

[PATCH V3 09/10] [SCSI] aacraid: Update driver version

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Signed-off-by: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com --- drivers/scsi/aacraid/aacraid.h | 2 +- drivers/scsi/aacraid/linit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V3 06/10] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: Reset irq affinity hints before releasing IRQ Removed duplicate code of IRQ acquire/release Changes from V2: None Reviewed by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com, Johannes Thumshirn

[PATCH V3 08/10] [SCSI] aacraid: Send commit-config to controller firmware

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: Controller BIOS/UEFI driver used to send this request. But for IBM-Power system there is no BIOS/UEFI driver. So this change is required for IBM, otherwise controller will be read-only mode.

[PATCH V3 10/10] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_exact()

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: As pci_enable_msix() deprecated, replaced with pci_enable_msix_exact() Changes from V2: Newly created for V3 based on review comment. Signed-off-by: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com ---

[PATCH V3 02/10] [SCSI] aacraid: Add Power Management support

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: * .suspend() and .resume() routines implemented in the driver * aac_release_resources() initiates firmware shutdown * aac_acquire_resources re-initializes the host interface Changes from V2:

[PATCH V3 04/10] [SCSI] aacraid: Enable 64-bit write to controller register

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: If writeq() not supported, then do atomic two 32bit write Changes from V2: None Reviewed by: Tomas Henzl the...@redhat.com, Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com, Johannes Thumshirn

[PATCH V3 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: This change always sets MSI interrupt mode for series-6 controller. Note: For series 6 family, MSIx is not supported. Changes from V2: Only Subject description change. Reviewed by: Tomas Henzl

[PATCH V3 00/10] [SCSI] aacraid: Patchset for aacraid driver version 41010

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com This patchset includes the following changes (bug fixes and new feature support) specific to aacraid driver. V3: Increased msleep() time from 1 to 20. Created new patch for pci_enable_msix() replacement. Changed subject/description

[PATCH V3 01/10] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-07-07 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: Driver sends the right size of the response buffer. Changes from V2: None V2: Reviewed-by: Johannes Thumshirn jthumsh...@suse.de Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Mahesh Rajashekhara

Re: [PATCH] megaraid:Remove no longer required variable ret from the function megasas_sync_map_info

2015-07-07 Thread Frans Klaver
Can't seem to find the original, so here's a reply to the ack mail. On Tue, Jul 7, 2015 at 10:49 AM, Sumit Saxena sumit.sax...@avagotech.com wrote: -Original Message- From: Nicholas Krause [mailto:xerofo...@gmail.com] Sent: Monday, July 06, 2015 9:43 PM To: kashyap.de...@avagotech.com

Re: [PATCH] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-07-07 Thread Sagi Grimberg
On 7/7/2015 12:01 PM, Nicholas A. Bellinger wrote: Hey Sagi, This addresses a regression with traditional iscsi-target that I noticed recently, but has not been tested with iser-target yet. Would you mind taking a quick spin with iser-target to verify, and try to intentionally fail

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-07 Thread Kashyap Desai
-Original Message- From: Jean Delvare [mailto:jdelv...@suse.de] Sent: Tuesday, July 07, 2015 2:14 PM To: Kashyap Desai Cc: Bjorn Helgaas; Robin H. Johnson; Adam Radford; Neela Syam Kolli; linux- s...@vger.kernel.org; arkadiusz.bub...@open-e.com; Matthew Garrett; Sumit Saxena; Uday

RE: [PATCH] megaraid:Remove no longer required variable ret from the function megasas_sync_map_info

2015-07-07 Thread Sumit Saxena
-Original Message- From: Frans Klaver [mailto:franskla...@gmail.com] Sent: Tuesday, July 07, 2015 3:37 PM To: Sumit Saxena Cc: Nicholas Krause; Kashyap Desai; Uday Lingala; jbottom...@odin.com; PDL,MEGARAIDLINUX; linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re:

Re: blk-mq vs kmemleak

2015-07-07 Thread Catalin Marinas
On Fri, Jul 03, 2015 at 06:04:00PM +0100, Bart Van Assche wrote: On 07/03/15 09:11, Dave Jones wrote: After a fuzzing run recently, I noticed that the machine had oom'd, and killed everything, but there was still 3GB of memory still in use, that I couldn't even reclaim with

[Announce] sg3_utils-1.41 available

2015-07-07 Thread Douglas Gilbert
sg3_utils is a package of command line utilities for sending SCSI and some ATA commands to devices. This package targets the Linux 4, 3, 2.6 and 2.4 kernel series. It has ports to FreeBSD, Tru64, Solaris, and Windows (cygwin and MinGW). There is one new utility (sg_zone) and additions to many

Re: blk-mq vs kmemleak

2015-07-07 Thread Bart Van Assche
On 07/07/15 03:33, Catalin Marinas wrote: On Fri, Jul 03, 2015 at 06:04:00PM +0100, Bart Van Assche wrote: A few weeks ago I had noticed similar kmemleak reports. However, when I reran my test with kmemleak disabled memory usage was stable. See also

[PATCH] scsi: Use module_pci_driver

2015-07-07 Thread Vaishali Thakkar
Use module_pci_driver for drivers whose init and exit functions only register and unregister, respectively. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @a@ identifier f, x; @@ -static f(...) { return pci_register_driver(x); } @b depends

[PATCH] scsi: Use module_platform_driver

2015-07-07 Thread Vaishali Thakkar
Use module_platform_driver for drivers whose init and exit functions only register and unregister, respectively. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @a@ identifier f, x; @@ -static f(...) { return platform_driver_register(x); }

[PATCH v3 1/3] megaraid : use dev_printk when possible

2015-07-07 Thread Bjorn Helgaas
Use dev_printk() when possible to make messages more useful. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/scsi/megaraid.c | 140 ++- 1 file changed, 66 insertions(+), 74 deletions(-) diff --git a/drivers/scsi/megaraid.c

[PATCH v3 0/3] megaraid: use dev_printk() when possible

2015-07-07 Thread Bjorn Helgaas
The current megaraid driver messages are somewhat inconsistent, with different combinations of driver name and device address: megasas: 0x1000:0x005b:0x15d9:0x0690: bus 1:slot 0:func 0 megaraid_sas :01:00.0: megasas: FW restarted successfully from megasas_init_fw! megasas: Waiting for

[PATCH v1 Resend] mpt2sas: setpci reset kernel oops fix

2015-07-07 Thread Nagarajkumar Narayanan
Patch Description: In mpt2sas driver due to lack of synchronization between ioctl, BRM status access through sysfs, pci resource removal kernel oops happen as ioctl path and BRM status sysfs access path still tries to access the removed resources kernel: BUG: unable to handle kernel paging

Re: [PATCH] [SCSI] FlashPoint: optimize string comparison

2015-07-07 Thread Christophe JAILLET
Le 07/07/2015 19:04, Khalid Aziz a écrit : On 07/07/2015 02:45 AM, Frans Klaver wrote: On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Stop comparing the strings as soon as we know that they don't match. Signed-off-by: Christophe JAILLET

Re: [PATCH] scsi: storvsc: make INQUIRY response SPC-compliant

2015-07-07 Thread Vitaly Kuznetsov
KY Srinivasan k...@microsoft.com writes: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Friday, July 3, 2015 9:19 AM To: Vitaly Kuznetsov Cc: linux-scsi@vger.kernel.org; Long Li; KY Srinivasan; Haiyang Zhang; James E.J. Bottomley;