Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common

2015-07-10 Thread Hannes Reinecke
On 07/08/2015 05:23 PM, Sagi Grimberg wrote: On 7/8/2015 6:06 PM, Hannes Reinecke wrote: We're adding extra fields here, so we need to make sure to not overflow the buffer. You probably have to pass in the buffersize to avoid an overflow ... Yeah, I know, it's theoretical at the moment.

Re: [PATCH] lpfc: Destroy lpfc_hba_index IDR on module exit

2015-07-10 Thread Hannes Reinecke
On 07/08/2015 05:19 PM, Johannes Thumshirn wrote: Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL @ defines_module_init @ declarer name module_init, module_exit;

Re: [PATCH] st: Destroy st_index_idr on module exit

2015-07-10 Thread Hannes Reinecke
On 07/08/2015 05:24 PM, Johannes Thumshirn wrote: Destroy st_index_idr on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL @ defines_module_init @ declarer name module_init, module_exit;

Re: [PATCH] arcmsr: Fix a potential data corruption issue

2015-07-10 Thread Dan Carpenter
On Fri, Jul 10, 2015 at 07:18:10AM +0200, Christophe JAILLET wrote: Resetting rqbuffer or wqbuffer must be done within a critial section in order to avoir potential data corruption. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr --- I don't know the code well enough to say

Re: [PATCH] lpfc: Destroy lpfc_hba_index IDR on module exit

2015-07-10 Thread James Smart
Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 7/8/2015 11:19 AM, Johannes Thumshirn wrote: Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) SmPL @

Re: [PATCH] st: Destroy st_index_idr on module exit

2015-07-10 Thread Kai Mäkisara (Kolumbus)
On 8.7.2015, at 18.24, Johannes Thumshirn jthumsh...@suse.de wrote: Destroy st_index_idr on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez mcg...@suse.com) ... Signed-off-by: Johannes Thumshirn

Re: [RESEND][PATCH] lpfc: fix model description

2015-07-10 Thread James Smart
As mentioned previously, it's a nit, and not too meaningful, but fine. If not merged prior, we'll repost as part of an upcoming commit that cleans up sparse warnings. Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 7/6/2015 5:22 PM, Sebastian Herbszt wrote: Remove

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-10 Thread Jean Delvare
Hi Kashyap, Le Tuesday 07 July 2015 à 14:48 +0530, Kashyap Desai a écrit : -Original Message- From: Jean Delvare [mailto:jdelv...@suse.de] Sent: Tuesday, July 07, 2015 2:14 PM To: Kashyap Desai Cc: Bjorn Helgaas; Robin H. Johnson; Adam Radford; Neela Syam Kolli; linux-

Re: possible race condition for usb_stor_port_reset and usb_reset_and_verify_device

2015-07-10 Thread yoma sophian
hi Alan: 2015-05-27 22:40 GMT+08:00 Alan Stern st...@rowland.harvard.edu: On Wed, 27 May 2015, yoma sophian wrote: After reading the kernel power document, freezing-of-tasks.txt , can I get the below conclusion: if I put my thread in freezable, it will get frozen automatically whenever the

RE: megaraid_sas: FW in FAULT state!!, how to get more debug output? [BKO63661]

2015-07-10 Thread Kashyap Desai
I am about to commit the patch that was successfully tested by the customer on SLES 12, but I'm a bit confused. The upstream patch you referred to is: https://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?h=for- nextid=6431f5d7c6025f8b007af06ea090de308f7e6881 [SCSI]

Re: [PATCH 1/1] ipr: Fix incorrect trace indexing

2015-07-10 Thread wenxiong
Reviewed-by: Wen Xiong wenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: James, One more ipr patch to go on top of my previous series I sent. This one fixes a pretty nasty bug that can cause us to go writing in memory that is not ours. 8 When

Re: [PATCHv2 1/1] ipr: Fix invalid array indexing for HRRQ

2015-07-10 Thread wenxiong
Reviewed-by: Wen Xiong wenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: Updated version per comments from Jiri Slaby. Thanks! 8 Fixes another signed / unsigned array indexing bug in the ipr driver. Currently, when hrrq_index wraps, it becomes a

Re: [PATCHv2 1/1] ipr: Fix invalid array indexing for HRRQ

2015-07-10 Thread Gabriel Krisman Bertazi
Brian King brk...@linux.vnet.ibm.com writes: drivers/scsi/ipr.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Hi Brian, The changes look good to me. Please add Reviewed-by: Gabriel Krisman Bertazi kris...@linux.vnet.ibm.com Thanks, -- Gabriel Krisman Bertazi -- To

[PATCH] Fix kmalloc overflow in LPFC driver at large core count

2015-07-10 Thread ian mitchell
This patch allows the LPFC to start up without a fatal kernel bug based on an exceeded KMALLOC_MAX_SIZE and a too large NR_CPU-based maskbits field. The bug was based on the number of CPU cores in a system. Using the get_cpu_mask() function declared in kernel/cpu.c allows the driver to load on the

Re: possible race condition for usb_stor_port_reset and usb_reset_and_verify_device

2015-07-10 Thread Alan Stern
On Fri, 10 Jul 2015, yoma sophian wrote: hi Alan: 2015-05-27 22:40 GMT+08:00 Alan Stern st...@rowland.harvard.edu: On Wed, 27 May 2015, yoma sophian wrote: After reading the kernel power document, freezing-of-tasks.txt , can I get the below conclusion: if I put my thread in

Re: [PATCH v1] libiscsi: Fix iscsi_check_transport_timeouts possible infinite loop

2015-07-10 Thread Mike Christie
On 7/4/15, 6:08 AM, Sagi Grimberg wrote: From: Ariel Nahum ari...@mellanox.com Connection last_ping is not being updated when iscsi_send_nopout fails. Not updating the last_ping will cause firing a timer to a past time (last_ping + ping_tmo current_time) which triggers an infinite loop of

Re: [PATCH 1/1] ipr: Fix incorrect trace indexing

2015-07-10 Thread Gabriel Krisman Bertazi
Brian King brk...@linux.vnet.ibm.com writes: One more ipr patch to go on top of my previous series I sent. This one fixes a pretty nasty bug that can cause us to go writing in memory that is not ours. Please add: Reviewed-by: Gabriel Krisman Bertazi kris...@linux.vnet.ibm.com Thanks, --

Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-10 Thread Brian King
On 06/19/2015 05:37 PM, Matthew R. Ochs wrote: diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 76a7286..2773177 100644 --- a/drivers/scsi/cxlflash/main.c +++ b/drivers/scsi/cxlflash/main.c @@ -679,10 +679,13 @@ static struct scsi_host_template driver_template =