Re: [PATCH V3] fnic: check pci_map_single() return value

2015-08-12 Thread Johannes Thumshirn
Maurizio Lombardi writes: > the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG. > This is because the fnic driver doesn't check the return value of > pci_map_single(). > > [ 11.942770] scsi host12: fnic > [ 11.950811] [ cut here ] > [ 11.950818]

[PATCH] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-12 Thread Spencer Baugh
From: Roland Dreier REPORT LUNS should not fail just because the allocation length is less than 16. The relevant section of SPC-4 is: 4.2.5.6 Allocation length The ALLOCATION LENGTH field specifies the maximum number of bytes or blocks that an application client has allocated in the Data

Re: [PATCH][SCSI] hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer

2015-08-12 Thread linux
Dear James, Sorry, it's our mistake. And thank you for help us to fix it. If there is any question, please do not hesitate to let us know. Best Regards, HighPoint Linux Team Sender: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Send Time: 2015/8/13 4:15 Receiver: linux

RE: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

2015-08-12 Thread Mahesh Rajashekhara
As Tomas Henzl suggested, I have merged 10 and 11 of V5 into single patch (i.e 9 of V6) Changes from V5: Applied driver update change at the end. Merged 10 and 11 of V5 into 9 of V6. AAC_MAX_MSIX definition change. aac_msi option description and subject change. Thanks, Mahesh -Original Mess

[PATCH v5 2/3] cxlflash: Superpipe support

2015-08-12 Thread Matthew R. Ochs
Add superpipe supporting infrastructure to device driver for the IBM CXL Flash adapter. This patch allows userspace applications to take advantage of the accelerated I/O features that this adapter provides and bypass the traditional filesystem stack. Signed-off-by: Matthew R. Ochs Signed-off-by:

[PATCH v5 3/3] cxlflash: Virtual LUN support

2015-08-12 Thread Matthew R. Ochs
Add support for physical LUN segmentation (virtual LUNs) to device driver supporting the IBM CXL Flash adapter. This patch allows user space applications to virtually segment a physical LUN into N virtual LUNs, taking advantage of the translation features provided by this adapter. Signed-off-by: M

[PATCH v5 1/3] cxlflash: Base error recovery support

2015-08-12 Thread Matthew R. Ochs
Introduce support for enhanced I/O error handling. A device state is added to track 3 possible states of the device: Normal - the device is operating normally and is fully operational Limbo - the device is in a reset/recovery scenario and its operational status is paused Failed/terminat

[PATCH v5 0/3] CXL Flash Error Recovery and Superpipe

2015-08-12 Thread Matthew R. Ochs
This patch set is intended for the 4.3 release and adds support for error recovery and the superpipe features provided by the IBM CXL Flash adapter. The superpipe function was originally presented in an RFC patch set in late April. To aid with the review of the superpipe portion of these enhancemen

Re: [PATCH][SCSI] hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer

2015-08-12 Thread James Bottomley
On Fri, 2015-07-10 at 14:18 +0800, linux wrote: > Hi, > >We found that the updated hptiop driver (version v1.10.0) was not embedded > into kernel 4.2 RC1, is there something wrong with the submitted patch or > when would the patch be accepted? > >If there is any question, please do no

Re: [PATCH v4 3/3] cxlflash: Virtual LUN support

2015-08-12 Thread Manoj Kumar
Mikey: Comments inline below. - Manoj Kumar On 8/11/2015 10:24 PM, Michael Neuling wrote: The ioctls have a standard header structure, with version etc. that are sanity checked before we get here. The other fields are sanity checked where they are used, i.e. in get_context(). That was my po

RE: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

2015-08-12 Thread Harry Yang
Hi James, Just FYI Raj is no longer with PMC-Sierra. Whatever patches he was handling is now taken over by Mahesh who has also been on associated email threads. Hi Mahesh, Please follow up. Regards, Harry -Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartne

Re: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

2015-08-12 Thread James Bottomley
> On 22.7.2015 18:49, rajinikanth.panduran...@pmcs.com wrote: > > From: Rajinikanth Pandurangan > > > > Description: > > In MSIx mode, we need at least 2 vectors. > > > > Changes from V4: > > Newly created for V5 based on review comment. > > > > Signed-off-by: Rajinikanth Pandura

Re: [PATCH] libiscsi: Fix host busy blocking during connection teardown

2015-08-12 Thread James Bottomley
On Wed, 2015-08-12 at 10:10 -0700, Chris Leech wrote: > Bump. > > We've done some testing, and this does prevent a deadlock that can be > triggered with a session logout while other sessions on the same HBA > are under high IO load. I'd be nice to see this merged. so now it needs a tag for stabl

Re: [PATCH] libiscsi: Fix host busy blocking during connection teardown

2015-08-12 Thread Chris Leech
Bump. We've done some testing, and this does prevent a deadlock that can be triggered with a session logout while other sessions on the same HBA are under high IO load. I'd be nice to see this merged. - Chris On Tue, Jun 23, 2015 at 6:11 PM, John Soni Jose wrote: > Issue: > In case of hw isc

Re: [PATCH v4 2/3] cxlflash: Superpipe support

2015-08-12 Thread Matthew R. Ochs
> On Aug 11, 2015, at 10:54 PM, Michael Neuling wrote: > > + pr_debug("%s: Wait for user context to quiesce...\n", __func__); + wake_up_all(&cfg->limbo_waitq); + ssleep(1); >>> >>> Why 1 sec and why in a loop? Can’t you poll/wait for completion somewhe

Re: [PATCH v4 2/3] cxlflash: Superpipe support

2015-08-12 Thread Matthew R. Ochs
Hi Wendy, Thanks for reviewing. Comments inline below. -matt > On Aug 11, 2015, at 11:18 PM, wenxi...@linux.vnet.ibm.com wrote: > Quoting "Matthew R. Ochs" : >> +struct ctx_info *get_context(struct cxlflash_cfg *cfg, u64 rctxid, >> + void *arg, enum ctx_ctrl ctx_ctrl) >>

Re: [PATCH v4 1/3] cxlflash: Base error recovery support

2015-08-12 Thread Matthew R. Ochs
Hi Wendy, Thanks for reviewing. Comments inline below. -matt > On Aug 11, 2015, at 11:15 PM, wenxi...@linux.vnet.ibm.com wrote: > > > Quoting "Matthew R. Ochs" : > >> Introduce support for enhanced I/O error handling. >> >> Signed-off-by: Matthew R. Ochs >> Signed-off-by: Manoj N. Kumar >

Re: threads scsi_eh_ and scsi_tmf_ don't die when ib_srp reconnect

2015-08-12 Thread Bart Van Assche
On 08/11/2015 10:15 PM, Konstantin Krotov wrote: > 11.08.2015 23:28, Bart Van Assche пишет: >> Are you using a kernel from Greg KH's stable repository or another kernel ? >> And to which values were the > yes, sources from upstream, 3.19.1 Hello Konstantin, Can you test the patch below ? That pa

[PATCH V3] fnic: check pci_map_single() return value

2015-08-12 Thread Maurizio Lombardi
the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG. This is because the fnic driver doesn't check the return value of pci_map_single(). [ 11.942770] scsi host12: fnic [ 11.950811] [ cut here ] [ 11.950818] WARNING: at lib/dma-debug.c:937 check_unm

Re: [PATCH V2] fnic: check pci_map_single() return value

2015-08-12 Thread Maurizio Lombardi
Hi, On 08/12/2015 03:33 PM, Johannes Thumshirn wrote: > Hi Maurizio, > > Sorry but it looks like you've forgotten one change in fnic_eth_send(). Ok, I converted fnic_eth_send() to use gotos for error cleanup and sent V3. Hopefully it'll be the final version. Thanks for the review. Regards, Mau

Re: [PATCH V2] fnic: check pci_map_single() return value

2015-08-12 Thread Johannes Thumshirn
Hi Maurizio, Sorry but it looks like you've forgotten one change in fnic_eth_send(). Maurizio Lombardi writes: > the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG. > This is because the fnic driver doesn't check the return value of > pci_map_single(). > > [ 11.942770] sc

[PATCH V2] fnic: check pci_map_single() return value

2015-08-12 Thread Maurizio Lombardi
the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG. This is because the fnic driver doesn't check the return value of pci_map_single(). [ 11.942770] scsi host12: fnic [ 11.950811] [ cut here ] [ 11.950818] WARNING: at lib/dma-debug.c:937 check_unm

Re: [PATCH] fnic: check pci_map_single() return value

2015-08-12 Thread Maurizio Lombardi
Hi Johannes, On 08/12/2015 01:42 PM, Johannes Thumshirn wrote: > hmmm, how about > > goto free_skb; >> +} >> + >> fnic_queue_rq_desc(rq, skb, pa, len); >> -return 0; >> +err: > > free_skb: > kfree_skb(skb); > >> +return r; >> } > > Although the return is near to the e

Re: [PATCH] fnic: check pci_map_single() return value

2015-08-12 Thread Johannes Thumshirn
Hi Maurizio, Maurizio Lombardi writes: > the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG. > This is because the fnic driver doesn't check the return value of > pci_map_single(). > > [ 11.942770] scsi host12: fnic > [ 11.950811] [ cut here ] > [

[PATCH] fnic: check pci_map_single() return value

2015-08-12 Thread Maurizio Lombardi
the kernel prints some warnings when compiled with CONFIG_DMA_API_DEBUG. This is because the fnic driver doesn't check the return value of pci_map_single(). [ 11.942770] scsi host12: fnic [ 11.950811] [ cut here ] [ 11.950818] WARNING: at lib/dma-debug.c:937 check_unm

pozdravy!

2015-08-12 Thread email
Mam vzajemne mit prospech podnik pro nas oba. pokud mate zajem, muzete mi dostat na e-mailovou adresu a pro detaily a vysvetlení. E-mail: chn.j...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More major