[Bug 101891] mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

2015-08-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101891 Turbo Fredriksson tu...@bayour.com changed: What|Removed |Added CC||tu...@bayour.com

[PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-08-20 Thread Dāvis Mosāns
When pci_pool_alloc fails in mvs_task_prep then task-lldd_task stays NULL but it's later used in mvs_abort_task as slot which is passed to mvs_slot_task_free causing NULL pointer dereference. Just return from mvs_slot_task_free when passed with NULL slot. Bugzilla:

[PATCH] fix: lpfc_send_rscn_event sends bigger buffer size

2015-08-20 Thread Ales Novak
lpfc_send_rscn_event() allocates data for sizeof(struct lpfc_rscn_event_header) + payload_len, but claims that the data has size of sizeof(struct lpfc_els_event_header) + payload_len. That leads to buffer overruns. Signed-off-by: Ales Novak alno...@suse.cz --- drivers/scsi/lpfc/lpfc_els.c | 2 +-

Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device

2015-08-20 Thread Akinobu Mita
2015-08-20 22:59 GMT+09:00 Yaniv Gardi yga...@codeaurora.org: @@ -1036,7 +1037,7 @@ void ufs_qcom_clk_scale_notify(struct ufs_hba *hba) * The variant operations configure the necessary controller and PHY * handshake during initialization. */ -static const struct ufs_hba_variant_ops

Re: [PATCH] target/qla2xxx: Honor max_data_sg_nents I/O transfer limit

2015-08-20 Thread Nicholas A. Bellinger
On Wed, 2015-08-19 at 17:48 -0700, Arun Easi wrote: Hi nab, On Thu, 13 Aug 2015, 1:45am -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi Arun, Roland Co, Based upon the feedback from last week, here is a proper patch for target-core to honor a

Re: [PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-08-20 Thread Akinobu Mita
2015-08-20 22:59 GMT+09:00 Yaniv Gardi yga...@codeaurora.org: @@ -30,6 +48,14 @@ static void ufs_qcom_get_speed_mode(struct ufs_pa_layer_attr *p, char *result); static int ufs_qcom_get_bus_vote(struct ufs_qcom_host *host, const char *speed_mode); static int

Re: Persistent Reservation API V2

2015-08-20 Thread Keith Busch
On Tue, 11 Aug 2015, Christoph Hellwig wrote: This series adds support for a simplified Persistent Reservation API to the block layer. The intent is that both in-kernel and userspace consumers can use the API instead of having to hand craft SCSI or NVMe command through the various pass through

Re: [PATCH v6 1/3] cxlflash: Base error recovery support

2015-08-20 Thread Manoj Kumar
James: Wondering whether there is anything else you were expecting from us before pulling this patch series in. Regards, - Manoj Kumar On 8/13/2015 9:47 PM, Matthew R. Ochs wrote: Introduce support for enhanced I/O error handling. A device state is added to track 3 possible states of the

[PATCH v2 4/8] add ufshcd_get_variant ufshcd_set_variant

2015-08-20 Thread Yaniv Gardi
Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/scsi/ufs/ufs-qcom.c | 34 +- drivers/scsi/ufs/ufshcd.h | 21 + 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH v2 5/8] scsi: ufs: creates wrapper functions for vops

2015-08-20 Thread Yaniv Gardi
In order to simplify the code a set of wrapper functions is created to test and call each of the variant operations. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/scsi/ufs/ufs-qcom.c | 1 - drivers/scsi/ufs/ufshcd.c | 104 +---

[PATCH v2 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-20 Thread Yaniv Gardi
New revisions of UFS host controller supports the new UniPro hardware controller (referred as QUniPro). This patch adds the support to enable this new UniPro controller hardware. This change also adds power optimization for bus scaling feature, as well as support for HS-G3 power mode.

[PATCH v2 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-08-20 Thread Yaniv Gardi
This change is required in order to be able to build the component as a module. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index

[PATCH v2 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-08-20 Thread Yaniv Gardi
Adds support for configuring and reading the test bus and debug registers. This change also adds another vops in order to print the debug registers. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/scsi/ufs/ufs-qcom.c | 164 +++-

[PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device

2015-08-20 Thread Yaniv Gardi
This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The ufshcd-pltfrm is no longer serves as a platform device. Now it only serves as a group of platform APIs such as PM APIs (runtime suspend/resume,

[PATCH v2 0/8] Fix error message and present UFS variant

2015-08-20 Thread Yaniv Gardi
V2 fixes a few issues of unnecessary EXPORT_SYMBOL, types of parameters in routine definition, build errors in case CONFIG_PM is not defined and some other minor fixes. Yaniv Gardi (8): phy: qcom-ufs: fix build error when the component is built as a module scsi: ufs-qcom: fix compilation

[PATCH v2 1/8] phy: qcom-ufs: fix build error when the component is built as a module

2015-08-20 Thread Yaniv Gardi
Export the following functions in order to avoid build errors when the component PHY_QCOM_UFS is compiled as a module: ERROR: ufs_qcom_phy_disable_ref_clk [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERROR: ufs_qcom_phy_enable_ref_clk [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERROR:

[PATCH v2 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

2015-08-20 Thread Yaniv Gardi
This change fixes a compilation warning that happens if SCSI_UFS_QCOM is compiled as a module. Also this patch fixes an error happens when insmod the module: ufs_qcom: module license 'unspecified' taints kernel. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/scsi/ufs/ufs-qcom.c |

[PATCH v2 7/10] megaraid_sas : Print critical fw event message

2015-08-20 Thread Sumit.Saxena
Print firmware event in readable format. This will help user to track any critical firmware event without any application support. sample syslogd output - megaraid_sas :02:00.0: 8619 (491648347s/0x0020/WARN) - Controller temperature threshold exceeded. This may indicate inadequate system

[PATCH v2 10/10] megaraid_sas : Version upgrade

2015-08-20 Thread Sumit.Saxena
Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com --- drivers/scsi/megaraid/megaraid_sas.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH v2 9/10] megaraid_sas : Code refactor for use of requestorId

2015-08-20 Thread Sumit.Saxena
Some of the code changes was proposed by David Binderman Removed redudant check of requestorId. Redundant condition: instance.requestorId. Check for plasma firmware 1.11 or new restructured to support only for specific device id Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com

[PATCH v2 8/10] megaraid_sas : Fix validHandles check in io path

2015-08-20 Thread Sumit.Saxena
Syncro firmware supports round robin IO switch on dual path. For this driver use validHandles as a check for dual path. This check suppose to be 1 (not 2) Without this patch, earlier driver code does not use dual path functionality. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com

Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-20 Thread ygardi
Thank you Mita for the review. Your comments were correct and helpful. I appreciate your time and effort. please see inline. 2015-08-16 19:14 GMT+09:00 Yaniv Gardi yga...@codeaurora.org: @@ -1208,6 +1510,7 @@ static struct ufs_hba_variant_ops ufs_hba_qcom_vops = { .resume

[PATCH v2 3/10] megaraid_sas : Jbod sequence number support

2015-08-20 Thread Sumit.Saxena
Implemented JBOD map which will provide quick access for JBOD path and also provide sequence number. This will help hardware to fail command to the FW in case of any sequence mismatch. Fast Path IO for JBOD will refer JBOD map (which has sequence number per JBOD devices) instead of Raid map.

[PATCH v2 02/10] megaraid_sas : Increase timeout to 60 secs for abort frames during shutdown

2015-08-20 Thread Sumit.Saxena
Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Reviewed-by: Martin Petersen martin.peter...@oracle.com --- drivers/scsi/megaraid/megaraid_sas_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 6/10] megaraid_sas : Chip reset if driver fail to bring ioc ready

2015-08-20 Thread Sumit.Saxena
Patch which fix the issue reported as below. http://marc.info/?l=linux-scsim=143694494104544w=2 This patch will try to do chip reset from driver load time. Driver load time, if firmware is not comming to ready state, driver try chip reset calling adp_reset() callback. For fusion adapter, that

[PATCH v2 5/10] megaraid_sas : Support for max_io_size 1MB

2015-08-20 Thread Sumit.Saxena
Driver will expose max sge = 256 (earlier it was 64), if firmware support extended IO size upto 1M. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Reviewed-by: Martin Petersen martin.peter...@oracle.com ---

[PATCH v2 0/10] megaraid_sas : Updates for scsi for-next

2015-08-20 Thread Sumit.Saxena
MegaRaid driver changes. This patch set is resent based on feedback received by Martin Petersen. Please consider this patch set for next kernel release. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com --- [PATCH v2 00/10]

[Bug 101891] mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

2015-08-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101891 --- Comment #7 from Dāvis davis...@gmail.com --- (In reply to Turbo Fredriksson from comment #6) Forgive an ignoramus, but those last lines doesn't look to good kernel: ata11.00: device reported invalid CHS sector 0 I have a problem

[PATCH v2 01/10] megaraid_sas : Synchronize driver headers with firmware APIs

2015-08-20 Thread Sumit.Saxena
Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com Signed-off-by: Kashyap Desai kashyap.de...@avagotech.com Reviewed-by: Martin Petersen martin.peter...@oracle.com --- drivers/scsi/megaraid/megaraid_sas.h| 18 ++ drivers/scsi/megaraid/megaraid_sas_fusion.h |3 ++-

Re: [PATCH V2 2/8] pm80xx: Corrected device state changes in I_T_Nexus_Reset.

2015-08-20 Thread Tomas Henzl
On 11.8.2015 11:36, viswa...@pmcs.com wrote: From: Viswas G viswa...@pmcs.com In Nexus reset the device state request are not needed. Changes from V1: Device state change request has been removed as the firmware will handle it during internal cleanup. Also updated the proper return value

Re: [PATCH 2/2] ipr: Enable SIS pipe commands for SIS-32 devices.

2015-08-20 Thread Brian King
On 08/19/2015 09:47 AM, Gabriel Krisman Bertazi wrote: Remove unnecessary check that disabled SIS pipe commands for SIS-32 devices. This change was sufficient to enable raw mode and send SIS pipe commands for a 57B3 device. Fixes: f8ee25d7d239 (ipr: AF DASD raw mode implementation in ipr

Re: [PATCH 1/2] ipr: Inhibit underlength data check for AFDASD in raw mode.

2015-08-20 Thread Brian King
On 08/19/2015 09:47 AM, Gabriel Krisman Bertazi wrote: Disable underlength error verification based on count of bytes actually transferred for AF DASD devices when SIS pipe mode is enabled. This avoids unexpected underlength errors when issuing some commands in raw mode. Signed-off-by:

SCSI scanning behavior

2015-08-20 Thread Brian King
In one of our SAN test labs where there is some storage controller error injection going on, I'm seeing some interesting behavior. We are getting into a scenario, when the target is coming back where we are going through SCSI scan for it and the Report LUNs we are issuing to it times out, so we