Re: [PATCH] target: Fix for hang of Ordered task in TCM

2016-06-08 Thread Nicholas A. Bellinger
On Wed, 2016-06-08 at 14:43 -0500, Bryant G. Ly wrote: > > Hi Nic, > > So I was testing the ibmvscsi target driver and I ran into some problems > again with UA stuff and it looks like you didnt remove the UA checks from > target_setup_cmd_from_cdb? Was that intentional? I thought we agreed to

Re: [PATCH v2] scsi_debug: fix sleep in invalid context

2016-06-08 Thread Douglas Gilbert
On 2016-06-08 04:57 PM, Douglas Gilbert wrote: On 2016-06-07 09:55 PM, Christoph Hellwig wrote: +static int p_fill_from_dev_buffer(struct scsi_cmnd *scp, const void *arr, + int arr_len, unsigned int off_dst) +{ +int act_len, n; +struct scsi_data_buffer *sdb =

Re: [RFC 0/2] nvme/loop: Add support for controllers-per-port model

2016-06-08 Thread Nicholas A. Bellinger
On Wed, 2016-06-08 at 14:14 +0200, Christoph Hellwig wrote: > Hi Nic, > > multiple ports have been on the todo list ever since we put that short > cut in place, but your patches aren't really how this should work. > > The host NQN is not available for the actual drivers - we need to be able > to

[PATCH 16/21] fnic: Use time64_t to represent trace timestamps

2016-06-08 Thread Deepa Dinamani
trace timestamps use struct timespec and CURRENT_TIME which are not y2038 safe. These timestamps are only part of the trace log on the machine and are not shared with the fnic. Replace then with y2038 safe struct timespec64 and ktime_get_real_ts64(), respectively. Signed-off-by: Deepa Dinamani

Re: NVMe over Fabrics target implementation

2016-06-08 Thread Nicholas A. Bellinger
On Wed, 2016-06-08 at 16:12 +0300, Sagi Grimberg wrote: > >> *) Extensible to multiple types of backend drivers. > >> > >> nvme-target needs a way to absorb new backend drivers, that > >> does not effect existing configfs group layout or attributes. > >> > >> Looking at the nvmet/configfs layout

Re: [PATCH] Add support for SCT Write Same

2016-06-08 Thread Martin K. Petersen
> "Shaun" == Shaun Tancheff writes: Shaun, Shaun> SATA drives may support write same via SCT. This is useful for Shaun> setting the drive contents to a specific pattern (0's). index 428c03e..c5c8424 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -52,6 +52,7

Re: NVMe over Fabrics target implementation

2016-06-08 Thread Nicholas A. Bellinger
On Wed, 2016-06-08 at 14:19 +0200, Christoph Hellwig wrote: > On Tue, Jun 07, 2016 at 10:21:41PM -0700, Nicholas A. Bellinger wrote: > > *) Extensible to multiple types of backend drivers. > > > > nvme-target needs a way to absorb new backend drivers, that > > does not effect existing configfs

Re: [PATCH] sd: remove redundant check for BLK_DEF_MAX_SECTORS

2016-06-08 Thread Martin K. Petersen
> "Long" == Long Li writes: Long, Long> The problem I'm trying to solve is that, I want to have lower Long> layer driver to setup max_sectors bigger than Long> BLK_DEF_MAX_SECTORS. Capping at BLK_DEF_MAX_SECTORS unless a device has explicitly reported requirements is

[PATCH 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-08 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH V1 0/2] Series short description

2016-06-08 Thread Don Brace
These patches are based on Linus's tree - add smartpqi to kernel.org - remove PCI IDs from aacraid driver - Depends on adoption of smartpqi driver Changes since initial upload - Forgot to give correct ownership to the author. --- Don Brace (1): aacraid: remove wildcard for series 9

[PATCH V1 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-08 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH] aic7xxx: fix wrong return values

2016-06-08 Thread Laurence Oberman
- Original Message - > From: "Luis de Bethencourt" > To: linux-ker...@vger.kernel.org > Cc: h...@suse.com, j...@linux.vnet.ibm.com, "martin petersen" > , > linux-scsi@vger.kernel.org, jav...@osg.samsung.com, "Luis de Bethencourt" >

[PATCH 0/2] initial submit of Microsemi smartpqi driver

2016-06-08 Thread Don Brace
This patches are based on Linus's tree - New smartpqi driver - removal of smartpqi PCI IDs from aacraid driver - this patch depends on adoption of smartpqi driver --- Don Brace (2): smartpqi: initial commit of Microsemi smartpqi driver aacraid: remove wildcard for series 9

Re: [PATCH v3 0/6] Introduce pci_(request|release)_(mem|io)_regions

2016-06-08 Thread Jeff Kirsher
On Wed, 2016-06-08 at 09:28 +0200, Johannes Thumshirn wrote: > On Tue, Jun 07, 2016 at 09:44:00AM +0200, Johannes Thumshirn wrote: > > The first patch in this series introduces the following 4 helper > functions to > > the PCI core: > >  > > * pci_request_mem_regions() > > *

[PATCH] aic7xxx: fix wrong return values

2016-06-08 Thread Luis de Bethencourt
Convention of error codes says to return them as negative values. Signed-off-by: Luis de Bethencourt --- drivers/scsi/aic7xxx/aic7770_osm.c | 6 +++--- drivers/scsi/aic7xxx/aic79xx_core.c| 24 drivers/scsi/aic7xxx/aic79xx_osm.c | 8

[PATCH] target: Fix for hang of Ordered task in TCM

2016-06-08 Thread Bryant G. Ly
From: Nicholas Bellinger If a command with a Simple task attribute is failed due to a Unit Attention, then a subsequent command with an Ordered task attribute will hang forever. The reason for this is that the Unit Attention status is checked for in

Re: NVMe over Fabrics target implementation

2016-06-08 Thread Christoph Hellwig
On Wed, Jun 08, 2016 at 04:12:27PM +0300, Sagi Grimberg wrote: >> Because it keeps the code simple. If you had actually participated >> on our development list you might have seen that until not too long >> ago we have very fine grainded locks here. In the end Armen convinced >> me that it's

Re: NVMe over Fabrics target implementation

2016-06-08 Thread Sagi Grimberg
*) Extensible to multiple types of backend drivers. nvme-target needs a way to absorb new backend drivers, that does not effect existing configfs group layout or attributes. Looking at the nvmet/configfs layout as-is, there are no multiple backend types defined, nor a way to control backend

Re: NVMe over Fabrics target implementation

2016-06-08 Thread Christoph Hellwig
On Tue, Jun 07, 2016 at 10:21:41PM -0700, Nicholas A. Bellinger wrote: > *) Extensible to multiple types of backend drivers. > > nvme-target needs a way to absorb new backend drivers, that > does not effect existing configfs group layout or attributes. > > Looking at the nvmet/configfs layout

Re: [RFC 0/2] nvme/loop: Add support for controllers-per-port model

2016-06-08 Thread Christoph Hellwig
Hi Nic, multiple ports have been on the todo list ever since we put that short cut in place, but your patches aren't really how this should work. The host NQN is not available for the actual drivers - we need to be able to virtualize it for containers for example, that's why we need to pass it

Re: [PATCH v3 0/6] Introduce pci_(request|release)_(mem|io)_regions

2016-06-08 Thread Johannes Thumshirn
On Tue, Jun 07, 2016 at 09:44:00AM +0200, Johannes Thumshirn wrote: > The first patch in this series introduces the following 4 helper functions to > the PCI core: > > * pci_request_mem_regions() > * pci_request_io_regions() > * pci_release_mem_regions() > * pci_release_io_regions() > > which

Re: [PATCH v2] scsi_debug: fix sleep in invalid context

2016-06-08 Thread Douglas Gilbert
On 2016-06-07 09:55 PM, Christoph Hellwig wrote: +static int p_fill_from_dev_buffer(struct scsi_cmnd *scp, const void *arr, + int arr_len, unsigned int off_dst) +{ + int act_len, n; + struct scsi_data_buffer *sdb = scsi_in(scp); + off_t skip =