Use of schedule() function while holding a lock in ql4_nx.c

Hello, I was wondering about the call to schedule in function qla4_82xx_crb_win_lock for driver drivers/scsi/qla4xxx/ql4_nx.c. It is called in 2 functions [qla4_82xx_rd_32 and qla4_82xx_wr_32] while holding a write_lock_irqsave. Normally we avoid using sleeping functions while holding a lock.

Re: dtc, pas16 and t128 removal, was Re: status of NCR5380-based ISA drivers

On Mon, 12 Sep 2016, I wrote: > > BTW, DTC3x80 support (NCR 53C406 chip I believe) should be easy to do in > g_NCR5380, which already supports the DTC3181E card. > Sorry, I should have written DTC406 chip, which is "supposedly compatible with the NCR 53C400" but is nothing like a NCR

dtc, pas16 and t128 removal, was Re: status of NCR5380-based ISA drivers

On Sun, 11 Sep 2016, Christoph Hellwig wrote: > Hi all, > > you seem to the currently active NCR580 cabal. Which frontends to > NCR5380 do you test at the moment, or could you test? I test the dmx3191d and mac_scsi drivers. > > NCR5380-based ISA drivers make up a significant part of those

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Joe Perches wrote: > On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > > Constify local structures. > > Thanks Julia. > > A few suggestions & questions: > > Perhaps the script should go into scripts/coccinelle/ > so that future cases could be caught by the robot > and

Re: [PATCH 00/26] constify local structures

On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > Constify local structures. Thanks Julia. A few suggestions & questions: Perhaps the script should go into scripts/coccinelle/ so that future cases could be caught by the robot and commit message referenced by the patch instances. Can you

[PATCH 2/3] qla2xxx: use struct t10_pi_tuple

Instead of defining a local version of it. Signed-off-by: Christoph Hellwig --- drivers/scsi/qla2xxx/qla_def.h | 10 -- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h

[PATCH 3/3] sd: move DIF protection types to t10-pi.h

These should go together with the rest of the T10 protection information defintions. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_debug.c | 39 +++ drivers/scsi/sd.c | 11 ++- drivers/scsi/sd.h | 21

consolidate T10 PI defintions

Hi Martin, this series ensures scsi_debug and qla2xxx use the common t10_pi_tuple defintion, and then also moves the remaining T10 PI related defintions to . -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More

[PATCH 1/3] scsi_debug: use struct t10_pi_tuple instead of struct sd_dif_tuple

And remove the declaration of the latter in sd.h as scsi_debug was the only user. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_debug.c | 15 --- drivers/scsi/sd.h | 9 - 2 files changed, 8 insertions(+), 16 deletions(-) diff --git

Re: RFC: should we deprecate unmaintained isa-only drivers?

On Sunday 11 September 2016 19:01:55 Christoph Hellwig wrote: > On Wed, Mar 25, 2015 at 09:52:53PM +0100, Ondrej Zary wrote: > > > - wd7000 > > > - aha1542 > > > - in2000 > > > - NCR53c406 > > > - sym53c416 > > > - u14-34f > > > - ultrastor > > > > NCR53c406a and sym53c416 look very

Re: status of NCR5380-based ISA drivers

On Sunday 11 September 2016 19:12:49 Christoph Hellwig wrote: > Hi all, > > you seem to the currently active NCR580 cabal. Which frontends to NCR5380 > do you test at the moment, or could you test? > > NCR5380-based ISA drivers make up a significant part of those drivers still > using

Re: [PATCH 00/26] constify local structures

On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > Constify local structures. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) Just my two cents but: 1. You *can* use a static analysis too to find bugs or other issues. 2. However, you

status of NCR5380-based ISA drivers

Hi all, you seem to the currently active NCR580 cabal. Which frontends to NCR5380 do you test at the moment, or could you test? NCR5380-based ISA drivers make up a significant part of those drivers still using scsi_module.c after it's 15 year deprecation period, and I'd like to either move them

Re: RFC: should we deprecate unmaintained isa-only drivers?

On Wed, Mar 25, 2015 at 09:52:53PM +0100, Ondrej Zary wrote: > > - wd7000 > > - aha1542 > > - in2000 > > - NCR53c406 > > - sym53c416 > > - u14-34f > > - ultrastor > > NCR53c406a and sym53c416 look very similar. The register numbers and commands > are almost the same so NCR53c406 support

[PATCH 4/6] vfio_pci: use pci_irq_allocate_vectors

Simply the interrupt setup by using the new PCI layer helpers. Signed-off-by: Christoph Hellwig --- drivers/vfio/pci/vfio_pci_intrs.c | 45 + drivers/vfio/pci/vfio_pci_private.h | 1 - 2 files changed, 10 insertions(+), 36 deletions(-) diff

[PATCH 2/6] ipr: use pci_irq_allocate_vectors

Switch the ipr driver to use pci_alloc_irq_vectors. We need to two calls to pci_alloc_irq_vectors as ipr only supports multiple MSI-X vectors, but not multiple MSI vectors. Otherwise this cleans up a lot of cruft and allows to use a common request_irq loop for irq types, which happens to only

[PATCH 6/6] media/cobalt: use pci_irq_allocate_vectors

Simply the interrupt setup by using the new PCI layer helpers. Despite using pci_enable_msi_range, this driver was only requesting a single MSI vector anyway. Signed-off-by: Christoph Hellwig --- drivers/media/pci/cobalt/cobalt-driver.c | 8 ++--

[PATCH 5/6] genwqe: use pci_irq_allocate_vectors

Simply the interrupt setup by using the new PCI layer helpers. One odd thing about this driver is that it looks like it could request multiple MSI vectors, but it will then only ever use a single one. Signed-off-by: Christoph Hellwig --- drivers/misc/genwqe/card_base.h | 1 -

[PATCH 1/6] arcmsr: use pci_alloc_irq_vectors

Switch the arcmsr driver to use pci_alloc_irq_vectors. We need to two calls to pci_alloc_irq_vectors as arcmsr only supports multiple MSI-X vectors, but not multiple MSI vectors. Otherwise this cleans up a lot of cruft and allows to use a common request_irq loop for irq types, which happens to

[PATCH 3/6] skd: use pci_alloc_irq_vectors

Switch the skd driver to use pci_alloc_irq_vectors. We need to two calls to pci_alloc_irq_vectors as skd only supports multiple MSI-X vectors, but not multiple MSI vectors. Otherwise this cleans up a lot of cruft and allows to a lot more common code. Signed-off-by: Christoph Hellwig

replace pci_enable_msi_{exact_range} with pci_alloc_irq_vectors

Hi all, this series switch the remaining users of pci_enable_msi_{exact_range} (accounting for ahci and nvme being done through other channels) to use the pci_alloc_irq_vectors helper instead and thus simplify the interrupt code in those drivers a lot. I decided to post it as a series to

[PATCH 22/26] esas2r: constify local structures

For structure types defined in the same file or local header files, find top-level static structure declarations that have the following properties: 1. Never reassigned. 2. Address never taken 3. Not passed to a top-level macro call 4. No pointer or array-typed field passed to a function or stored

[PATCH 00/26] constify local structures

Constify local structures. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // // The first rule ignores some cases that posed problems @r disable optional_qualifier@ identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer}; identifier i !=

[PATCH 12/26] [SCSI] hptiop: constify local structures

For structure types defined in the same file or local header files, find top-level static structure declarations that have the following properties: 1. Never reassigned. 2. Address never taken 3. Not passed to a top-level macro call 4. No pointer or array-typed field passed to a function or stored

[Bug 156411] scsi host6: runtime PM trying to activate child device host6 but parent (3-4:1.0) is not active

https://bugzilla.kernel.org/show_bug.cgi?id=156411 Thorsten Leemhuis changed: What|Removed |Added CC|

[Bug 153171] scsi host6: runtime PM trying to activate child device host6 but parent (2-2:1.0) is not active

https://bugzilla.kernel.org/show_bug.cgi?id=153171 Thorsten Leemhuis changed: What|Removed |Added CC|