Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-13 Thread James Bottomley
On Tue, 2016-09-13 at 15:05 -0400, Ewan D. Milne wrote: > On Tue, 2016-09-13 at 08:06 -0700, James Bottomley wrote: > > On Tue, 2016-09-13 at 16:24 +0200, Hannes Reinecke wrote: > > > On 09/13/2016 04:04 PM, James Bottomley wrote: > > > > You could argue that the entire message needs removing,

Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-13 Thread Ewan D. Milne
On Tue, 2016-09-13 at 08:06 -0700, James Bottomley wrote: > On Tue, 2016-09-13 at 16:24 +0200, Hannes Reinecke wrote: > > On 09/13/2016 04:04 PM, James Bottomley wrote: > > > You could argue that the entire message needs removing, since it's > > > reporting stuff that mostly only shows when

Re: [PATCH] scsi:Prevent deletion of SCSI block device in use

2016-09-13 Thread Ewan D. Milne
On Tue, 2016-09-13 at 22:08 +0530, Gurunath, Vasundhara wrote: > From: "Gurunath, Vasundhara" > > SCSI block device can be removed, using write to sysfs > delete file as below: > echo 1 > /sys/block/sdX/device/delete > If the device is in use by applications, or part

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-13 Thread Chad Dupuis
On Fri, 9 Sep 2016, 11:28am -, Martin K. Petersen wrote: > > "Johannes" == Johannes Thumshirn writes: > > >> On Wed, Aug 17, 2016 at 12:09:59PM +0200, Sebastian Andrzej Siewior > wrote: > >> The driver creates its own per-CPU threads which are updated based on > >>

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-13 Thread Henrique de Moraes Holschuh
On Mon, 12 Sep 2016, Jason A. Donenfeld wrote: > I was wondering if it'd be possible to have the uas driver -- or > perhaps somewhere else in the stack -- fall back to using > ATA-passthrough-TRIM for UNMAP, so that discard can work properly. > AFAIK, the Windows drivers do exactly this. > > If

Re: [PATCH] scsi:Prevent deletion of SCSI block device in use

2016-09-13 Thread James Bottomley
On Tue, 2016-09-13 at 22:08 +0530, Gurunath, Vasundhara wrote: > From: "Gurunath, Vasundhara" > > SCSI block device can be removed, using write to sysfs > delete file as below: > echo 1 > /sys/block/sdX/device/delete > If the device is in use by applications, or part

Query related to the UPIU endianess

2016-09-13 Thread Sangamesh O Shetty
Hi all, I have a query related to the endianess of the UPIU packet. The JESD223C document mentions that the CDB should be in big-endian. The JESD220C document section 10.7 mentions the layout of all the UFS UPIU's. It mentions that the first byte is transaction type, second byte is flags and so

[PATCH] scsi:Prevent deletion of SCSI block device in use

2016-09-13 Thread Gurunath, Vasundhara
From: "Gurunath, Vasundhara" SCSI block device can be removed, using write to sysfs delete file as below: echo 1 > /sys/block/sdX/device/delete If the device is in use by applications, or part of system configuration such as boot device, removal can result in

Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-13 Thread James Bottomley
On Tue, 2016-09-13 at 16:24 +0200, Hannes Reinecke wrote: > On 09/13/2016 04:04 PM, James Bottomley wrote: > > You could argue that the entire message needs removing, since it's > > reporting stuff that mostly only shows when systems using > > reservations correctly are in operation. > > > Oh,

Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-13 Thread Hannes Reinecke
On 09/13/2016 04:04 PM, James Bottomley wrote: > On Mon, 2016-09-12 at 10:20 +0200, Hannes Reinecke wrote: >> SPC-2 and SPC-3 (or later) differ in the handling of reservation >> conflict for TEST UNIT READY. SPC-2 will return 'reservation >> conflict', whereas SPC-3 will return GOOD status. >> On

Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-13 Thread James Bottomley
On Mon, 2016-09-12 at 10:20 +0200, Hannes Reinecke wrote: > SPC-2 and SPC-3 (or later) differ in the handling of reservation > conflict for TEST UNIT READY. SPC-2 will return 'reservation > conflict', whereas SPC-3 will return GOOD status. > On a mixed system with both SPC-2 and SPC-3 targets one

[PATCH v6 2/9] rpmb: enable emmc specific read data fixup

2016-09-13 Thread Tomas Winkler
For eMMC the block count of the RPMB read operation is not indicated in the original RPMB Data Read Request packet. This might be different then the implementation of other protocol standards. This patch implements a fixup for this behavior. Signed-off-by: Tomas Winkler

[PATCH v6 8/9] mmc: block: register RPMB partition with the RPMB subsystem

2016-09-13 Thread Tomas Winkler
Register eMMC RPMB partition with the RPMB subsystem and provide implementation for the RPMB access operations abstracting actual multi step process. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V2: resend V3: commit

[PATCH v6 7/9] tools rpmb: add RPBM access tool

2016-09-13 Thread Tomas Winkler
Add simple RPMB host testing tool. It can be used to program key, write and read data block, and retrieve write counter. Signed-off-by: Tomas Winkler --- V2: resend V3: fix missing objtool V4: add verbose option V5: 1. Adjust to the new API. 2. Exercise both request

[PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-13 Thread Tomas Winkler
Few storage technologies such is EMMC, UFS, and NVMe support RPMB hardware partition with common protocol and frame layout. The RPMB partition cannot be accessed via standard block layer, but by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and PROGRAM_KEY. Such a partition provides

[PATCH v6 9/9] scsi: ufs: connect to RPMB subsystem

2016-09-13 Thread Tomas Winkler
Register UFS RPMB LUN with the RPMB subsystem and provide implementation for the RPMB access operations. RPMB partition is accessed via a sequence of security protocol in and security protocol out commands with UFS specific parameters. This multi step process is abstracted into 4 basic RPMB

[PATCH v6 5/9] char: rpmb: provide a user space interface

2016-09-13 Thread Tomas Winkler
The user space API is achieved via two synchronous IOCTLs. Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is performed by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD where the whole RPMB sequence including RESULT_READ is supplied by the caller. The latter is intended

[PATCH v6 3/9] rpmb: add sysfs-class ABI documentation

2016-09-13 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- V2: resend V3: add more verbose description V4: resend V5: adjust date and kernel version V6: adjust date and kernel version Documentation/ABI/testing/sysfs-class-rpmb | 20 MAINTAINERS

[PATCH v6 4/9] char: rpmb: add device attributes

2016-09-13 Thread Tomas Winkler
Add attribute type that displays underlay storage type technology EMMC, UFS, and attribute id, that displays underlay storage device id. For EMMC this would be content of CID and for UFS serial number from the device descriptor. Signed-off-by: Tomas Winkler --- V2:

[PATCH v6 6/9] char: rpmb: add RPMB simulation device

2016-09-13 Thread Tomas Winkler
The RPMB partition simulation device is a virtual device that provides simulation of the RPMB protocol and use kernel memory as storage. Be aware it doesn't promise any real security. This driver is suitable only for testing of the RPMB subsystem or RPMB applications prior to RPMB key

[PATCH v6 0/9] Replay Protected Memory Block (RPMB) subsystem

2016-09-13 Thread Tomas Winkler
Few storage technologies such is EMMC, UFS, and NVMe support RPMB hardware partition with common protocol and frame layout. The RPMB partition cannot be accessed via standard block layer, but by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and PROGRAM_KEY. Such a partition provides

RE: [PATCH] scsi: megaraid_sas: add in missing white space in error message text

2016-09-13 Thread Sumit Saxena
>-Original Message- >From: Colin King [mailto:colin.k...@canonical.com] >Sent: Monday, September 12, 2016 6:12 PM >To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E . J . Bottomley; >Martin K >. Petersen; megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org >Cc:

[Question] Calling request_firmware under the spinlocks in file advansys.c

2016-09-13 Thread Vaishali Thakkar
Hi, In the file drivers/scsi/advansys.c we are calling function AdvISR at 2 instances [in the function advansys_reset and advansys_interrupt] while holding spinlock. Function AdvISR eventually calls request_firmware following this sequence of routines: AdvISR -> adv_async_callback ->

[PATCH 3/3] virtio_scsi: use complete() instead complete_all()

2016-09-13 Thread Daniel Wagner
From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context

[PATCH 2/3] sym53c8xx_2: use complete() instead complete_all()

2016-09-13 Thread Daniel Wagner
From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context

[PATCH 0/3] wireless: Use complete() instead complete_all()

2016-09-13 Thread Daniel Wagner
From: Daniel Wagner Hi, Using complete_all() is not wrong per se but it suggest that there might be more than one waiter. For -rt I am reviewing all complete_all() users and would like to leave only the real ones in the tree. The main problem for -rt about

[PATCH 1/3] csiostor: fix completion usage

2016-09-13 Thread Daniel Wagner
From: Daniel Wagner The (re)initialzing of the completion object should be done before we trigger the transfer. Doing this after triggering the hardware opens up a race window. Without the timeout we would problaly even deadlock. Use also reinit_completion because we

Re: [PATCH 3/3] sd: move DIF protection types to t10-pi.h

2016-09-13 Thread Bart Van Assche
On 09/11/2016 07:35 PM, Christoph Hellwig wrote: These should go together with the rest of the T10 protection information defintions. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 2/3] qla2xxx: use struct t10_pi_tuple

2016-09-13 Thread Bart Van Assche
On 09/11/2016 07:35 PM, Christoph Hellwig wrote: Instead of defining a local version of it. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/3] scsi_debug: use struct t10_pi_tuple instead of struct sd_dif_tuple

2016-09-13 Thread Bart Van Assche
On 09/11/2016 07:35 PM, Christoph Hellwig wrote: And remove the declaration of the latter in sd.h as scsi_debug was the only user. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to