Re: [PATCH v2] lpfc: Finalize Kconfig options for nvme

2017-03-13 Thread Martin K. Petersen
> "James" == jsmart2021 writes: James> Reviewing the result of what was just added for Kconfig, we made James> a poor choice. It worked well for full kernel builds, but not so James> much for how it would be deployed on a distro. Applied to 4.11/scsi-fixes. Thanks!

Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

2017-03-13 Thread Martin K. Petersen
> "Tomas" == Tomas Winkler writes: Tomas> Fix compilation warning drivers/scsi/ufs/ufshcd.c:7645:13: Tomas> warning: comparison of unsigned expression < 0 is always false Tomas> [-Wtype-limits] if ((value < UFS_PM_LVL_0) || (value >= Tomas> UFS_PM_LVL_MAX)) Applied

Re: [PATCH V3 0/3] hpsa updates

2017-03-13 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> These patches are based on Linus's tree The changes are: Don> - add in a new offline volume status Don> - limit the number of outstanding rescan operation Don> - do not timeout reset operations Applied to 4.11/scsi-fixes. Thank

Re: [PATCH 0/4] megaraid_sas: Bug fixes and improvements for 4.11-rc

2017-03-13 Thread Martin K. Petersen
> "Shivasharan" == Shivasharan S > writes: Shivasharan> This patchset fixes few issues introduced during previous Shivasharan> set of patch submissions for 4.11 Applied to 4.11/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux

Re: [PATCH] qla2xxx: Fix crash in qla2xxx_eh_abort on bad ptr

2017-03-13 Thread Martin K. Petersen
> "Bill" == Bill Kuzeja writes: Hi Bill, Bill> I've seen this issue only after a Qlogic card breaks upon Bill> initialization (one of my test cases). After the break, Bill> qla2x00_abort_all_cmds gets invoked. This routine has a relatively Bill> new section

Re: [PATCH] scsi: storvsc: Add support for FC rport.

2017-03-13 Thread Martin K. Petersen
> "Cathy" == Cathy Avery writes: Hi Cathy, Cathy> I haven't received any feedback yet. Cathy> Should I resend? You sent this right at the beginning of the merge window. That almost guarantees that nobody will have time to look at it. Whereas now is a good time to send

Re: [PATCH v2] scsi_sysfs: fix hang when removing scsi device

2017-03-13 Thread Bart Van Assche
On Mon, 2017-03-13 at 14:55 -0700, James Bottomley wrote: > This is true, but I don't see how it can cause the host to be freed > before the sdev. The memory for struct Scsi_Host is freed in the > shost_gendev release routine, which should be pinned by the parent > traversal from sdev. So it

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Himanshu Madhani" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Monday, March 13, 2017 9:06:38 PM > Subject: Re: 4.10+

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Himanshu Madhani" > Cc: "Chad Dupuis" , "Linux SCSI List" > > Sent: Monday, March 13, 2017 12:54:12 PM > Subject: Re: 4.10+

Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

2017-03-13 Thread Subhash Jadavani
On 2017-03-12 03:22, Tomas Winkler wrote: Fix compilation warning drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) Signed-off-by: Tomas Winkler

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Christoph Hellwig Date: Mon, 13 Mar 2017 16:19:47 -0700 > On Mon, Mar 13, 2017 at 03:33:47PM -0700, David Miller wrote: >> Applied, thanks. > > So everyone who doesn't have the very latests linux-firmware will now > have a non-working card after upgrading the kernel?

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread Christoph Hellwig
On Mon, Mar 13, 2017 at 03:33:47PM -0700, David Miller wrote: > Applied, thanks. So everyone who doesn't have the very latests linux-firmware will now have a non-working card after upgrading the kernel?

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Yuval Mintz Date: Sat, 11 Mar 2017 18:39:18 +0200 > This patch advances the qed* drivers into using the newer firmware - > This solves several firmware bugs, mostly related [but not limited to] > various init/deinit issues in various offloaded protocols. > > It

Re: [PATCH v2] scsi_sysfs: fix hang when removing scsi device

2017-03-13 Thread James Bottomley
On Mon, 2017-03-13 at 20:33 +, Bart Van Assche wrote: > On Mon, 2017-03-13 at 12:23 -0700, James Bottomley wrote: > > On Mon, 2017-03-13 at 18:49 +, Bart Van Assche wrote: > > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > > > index 7bfbcfa7af40..b3bb49d06943 100644 > > > ---

Re: [PATCH v2] scsi_sysfs: fix hang when removing scsi device

2017-03-13 Thread Bart Van Assche
On Mon, 2017-03-13 at 12:23 -0700, James Bottomley wrote: > On Mon, 2017-03-13 at 18:49 +, Bart Van Assche wrote: > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > > index 7bfbcfa7af40..b3bb49d06943 100644 > > --- a/drivers/scsi/scsi.c > > +++ b/drivers/scsi/scsi.c > > @@ -602,7

Re: [PATCH v2] scsi_sysfs: fix hang when removing scsi device

2017-03-13 Thread James Bottomley
On Mon, 2017-03-13 at 18:49 +, Bart Van Assche wrote: > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 7bfbcfa7af40..b3bb49d06943 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -602,7 +602,7 @@ EXPORT_SYMBOL(scsi_device_get); > */ > void

[PATCH] scsi: cxgb3i: remove redundant null check and kfree on skb

2017-03-13 Thread Colin King
From: Colin Ian King On the error exit path, skb is always null, so the non-null check and __kfree_skb call are redundant. Remove the redundant code, rename the rel_release label to err and make error paths jump to the err exit path. Detected by CoverityScan,

Re: [PATCH v2] scsi_sysfs: fix hang when removing scsi device

2017-03-13 Thread Bart Van Assche
On Sun, 2017-03-12 at 12:26 +0200, Israel Rukshin wrote: > scsi_device_get() affects I/O because scsi_target_unblock() use it and calls > to blk_start_queue(). > terminate_rport_io() is called after scsi_target_unblock() and completes all > the commands > including the SYNCHRONIZE CACHE command.

Re: [PATCH] libata: make ata_sg_clean static over again

2017-03-13 Thread Tejun Heo
On Fri, Mar 10, 2017 at 10:05:40AM +0800, Jason Yan wrote: > Fixes the following sparse warning: > > drivers/ata/libata-core.c:4913:6: warning: symbol 'ata_sg_clean' was not > declared. Should it be static? > > Signed-off-by: Jason Yan Applied to libata/for-4.12. Thanks.

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Laurence Oberman
- Original Message - > From: "Himanshu Madhani" > To: "Laurence Oberman" , "Chad Dupuis" > > Cc: "Linux SCSI List" > Sent: Monday, March 13, 2017 12:39:03 PM > Subject: RE: 4.10+

RE: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

2017-03-13 Thread Madhani, Himanshu
Hi Laurence, > -Original Message- > From: Laurence Oberman [mailto:lober...@redhat.com] > Sent: Sunday, March 12, 2017 11:31 AM > To: Dupuis, Chad ; Madhani, Himanshu > > Cc: Linux SCSI List > Subject: Re:

[Bug 194837] VM with virtio-scsi drive often crashes during boot with kernel 4.11rc1

2017-03-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194837 --- Comment #5 from Adam Williamson (ad...@happyassassin.net) --- Only here and downstream Bugzilla. I'm not really signed up to any kernel mailing lists. Please do feel free to forward it anywhere appropriate... -- You are receiving this mail

Re: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run

2017-03-13 Thread Mauricio Faria de Oliveira
On 03/13/2017 11:48 AM, Hannes Reinecke wrote: This is assuming that we're always running on a scsi_disk, and that scsi_disk is the only one implementing 'eh_action'. Neither of which is necessarily true. Ah, OK. Thanks for explaining. -- Mauricio Faria de Oliveira IBM Linux Technology

Re: [PATCHv4 09/12] mpt3sas: simplify task management functions

2017-03-13 Thread Hannes Reinecke
On 03/06/2017 06:16 AM, Sreekanth Reddy wrote: > I feel that using these flags are not working as expected. From the > driver's prospective it should return status of the TM based on > whether it has cleared reference of the timed out IO in the driver or > not (i.e. if it is successfully able to

[Bug 194837] VM with virtio-scsi drive often crashes during boot with kernel 4.11rc1

2017-03-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194837 --- Comment #4 from Thorsten Leemhuis (li...@leemhuis.info) --- (In reply to Adam Williamson from comment #1) > so the delta is to 'v4.10-11319-gc82be9d', but I dunno what that means > exactly. FWIW, most likely suspects afaics: the second

[Bug 194837] VM with virtio-scsi drive often crashes during boot with kernel 4.11rc1

2017-03-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194837 Thorsten Leemhuis (li...@leemhuis.info) changed: What|Removed |Added CC|

Re: [PATCH] scsi: storvsc: Add support for FC rport.

2017-03-13 Thread Cathy Avery
Hi, I haven't received any feedback yet. Should I resend? Thanks, Cathy On 02/28/2017 01:45 PM, Cathy Avery wrote: Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver

Re: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run

2017-03-13 Thread Hannes Reinecke
On 03/13/2017 02:37 PM, Mauricio Faria de Oliveira wrote: > Hannes, > > On 03/01/2017 06:15 AM, Hannes Reinecke wrote: >> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c >> index f2cafae..cec439c 100644 >> --- a/drivers/scsi/scsi_error.c >> +++ b/drivers/scsi/scsi_error.c >> @@

Re: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run

2017-03-13 Thread Mauricio Faria de Oliveira
Hannes, On 03/01/2017 06:15 AM, Hannes Reinecke wrote: diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index f2cafae..cec439c 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -58,6 +58,7 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd); static

Re: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run

2017-03-13 Thread Hannes Reinecke
On 03/02/2017 09:16 PM, Benjamin Block wrote: > Hej Hannes, > > On Wed, Mar 01, 2017 at 10:15:15AM +0100, Hannes Reinecke wrote: >> The current medium access timeout counter will be increased for >> each command, so if there are enough failed commands we'll hit >> the medium access timeout for

Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

2017-03-13 Thread Sreekanth Reddy
Hi, Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. Whenever we load the mpt3sas driver then we are observing below error message, "Wrong diagnostic page; asked for 7 got 0" Our virtual SES device doesn't support Diagnostic page 7, it supports only below diagnostic pages, •