[Bug 198975] Highpoint 840A RocketRAID Controller and drives are NOT detected by SCSI_HPTIOP kernel module

2018-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198975 --- Comment #2 from Matthias Lippert (mae.lipp...@gmail.com) --- lspci -knn outputs this: 02:00.0 RAID bus controller [0104]: HighPoint Technologies, Inc. Device [1103:0840] (rev a1) Subsystem: HighPoint Technologies, Inc. Device

RE: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-04 Thread Kashyap Desai
> -Original Message- > From: Laurence Oberman [mailto:lober...@redhat.com] > Sent: Saturday, March 3, 2018 3:23 AM > To: Don Brace; Ming Lei > Cc: Jens Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mike > Snitzer; > linux-scsi@vger.kernel.org; Hannes Reinecke; Arun Easi; Omar

Re:[PATCH] scsi: lpfc: Switch memcpy_fromio() to __read32_copy()

2018-03-04 Thread 陈华才
No one has the same problem? Or this patch need improve? Huacai -- Original -- From: "陈华才"; Date: Thu, Mar 1, 2018 01:59 PM To: "James Smart"; "Dick Kennedy"; Cc: "James E . J .

RE: [PATCH] scsi: mpt3sas: clarify mmio pointer types

2018-03-04 Thread Sreekanth Reddy
-Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Thursday, March 1, 2018 6:37 PM To: Suganath Prabu S; Sathya Prakash; Chaitra P B; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Bergmann; Hannes Reinecke; Sreekanth Reddy; mpt-fusionlinux@broadcom.com;

[PATCH V2] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-03-04 Thread Bill Kuzeja
Because of the shifting around of code in qla2x00_probe_one recently, failures during adapter initialization can lead to problems, i.e. NULL pointer crashes and doubly freed data structures which cause eventual panics. This V2 version makes the relevant memory free routines idempotent, so repeat

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Finn Thain
On Mon, 5 Mar 2018, Michael Schmitz wrote: > All Zorro-3 boards have to have both their regs and dma_regs remapped. > I see. > What's confusing is that there is only a single Zorro-3 board currently > supported by the driver. Others will be added and I"ll use a switch > statement to pick the

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Finn Thain
On Mon, 5 Mar 2018, Michael Schmitz wrote: > > The TCQ issue showed up on the AV Quadras becasue mac_esp doesn't know > > how to do PDMA or DMA on that hardware, and so it always uses PIO. It > > sounds like this bug would show up too given the right kind of target. > > If so, I will need to

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-04 Thread Ming Lei
On Fri, Mar 02, 2018 at 04:53:21PM -0500, Laurence Oberman wrote: > On Fri, 2018-03-02 at 15:03 +, Don Brace wrote: > > > -Original Message- > > > From: Laurence Oberman [mailto:lober...@redhat.com] > > > Sent: Friday, March 02, 2018 8:09 AM > > > To: Ming Lei > >

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Michael Schmitz
Hi Finn, On Mon, Mar 5, 2018 at 2:01 PM, Finn Thain wrote: > On Mon, 5 Mar 2018, Michael Schmitz wrote: > >> >> +fail_unmap_dma_regs: >> >> + if (ioaddr > 0xff) >> >> + iounmap(esp->dma_regs); >> > >> > I think you need to test for

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Michael Schmitz
Hi Finn, >> >> +#define ZORRO_ESP_GET_PRIV(esp) ((struct zorro_esp_priv *) \ >> >> + _esp_private_data[(esp->host->host_no)]) >> >> + >> > >> > How do you know that host_no won't exceed the array bounds? >> > Why not use dev_{set,get}_drvdata(esp->dev)? -- much as mac_esp

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Finn Thain
On Mon, 5 Mar 2018, Michael Schmitz wrote: > >> +fail_unmap_dma_regs: > >> + if (ioaddr > 0xff) > >> + iounmap(esp->dma_regs); > > > > I think you need to test for ZORRO_PROD_PHASE5_BLIZZARD_1230_IV_1260 here? > > On second thought - no, I don't. the ID check above only

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Michael Schmitz
Hi Finn, >> +/* zorro_esp.c: ESP front-end for Amiga ZORRO SCSI systems. >> + * >> + * Copyright (C) 1996 Jesper Skov (js...@cygnus.co.uk) >> + * >> + * Copyright (C) 2011,2018 Michael Schmitz (schm...@debian.org) for >> + * migration to ESP SCSI core > > You can blame me for some

Re: [PATCH] Improve ZBC/ZAC error handling

2018-03-04 Thread Damien Le Moal
Tejun, On 2018/03/05 5:33, Tejun Heo wrote: > On Fri, Mar 02, 2018 at 04:40:18AM +0900, Damien Le Moal wrote: >> This series introduces changes to scsi and libata error handling for ZBC and >> ZAC >> devices. >> >> The first patch moves ZBC specific error handling in sd_zbc_complete() to a >>

Re: [PATCH] Improve ZBC/ZAC error handling

2018-03-04 Thread Tejun Heo
On Fri, Mar 02, 2018 at 04:40:18AM +0900, Damien Le Moal wrote: > This series introduces changes to scsi and libata error handling for ZBC and > ZAC > devices. > > The first patch moves ZBC specific error handling in sd_zbc_complete() to a > generic scsi error function that can be used also in

Re: [PATCH 6/6] libata: Be quiet when asked to

2018-03-04 Thread Tejun Heo
Hello, On Fri, Mar 02, 2018 at 04:40:24AM +0900, Damien Le Moal wrote: > For a successful setting of the device transfer speed mode in > ata_dev_set_mode(), do not print the message > "ataX.XX: configured for xxx" if the EH context has the quiet flag set. > > Signed-off-by: Damien Le Moal

[PATCH] scsi: devinfo: delete duplicate "Generic"/"USB Storage-SMC" device

2018-03-04 Thread Xose Vazquez Perez
Revision is irrelevant, it's unused by the scsi infrastructure. Cc: Hannes Reinecke Cc: Martin K. Petersen Cc: James E.J. Bottomley Cc: SCSI ML Signed-off-by: Xose Vazquez Perez

[PATCH] scsi: devinfo: add HP DISK-SUBSYSTEM device, for HP XP arrays

2018-03-04 Thread Xose Vazquez Perez
"The DISK-SUBSYSTEM is a special model name returned when LUs are not installed. For example, when LU#0 is not installed in "OPEN-" models, LU#0 is detected as the DISK-SUBSYSTEM model": https://marc.info/?l=linux-scsi=125424006417825 It's missing for HP XP rebranded arrays, "HP"/"OPEN-". Only

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Finn Thain
On Sun, 4 Mar 2018, Michael Schmitz wrote: > Am 04.03.2018 um 15:55 schrieb Finn Thain: > >> +/* zorro_esp.c: ESP front-end for Amiga ZORRO SCSI systems. > >> + * > >> + * Copyright (C) 1996 Jesper Skov (js...@cygnus.co.uk) > >> + * > >> + * Copyright (C) 2011,2018 Michael Schmitz

[Bug 198861] Regression causes kernel OOPS and hang in SCSI error report

2018-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198861 JMD (kionm...@gmail.com) changed: What|Removed |Added CC||kionm...@gmail.com ---

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 Thread Michael Schmitz
Hi Finn, thanks for your review! Am 04.03.2018 um 15:55 schrieb Finn Thain: > On Sun, 4 Mar 2018, Michael Schmitz wrote: > >> From: Michael Schmitz >> >> New combined SCSI driver for all ESP based Zorro SCSI boards for >> m68k Amiga. >> > > Nice work! > > Shouldn't both