Re: [PATCH V3 7/8] scsi: hpsa: improve scsi_mq performance via .host_tagset

> + /* 256 tags should be high enough to saturate device */ > + int max_queues = DIV_ROUND_UP(h->scsi_host->can_queue, 256); > + > + /* per NUMA node hw queue */ > + h->scsi_host->nr_hw_queues = min_t(int, nr_node_ids, max_queues); I don't think this magic should be in a driver.

Re: [PATCH V3 4/8] blk-mq: introduce BLK_MQ_F_HOST_TAGS

On Tue, Feb 27, 2018 at 06:07:46PM +0800, Ming Lei wrote: > This patch can support to partition host-wide tags to multiple hw queues, > so each hw queue related data structures(tags, hctx) can be accessed in > NUMA locality way, for example, the hw queue can be per NUMA node. > > It is observed

Re: [PATCH V3 3/8] blk-mq: introduce 'start_tag' field to 'struct blk_mq_tags'

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

> +static void hpsa_setup_reply_map(struct ctlr_info *h) > +{ > + const struct cpumask *mask; > + unsigned int queue, cpu; > + > + for (queue = 0; queue < h->msix_vectors; queue++) { > + mask = pci_irq_get_affinity(h->pdev, queue); > + if (!mask) > +

,Your urgent confirmation

Attn: Beneficiary, We have contacted the Federal Ministry of Finance on your Behalf and they have brought a solution to your problem by coordinating your payment in total (10,000,000.00) Ten Million Dollars in an atm card which you can use to withdraw money from any ATM MACHINE CENTER anywhere in

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Tuomas, Am 06.03.2018 um 04:31 schrieb Tuomas Vainikka: >>> I think you are talking about esp->regs? For esp->dma_regs, the >>> ioremap is >>> conditional on ent->id, but the unmap is not. >> The details of the ioremap are conditional on the ID, but the fact >> that the ioremap happens (and

[Bug 198923] Linux 4.15.4+: Write on Ext4 causes system block

https://bugzilla.kernel.org/show_bug.cgi?id=198923 Theodore Tso (ty...@mit.edu) changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Bug 198861] Regression causes kernel OOPS and hang in SCSI error report

https://bugzilla.kernel.org/show_bug.cgi?id=198861 Theodore Tso (ty...@mit.edu) changed: What|Removed |Added CC||m...@elbmurf.de ---

Re: [PATCH v3] scsi: libsas: defer ata device eh commands to libata

On Wed, Mar 7, 2018 at 6:34 PM, Jason Yan wrote: > When ata device doing EH, some commands still attached with tasks are not > passed to libata when abort failed or recover failed, so libata did not > handle these commands. After these commands done, sas task is freed, but >

Re: [PATCH v4 01/10] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

On Wed, Mar 07, 2018 at 08:25:05PM +0800, John Garry wrote: > From: Xiaofei Tan > > For some new boards with hip07 chipset we are required to > set PHY config registers differently. The hw property which > determines how to set these registers is in the PHY signal >

[PATCH v3] scsi: libsas: defer ata device eh commands to libata

When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata did not handle these commands. After these commands done, sas task is freed, but ata qc is not freed. This will cause ata qc leak and trigger a warning like

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Geert, fine, I'll rely on the base address and the z->rom.er_Type value to pick the correct config data. Cheers, Michael On Wed, Mar 7, 2018 at 9:06 PM, Geert Uytterhoeven wrote: > Hi Michael, > > On Wed, Mar 7, 2018 at 8:55 AM, Michael Schmitz

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Wed, Mar 07, 2018 at 10:58:34PM +0530, Kashyap Desai wrote: > > > > > > Also one observation using V3 series patch. I am seeing below Affinity > > > mapping whereas I have only 72 logical CPUs. It means we are really > > > not going to use all reply queues. > > > e.a If I bind fio jobs on CPU

[PATCH] qla2xxx: Remove FC_NO_LOOP_ID for FCP and FC-NVMe Discovery

Commit 7d64c39e64310 fixed regression of FCP discovery when Nport Handle is in-use and relogin is triggered. However, during FCP and FC-NVMe discovery this resulted into only discovering NVMe LUNs. This patch fixes issue where FCP and FC-NVMe protocol is used on same port where assigning

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: > We can derive the order from sg->length and so do not need to pass it > in explicitly.

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 17:23 +, Tvrtko Ursulin wrote: > Ok I guess my main questions are the ones from the cover letter - where > is this API going and why did it get in a bit of a funky state? Because > it doesn't look fully thought through and tested to me. Funky state? Not fully tested?

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

> > > > Also one observation using V3 series patch. I am seeing below Affinity > > mapping whereas I have only 72 logical CPUs. It means we are really > > not going to use all reply queues. > > e.a If I bind fio jobs on CPU 18-20, I am seeing only one reply queue > > is used and that may lead to

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On 07/03/18 16:23, Bart Van Assche wrote: On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: We can derive the order from sg->length and so do not need to pass it in explicitly. Rename the function to sgl_free_n. Using get_order() to compute the order looks fine to me but this patch

Re: dmesg flooded with "Very big device. Trying to use READ CAPACITY(16)"

hen go to the smartmontools mirror at: https://github.com/mirror/smartmontools To check it is the revision (svn rev >= 4718) you need for this fix, look at the top of the ChangeLog file and look for today's date (20180307). Assuming it is there, clone it then try to build smartmontools ( './a

[Bug 198861] Regression causes kernel OOPS and hang in SCSI error report

https://bugzilla.kernel.org/show_bug.cgi?id=198861 Bart Van Assche (bvanass...@acm.org) changed: What|Removed |Added CC||bvanass...@acm.org

[Bug 198923] Linux 4.15.4+: Write on Ext4 causes system block

https://bugzilla.kernel.org/show_bug.cgi?id=198923 Bart Van Assche (bvanass...@acm.org) changed: What|Removed |Added CC||bvanass...@acm.org

[Bug 198923] Linux 4.15.4+: Write on Ext4 causes system block

https://bugzilla.kernel.org/show_bug.cgi?id=198923 Theodore Tso (ty...@mit.edu) changed: What|Removed |Added Status|REOPENED|ASSIGNED

Re: [PATCH v2] scsi: libsas: defer ata device eh commands to libata

On 07/03/2018 09:18, Jack Wang wrote: 2018-03-07 8:47 GMT+01:00 Jason Yan : When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata did not handle these commands. After these commands done,

Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

On Wed, 2018-03-07 at 12:47 +, Tvrtko Ursulin wrote: > We can derive the order from sg->length and so do not need to pass it in > explicitly. Rename the function to sgl_free_n. Using get_order() to compute the order looks fine to me but this patch will have to rebased in order to address the

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Wed, Mar 07, 2018 at 08:31:31PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Wednesday, March 7, 2018 10:58 AM > > To: Kashyap Desai > > Cc: Jens Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mike > Snitzer; > >

Re: [PATCH v2] scsi: libsas: defer ata device eh commands to libata

On Tue, Mar 6, 2018 at 11:47 PM, Jason Yan wrote: > When ata device doing EH, some commands still attached with tasks are not > passed to libata when abort failed or recover failed, so libata did not > handle these commands. After these commands done, sas task is freed, but >

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Wednesday, March 7, 2018 10:58 AM > To: Kashyap Desai > Cc: Jens Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mike Snitzer; > linux-scsi@vger.kernel.org; Hannes Reinecke; Arun Easi; Omar Sandoval; > Martin

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote: > Ming, > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > does fix IO hang, could you consider to merge the two first? > > Oh, and I would still need a formal Acked-by: from Don and Tested-by: > from

Re: dmesg flooded with "Very big device. Trying to use READ CAPACITY(16)"

2018-03-07 14:51 GMT+01:00 Steffen Maier : > > On 03/07/2018 09:24 AM, Menion wrote: >> > ... > > but from then on, you only get it roughly once every 300 seconds, i.e. 5 > minutes > > that's where I suspect user space as trigger, unless there is a kernel > feature I'm

Re: dmesg flooded with "Very big device. Trying to use READ CAPACITY(16)"

On 03/07/2018 09:24 AM, Menion wrote: By flooded I mean that it continously fill the dmesg log with no interruption, check attached a log that I have just taken from my server Some more details on my setup. I have these 5 HDD, WD RED 8TB in an Orico 5 bay enclosure, running JMS567 USBtoSATA

[bug report] scsi: lpfc: Add WQ Full Logic for NVME Target

Hello James Smart, The patch 6e8e1c14c61e: "scsi: lpfc: Add WQ Full Logic for NVME Target" from Jan 30, 2018, leads to the following static checker warning: drivers/scsi/lpfc/lpfc_nvmet.c:921 lpfc_nvmet_xmt_fcp_abort() warn: inconsistent returns 'ctxp->ctxlock'.

[PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order

From: Tvrtko Ursulin We can derive the order from sg->length and so do not need to pass it in explicitly. Rename the function to sgl_free_n. Signed-off-by: Tvrtko Ursulin Cc: Bart Van Assche Cc: Hannes Reinecke

[PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

iscsi tcp will first send out data, then calculate and send data digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will be written in spite of the on going writeback. Consequently, wrong digest will be got and sent to target. To fix this, set BDI_CAP_STABLE_WRITES when data digest is

[PATCH v4 0/10] hisi_sas: support x6000 board and some misc changes

This patchset primarily adds support for the Huawei x6000 board, which includes hip07 chipset. Unfortunately, due to some board layout differences with our development board, we need to set a PHY-related register differently for optimal signal quality. As such, a signal attenuation property is

[PATCH v4 02/10] scsi: hisi_sas: support the property of signal attenuation for v2 hw

From: Xiaofei Tan The register SAS_PHY_CTRL is configured according to signal quality. The signal quality is calculated by signal attenuation of hardware physical link. It may be different for different PCB layout. So, in order to give better support to new board, this

[PATCH v4 06/10] scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req

From: Xiang Chen The structure element hisi_sas_devices.running_req to count how many commands are active is in effect only ever written in the code, so remove it. Signed-off-by: Xiang Chen Signed-off-by: John Garry

[PATCH v4 03/10] scsi: hisi_sas: fix the issue of link rate inconsistency

From: Xiaofei Tan In sysfs, there are two files about minimum linkrate, and also two files for maximum linkrate. Take maximum linkrate example, maximum_linkrate_hw is read-only and indicated by the register HARD_PHY_LINKRATE, and maximum_linkrate is read-write and

[PATCH v4 09/10] scsi: hisi_sas: modify some register config for hip08

From: Xiaofei Tan Do some modifications for register configuring for hip08. In future, to reduce kernel churn with patches to modify registers, any registers which may change between board models (mostly PHY/SERDES related) should be set in ACPI reset handler.

[PATCH v4 05/10] scsi: hisi_sas: increase timer expire of internal abort task

From: Xiaofei Tan The current 110ms expiry time is not long enough for the internal abort task. The reason is that the internal abort task could be blocked in HW if the HW is retrying to set up link. The internal abort task will be executed only when the retry process

[PATCH v4 10/10] scsi: hisi_sas: add v3 hw MODULE_DEVICE_TABLE()

From: Xiang Chen Export device table of v3 hw to userspace, or auto probe will fail for v3 hw. Also change the module alias to include "pci", instead of "platform". Signed-off-by: Xiang Chen Signed-off-by: John Garry

[PATCH v4 08/10] scsi: hisi_sas: Code cleanup and minor bug fixes

From: Xiang Chen The patch does some code cleanup and fixes some small bugs: - Correct return status of phy_up_v3_hw() and phy_bcast_v3_hw() - Add static for function phy_get_max_linkrate_v3_hw() - Change exception return status when no reset method - Change magic

[PATCH v4 01/10] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

From: Xiaofei Tan For some new boards with hip07 chipset we are required to set PHY config registers differently. The hw property which determines how to set these registers is in the PHY signal attenuation readings. This patch add an devicetree property,

[PATCH v4 04/10] scsi: hisi_sas: fix the issue of setting linkrate register

From: Xiaofei Tan It is not right to set the register PROG_PHY_LINK_RATE while PHY is still enabled. So if we want to change PHY linkrate, we need to disable PHY before setting the register PROG_PHY_LINK_RATE, and then start-up PHY. This patch is to fix this issue.

[PATCH v4 07/10] scsi: hisi_sas: fix return value of hisi_sas_task_prep()

From: Xiaofei Tan It is an implicit regulation that error code that function returned should be negative. But hisi_sas_task_prep() doesn't follow this. This may cause problems in the upper layer code. For example, in sas_expander.c of libsas, smp_execute_task_sg() may

[PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/scsi/scsi_transport_iscsi.c | 27 +-- 1 file changed,

[PATCH] target: tcm_loop: use put_device() if device_register fail

if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/target/loopback/tcm_loop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/target/loopback/tcm_loop.c

Re: dmesg flooded with "Very big device. Trying to use READ CAPACITY(16)"

Hello Martin Thanks for your answer. By flooded I mean that it continously fill the dmesg log with no interruption, check attached a log that I have just taken from my server Some more details on my setup. I have these 5 HDD, WD RED 8TB in an Orico 5 bay enclosure, running JMS567 USBtoSATA bridge

Re: [PATCH] scsi: ipr: Use dma_pool_zalloc()

On Wed, Mar 7, 2018 at 8:45 AM, Martin K. Petersen wrote: > > Brian, > >> Thanks! >> >> Acked-by: Brian King > > Not sure where this patch was sent but it's not in my mailbox, nor the > list archives. > > Souptick: Please resubmit to

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Michael, On Wed, Mar 7, 2018 at 8:55 AM, Michael Schmitz wrote: > OK, in that case I'll need to work out something similar to the test for > optional SCSI function on the Blizzard 1230/1260 to find out what board > I have when dealing with the duplicate