Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

2018-03-13 Thread Michael Schmitz
Hi Finn, Am 12.03.2018 um 22:04 schrieb Finn Thain: >> +if (addr == esp->command_block_dma) >> +addr = (u32) esp->command_block; > > Since you've removed the alternative branch and phys_to_virt(), I suggest > you do this at function invocation... (see below) Keeps it together

答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-03-13 Thread liwei (CM)
Hi,Arnd Sorry to bother you again, please take the time to review the patch. Are there any other suggestions? Looking forward to your reply. Thanks! -邮件原件- 发件人: liwei (CM) 发送时间: 2018年2月23日 16:36 收件人: 'Arnd Bergmann' 抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will

Re: mpt3sas: sleeping function called from invalid context

2018-03-13 Thread Bart Van Assche
(+Jaco) On Tue, 2018-03-13 at 16:18 +0530, Suganath Prabu Subramani wrote: > We have root caused the issue and it is same as you mentioned. > "_scsih_get_enclosure_logicalid_chassis_slot()" is called with interrupts > disabled and this function > "_scsih_get_enclosure_logicalid_chassis_slot"

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-13 Thread Salvatore Mesoraca
2018-03-13 10:05 GMT+01:00 Christoph Hellwig : > On Mon, Mar 12, 2018 at 10:35:36PM -0400, Martin K. Petersen wrote: >> No objections to Salvatore's patch but I have a slight affinity for >> retiring unused code over patching it. So unless there are objections... > > Lets kill

[PATCH] scsi: eata: eata-pio: Deprecate legacy EATA drivers

2018-03-13 Thread Martin K. Petersen
These two drivers do not appear to be in active use. Deprecate them. Signed-off-by: Martin K. Petersen --- MAINTAINERS |6 - drivers/scsi/Kconfig| 62 -- drivers/scsi/Makefile |2 - drivers/scsi/eata.c | 2571

Re: bsg-lib interface cleanup V2

2018-03-13 Thread Jens Axboe
On 3/13/18 9:28 AM, Christoph Hellwig wrote: > Hi all, > > this series cleans up various abuses of the bsg interfaces, and then > splits bsg for SCSI passthrough from bsg for arbitrary transport > passthrough. This removes the scsi_request abuse in bsg-lib that is > very confusing, and also

RE: [PATCH V5 2/5] scsi: megaraid_sas: fix selection of reply queue

2018-03-13 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Tuesday, March 13, 2018 3:13 PM > To: James Bottomley; Jens Axboe; Martin K . Petersen > Cc: Christoph Hellwig; linux-scsi@vger.kernel.org; linux- > bl...@vger.kernel.org; Meelis Roos; Don Brace; Kashyap Desai;

Re: [PATCH][next] scsi: lpfc: make several unions static, fix non-ANSI prototype

2018-03-13 Thread James Smart
On 3/13/2018 5:08 AM, Colin King wrote: From: Colin Ian King There are several unions that are local to the source and do not need to be in global scope, so make them static. Also add in a missing void parameter to functions lpfc_nvme_cmd_template and

[PATCH 2/3] bsg-lib: remove bsg_job.req

2018-03-13 Thread Christoph Hellwig
Users of the bsg-lib interface should only use the bsg_job data structure and not know about implementation details of it. Signed-off-by: Christoph Hellwig Reviewed-by: Benjamin Block Reviewed-by: Hannes Reinecke Reviewed-by: Johannes

[PATCH 3/3] bsg: split handling of SCSI CDBs vs transport requeues

2018-03-13 Thread Christoph Hellwig
The current BSG design tries to shoe-horn the transport-specific passthrough commands into the overall framework for SCSI passthrough requests. This has a couple problems: - each passthrough queue has to set the QUEUE_FLAG_SCSI_PASSTHROUGH flag despite not dealing with SCSI commands at all.

[PATCH 1/3] bsg-lib: introduce a timeout field in struct bsg_job

2018-03-13 Thread Christoph Hellwig
The zfcp driver wants to know the timeout for a bsg job, so add a field to struct bsg_job for it in preparation of not exposing the request to the bsg-lib users. Signed-off-by: Christoph Hellwig Reviewed-by: Benjamin Block Reviewed-by: Hannes Reinecke

bsg-lib interface cleanup V2

2018-03-13 Thread Christoph Hellwig
Hi all, this series cleans up various abuses of the bsg interfaces, and then splits bsg for SCSI passthrough from bsg for arbitrary transport passthrough. This removes the scsi_request abuse in bsg-lib that is very confusing, and also makes sure we can sanity check the requests we get. The

Re: [Possible REGRESSION, 4.16-rc4] Error updating SMART data during runtime and could not connect to lvmetad at some boot attempts

2018-03-13 Thread Bart Van Assche
On Tue, 2018-03-13 at 22:32 +0800, Ming Lei wrote: > On Tue, Mar 13, 2018 at 02:08:23PM +0100, Martin Steigerwald wrote: > > Ming and Bart, I added you to cc, cause I had to do with you about another > > blk-mq report, please feel free to adapt. > > Looks RIP points to scsi_times_out+0x17/0x1d0,

Re: [Possible REGRESSION, 4.16-rc4] Error updating SMART data during runtime and could not connect to lvmetad at some boot attempts

2018-03-13 Thread Ming Lei
On Tue, Mar 13, 2018 at 02:08:23PM +0100, Martin Steigerwald wrote: > Hans de Goede - 11.03.18, 15:37: > > Hi Martin, > > > > On 11-03-18 09:20, Martin Steigerwald wrote: > > > Hello. > > > > > > Since 4.16-rc4 (upgraded from 4.15.2 which worked) I have an issue > > > with SMART checks

Immediate Reply.

2018-03-13 Thread Isa Zongo
Dear Friend, I know that, this letter will come to you as surprise, I got your contact address while I was searching for foreign partner to champion this golden appoint unity that is present in our favor, My name is Mr. Isa Zongo, I am the Bill and Exchange (assistant) Manager CORIS BANK

[PATCH][next] scsi: lpfc: make several unions static, fix non-ANSI prototype

2018-03-13 Thread Colin King
From: Colin Ian King There are several unions that are local to the source and do not need to be in global scope, so make them static. Also add in a missing void parameter to functions lpfc_nvme_cmd_template and lpfc_nvmet_cmd_template to clean up non-ANSI warning.

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

2018-03-13 Thread Kashyap Chamarthy
On Tue, Mar 13, 2018 at 12:42:47PM +0100, Kashyap Chamarthy wrote: > [Cross-posted to 'linux-scsi' and 'linux-usb' lists; please keep me > Cced, as I'm not subscribed to either of them.) [...] > I was suggested to return this SSD. But the Interweb[%] claims Samsung > T5 *does* have 'TRIM' (i.e.

Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

2018-03-13 Thread Kashyap Chamarthy
[Cross-posted to 'linux-scsi' and 'linux-usb' lists; please keep me Cced, as I'm not subscribed to either of them.) I unboxed a brand new Samsung T5 SSD[*]. Then formatted it with EXT4 filesystem. I wanted to clean the disk of any existing software, so I was reminded by a colleague to use

RE: [PATCH] scsi: resolve COMMAND_SIZE at compile time

2018-03-13 Thread David Laight
From: Stephen Kitt > Sent: 09 March 2018 22:34 > > COMMAND_SIZE currently uses an array of values in block/scsi_ioctl.c. > A number of device_handler functions use this to initialise arrays, > and this is flagged by -Wvla. > > This patch replaces COMMAND_SIZE with a variant using a formula which

Re: mpt3sas: sleeping function called from invalid context

2018-03-13 Thread Suganath Prabu Subramani
Hi Bart, We have root caused the issue and it is same as you mentioned. "_scsih_get_enclosure_logicalid_chassis_slot()" is called with interrupts disabled and this function "_scsih_get_enclosure_logicalid_chassis_slot" again calls _config_request(), with mutex_lock(). We have patch ready along

[PATCH V5 5/5] scsi: virtio_scsi: unify scsi_host_template

2018-03-13 Thread Ming Lei
Now we switch to use_blk_mq always, and both single queue and multi queue cases can be handled in one .queuecommand callback, not necessary to use two scsi_host_template. Suggested-by: Christoph Hellwig , Cc: Omar Sandoval , Cc: "Martin K. Petersen"

[PATCH V5 3/5] scsi: introduce force_blk_mq

2018-03-13 Thread Ming Lei
>From scsi driver view, it is a bit troublesome to support both blk-mq and non-blk-mq at the same time, especially when drivers need to support multi hw-queue. This patch introduces 'force_blk_mq' to scsi_host_template so that drivers can provide blk-mq only support, so driver code can avoid the

[PATCH V5 4/5] scsi: virtio_scsi: fix IO hang caused by irq vector automatic affinity

2018-03-13 Thread Ming Lei
Now 84676c1f21e8ff5(genirq/affinity: assign vectors to all possible CPUs) has been merged to V4.16-rc, and it is easy to allocate all offline CPUs for some irq vectors, this can't be avoided even though the allocation is improved. For example, on a 8cores VM, 4~7 are not-present/offline, 4 queues

[PATCH V5 2/5] scsi: megaraid_sas: fix selection of reply queue

2018-03-13 Thread Ming Lei
>From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs), one msix vector can be created without any online CPU mapped, then command may be queued, and won't be notified after its completion. This patch setups mapping between cpu and reply queue according to irq affinity info

[PATCH V5 1/5] scsi: hpsa: fix selection of reply queue

2018-03-13 Thread Ming Lei
>From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs), one msix vector can be created without any online CPU mapped, then one command's completion may not be notified. This patch setups mapping between cpu and reply queue according to irq affinity info retrived by

[PATCH V5 0/5] SCSI: fix selection of reply(hw) queue

2018-03-13 Thread Ming Lei
Hi All, The patches fixes reply queue(virt-queue on virtio-scsi) selection on hpsa, megaraid_sa and virtio-scsi, and IO hang can be caused easily by this issue. This issue is triggered by 84676c1f21e8 ("genirq/affinity: assign vectors to all possible CPUs"). After 84676c1f21e8, it is easy to see

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-13 Thread Christoph Hellwig
On Mon, Mar 12, 2018 at 10:35:36PM -0400, Martin K. Petersen wrote: > No objections to Salvatore's patch but I have a slight affinity for > retiring unused code over patching it. So unless there are objections... Lets kill it. And the not DMA capable eata_pio driver with it for good riddance. >