RE: [PATCH 1/1] target:separate tx/rx cmd_puds

> -Original Message- > From: David Disseldorp [mailto:dd...@suse.de] > Sent: Friday, April 6, 2018 8:10 PM > To: Zhang Zhuoyu > Cc: n...@linux-iscsi.org; linux-scsi@vger.kernel.org; target- > de...@vger.kernel.org; linux-ker...@vger.kernel.org >

[PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for lack of maintenance) with contributions by

Re: [PATCH v2] scsi_debug: implement IMMED bit

On Fri, Feb 09, 2018 at 09:36:39PM -0500, Douglas Gilbert wrote: > The Start Stop Unit (SSU) command takes in the order of a second to > complete on some SAS SSDs and longer on hard disks. Synchronize Cache (SC) > can also take some time. Both commands have an IMMED bit in their cdbs for > those

Re: [PATCH v6] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Finn, Am 07.04.2018 um 22:19 schrieb Finn Thain: > On Sat, 7 Apr 2018, Michael Schmitz wrote: > >>> >>> CHECK /home/fthain/src/kernel.org/linux/drivers/scsi/zorro_esp.c >>> drivers/scsi/zorro_esp.c:274:14: warning: cast removes address space of >>> expression >>>

[PATCH 03/14] lpfc: Add per io channel NVME IO statistics

When debugging various issues, per IO channel IO statistics were useful to understand what was happening. However, many of the stats were on a port basis rather than an io channel basis. Move statistics to an io channel basis. Signed-off-by: Dick Kennedy

[PATCH 00/14] lpfc updates for 12.0.0.2

This patch contains lpfc bug fixes The patches were cut against the Martin's 4.17/scsi-queue tree James Smart (14): lpfc: Fix multiple PRLI completion error path lpfc: Correct target queue depth application changes lpfc: Add per io channel NVME IO statistics lpfc: Enlarge nvmet

[PATCH 10/14] lpfc: Fix nvme remoteport registration race conditions

On tests adding and removing a remote port, calls to nvme_info would eventually show fewer target ports discovered than were present in the san. Additionally, the following error messages were seen: 6031 RemotePort Registration failed err: -116, DID x471301 There is a race condition that exists

[PATCH 14/14] lpfc: update driver version to 12.0.0.2

Update the driver version to 12.0.0.2 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h

[PATCH 11/14] lpfc: Fix NULL pointer reference when resetting adapter

Points referencing local port structures didn't accommodate cases where the localport may not be registered yet. Add NULL pointer checks to logic. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 36

[PATCH 01/14] lpfc: Fix multiple PRLI completion error path

Nodelist entry for SCSI array ends up in UNMAPPED state. This is due to illegal discovery State machine transition because of two PRLIs and the first one failing with LS_RJT. Also, the error path was designed assuming the PRLIs complete in the order they were sent, FCP first, then NVME. In a

[PATCH 05/14] lpfc: Fix Abort request WQ selection

When running loads that generated aborts, io errors where seen. Turns out the abort requests where not placed on the proper WQ resulting in the errors. Closer inspection inspection of this error also showed improper spinlock api use. Correct the WQ selection policy for the abort requests. Correct

[PATCH 07/14] lpfc: Fix NULL pointer access in lpfc_nvme_info_show

After making remoteport unregister requests, the ndlp nrport pointer was stale. Track when waiting for waiting for unregister completion callback and adjust nldp pointer assignment. Add a few safety checks for NULL pointer values. Signed-off-by: Dick Kennedy

[PATCH 08/14] lpfc: Fix WQ/CQ creation for older asic's.

The patch to enlarge WQ/CQ creation keys off of an adapter response that indicates support for the larger values. Older adapters return an incorrect response and are limited in size. Thus the adapters fail the WQ creation steps. Augment the WQ sizing checks with a check on the older adapter types

[PATCH 04/14] lpfc: Enlarge nvmet asynchronous receive buffer counts

Under large io load, the current sizing of asynchronous buffer counts could be exceeded, indicated by a 2885 log message: 2885 Port Status Event: port status reg 0x8180, port smphr reg 0xc000, error 1=0x52004a01, error 2=0x0 Enlarge the async receive queue size. Allow for a

[PATCH 02/14] lpfc: Correct target queue depth application changes

The max_scsicmpl_time parameter can be used to perform scsi cmd queue depth mgmt based on io completion time: the queue depth is reduced to make completion time shorter. However, as soon as an io completes and the completion time is within limits, the code immediately bumps the queue depth limit

[PATCH 06/14] lpfc: Fix lingering lpfc_wq resource after driver unload

After driver unloads lpfc_wq remains active. The destroy_workqueue calls were not being made in driver unload. Additionally, SLI3 is allocating lpfc_wq resources, but never uses it. Make the destroy_workqueue calls on driver unload. Modify the SLI3 code path no longer allocate lpfc_wq resources.

[PATCH 09/14] lpfc: Fix driver not recovering NVME rports during target link faults

During target-side port faults, the driver would not recover all target port logins. This resulted in a loss of nvme device discovery. The driver is coded to wait for all GID_FT requests to complete before restarting discovery. A fault is seen where the outstanding GIT_FT counts are not properly

[PATCH 13/14] lpfc: Correct missing remoteport registration during link bounces

Remote port disappearance/reappearances would cause a series of RSCN events to be delivered to the driver. During the resulting GID_FT handling, the driver clears the fc4 settings on the remote port, which makes it skip registration. As such, the nvme associations eventually fail and return io

[PATCH 12/14] lpfc: Fix create_association oops on unloading LPFC driver

Driver unload isn't waiting for all outstanding nvme associations to terminate before clearing structures. In particular, it did not set dev_loss_tmo to 0 such that all associations are immediately terminated. Thus the transport would enter reconnect timeouts and reattempt reconnect to an nvme

Re: 4.15.14 crash with iscsi target and dvd

Wakko Warner wrote: > Bart Van Assche wrote: > > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is > > > null. > > > I added a dev_printk in scsi_print_command where the 2 if statements > > > return. > > > Logs: > >

Re: 4.15.14 crash with iscsi target and dvd

Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: [PATCH v6] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Finn, Am 07.04.2018 um 12:59 schrieb Finn Thain: > On Sat, 7 Apr 2018, Michael Schmitz wrote: > >> Changes since v5: >> >> Christoph Hellwig: >> >> - fix comment style >> - drop initialization to zero in driver data init >> - fix alignment in struct declarations >> - drop braces around asm

Re: [PATCH 01/10] staging: fnic2 add initialization

On Fri, Apr 06, 2018 at 03:00:11PM -0700, Oliver Smith-Denny wrote: > On Fri, Apr 06, 2018 at 07:07:52AM +0200, Greg Kroah-Hartman wrote: > > Why is this a drivers/staging/ driver at all? What is keeping you from > > getting this merged into the "proper" place in the kernel? > > > > If you have