Re: [PATCH v2] target: transport should allow st ILI reads

2018-05-10 Thread Lee Duncan
On 05/10/2018 12:19 PM, Mike Christie wrote: > On 05/10/2018 01:51 PM, Mike Christie wrote: >> On 05/09/2018 03:59 PM, Lee Duncan wrote: >>> When a tape drive is exported via LIO using the >>> pscsi module, a read that requests more bytes per block >>> than the tape can supply returns an empty

Re: [PATCH v2] target: transport should allow st ILI reads

2018-05-10 Thread Mike Christie
On 05/10/2018 01:51 PM, Mike Christie wrote: > On 05/09/2018 03:59 PM, Lee Duncan wrote: >> When a tape drive is exported via LIO using the >> pscsi module, a read that requests more bytes per block >> than the tape can supply returns an empty buffer. This >> is because the pscsi pass-through

Re: [PATCH v2] target: transport should allow st ILI reads

2018-05-10 Thread Mike Christie
On 05/09/2018 03:59 PM, Lee Duncan wrote: > When a tape drive is exported via LIO using the > pscsi module, a read that requests more bytes per block > than the tape can supply returns an empty buffer. This > is because the pscsi pass-through target module sees > the "ILI" illegal length bit set

Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host

2018-05-10 Thread Tejun Heo
On Thu, May 10, 2018 at 11:05:16AM +0800, Jason Yan wrote: > Commit 2623c7a5f2 ("libata: add refcounting to ata_host") v4.17+ > introduced refcounting to ata_host and will increase or decrease the > refcount when adding or deleting transport ATA port. libata side looks good to me. Acked-by:

Re: [RESEND] tcmu: fix error resetting qfull_time_out to default

2018-05-10 Thread Mike Christie
On 05/10/2018 08:42 AM, Prasanna Kumar Kalever wrote: > Problem: > --- > $ cat /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out > -1 > > $ echo "-1" > > /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out > -bash: echo: write error: Invalid argument > > Fix: >

[RESEND] tcmu: fix error resetting qfull_time_out to default

2018-05-10 Thread Prasanna Kumar Kalever
Problem: --- $ cat /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out -1 $ echo "-1" > /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out -bash: echo: write error: Invalid argument Fix: --- This patch will help reset qfull_time_out to its default i.e.

Re: [PATCH] scsi: qlogicpti: Fix an error handling path in 'qpti_sbus_probe()'

2018-05-10 Thread Dan Carpenter
On Thu, May 10, 2018 at 01:45:58PM +0200, Christophe JAILLET wrote: > The 'free_irq()' call is not at the right place in the error handling path. > The changed order has been introduced in commit 3d4253d9afab > ("[SCSI] qlogicpti: Convert to new SBUS device framework.") > > Fixes: 3d4253d9afab

[PATCH] scsi: qlogicpti: Fix an error handling path in 'qpti_sbus_probe()'

2018-05-10 Thread Christophe JAILLET
The 'free_irq()' call is not at the right place in the error handling path. The changed order has been introduced in commit 3d4253d9afab ("[SCSI] qlogicpti: Convert to new SBUS device framework.") Fixes: 3d4253d9afab ("[SCSI] qlogicpti: Convert to new SBUS device framework.") Signed-off-by:

Re: [PATCH v2] target: transport should allow st ILI reads

2018-05-10 Thread Christoph Hellwig
On Wed, May 09, 2018 at 01:59:21PM -0700, Lee Duncan wrote: > When a tape drive is exported via LIO using the > pscsi module, a read that requests more bytes per block > than the tape can supply returns an empty buffer. This > is because the pscsi pass-through target module sees > the "ILI"