On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote:
That's good to know (I was worried the device would not be detected as
supporting discard because it doesn't report lbpme and doesn't declare a
conformance version (see below)).
Ok, that makes things worse - you might be able to
On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote:
I'm not sure this alone will work - won't sdev_bflags/bflags have
already been built at this point?
They've been built up, but we can still or new values into it. It looks
fine to me from review, but if you can test it on an
Thanks, this one looks good to me. Can someone else give me a second
review on the attached patch so I can merged it?
---
From 95bc83fa0d6e9a6152cd6fce79ff87c0994e83ed Mon Sep 17 00:00:00 2001
From: Janusz Dziemidowicz rrapt...@nails.eu.org
Date: Thu, 24 Jul 2014 15:48:46 +0200
Subject: [PATCH]
On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote:
I'm very much against short-circuiting the LBP logic in a passthrough
driver because then we might end up in the exact situation we were
trying to avoid with this patch series. Namely sending down commands
unsupported by the
On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote:
I agree - I'd like to pull in KY's simple fix as soon as I get a second
review for it.
Ok, looks like I just got that from Hannes. Let's see if there's more
to be done for the pass through case, but I'd rather wait for the next
On Tue, Jul 22, 2014 at 12:18:19AM -0400, Martin K. Petersen wrote:
More nitpicking. In the two previous atomic conversion patches you kept
%hu for the atomic_t. Here it's %d.
I'll fix it to use %d everywhere, given that's it's not an unsigned short
anymore.
--
To unsubscribe from this list:
I've pushed out new version of the for-3.17 core and drivers trees:
git://git.infradead.org/users/hch/scsi-queue.git core-for-3.17
git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17
In the core tree the biggest update is the merge of the blk-mq
support, but various smaller
choose which I/O direction the calculation should apply to.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Thanks, this looks good to me,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
Just a quick glance:
a) this should move to drivers/target with the other target code
b) you're still having your own CDB emulation in there, the target code
should be taking care of all that.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
Not sure what this buys us until other uses show up, but it looks
fine to me:
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 25, 2014 at 04:34:21PM -0400, Martin K. Petersen wrote:
+ return sectors (ilog2(bi-interval) - 9);
I was going to say this should be 'SECTOR_SHIFT', but that constant
or variants of it are only defined locally in various subsystems..
Looks good,
Reviewed-by: Christoph Hellwig
Christoph Hellwig (1):
reserve block tags in scsi host
So you found this one useful. This begs the question how we should
move forward with it, as it will only work with the blk-mq path in
it's current form.
I can see three ways:
- we implement equivalent functionality in the old block
I just saw this patch showing up again in the hpsa series, so let's get
the discussiong going on how to proceed again:
I think we can't simply apply the current version as it breaks the intended
semantics in the FC drivers that expect an array with target-wide ressources.
So if we want to go
On Sat, Jul 26, 2014 at 11:14:35AM -0500, Stephen Cameron wrote:
Hmm, I forgot that that patch was in there, I wasn't trying to keep pushing
it along. From the previous discussion, I got the impression I was simply
wrong, and that this patch wasn't needed, so I had meant to drop it, I just
Here's a formal one.
James, can I get your signoff for it?
Vladimir, can I get a reviewed-by from you (or anyone else)?
---
From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001
From: James Bottomley james.bottom...@hansenpartnership.com
Date: Sat, 26 Jul 2014 12:21:26 -0400
I haven't done an in-depth review of the whole series, but it looks
generally good to me. How should we pull it in? Normally block
stuff should go through Jens, but the sd changes won't apply without
the various patches in the scsi tree.
--
To unsubscribe from this list: send the line
Can I get a quick review for this one?
On Mon, Jul 14, 2014 at 10:26:33AM +0200, Christoph Hellwig wrote:
port_detect is only called from the module_init routine and thus implicitly
serialized, so remove the driver lock which was held over potentially
sleeping function calls.
Signed-off
On Sun, Jul 27, 2014 at 12:11:11PM +0300, Boaz Harrosh wrote:
If you have a tree that you want me to test I will be glad too.
From this thread I'm confused as to what patches you want me to
test? please point me to a tree you need testing. You can bug me
any time, any tree. I will be happy to
On Mon, Jul 28, 2014 at 11:49:22AM +0400, James Bottomley wrote:
That needs to be
From: James Bottomley jbottom...@parallels.com
As well. I do list handling on hansenpartnership.com to minimise
exchange wreckage on mailinglists, but I should acknowledge Parallels as
supporting the work I
On Mon, Jul 28, 2014 at 05:35:34AM +0200, J?rgen Gro? wrote:
On 07/26/2014 05:23 PM, Christoph Hellwig wrote:
Just a quick glance:
a) this should move to drivers/target with the other target code
I don't mind. I just followed the example of drivers/vhost/vhost.c and
thought the similar
Sami, can you review the remaining patches in the series so that it's
ready to be included in the scsi tree once Jens decides he is fine with
that?
Thanks,
Christoph
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
On Thu, Jul 17, 2014 at 01:28:20PM -0700, Christoph Hellwig wrote:
Can I get reviews for the patches still missing one, maybe from the
Distro folks? I'd like to pull in the whole things in favor of cherry
picking the reviewed patches.
I've applied those few patches that did get a review
ping? ?I'd really like to get a review on this one and merge it for
3.17
On Thu, Jul 24, 2014 at 08:28:38AM -0700, Christoph Hellwig wrote:
Thanks, this one looks good to me. Can someone else give me a second
review on the attached patch so I can merged it?
---
From
Nic,
any progress on looking over these? Seems like there's actually
nothing at all queued up for 3.17 in the target tree, or am І missing
something?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote:
Hi,
patch looks good.
A correction in pm8001_request_irq might be added too to allow
the INT-X path when pm8001_setup_msix fails, but that is not part
of this fix.
There's actually an equivalent fix already in through one of
Can I get another review for this one? Sami?
On Fri, Jul 25, 2014 at 02:19:27PM -0700, Christoph Hellwig wrote:
On Fri, Jul 25, 2014 at 04:00:19PM -0400, Martin K. Petersen wrote:
For bidirectional commands we need to be able to distinguish between the
in and out scsi_data_buffers when
+ * Patched to support 2TB drives
+ * 2010, Samuel Kvasnica, IMS Nanofabrication AG
+ */
This doesn't really belong into the top of the file comment and should
be moved to the patch description.
+
+#include linux/version.h
not needed.
+static int get_id_from_freelist(struct
On Tue, Jul 29, 2014 at 04:15:45PM +0200, Alexander Gordeev wrote:
Hmm.. 18/23 applies with a minor fuzz against
git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17
Okay, it was just git-am being goofy then. I'll take care of it.
--
To unsubscribe from this list: send the line
On Tue, Jul 29, 2014 at 04:45:16PM +0200, Hannes Reinecke wrote:
ZAC (zoned-access command) drives translate into ZBC (Zoned block
command) device type for SCSI. So implement the correct mappings
into libata-scsi and update the SCSI command set versions.
This seems to both set the periphal
On Tue, Jul 29, 2014 at 04:45:17PM +0200, Hannes Reinecke wrote:
ZBC drives are close to disk devices, so sd.c is well
suited as a testbed for ZBC devices.
This patch introduces a module option 'attach_zbc' to
sd which will make the sd driver accept ZBC
devices as normal disk drives.
On Tue, Jul 29, 2014 at 07:07:51PM +, bugzilla-dae...@bugzilla.kernel.org
wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=79901
--- Comment #3 from Janusz Dziemidowicz rrapt...@nails.eu.org ---
I've read that document before creating the patch. Now, I've read it again. I
must say I'm
On Wed, Jul 30, 2014 at 08:41:55AM +0200, Hannes Reinecke wrote:
Yes, eventually. But can't we defer that to a next patchset?
I'd really like to have this one in, as it makes dealing with ZAC devices
_so much_ easier ...
I'm happy to put the sd patch in if I can get another review for it.
But
Can I get reviews for the remaining patches, please?
On Sat, Jul 12, 2014 at 03:51:47PM -0500, micha...@cs.wisc.edu wrote:
The following patches were made over Chrisoph's scsi-queue drivers-for-3.17
branch. They are some fixes to the get_host_stats code and new error code
for when a iscsi ping
On Wed, Jul 30, 2014 at 08:21:35AM -0400, Josh Boyer wrote:
Thanks, I've update the author, added a Cc to ћtable and pushed it out to
the core-for-3.17 branch.
This fixes a bug in the 3.16 kernel. Why wouldn't it be sent to Linus
for inclusion in the final release there?
I'm only
On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote:
Some drivers like qla2xxx do not set proc_name. I think if 2 drivers
like that are loaded then you will hit some other warns/bugs in the kmem
cache setup code right?
Drivers have to opt into using their own caches by setting
Thanks, Randy.
I'll merge it. I usually want a second review for scsi patches, but I
guess this one is trivial enough to waive that requirement.
That being said is anyone still using the u14-34f driver? From looking
at the commit history it doesn't really look either maintained or used..
--
Can I also get a second review?
On Sat, Jul 26, 2014 at 09:25:59AM -0700, Christoph Hellwig wrote:
Can I get a quick review for this one?
On Mon, Jul 14, 2014 at 10:26:33AM +0200, Christoph Hellwig wrote:
port_detect is only called from the module_init routine and thus implicitly
On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote:
From: Juergen Gross jgr...@suse.com
If a scsi host driver specifies .cmd_len in it's scsi_host_template, a
driver's
private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
scsi_alloc_host_cmd_pool()
On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote:
Hmm, I looked into scsi_add_device(). It seems as if the caller can't
distinguish between a new created and an already existing device. Am I
missing something?
That's right. If you need that I still think it's better to add a
I've pushed out updates to both the core-for-3.17 and drivers-for-3.17
branches. I think we're in a good shape for the merge window, but
I'd still like to get reviewers attention for a few driver updates that
I'd love to get in still:
- my eata patch to remove the driver_lock
- the partially
-static void arcmsr_define_adapter_type(struct AdapterControlBlock *acb)
+static bool arcmsr_define_adapter_type(struct AdapterControlBlock *acb)
{
struct pci_dev *pdev = acb-pdev;
u16 dev_id;
+
pci_read_config_word(pdev, PCI_DEVICE_ID, dev_id);
acb-dev_id =
@@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru
arcmsr_handle_virtual_command(acb, cmd);
return 0;
}
- if (atomic_read(acb-ccboutstandingcount) =
- ARCMSR_MAX_OUTSTANDING_CMD)
+ if
Hi Anish,
Linus plans to do the 3.16 release this weekend, so unless you have
really urgent fixes that require changes from the scsi and net tree I'd
rather avoid the whole issue but waiting for the next merge window.
Can you wait another week or two for these updates?
--
To unsubscribe from
On Fri, Aug 01, 2014 at 03:06:04PM +0200, Juergen Gross wrote:
That's right. If you need that I still think it's better to add a
variant of scsi_add_device helping you with that.
I'm open to that solution.
Do you have preferences how to do it (IOW: can you give me a hint)?
I thought
On Mon, Aug 04, 2014 at 10:48:37AM +0200, Martin Kepplinger wrote:
Use %llu for u64 and %u for int. Not the other way round.
I've already queued up an equivalent fix in my core-for-3.17 branch,
I just need James to pull it into the scsi for-next tree.
--
To unsubscribe from this list: send the
On Mon, Aug 04, 2014 at 06:22:59AM +0200, Juergen Gross wrote:
OTOH it would be possible to just delete .cmd_pool in the template when
deleting the pool. I'll send a patch doing this and you can decide
whether to take it or to use the other solution.
I'm not sure which to prefer: the
On Sat, Aug 02, 2014 at 12:24:34AM +0400, James Bottomley wrote:
Wait, that's not right at all. There looks to be a thinko in the
command pool handling code. We have both a cmd_pool in the host
structure and in the host template structure, but there's confusion
about which one we're supposed
On Mon, Aug 04, 2014 at 06:26:09AM +0200, jgr...@suse.com wrote:
From: Juergen Gross jgr...@suse.com
If a scsi host driver specifies .cmd_len in it's scsi_host_template, a
driver's
private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
scsi_alloc_host_cmd_pool()
On Fri, Aug 01, 2014 at 04:32:01PM -0400, James Bottomley wrote:
On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote:
I've pushed out updates to both the core-for-3.17 and drivers-for-3.17
branches.
So I'm afraid we missed the last -next build on these, so they can't go
To modify the timeout on a queue please use blk_queue_rq_timeout in
the slave_configure method instead of poking directly into the block
timer, which won't work e.g. for the blk-mq path.
But this really needs an explanation on why you'd need a configurable
timeout to start with.
--
To
On Mon, Aug 04, 2014 at 09:30:59PM +1000, Stephen Rothwell wrote:
You realise that neither of these in linux-next as the scsi-core and
scsi-drivers trees had for-3.16 branches in the last round. I assume I
should just drop these trees completely from linux-next?
Well, they get pulled in
On Tue, Aug 05, 2014 at 05:02:46PM -0400, Chad Dupuis wrote:
On Tue, 5 Aug 2014, Venkatesh Srinivas wrote:
On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote:
Set this to 1 for now as we've observed crashes when this is set to the
default
value of 0.
What sorts of
On Wed, Aug 06, 2014 at 03:29:47PM +0200, Douglas Gilbert wrote:
If not and since I'm told black lists and the like won't
work, my advice for the record is to use FreeBSD or Windows
for tools that need this capability.
I doubt either of them forces users to hack up flags for these cases.
At
Can I get another review for this one so I can queue it up for 3.17?
(or v4 if you have a strong preference for it..)
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote:
I doubt either of them forces users to hack up flags for these cases.
Why was this change needed in the first place? There's no explanation
in the patch itself.
Which chance? The one to not support SG_FLAG_LUN_INHIBIT?
At
On Wed, Aug 06, 2014 at 04:01:12PM -0400, Chad Dupuis wrote:
This was on RHEL 7. Should we retry the test case with the latest
mainline?
Yes. Please always test your patches against latest mainline. If that is
for some reason not possible please at least very prominently mention that
the
Thanks Doug,
all the patches look good to me.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 11, 2014 at 10:54:34AM +0200, Alexander Gordeev wrote:
On Mon, Jul 28, 2014 at 11:47:19AM +, Vikas Chaudhary wrote:
Acked-By: Vikas Chaudhary vikas.chaudh...@qlogic.com
Christoph,
This patch seems ready..
I will apply all the patches that have gotten reviews once I
Any chance to get a review for this once so I can queued it up for 3.17?
On Fri, Aug 08, 2014 at 09:44:00AM +0200, jgr...@suse.com wrote:
From: Juergen Gross jgr...@suse.com
If a scsi host driver specifies .cmd_len in it's scsi_host_template, a
driver's
private command pool is needed.
+ BUG_ON(sc-cmd_len VSCSIIF_MAX_COMMAND_SIZE);
+
+ if (sc-cmd_len)
I can't see how you can get a zero cmd_len here.
+static int scsifront_action_handler(struct scsi_cmnd *sc, uint8_t act)
Please add a comment explaining your unusual EH strategy here.
+static void
On Mon, Aug 11, 2014 at 04:07:31PM +0300, Dan Carpenter wrote:
On Mon, Aug 11, 2014 at 07:09:55PM +0800, Ching Huang wrote:
Yes. 18/18 is obsolete.
Thanks to Tomas's advice.
There is no way to keep track of all the patches because they aren't
in an email thread. Could you resend
On Mon, Aug 04, 2014 at 04:55:12PM +0800, Ching Huang wrote:
From: Ching Huang ching2...@areca.com.tw
This patch rewrites the arcmsr_define_adapter_type function to precisely
check Areca adapter's ID.
This can prevent an unknown adapter being used as a default adapter type by
driver.
On Mon, Aug 11, 2014 at 12:27:29PM +0200, Juergen Gross wrote:
What do you mean with unusual? You mean transferring the EH action to
Dom0?
Yes. Note that hyperv tries something similar and they've run into
timeout issues, you might want to read up the recent thread on that.
+
+#include scsi/scsi_dbg.h
+#include scsi/scsi_eh.h
+#include scsi/scsi_tcq.h
What do you need these for? Normally target drivers shouldn't need
these.
+struct vscsibk_emulate {
+ void (*pre_function)(struct vscsibk_pend *, void *);
+ void (*post_function)(struct vscsibk_pend *,
On Mon, Aug 11, 2014 at 01:07:15PM -0400, James Smart wrote:
Acked-by: James Smart james.sm...@emulex.com
Can you jsut queue this up (and the pci fix as well) together with
anything else you have pending for 3.18?
I'd really like to move towards a model where maintainers of driver
collect
On Fri, Aug 15, 2014 at 12:34:22PM -0600, Jens Axboe wrote:
On 2014-08-15 12:22, Guenter Roeck wrote:
ping ... the problem fixed by this patch still affects the upstream kernel
(v3.16-11383-gc9d2642) as well as -next (20140815).
James, could you upstream this one in time for -rc1?
It's in
On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote:
So this is a bit late to get through linux-next and into a pull request.
I was planning on sending the final pull tomorrow (in case Linus planned
a surprise early release). Can we redo some of these as bug fixes and
send them in
Hi Ching,
I've fixed up various checkpatch errors and fixed up some descriptions
and applied the patches to a branch. This includes patch 4, so please
send a fix for this and any other patches relative to the branch.
Please find the branch at
On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote:
I read this comment and find that very few drivers are using this
cmd_list. I think if we remove this cmd_list, performance will scale as I
am seeing major contention in this lock.
Just thought to ping you to see if this is known
On Tue, Jul 01, 2014 at 02:56:20PM +0200, Rasmus Villemoes wrote:
Rounding up to a multiple of 4 should be done using the ALIGN
macro. As a bonus, this also makes the generated code smaller.
In GetIocFacts(), sz is assigned to a few lines below without being
read in the meantime, so it is ok
Thanks,
I've applied patches 1 to 7 to the drivers-for-3.18 branch.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
applied to the drivers-for-3.18 branch.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
applied to the drivers-for-3.18 branch.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
applied to the drivers-for-3.18 tree.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
applied the whole series to the drivers-for-3.18 tree.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks, I've applied both docbook fixups to the drivers-for-3.18 and
also addressed the addition nitpicks from Ewan.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
This looks reasonable to me. Martin, and objections?
On Mon, Aug 11, 2014 at 03:40:37PM +0300, Dolev Raviv wrote:
From: Sujit Reddy Thumma sthu...@codeaurora.org
The SYNCHRONIZE_CACHE command is a medium write command and hence can
fail when the device is write protected. Avoid sending such
, SCSI_QUEUE_DELAY);
}
'sdev-device_busy == 0' was replaced with 'atomic_read(sdev-device_busy)',
meaning the logic was reversed. Changing this expression to
'!atomic_read(sdev-device_busy)' fixes the problem.
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Webb
On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote:
The host asks the guest to scan when a LUN is removed or added.
The only way a guest can identify the removed LUN is when an I/O is
attempted on a removed LUN - the SRB status code indicates that the LUN
is invalid. We currently
On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote:
On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote:
I doubt either of them forces users to hack up flags for these cases.
Why was this change needed in the first place? There's no explanation
in the patch itself.
Thanks,
I've applied all three patches to the driver-for-3.18 branch.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 05, 2014 at 04:10:08PM +0300, Ari Sundholm wrote:
On Mon, 4 Aug 2014, Christoph Hellwig wrote:
To modify the timeout on a queue please use blk_queue_rq_timeout in
the slave_configure method instead of poking directly into the block
timer, which won't work e.g. for the blk-mq
On Wed, Aug 20, 2014 at 06:08:37PM +0530, Kashyap Desai wrote:
This code is in the hot path which means that caching enable_cmd_list
in struct Scsi_Host (as is done for many other SCSI host parameters)
probably
will (slightly) improve performance further. Otherwise this patch looks
fine
On Wed, Aug 20, 2014 at 08:14:17PM +0100, Alexander Gordeev wrote:
I've applied patches 1 to 7 to the drivers-for-3.18 branch.
Thanks, Christoph!
Not sure how to handle the rest, though. Chelsio driver has no
maintainers and none of be2iscsi, pmcraid and csiostor has been
reviewed for
On Thu, Aug 21, 2014 at 03:32:09PM +0300, Sagi Grimberg wrote:
So I just got back to checking this issue of *extremely low* IO write
performance I got in 3.16-rc2.
Please test with 3.16 final. There once issue each in aio and dio
that caused bad I/O performance regression that were only fixed
On Thu, Aug 21, 2014 at 10:41:02AM -0400, Douglas Gilbert wrote:
Perhaps we could add another bit flag in struct
scsi_host_template such as:
unsigned int transport_says_dont_scsi2_lun_cmd:1;
then drivers/usb/storage/scsiglue.c could set that
bit in its usb_stor_host_template and
On Thu, Aug 21, 2014 at 12:33:17PM -0700, adam radford wrote:
Can we get someone to finish reviewing the megaraid_sas patch series ?
Or let me know if anything else needs to be corrected ?
I know it has been reviewed by yourself and Martin Petersen so far,
however, I could not find the
On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote:
Alan Okay, here's a patch that implements the suggestion, except that I
Alan put the flag in the Scsi_Host structure instead of the template.
Alan This was to minimize the impact of the change. Among the various
Alan
On Thu, Aug 21, 2014 at 04:26:09PM -0400, Martin K. Petersen wrote:
Christoph I think I'm missing an ACK from Martin on one of the patches.
3/5 and 4/5 look good to me.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Thanks Martin,
I'll pull in the megaraid_sas patches for the
On Fri, Aug 22, 2014 at 06:18:03AM +0200, Juergen Gross wrote:
The resulting number of struct scsiif_request_segment is the sum of
seg[0..nr_segments-1].length / sizeof(struct scsiif_request_segment).
Where the nr_segments can only go Up to VSCSIIF_SG_TABLESIZE, so the max
total SG entries
On Fri, Aug 22, 2014 at 08:08:33AM -0400, Chad Dupuis wrote:
Eddie, Maurizio,
Since it looks like there can be a difference in the pdev would it make
sense instead to convert the unmap function to use the bare DMA API so
we're consistent in our use of hba-pcidev-dev? Maybe something like
to do that into the patch.
Looks good to me,
Acked-by: Christoph Hellwig h...@lst.de
Do you want to queue this up in the USB tree? From the looks of what I
have on my plate so far it seems like we could avoid conflicts with it
in the SCSI tree.
--
To unsubscribe from this list: send the line
On Fri, Aug 22, 2014 at 08:28:27PM -0400, Douglas Gilbert wrote:
To test this ioctl one option is to get the sg3_utils
package and build scsi_ioctl.c in the examples
directory with 'make scsi_ioctl'.
In lk 3.17-rc1, scsi_ioctl indicates that
SCSI_IOCTL_SEND_COMMAND is not working. In my test
On Sat, Aug 23, 2014 at 05:41:34PM +0530, Sreekanth Reddy wrote:
Just resending the complete Phase2 and Phase3
mpt3sas driver patch set Reviewed by the Martin K. Petersen.
This will make easy for Christoph to pick up this patch set for next kernel
release.
Can you please also send me the
On Fri, Aug 22, 2014 at 01:29:32PM -0400, Alan Stern wrote:
Other than this, I'm fine with the code ... you can add the acked by
from me when we resolve the above question.
Okay. It's true that this issue is only tangentially related to the
main point of the patch. It could be removed
On Fri, Aug 08, 2014 at 07:38:07AM -0400, Chad Dupuis wrote:
Hi James, Christoph,
Pleas apply the following two patches at your earliest convenience.
Thanks, I've applied them to the drivers-for-3.18 branch (actually
already a few days ago, so they are in Linux-next already)
--
To
On Fri, Aug 22, 2014 at 02:37:33PM +0200, Rasmus Villemoes wrote:
The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
drivers/scsi/ contain two-thirds of an include guard, but do not
elsewhere.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
Looks reasonable to me, can
Can you please send me a single big series with all the mpt2 and mpt3
updates? With all the resends I'm losing track.
Please also pick up third party mpt patches like
'[PATCH 3/3] mpt3sas, mpt2sas: fix scsi_add_host error handling problems in
_scsih_probe' from Robert Elliott.
And while I
Thanks,
applied.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
401 - 500 of 3866 matches
Mail list logo
