[PATCH v3 02/16] qla2xxx: Fix N2N link re-connect

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran In case of N2N connect, when sg_regset for bus/device/host was causing driver and firmware state to go out of sync. This patch fixes this link instablity when reconnect is attempted after link flap. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH v3 06/16] qla2xxx: Silent erroneous message

2018-08-02 Thread Himanshu Madhani
qla27xx_fwdt_entry_t268: unknown buffer 5 This patch fixes these error message by adding skip_entry() to not read them from template. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v3 03/16] qla2xxx: Fix login retry count

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran Login retry count was not properly decrementing, which lead to endless login retry. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 16 +++ drivers/scsi/qla2xxx/qla_init.c | 23 +++--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH v3 15/16] qla2xxx: Migrate NVME N2N handling into state machine

2018-08-02 Thread Himanshu Madhani
. With this state change now driver will not wait for pull NPort ID from FW. Fixes: edd05de197592 ("scsi: qla2xxx: Changes to support N2N logins") Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 12 +- drivers/scsi/qla2xxx/qla_fw.h

[PATCH v3 09/16] qla2xxx: Fix unintended Logout

2018-08-02 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 4f9c315813df..f9036004f179 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b

[PATCH v3 12/16] qla2xxx: Fix race between switch cmd completion and timeout

2018-08-02 Thread Himanshu Madhani
Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 75 ++--- 3 files changed, 58 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b

[PATCH v3 10/16] qla2xxx: Flush mailbox commands on chip reset

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran Flush pending mailbox commands on chip reset. Wake up command that's waiting for an interrupt and wait for mailbox counters to go to zero. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 5 + drivers/scsi/qla2xxx

[PATCH v3 05/16] qla2xxx: Prevent SysFS access when chip is down

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 33 +++-- drivers/scsi/qla2xxx/qla_init.c | 2

[PATCH v3 11/16] qla2xxx: Fix Management Server NPort handle reservation logic

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran After selecting the NPort handle/loop_id, set a bit in the loop_id_map to prevent others from selecting the same NPort handle. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 28

[PATCH v3 07/16] qla2xxx: Fix redundant fc_rport registration

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran Prevent multiple registration with transport layer for the same remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH v3 04/16] qla2xxx: Add longer window for Chip reset

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran The qla2x00_reset_active only cover the window of turning the chip off, add check to cover Chip on. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++- 2 files changed, 6 insertions

[PATCH v2 00/16] qla2xxx: Updates for the driver

2018-08-02 Thread Himanshu Madhani
ebased on 4.19/scsi-queue Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Cleanup for N2N code qla2xxx: Fix stalled relogin qla2xxx: Update driver version to 10.00.00.08-k Quinn Tran (13): qla2xxx: Fix N2N link re-connect qla2xxx: Fix login retry count qla2xxx: Add longer window for Chip

[PATCH v3 14/16] qla2xxx: Save frame payload size from ICB

2018-08-02 Thread Himanshu Madhani
From: Quinn Tran Save frame payload size from init control block. This field/data is used to register with switch data base. This allow the init control block temp buf to be reuse Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers

[PATCH v3 13/16] qla2xxx: Fix stalled relogin

2018-08-02 Thread Himanshu Madhani
;) Cc: sta...@vger.kernel.org #4.17 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/scsi/qla2xxx/qla_iocb.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 75538383de5b..c3

[PATCH v3 01/16] qla2xxx: Cleanup for N2N code

2018-08-02 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 112 drivers/scsi/qla2xxx/qla_iocb.c | 25 - 2 files changed, 137 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index

[PATCH v3 16/16] qla2xxx: Update driver version to 10.00.00.08-k

2018-08-02 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 1ad7582220c3..3850b28518e5 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v2 12/16] qla2xxx: Fix race between switch cmd completion and timeout

2018-08-01 Thread Himanshu Madhani
Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 75 ++--- 3 files changed, 58 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b

[PATCH v2 08/16] qla2xxx: Fix session state stuck in Get Port DB

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran This patch sets discovery state back to GNL (Get Name List) when session is stuck at GPDB (Get Port DataBase). This will allow state machine to retry login and move session state ahead in discovery. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH v2 11/16] qla2xxx: Fix Management Server NPort handle reservation logic

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran After selecting the NPort handle/loop_id, set a bit in the loop_id_map to prevent others from selecting the same NPort handle. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 28

[PATCH v2 03/16] qla2xxx: Fix login retry count

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran Login retry count was not properly decrementing, which lead to endless login retry. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 16 +++ drivers/scsi/qla2xxx/qla_init.c | 23 +++--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH v2 10/16] qla2xxx: Flush mailbox commands on chip reset

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran Flush pending mailbox commands on chip reset. Wake up command that's waiting for an interrupt and wait for mailbox counters to go to zero. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 5 + drivers/scsi/qla2xxx

[PATCH v2 02/16] qla2xxx: Fix N2N link re-connect

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran In case of N2N connect, when sg_regset for bus/device/host was causing driver and firmware state to go out of sync. This patch fixes this link instablity when reconnect is attempted after link flap. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH v2 07/16] qla2xxx: Fix redundant fc_rport registration

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran Prevent multiple registration with transport layer for the same remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH v2 00/16] qla2xxx: Updates for the driver

2018-08-01 Thread Himanshu Madhani
Hi Martin, This patch series addresses issue with N2N connection for FCP and FC-NVMe by moving login to state machine and handle various state change. Please apply this series to 4.19/scsi-queue at your earliest. Changes from v1 -> v2 o Rebased on 4.19/scsi-queue Thanks, Himanshu Himan

[PATCH v2 14/16] qla2xxx: Save frame payload size from ICB

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran Save frame payload size from init control block. This field/data is used to register with switch data base. This allow the init control block temp buf to be reuse Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers

[PATCH v2 09/16] qla2xxx: Fix unintended Logout

2018-08-01 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 4f9c315813df..f9036004f179 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b

[PATCH v2 15/16] qla2xxx: Migrate NVME N2N handling into state machine

2018-08-01 Thread Himanshu Madhani
. With this state change now driver will not wait for pull NPort ID from FW. Fixes: edd05de197592 ("scsi: qla2xxx: Changes to support N2N logins") Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 12 +- drivers/scsi/qla2xxx/qla_fw.h

[PATCH v2 04/16] qla2xxx: Add longer window for Chip reset

2018-08-01 Thread Himanshu Madhani
From: Quinn Tran The qla2x00_reset_active only cover the window of turning the chip off, add check to cover Chip on. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++- 2 files changed, 6 insertions

[PATCH v2 13/16] qla2xxx: Fix stalled relogin

2018-08-01 Thread Himanshu Madhani
;) Cc: sta...@vger.kernel.org #4.17 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/scsi/qla2xxx/qla_iocb.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index b5c1a1dea087..a0

[PATCH v2 16/16] qla2xxx: Update driver version to 10.00.00.08-k

2018-08-01 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 1ad7582220c3..3850b28518e5 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v2 01/16] qla2xxx: Cleanup for N2N code

2018-08-01 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 112 drivers/scsi/qla2xxx/qla_iocb.c | 25 - 2 files changed, 137 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index

[PATCH] qla2xxx: Fix memory leak for allocating abort IOCB

2018-07-26 Thread Himanshu Madhani
From: Quinn Tran In the case of IOCB QFull, Initiator code can leave behind a stale pointer to an SRB structure on the outstanding command array. Fixes: 82de802ad46e ("scsi: qla2xxx: Preparation for Target MQ.") Cc: sta...@vger.kernel.org #4.16 Signed-off-by: Quinn Tran Signed-off-by

[PATCH 02/16] qla2xxx: Fix N2N link re-connect

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran In case of N2N connect, when sg_regset for bus/device/host was causing driver and firmware state to go out of sync. This patch fixes this link instablity when reconnect is attempted after link flap. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH 03/16] qla2xxx: Fix login retry count

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran Login retry count was not properly decrementing, which lead to endless login retry. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 16 +++ drivers/scsi/qla2xxx/qla_init.c | 23 +++--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH 11/16] qla2xxx: Fix Management Server NPort handle reservation logic

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran After selecting the NPort handle/loop_id, set a bit in the loop_id_map to prevent others from selecting the same NPort handle. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 28

[PATCH 14/16] qla2xxx: Save frame payload size from ICB

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran Save frame payload size from init control block. This field/data is used to register with switch data base. This allow the init control block temp buf to be reuse Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers

[PATCH 08/16] qla2xxx: Fix session state stuck in Get Port DB

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran This patch sets discovery state back to GNL (Get Name List) when session is stuck at GPDB (Get Port DataBase). This will allow state machine to retry login and move session state ahead in discovery. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH 09/16] qla2xxx: Fix unintended Logout

2018-07-25 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 70c98316b793..8c811b251d42 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b

[PATCH 05/16] qla2xxx: Prevent SysFS access when chip is down

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 33 +++-- drivers/scsi/qla2xxx/qla_init.c | 2

[PATCH 13/16] qla2xxx: Fix stalled relogin

2018-07-25 Thread Himanshu Madhani
;) Cc: sta...@vger.kernel.org #4.17 Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/scsi/qla2xxx/qla_iocb.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 6d12da271a39..9b

[PATCH 04/16] qla2xxx: Add longer window for Chip reset

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran The qla2x00_reset_active only cover the window of turning the chip off, add check to cover Chip on. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++- 2 files changed, 6 insertions

[PATCH 10/16] qla2xxx: Flush mailbox commands on chip reset

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran Flush pending mailbox commands on chip reset. Wake up command that's waiting for an interrupt and wait for mailbox counters to go to zero. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 5 + drivers/scsi/qla2xxx

[PATCH 12/16] qla2xxx: Fix race between switch cmd completion and timeout

2018-07-25 Thread Himanshu Madhani
Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 75 ++--- 3 files changed, 58 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b

[PATCH 15/16] qla2xxx: Migrate NVME N2N handling into state machine

2018-07-25 Thread Himanshu Madhani
. With this state change now driver will not wait for pull NPort ID from FW. Fixes: edd05de197592 ("scsi: qla2xxx: Changes to support N2N logins") Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 11 +- drivers/scsi/qla2xxx/qla_fw.h

[PATCH 16/16] qla2xxx: Update driver version to 10.00.00.08-k

2018-07-25 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 1ad7582220c3..3850b28518e5 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 06/16] qla2xxx: Silent erroneous message

2018-07-25 Thread Himanshu Madhani
qla27xx_fwdt_entry_t268: unknown buffer 5 This patch fixes these error message by adding skip_entry() to not read them from template. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 07/16] qla2xxx: Fix redundant fc_rport registration

2018-07-25 Thread Himanshu Madhani
From: Quinn Tran Prevent multiple registration with transport layer for the same remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/scsi

[PATCH 00/16] qla2xxx: Updates for the driver

2018-07-25 Thread Himanshu Madhani
Hi Martin, This patch series addresses issue with N2N connection for FCP and FC-NVMe by moving login to state machine and handle various state change. Please apply this series to 4.19/scsi-queue at your earliest. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Cleanup for N2N code

[PATCH 01/16] qla2xxx: Cleanup for N2N code

2018-07-25 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 112 drivers/scsi/qla2xxx/qla_iocb.c | 25 - 2 files changed, 137 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index

[PATCH 10/12] qla2xxx: Fix Management Server NPort handle reservation logic

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran After selecting the NPort handle/loop_id, set a bit in the loop_id_map to prevent others from selecting the same NPort handle. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 27

[PATCH 5/5] qla2xxx: Return error when TMF returns

2018-07-18 Thread Himanshu Madhani
From: Anil Gurumurthy Propagate the task management completion status properly to avoid unnecessary waits for commands to complete. Fixes: faef62d13463 ("[SCSI] qla2xxx: Fix Task Management command asynchronous handling") Cc: Signed-off-by: Anil Gurumurthy Signed-off-by: Himans

[PATCH 0/5] qla2xxx: Bug fixes for the driver

2018-07-18 Thread Himanshu Madhani
Hi Martin, This patch series fixes issues with load/unload of the driver in a loop. Please apply this series for 4.18/scsi-fixes at your earliest convenience to be included in 4.18.0-rc6. Thanks, Himanshu Anil Gurumurthy (1): qla2xxx: Return error when TMF returns Quinn Tran (4):

[PATCH 06/12] qla2xxx: Fix redundant fc_rport registration

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran Prevent multiple registration with transport layer for the same remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/scsi

[PATCH 3/5] qla2xxx: Fix driver unload by shutting down chip

2018-07-18 Thread Himanshu Madhani
Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 3 +++ drivers/scsi/qla2xxx/qla_mbx.c | 6 ++ drivers/scsi/qla2xxx/qla_mid.c | 6 -- drivers/scsi/qla2xxx/qla_os.c | 44 +- drivers/scsi/qla2xxx/qla_sup.c | 3 ++

[PATCH 4/5] qla2xxx: Fix ISP recovery on unload

2018-07-18 Thread Himanshu Madhani
oring") Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 2cd2e5ccce15..1fbd16c8c9a7 100644 --- a/dr

[PATCH 2/5] qla2xxx: Fix NPIV deletion by calling wait_for_sess_deletion

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran Add wait for session deletion to finish before freeing an NPIV scsi host. Fixes: 726b85487067 ("qla2xxx: Add framework for async fabric discovery") Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 1 + drivers/sc

[PATCH 1/5] qla2xxx: Fix unintialized List head crash

2018-07-18 Thread Himanshu Madhani
Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 4 drivers/scsi/qla2xxx/qla_inline.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 2c35b0b2baa0..7a3744006419 100644 --- a/drivers/scsi/qla2xx

[PATCH 05/12] qla2xxx: Silent erroneous message

2018-07-18 Thread Himanshu Madhani
: qla27xx_fwdt_entry_t268: unknown buffer 4 kernel: qla2xxx [:81:00.0]-d82b:19: qla27xx_fwdt_entry_t268: unknown buffer 5 This patch fixes these error message by adding skip_entry() to not read them from template. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH 07/12] qla2xxx: Fix session state stuck in Get Port DB

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran This patch sets discovery state back to GNL (Get Name List) when session is stuck at GPDB (Get Port DataBase). This will allow state machine to retry login and move session state ahead in discovery. Signed-off-by: Quinn Tran --- drivers/scsi/qla2xxx/qla_init.c | 9 ++---

[PATCH 11/12] qla2xxx: Fix race between switch cmd completion and timeout

2018-07-18 Thread Himanshu Madhani
Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 75 ++--- 3 files changed, 58 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b

[PATCH 08/12] qla2xxx: Fix unintended Logout

2018-07-18 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index c5c96e698799..d144719a96d6 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b

[PATCH 04/12] qla2xxx: Prevent SysFS access when chip is down

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 33 +++-- drivers/scsi/qla2xxx/qla_init.c | 2

[PATCH 09/12] qla2xxx: Flush mailbox commands on chip reset

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran Flush pending mailbox commands on chip reset. Wake up command that's waiting for an interrupt and wait for mailbox counters to go to zero. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 4 drivers/scsi/qla2xxx

[PATCH 12/12] qla2xxx: Update driver version to 10.00.00.08-k

2018-07-18 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 1ad7582220c3..3850b28518e5 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 01/12] qla2xxx: Fix N2N link re-connect

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran In case of N2N connect, when sg_regset for bus/device/host was causing driver and firmware state to go out of sync. This patch fixes this link instablity when reconnect is attempted after link flap. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH 03/12] qla2xxx: Add longer window for Chip reset

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran The qla2x00_reset_active only cover the window of turning the chip off, add check to cover Chip on. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++- 2 files changed, 6 insertions

[PATCH 02/12] qla2xxx: Fix login retry count

2018-07-18 Thread Himanshu Madhani
From: Quinn Tran Login retry count was not properly decrementing, which lead to endless login retry. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 16 +++ drivers/scsi/qla2xxx/qla_init.c | 23 +++--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH 00/12] qla2xxx: Updates for driver

2018-07-18 Thread Himanshu Madhani
Hi Martin, This series contains bug-fixes for driver mainly in the area of interaction with switch and small patch for N2N link reconnect. Please apply this serise to 4.19/scsi-queue at your earliest convenience. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Update driver version

[PATCH 3/3] qla2xxx: Fix NULL pointer derefrence for fcport search

2018-07-02 Thread Himanshu Madhani
gin") Cc: #4.17.0 Signed-off-by: Chuck Anderson Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 7b675243bd

[PATCH 2/3] qla2xxx: Fix kernel crash due to late workqueue allocation

2018-07-02 Thread Himanshu Madhani
] ---[ end trace 01b7b7ae2c005cf3 ]--- Cc: #4.17.0 Fixes: 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing out of DPC thread" Reported-by: Li Wang Tested-by: Li Wang Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/3] qla2xxx: Fix inconsistent DMA mem alloc/free

2018-07-02 Thread Himanshu Madhani
: #4.17.0 Fixes: 33b28357dd00 ("scsi: qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan") Reported-by: Ewan D. Milne Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 ++ drivers/scsi/qla2xxx/qla_

[PATCH 0/3] qla2xxx: Bug fixes for driver

2018-07-02 Thread Himanshu Madhani
Hi Martin, This series contains critical fixes for the driver to address crashes. Please apply this series to 4.18/scsi-fixes branch at your earliest convenience. Thanks, Himanshu Chuck Anderson (1): qla2xxx: Fix NULL pointer derefrence for fcport search Himanshu Madhani (1): qla2xxx

[PATCH 02/12] qla2xxx: Fix login retry count

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran Login retry count was not properly decrementing, which lead to endless login retry. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 16 +++ drivers/scsi/qla2xxx/qla_init.c | 23 +++--- drivers/scsi/qla2xxx/qla_mbx.c

[PATCH 12/12] qla2xxx: Update driver version to 10.00.00.08-k

2018-06-06 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 1ad7582220c3..3850b28518e5 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 11/12] qla2xxx: Fix race between switch cmd completion and timeout

2018-06-06 Thread Himanshu Madhani
Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xxx/qla_init.c | 75 ++--- 3 files changed, 58 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b

[PATCH 00/12] qla2xxx: Updates for driver

2018-06-06 Thread Himanshu Madhani
Hi Martin, This series contains bug-fixes for driver mainly in the area of interaction with switch and small patch for N2N link reconnect. Please apply this serise to 4.19/scsi-queue at your earliest convenience. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Update driver version

[PATCH 05/12] qla2xxx: Silent erroneous message

2018-06-06 Thread Himanshu Madhani
: qla27xx_fwdt_entry_t268: unknown buffer 4 kernel: qla2xxx [:81:00.0]-d82b:19: qla27xx_fwdt_entry_t268: unknown buffer 5 This patch fixes these error message by adding skip_entry() to not read them from template. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH 10/12] qla2xxx: Fix Management Server NPort handle reservation logic

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran After selecting the NPort handle/loop_id, set a bit in the loop_id_map to prevent others from selecting the same NPort handle. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 27

[PATCH 01/12] qla2xxx: Fix N2N link re-connect

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran In case of N2N connect, when sg_regset for bus/device/host was causing driver and firmware state to go out of sync. This patch fixes this link instablity when reconnect is attempted after link flap. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi

[PATCH 08/12] qla2xxx: Fix unintended Logout

2018-06-06 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index c5c96e698799..d144719a96d6 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b

[PATCH 03/12] qla2xxx: Add longer window for Chip reset

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran The qla2x00_reset_active only cover the window of turning the chip off, add check to cover Chip on. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++- 2 files changed, 6 insertions

[PATCH 06/12] qla2xxx: Fix redundant fc_rport registration

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran Prevent multiple registration with transport layer for the same remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/scsi

[PATCH 09/12] qla2xxx: Flush mailbox commands on chip reset

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran Flush pending mailbox commands on chip reset. Wake up command that's waiting for an interrupt and wait for mailbox counters to go to zero. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 4 drivers/scsi/qla2xxx

[PATCH 04/12] qla2xxx: Prevent SysFS access when chip is down

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 33 +++-- drivers/scsi/qla2xxx/qla_init.c | 2

[PATCH 07/12] qla2xxx: Fix session state stuck in Get Port DB

2018-06-06 Thread Himanshu Madhani
From: Quinn Tran This patch sets discovery state back to GNL (Get Name List) when session is stuck at GPDB (Get Port DataBase). This will allow state machine to retry login and move session state ahead in discovery. Signed-off-by: Quinn Tran --- drivers/scsi/qla2xxx/qla_init.c | 9 ++---

[PATCH] qla2xxx: Mask off Scope bits in retry delay.

2018-06-06 Thread Himanshu Madhani
Scope bits, driver was using that value as timeout value which resulted into driver waiting for 27min timeout. This patch masks off this Scope bits so that driver does not use this value as retry delay time. Cc: Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Himan

[PATCH] qla2xxx: Fix setting lower transfer speed if GPSC fails

2018-06-03 Thread Himanshu Madhani
for gpsc_supported flags and prevents driver from issuing MBC_SET_PORT_PARAM (001Ah) to set default speed of 1 GB/sec. If driver does not send this mailbox command, firmware assumes maximum supported link speed and will operate at the max speed. Cc: sta...@vger.kernel.org Signed-off-by: Himanshu Madhani --- Hi

[PATCH 1/1] qla2xxx: Allow SCSI-MQ to be enabled selectively

2018-05-16 Thread Himanshu Madhani
when ql2xmqsupport=1, use that value to selectively enable SCSI-MQ Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 817c18

[PATCH 12/12] qla2xxx: Update driver version to 10.00.00.07-k

2018-05-01 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0c55d7057280..1ad7582220c3 100644 --- a/d

[PATCH 07/12] qla2xxx: Fix Inquiry command being dropped in Target mode

2018-05-01 Thread Himanshu Madhani
ession is created. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_target.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/dr

[PATCH 11/12] qla2xxx: Fix TMF and Multi-Queue config

2018-05-01 Thread Himanshu Madhani
avium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_target.c | 135 ++--- drivers/scsi/qla2xxx/qla_target.h | 4 +- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 27 3 files changed, 141 insertion

[PATCH 10/12] qla2xxx: Prevent relogin loop by removing stale code

2018-05-01 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_init.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 3405cb9031b6..1aa3720ea2ed 100644 --- a/drivers/scsi/q

[PATCH 09/12] qla2xxx: Remove stale debug value for login_retry flag

2018-05-01 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/dr

[PATCH 03/12] qla2xxx: Fix Rport and session state getting out of sync

2018-05-01 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> This patch fixes rport state and session state getting out of sync. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx

[PATCH 06/12] qla2xxx: Move GPSC and GFPNID out of session management

2018-05-01 Thread Himanshu Madhani
ate is set to Online. Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_def.h| 3 +- drivers/scsi/qla2xxx/qla_gbl.h| 3 +- drivers/scsi/qla2xxx/qla_gs.c | 10 + drivers/scsi/qla

[PATCH 04/12] qla2xxx: Delete session for nport id change

2018-05-01 Thread Himanshu Madhani
h command to simplify fabric discovery") Cc: <sta...@vger.kernel.org> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_gs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH 05/12] qla2xxx: Reduce redundant ADISC command for RSCNs

2018-05-01 Thread Himanshu Madhani
n Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gs.c | 27 --- drivers/scsi/qla2xxx/qla_init.c | 6 ++ 3 files changed, 31 insertions(+), 3 deleti

[PATCH 08/12] qla2xxx: Use predefined get_datalen_for_atio() inline function

2018-05-01 Thread Himanshu Madhani
From: Quinn Tran <quinn.t...@cavium.com> o Uses predefine inline function to access add_cdb_len field in ATIO. o Return SS_RESIDUAL_UNDER status when sending BUSY Signed-off-by: Quinn Tran <quinn.t...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com>

[PATCH 00/12] qla2xxx: Updates for driver

2018-05-01 Thread Himanshu Madhani
Hi Martin, This series contains updates for driver. Please apply this to 4.18 scsi-misc branch at your earliest convenience. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Add Laser Control for ISP26XX/27XX qla2xxx: Prevent relogin loop by removing stale code qla2xxx: Update driver

[PATCH 01/12] qla2xxx: Add Laser Control for ISP26XX/27XX

2018-05-01 Thread Himanshu Madhani
From: Himanshu Madhani <himanshu.madh...@qlogic.com> This patch disables laser while unloading driver for 16/32G adapters. Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- drivers/scsi/qla2xxx/qla_def.h| 7 drivers/scsi/qla2xxx/qla_fw.h | 2 ++

<    1   2   3   4   5   6   7   8   9   10   >