Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: Il 24/05/2013 09:36, James Bottomley ha scritto: On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: Adjust the blk_verify_command function to let it look at per-queue data. This will be done in the next patch

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 09:53 +0200, Paolo Bonzini wrote: Il 24/05/2013 09:50, James Bottomley ha scritto: On Fri, 2013-05-24 at 09:43 +0200, Paolo Bonzini wrote: Il 24/05/2013 09:36, James Bottomley ha scritto: On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote: Adjust

Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 10:32 +0200, Paolo Bonzini wrote: Il 24/05/2013 10:03, James Bottomley ha scritto: Does anyone in the real world actually care about this bug? Yes, or I would move on and not waste so much time on this. Fine, so produce a simple fix for this bug which we

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-24 Thread James Bottomley
On Fri, 2013-05-24 at 17:02 +0900, Tejun Heo wrote: On Fri, May 24, 2013 at 4:13 PM, Paolo Bonzini pbonz...@redhat.com wrote: The same filtering table being applied to different classes of hardware is a software bug, but my point is that the practive essentially entrusts non-insignificant

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-26 Thread James Bottomley
On Thu, 2013-05-23 at 11:14 -0700, Roland Dreier wrote: At LSF this year, we had a discussion about error handling and in particular the problem that SCSI midlayer error handling waits for the entire SCSI host (HBA) to quiesce before it starts to abort commands etc. James made the

Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-27 Thread James Bottomley
On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote: use module_pci_driver instead of init/exit, make code clean. For the ancient drivers, like this, the principal is that we really don't touch except for tested bug fixes. For the current ones (like mvumi) it's up to the maintainer. James --

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-27 Thread James Bottomley
On Mon, 2013-05-27 at 16:39 +0200, Hannes Reinecke wrote: On 05/27/2013 12:44 AM, James Bottomley wrote: On Thu, 2013-05-23 at 11:14 -0700, Roland Dreier wrote: At LSF this year, we had a discussion about error handling and in particular the problem that SCSI midlayer error handling

Re: [PATCH 0/5] scsi: use platform helper macro and wrapper functions

2013-05-30 Thread James Bottomley
On Thu, 2013-05-30 at 20:09 +0800, Kefeng Wang wrote: use module_platform_driver() and paltform{set,get}_drvdata to simpily code, and patch 2/5 delete unnecessery drvdate set to null. Kefeng Wang (5): scsi: jazz: use module_platform_driver() and platform_{set,get}_drvdata scsi:

Re: [PATCH] [SCSI] libsas: Cocci spatch ptr_ret.spatch

2013-06-01 Thread James Bottomley
On Sat, 2013-06-01 at 11:59 +0200, Thomas Meyer wrote: Signed-off-by: Thomas Meyer tho...@m3y3r.de --- diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c --- a/drivers/scsi/libsas/sas_scsi_host.c +++ b/drivers/scsi/libsas/sas_scsi_host.c @@ -1093,9

Re: [PATCH 1/5] Drivers: scsi: storvsc: Make the scsi timeout a module parameter

2013-06-03 Thread James Bottomley
On Mon, 2013-06-03 at 16:21 -0700, K. Y. Srinivasan wrote: The standard scsi timeout is not appropriate in some of the environments where Hyper-V is deployed. Set this timeout appropriately for all devices managed by this driver. Further make this a module parameter. Signed-off-by: K. Y.

Re: [PATCH 1/5] Drivers: scsi: storvsc: Make the scsi timeout a module parameter

2013-06-03 Thread James Bottomley
On Mon, 2013-06-03 at 23:25 +, KY Srinivasan wrote: -Original Message- From: James Bottomley [mailto:jbottom...@parallels.com] Sent: Monday, June 03, 2013 7:03 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org

Re: [SCSI] mvsas: Fix the kernel panic due to unaligned data access

2013-06-09 Thread James Bottomley
On Wed, 2013-05-08 at 15:01 +0800, Paul Guo wrote: It's easy to find the address and symbol that causes the unalignd data access according to the stack dump information. The following small patch will fix it. Do you have the panic log? because it sounds like a bug in your platform code. All

Re: [PATCH RESEND] scsi: Introduce a help function local_time_seconds() to simplify the getting time stamp operation

2013-06-10 Thread James Bottomley
On Mon, 2013-06-10 at 09:57 +0800, Gu Zheng wrote: diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h index 66216c1..f3377ca 100644 --- a/include/scsi/scsi.h +++ b/include/scsi/scsi.h @@ -574,4 +574,13 @@ static inline __u32 scsi_to_u32(__u8 *ptr) return (ptr[0]24) + (ptr[1]16) +

Re: [PATCH 3/9] scsi: improved eh timeout handler

2013-06-11 Thread James Bottomley
On Mon, 2013-06-10 at 01:20 -0700, Christoph Hellwig wrote: On Mon, Jun 10, 2013 at 09:40:52AM +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this

Re: [PATCH 3/9] scsi: improved eh timeout handler

2013-06-11 Thread James Bottomley
On Tue, 2013-06-11 at 16:41 -0400, Ewan Milne wrote: On Tue, 2013-06-11 at 18:57 +, James Bottomley wrote: On Mon, 2013-06-10 at 01:20 -0700, Christoph Hellwig wrote: On Mon, Jun 10, 2013 at 09:40:52AM +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send

Re: [PATCH 01/10] qla2xxx: Clean up qla24xx_iidma()

2013-06-12 Thread James Bottomley
On Wed, 2013-06-12 at 08:05 +, Saurav Kashyap wrote: Hi Bart, Missing msg ids needs to be updated in qla_dbg.c file. Here is an updated patch OK, so since you modified the first patch in the series, you need to be the one who sends it all to me (with proper signoffs). Thanks, James --

Re: [scsi] WARNING: at fs/sysfs/dir.c:530 sysfs_add_one()

2013-06-12 Thread James Bottomley
On Thu, 2013-06-13 at 09:30 +0800, Fengguang Wu wrote: Greetings, I got the below dmesg and the first bad commit is commit a256ba092ec57213f96059d41ac5473ff92f5e7c Author: Nicholas Bellinger n...@linux-iscsi.org Date: Sat May 18 02:40:43 2013 -0700 scsi: Split scsi_dispatch_cmd

Re: [PATCH v3 1/6] [SCSI] Add a kernel config option for enhanced Unit Attention support

2013-06-19 Thread James Bottomley
On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Added CONFIG_SCSI_ENHANCED_UA kernel config option to enable changes in the SCSI mid-layer which detect and report certain Unit Attention conditions reported by devices. These changes are primarily

Re: [PATCH v3 2/6] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event

2013-06-19 Thread James Bottomley
On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com The names of the struct and some of the functions for scsi_device events are too generic and do not match the comments in the source. Changed all of the names to begin with sdev_ in order to avoid

Re: [PATCH v3 4/6] [SCSI] Generate uevents for certain Unit Attention codes

2013-06-19 Thread James Bottomley
On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Generate a uevent on the scsi_target object when the following Unit Attention ASC/ASCQ code is received: 3F/0E REPORTED LUNS DATA HAS CHANGED Generate a uevent on the scsi_device object

Re: [PATCH v11 8/9] Save and restore host_scribble during error handling

2013-06-23 Thread James Bottomley
by scsi_eh_prep_cmnd() and must be restored by scsi_eh_restore_cmnd(). Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: James Bottomley jbottom...@parallels.com Cc: Mike Christie micha...@cs.wisc.edu Cc: Hannes Reinecke h...@suse.de Cc: Tejun Heo t...@kernel.org How have we not hit

Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-23 Thread James Bottomley
On Wed, 2013-06-12 at 14:51 +0200, Bart Van Assche wrote: Now that all scsi_request_fn() callers hold a reference on the SCSI device that function is invoked for What makes you think that this is a true statement? The usual caller is the block layer, which doesn't really know anything about

Re: [PATCH v11 2/9] Remove get_device() / put_device() pair from scsi_request_fn()

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 09:13 +0200, Bart Van Assche wrote: On 06/24/13 04:36, James Bottomley wrote: On Wed, 2013-06-12 at 14:51 +0200, Bart Van Assche wrote: Now that all scsi_request_fn() callers hold a reference on the SCSI device that function is invoked for What makes you think

Re: [PATCH v3 4/6] [SCSI] Generate uevents for certain Unit Attention codes

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 10:11 -0400, Ewan Milne wrote: On Wed, 2013-06-19 at 18:48 +, James Bottomley wrote: On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Generate a uevent on the scsi_target object when the following Unit Attention

Re: [PATCH v11 1/9] Fix race between starved list and device removal

2013-06-24 Thread James Bottomley
On Wed, 2013-06-12 at 14:49 +0200, Bart Van Assche wrote: scsi_run_queue() examines all SCSI devices that are present on the starved list. Since scsi_run_queue() unlocks the SCSI host lock before running a queue a SCSI device can get removed after it has been removed from the starved list and

Re: [PATCH v11 1/9] Fix race between starved list and device removal

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 18:16 +0200, Bart Van Assche wrote: On 06/24/13 17:38, James Bottomley wrote: I really don't like this because it's shuffling potentially fragile lifetime rules since you now have to have the sdev deleted from the starved list before final put. That becomes

Re: [PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-24 Thread James Bottomley
On Wed, 2013-06-12 at 14:52 +0200, Bart Van Assche wrote: SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked by the LUN scanning code

Re: [PATCH v11 1/9] Fix race between starved list and device removal

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 12:24 -0500, Mike Christie wrote: On 06/24/2013 10:38 AM, James Bottomley wrote: On Wed, 2013-06-12 at 14:49 +0200, Bart Van Assche wrote: scsi_run_queue() examines all SCSI devices that are present on the starved list. Since scsi_run_queue() unlocks the SCSI host

Re: [PATCH v11 4/9] Disallow changing the device state via sysfs into deleted

2013-06-24 Thread James Bottomley
On Wed, 2013-06-12 at 14:53 +0200, Bart Van Assche wrote: Changing the state of a SCSI device via sysfs into cancel or deleted prevents removal of these devices by scsi_remove_host(). Hence do not allow this. Also, introduce the symbolic name INVALID_SDEV_STATE, representing a value different

Re: [PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished

2013-06-24 Thread James Bottomley
On Wed, 2013-06-12 at 14:55 +0200, Bart Van Assche wrote: A SCSI LLD may start cleaning up host resources as soon as scsi_remove_host() returns. These host resources may be needed by the LLD in an implementation of one of the eh_* functions. So if one of the eh_* functions is in progress when

Re: [PATCH RESEND v2 0/2] scsi: Port buslogic driver to 64 bits

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 14:25 -0600, Khalid Aziz wrote: This patchset ports buslogic driver to 64-bit. OK, thought long and hard about this., I'll take it on the proviso that you're the new buslogic maintainer. The reason being that without someone to sort through any bug reports, the only option

Re: [PATCH RESEND v2 0/2] scsi: Port buslogic driver to 64 bits

2013-06-24 Thread James Bottomley
On Mon, 2013-06-24 at 15:17 -0600, Khalid Aziz wrote: On 06/24/2013 02:55 PM, James Bottomley wrote: On Mon, 2013-06-24 at 14:25 -0600, Khalid Aziz wrote: This patchset ports buslogic driver to 64-bit. OK, thought long and hard about this., I'll take it on the proviso that you're

Re: [PATCH v11 4/9] Disallow changing the device state via sysfs into deleted

2013-06-25 Thread James Bottomley
On Tue, 2013-06-25 at 10:41 +0200, Bart Van Assche wrote: On 06/24/13 19:59, James Bottomley wrote: On Wed, 2013-06-12 at 14:53 +0200, Bart Van Assche wrote: Changing the state of a SCSI device via sysfs into cancel or deleted prevents removal of these devices by scsi_remove_host(). Hence

Re: [PATCH v11 3/9] Avoid calling __scsi_remove_device() twice

2013-06-25 Thread James Bottomley
On Tue, 2013-06-25 at 10:37 +0200, Bart Van Assche wrote: On 06/24/13 19:38, James Bottomley wrote: On Wed, 2013-06-12 at 14:52 +0200, Bart Van Assche wrote: SCSI devices are added to the shost-__devices list from inside scsi_alloc_sdev(). If something goes wrong during LUN scanning, e.g

Re: [PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished

2013-06-25 Thread James Bottomley
On Tue, 2013-06-25 at 11:01 +0200, Bart Van Assche wrote: On 06/25/13 00:27, James Bottomley wrote: On Mon, 2013-06-24 at 15:04 -0500, Mike Christie wrote: On 06/24/2013 02:19 PM, James Bottomley wrote: On Wed, 2013-06-12 at 14:55 +0200, Bart Van Assche wrote: A SCSI LLD may start

Re: [PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished

2013-06-25 Thread James Bottomley
On Tue, 2013-06-25 at 11:13 -0500, Michael Christie wrote: On Jun 25, 2013, at 10:31 AM, Bart Van Assche bvanass...@acm.org wrote: On 06/25/13 15:45, James Bottomley wrote: On Tue, 2013-06-25 at 11:01 +0200, Bart Van Assche wrote: There is a difference though between moving the EH

Re: [PATCH 1/1] bfa: Fixes for 0-terminated strncpy and possible null pointer dereference

2013-06-26 Thread James Bottomley
On Wed, 2013-05-15 at 21:41 +0200, Jakob Normark wrote: This patch fixes two cppcheck errors in drivers/scsi/bfa/bfad_im.c Signed-off-by: Jakob Normark jakobnorm...@gmail.com --- drivers/scsi/bfa/bfad_im.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support

2013-06-26 Thread James Bottomley
On Tue, 2013-06-04 at 12:05 -0700, K. Y. Srinivasan wrote: Implement multi-channel support for the storage devices. This doesn't compile: CC [M] drivers/scsi/storvsc_drv.o drivers/scsi/storvsc_drv.c: In function ‘handle_sc_creation’: drivers/scsi/storvsc_drv.c:763:35: error: ‘struct

Re: [PATCH V3 0/5] Drivers: scsi: storvsc

2013-06-26 Thread James Bottomley
On Wed, 2013-06-26 at 12:58 +, KY Srinivasan wrote: -Original Message- From: KY Srinivasan Sent: Monday, June 17, 2013 9:32 AM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

Re: fcoe pull request for 3.9-rc

2013-06-27 Thread James Bottomley
On Tue, 2013-06-25 at 20:55 +, Love, Robert W wrote: The following changes since commit 1e876e3b1a9df25bb04682b0d48aaa7e8ae1fc82: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (2013-06-25 09:08:07 -1000) are available in the git repository

[GIT PULL] SCSI fixes for 3.10-rc7

2013-06-27 Thread James Bottomley
This is a set of seven bug fixes. Several fcoe fixes for locking problems, initiator issues and a VLAN API change, all of which could eventually lead to data corruption, one fix for a qla2xxx locking problem which could lead to multiple completions of the same request (and subsequent data

Re: SCSI vs MN10300: Can get_user() be given an array?

2013-06-28 Thread James Bottomley
On Fri, 2013-06-28 at 17:39 +0100, David Howells wrote: The MN10300 arch is throwing up an error in the SCSI driver and I'm not sure whether it needs fixing in the arch - in get_user() - or in the SCSI code. The problem is this line in sg_scsi_ioctl(): if (get_user(opcode, sic-data))

Re: [PATCH v12 2/6] Avoid calling __scsi_remove_device() twice

2013-07-01 Thread James Bottomley
On Thu, 2013-06-27 at 16:53 +0200, Bart Van Assche wrote: If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked by the LUN scanning code for a SCSI device in state SDEV_CREATED_BLOCK. If this happens then the SCSI

Re: Can not see/access devices on Marvell 88SE9485 + SiI 3726 PMP

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 16:09 +0200, Hajo Möller wrote: Hi, I've got a box which recently got a Marvell 88SE9485 PCIe card (Supermicro AOC-SAS2LP-MV8), which is connected by a mSAS-4x SATA-cable to some 5 HDD backplanes (CFI-B53PM, chip is a SiI 3726). The HBA's BIOS can see and access the

Re: [PATCH v12 2/6] Avoid calling __scsi_remove_device() twice

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 09:14 +0200, Bart Van Assche wrote: On 07/01/13 09:05, James Bottomley wrote: On Thu, 2013-06-27 at 16:53 +0200, Bart Van Assche wrote: If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked

Re: [PATCH v12 5/6] Avoid that scsi_device_set_state() triggers a race

2013-07-01 Thread James Bottomley
On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote: Make concurrent invocations of scsi_device_set_state() safe. Firstly, I don't understand from this where you think the races are. Secondly, shouldn't this be the device lock? and thirdly, if we accept that locking is required,

Re: [PATCH v12 5/6] Avoid that scsi_device_set_state() triggers a race

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 17:17 +0200, Bart Van Assche wrote: On 07/01/13 16:49, James Bottomley wrote: On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote: Make concurrent invocations of scsi_device_set_state() safe. Firstly, I don't understand from this where you think the races

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote: If a single device is bad, don't ever do a host reset. This isn't a tenable position. Sometimes a device looks bad because the host state for it has gone insane. At that point, the only safe action is a reset of the host to sane state. I

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 15:17 -0700, Andrew Morton wrote: On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma sthu...@codeaurora.org wrote: When block runtime PM is enabled following warning is seen while resuming the device. BUG: sleeping function called from invalid context at

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-02 Thread James Bottomley
On Mon, 2013-07-01 at 16:55 -0400, Jörn Engel wrote: On Mon, 1 July 2013 19:23:25 +, James Bottomley wrote: On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote: If a single device is bad, don't ever do a host reset. This isn't a tenable position. Sometimes a device looks bad

Re: [PATCH 3/4] Avoid re-enabling I/O after the transport became offline

2013-07-02 Thread James Bottomley
SDEV_CANCEL if the transport is offline. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Mike Christie micha...@cs.wisc.edu Cc: James Bottomley jbottom...@parallels.com Cc: Hannes Reinecke h...@suse.de Cc: Tejun Heo t...@kernel.org --- drivers/scsi/scsi_lib.c |1 - drivers/scsi

[GIT PULL] First round of SCSI updates for the 3.10+ merge window

2013-07-02 Thread James Bottomley
Normark (1): bfa: Fixes for 0-terminated strncpy and possible null pointer dereference James Bottomley (1): libsas: implement 16 byte CDB support James Georgas (1): megaraid: minor cut and paste error fixed. James Smart (17): lpfc 8.3.40: Update lpfc version to driver version

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-02 Thread James Bottomley
On Tue, 2013-07-02 at 10:58 -0400, Jörn Engel wrote: On Tue, 2 July 2013 06:37:05 +, James Bottomley wrote: I don't understand what you're getting at. In a dual HBA situation, whether the second HBA is implicated or not depends on configuration and what the first HBA is doing

Re: Can not see/access devices on Marvell 88SE9485 + SiI 3726 PMP

2013-07-03 Thread James Bottomley
On Wed, 2013-07-03 at 14:52 +0200, Hajo Möller wrote: On 01.07.2013 16:38, James Bottomley wrote: mv_sas is a libsas based driver. libsas doesn't have any support for SATA PMPs. When it was added they were left as a todo item but then in the field everyone deployed enterprise type SATA

Re: atomic write T10 standards

2013-07-03 Thread James Bottomley
On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: On 07/03/2013 11:00 AM, James Bottomley wrote: On Wed, 2013-07-03 at 10:56 -0400, Ric Wheeler wrote: On 07/03/2013 10:38 AM, Chris Mason wrote: Quoting Ric Wheeler (2013-07-03 10:34:04) As I was out walking Skeeter this morning, I

Re: atomic write T10 standards

2013-07-03 Thread James Bottomley
On Wed, 2013-07-03 at 11:27 -0400, Ric Wheeler wrote: On 07/03/2013 11:22 AM, James Bottomley wrote: On Wed, 2013-07-03 at 11:04 -0400, Ric Wheeler wrote: Why not have the atomic write actually imply that it is atomic and durable for just that command? I don't understand why you think

Re: [scsi:misc 34/37] include/uapi/linux/swab.h:106:23: warning: 'csum' may be used uninitialized in this function

2013-07-09 Thread James Bottomley
On Tue, 2013-07-09 at 17:38 +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 06ba9fa7f8cec5b9c04e511bfe21c5aa7cc3044c commit: eb7b211bac8e0aad45c2349a853be13cef20048a [34/37] [SCSI] scsi_debug: reduce duplication between

Re: [PATCH 0/3] [SCSI] megaraid: Remove local (struct pci_dev) pdev's

2013-07-09 Thread James Bottomley
On Tue, 2013-07-09 at 14:39 -0600, Myron Stowe wrote: Is the megaraid driver still actively used and maintained? I originally posted this series on 06.07.2013 and after receiving no comments, pinged the list again on 06.17.2013 and still received no comments/feedback. Trying again as I

Re: [PATCH 0/3] [SCSI] megaraid: Remove local (struct pci_dev) pdev's

2013-07-10 Thread James Bottomley
On Tue, 2013-07-09 at 15:12 -0700, adam radford wrote: On Tue, Jul 9, 2013 at 2:18 PM, James Bottomley Adam, you do drive by coding on this for LSI ... ack or reject, please. I have just now located my box of MegaRAID Parallel SCSI controllers. I will review and test the patch series from

[GIT PULL] Final round of SCSI updates for the 3.10+ merge window

2013-07-12 Thread James Bottomley
. qla2xxx: Clear the MBX_INTR_WAIT flag when the mailbox time-out happens. James Bottomley (1): Fix race between starved list and device removal K. Y. Srinivasan (3): storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS storvsc: Support FC devices storvsc: Implement

Re: [Ksummit-2013-discuss] [ATTEND] scsi-mq prototype discussion

2013-07-13 Thread James Bottomley
is high on priority list for discussion. The parties to be included in such a discussion are: - Jens Axboe (blk-mq author) - James Bottomley (scsi maintainer) - Christoph Hellwig (scsi) - Martin Petersen (scsi) - Tejun Heo (block + libata) - Hannes Reinecke (scsi

Re: [PATCH 1/3] arcmsr: Modify maximum outstanding command

2013-07-16 Thread James Bottomley
On Tue, 2013-07-16 at 18:22 +0800, 黃清隆 wrote: From: Chingching2...@areca.com.tw Modify maximum outstanding command value, notify auto request sense, reassign ARC12x4 series to SATA adapter. Signed-off-by:Chingching2...@areca.com.tw --- This patch needs to make it to the SCSI mailing list

Re: mpt2sas,mpt3sas watchdog device removal

2013-07-16 Thread James Bottomley
On Tue, 2013-07-16 at 17:30 +0530, Reddy, Sreekanth wrote: James, This patch seem to be fine. Please consider this patch. Where's the new version? The one that has all of this fixed: Off list, Sreekanth from LSI tested and noticed a few issues with this patch: -

Re: ATTO esas2r - Scsi_Host_template max_lun setting

2013-07-16 Thread James Bottomley
[please keep linux-scsi in the cc otherwise I'll lose the email] On Tue, 2013-07-16 at 10:05 -0400, Bradley Grove wrote: James, When we sent the first version of our driver code for comments, you suggested that we set max_lun in the host template and use that to enforce the lun limit.

Re: [Ksummit-2013-discuss] [ATTEND] scsi-mq prototype discussion

2013-07-16 Thread James Bottomley
On Tue, 2013-07-16 at 15:15 -0600, Jens Axboe wrote: On Tue, Jul 16 2013, Nicholas A. Bellinger wrote: On Sat, 2013-07-13 at 06:53 +, James Bottomley wrote: On Fri, 2013-07-12 at 12:52 +0200, Hannes Reinecke wrote: On 07/12/2013 03:33 AM, Nicholas A. Bellinger wrote: On Thu

Re: [PATCH 1/2] qla2xxx: Fix sparse warnings in qlafx00_fxdisc_iocb function.

2013-07-19 Thread James Bottomley
On Fri, 2013-07-12 at 14:47 -0400, Saurav Kashyap wrote: Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com This does not fix a bug ... therefore it's not really -rc fixes material. In early -rc this rule can be relaxed a bit

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-19 Thread James Bottomley
On Thu, 2013-07-18 at 23:34 -0700, Nicholas A. Bellinger wrote: diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 0101af5..191bc15 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1144,7 +1144,11 @@ static int ata_scsi_dev_config(struct

Re: [Ksummit-2013-discuss] [ATTEND] scsi-mq prototype discussion

2013-07-19 Thread James Bottomley
On Fri, 2013-07-19 at 14:22 -0700, Nicholas A. Bellinger wrote: On Wed, 2013-07-17 at 04:52 +, James Bottomley wrote: On Tue, 2013-07-16 at 15:15 -0600, Jens Axboe wrote: On Tue, Jul 16 2013, Nicholas A. Bellinger wrote: On Sat, 2013-07-13 at 06:53 +, James Bottomley wrote

Re: [PATCH v3 0/6] [SCSI] Enhanced sense and Unit Attention handling

2013-07-22 Thread James Bottomley
On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com This patch set adds changes to the SCSI mid-layer, sysfs and scsi_debug to provide enhanced support for Unit Attention conditions, as well as detection of a unit attention queue overflow condition

Re: [PATCH] mvsas: fix unaligned-access kernel panic under heavy disk testing

2013-07-23 Thread James Bottomley
On Tue, 2013-07-23 at 16:50 -0400, Chris Metcalf wrote: The slot-response value may not be aligned, so should be read using the appropriate kernel unaligned accessor. Hm, institutional memory re-presenting the wrong patch? However, I am reminded to push the right one in spite of no ack from

Re: [PATCH] mvsas: fix unaligned-access kernel panic under heavy disk testing

2013-07-23 Thread James Bottomley
On Tue, 2013-07-23 at 17:17 -0400, Chris Metcalf wrote: On 7/23/2013 5:00 PM, James Bottomley wrote: On Tue, 2013-07-23 at 16:50 -0400, Chris Metcalf wrote: The slot-response value may not be aligned, so should be read using the appropriate kernel unaligned accessor. Hm, institutional

Re: [PATCH] mvsas: fix unaligned-access kernel panic under heavy disk testing

2013-07-23 Thread James Bottomley
On Tue, 2013-07-23 at 18:40 -0400, Chris Metcalf wrote: On 7/23/2013 6:33 PM, James Bottomley wrote: On Tue, 2013-07-23 at 17:17 -0400, Chris Metcalf wrote: On 7/23/2013 5:00 PM, James Bottomley wrote: On Tue, 2013-07-23 at 16:50 -0400, Chris Metcalf wrote: The slot-response value may

Re: scsi scan: INQUIRY result too short (5), using 36

2013-07-24 Thread James Bottomley
On Wed, 2013-07-24 at 11:53 -0700, Tony Luck wrote: v3.10 used to boot on this machine, linus latest doesn't. git bisect points to this commit. commit e73823f7a2c921dcf068d34ea03bd682498d9e42 Author: James Bottomley jbottom...@parallels.com Date: Tue May 7 15:38:18 2013 -0700

Re: targetcli -fb now also Apache 2.0 licensed

2013-07-24 Thread James Bottomley
On Wed, 2013-07-24 at 13:09 -0700, Nicholas A. Bellinger wrote: On Tue, 2013-07-23 at 23:27 -0700, Andy Grover wrote: Hi Nick, I just wanted to let you know that I finally received permission from all contributors, and have matched RisingTide's relicensing of targetcli and its

Re: [PATCH 5/8][SCSI] mpt2sas: Infinite loop can occur if MPI2_IOCSTATUS_CONFIG_INVALID_PAGE is not returned

2013-07-25 Thread James Bottomley
On Thu, 2013-07-25 at 11:29 +0530, Sreekanth Reddy wrote: Infinite loop can occur if IOCStatus is not equal to MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions _scsih_search_responding_sas_devices, _scsih_search_responding_raid_devices and

[GIT PULL] SCSI fixes for 3.11-rc2

2013-07-27 Thread James Bottomley
is: Ewan D. Milne (1): sd: fix crash when UA received on DIF enabled device James Bottomley (2): isci: fix breakage caused by 16byte CDB patch mvsas: Fix kernel panic on tile due to unaligned data access Jeff Skirvin (1): isci: Fix a race condition in the SSP task management

Re: [PATCH 25/36] SCSI: sd: convert class code to use dev_groups

2013-07-30 Thread James Bottomley
On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: The dev_attrs field of struct class is going away soon, dev_groups should be used instead. This converts the scsi disk class code to use the correct field. It required some functions to be moved around to place the show and store

Re: [PATCH 26/36] SCSI: st: convert class code to use dev_groups

2013-07-30 Thread James Bottomley
Adding linux-scsi to cc. James On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: The dev_attrs field of struct class is going away soon, dev_groups should be used instead. This converts the scsi tape class code to use the correct field. Cc: Kai Mäkisara kai.makis...@kolumbus.fi

Re: [PATCH 25/36] SCSI: sd: convert class code to use dev_groups

2013-07-30 Thread James Bottomley
On Tue, 2013-07-30 at 12:01 -0700, Greg Kroah-Hartman wrote: On Tue, Jul 30, 2013 at 04:11:52PM +, James Bottomley wrote: On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: The dev_attrs field of struct class is going away soon, dev_groups should be used instead

Re: [PATCH v4 00/10] Enhanced Unit Attention handling

2013-08-02 Thread James Bottomley
On Thu, 2013-08-01 at 16:57 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com This patch set adds changes to the SCSI mid-layer, sysfs and scsi_debug to provide enhanced support for Unit Attention conditions. Well it doesn't really does it? As I see it, patches 1-6 are

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-02 Thread James Bottomley
On Thu, 2013-08-01 at 16:57 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com Generate a uevent when the following Unit Attention ASC/ASCQ codes are received: 2A/01 MODE PARAMETERS CHANGED 2A/09 CAPACITY DATA HAS CHANGED 38/07 THIN PROVISIONING SOFT

Re: [PATCH] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-05 Thread James Bottomley
On Mon, 2013-08-05 at 15:02 -0700, Roland Dreier wrote: From: Roland Dreier rol...@purestorage.com There is a nasty bug in the SCSI SG_IO ioctl that in some circumstances leads to one process writing data into the address space of some other random unrelated process if the ioctl is

Re: [PATCH] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-05 Thread James Bottomley
On Mon, 2013-08-05 at 16:38 -0700, Roland Dreier wrote: On Mon, Aug 5, 2013 at 4:31 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: I agree with the analysis. The fix is a bit draconian, though. A workqueue actually runs in a kernel thread and there's a simple test

Re: [PATCH] pm80xx: Fix for 32 bit compilation issue.

2013-08-07 Thread James Bottomley
On Wed, 2013-08-07 at 00:51 -0700, Anand wrote: From cc606631fae60a38ab9532bab79fd93523f4c579 Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Mon, 5 Aug 2013 14:16:52 +0530 Subject: [PATCH] pm80xx: Fix for 32 bit compilation issue. pm80xx driver does

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-08 Thread James Bottomley
On Thu, 2013-08-08 at 12:08 -0400, Ewan Milne wrote: On Fri, 2013-08-02 at 10:06 -0700, James Bottomley wrote: On Thu, 2013-08-01 at 16:57 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com + * scsi_report_lun_change - Set flag on all *other* devices on the same target

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-09 Thread James Bottomley
On Fri, 2013-08-09 at 10:50 -0400, Ewan Milne wrote: On Thu, 2013-08-08 at 18:15 -0700, James Bottomley wrote: OK, I'm fine either way, so I think we're good to go. I sent v5 yesterday. Let me know if you want a v6 with that SPC_3 test removed. (I'll be out next week, if you want to just

[GIT PULL] SCSI fixes for 3.11-rc4

2013-08-11 Thread James Bottomley
This is three bug fixes: An fnic warning caused by sleeping under a lock, a major regression with our updated WRITE SAME/UNMAP logic which caused tons of USB devices (and one RAID card) to cease to function and a megaraid_sas firmware initialisation problem which causes kdump failures. The patch

Re: [PATCH 1/1] cciss: set max scatter gather entries to 32 on P600

2013-08-14 Thread James Bottomley
On Wed, 2013-08-14 at 15:52 -0500, Mike Miller wrote: Patch 1/1 From: Mike Miller mike.mil...@hp.com At one time we used to set the maximum number of scatter gather elements on all Smart Array controllers to 32. At some point in time the firmware began to write the appropriate value for

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-19 Thread James Bottomley
On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: Hello, This patch adds scsi device failfast mode to avoid infinite retry loop. Currently, scsi error handling in scsi_decide_disposition() and scsi_io_completion() unconditionally retries on some errors. This is because retryable

Re: [PATCH 6/6] scsi_scan: Fixup scsilun_to_int()

2014-06-02 Thread James Bottomley
On Sat, 2014-05-31 at 11:01 +0200, Hannes Reinecke wrote: scsilun_to_int() has an error which prevents it from generating correct LUN numbers for 64bit values. Also we should remove the misleading comment about portions of the LUN being ignored; the initiator should treat the LUN as an opaque

Re: [PATCH 7/8] be2iscsi: Fix processing cqe for cxn whose endpoint is freed

2014-06-02 Thread James Bottomley
On Mon, 2014-06-02 at 12:33 -0700, h...@infradead.org wrote: On Mon, Jun 02, 2014 at 07:22:07PM +, James Bottomley wrote: Actually, can you really pull it out, not just revert it? Reverts cause problems with bisection and are unnecessary before the tree goes to Linus

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-04 Thread James Bottomley
On Wed, 2014-06-04 at 09:33 -0700, K. Y. Srinivasan wrote: Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the basic I/O timeout of the device. Fix this bug. Signed-off-by: K. Y. Srinivasan

Re: [PATCH] scsi: mpt2sas: mpt2sas_base.c: Cleaning up missing null-terminate after strncpy call

2014-06-04 Thread James Bottomley
On Wed, 2014-06-04 at 23:36 +0200, Rickard Strandqvist wrote: Added a guaranteed null-terminate after call to strncpy. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-06 Thread James Bottomley
On Fri, 2014-06-06 at 12:18 -0500, Mike Christie wrote: On 6/5/14, 9:53 PM, KY Srinivasan wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Thursday, June 5, 2014 6:33 PM To: KY Srinivasan Cc: James Bottomley; linux-ker...@vger.kernel.org

Re: [RFC Patch]: scsi: sysfs file cache_type not in sync with mode page

2014-06-06 Thread James Bottomley
On Fri, 2014-06-06 at 17:14 -0400, Pai wrote: Hi All, I noticed that the sysfs file cache_type is not is sync with the information in the mode page. If we change the WCE attribute in the mode page (sdparm --set=WCE /dev/sda and sdparm --clear=WCE /dev/sda) it does not reflect this in

Re: SCSI eats error from flush failure during hot plug

2014-06-07 Thread James Bottomley
On Thu, 2014-06-05 at 16:52 -0700, Steven Haber wrote: Hello, I am testing ATA device durability during hot unplug. I have a power fault test suite that has turned up issues with the fsync-SCSI-ATA codepath. If a device is unplugged while an fsync is in progress, ATA returns a flush error

[GIT PULL] First round of SCSI updates for the 3.15+ merge window

2014-06-09 Thread James Bottomley
This patch consists of the usual driver updates (qla2xxx, qla4xxx, lpfc, be2iscsi, fnic, ufs, NCR5380) The NCR5380 is the addition to maintained status of a long neglected driver for older hardware. In addition there are a lot of minor fixes and cleanups and some more updates to make scsi mq

Re: [PATCH 6/6] scsi_scan: Fixup scsilun_to_int()

2014-06-10 Thread James Bottomley
On Tue, 2014-06-10 at 16:48 +0200, Bart Van Assche wrote: On 06/10/14 16:06, James Bottomley wrote: On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote: On 06/03/14 10:58, Hannes Reinecke wrote: + * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function

Re: [Bug 77631] New: task scsi_eh_6:537 blocked for more than 120 seconds.

2014-06-10 Thread James Bottomley
From the trace below, this looks to be a USB issue (USB added to cc): the scsi error handler thread is waiting for usb storage to complete the reset. It's a 3.14.5 kernel, so the previous reset hang because of spurious sense requests should be fixed. James On Tue, 2014-06-10 at 16:50 +,

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread James Bottomley
On Tue, 2014-06-10 at 12:57 -0700, Nicholas A. Bellinger wrote: On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote: On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: On Tue, Jun 10, 2014 at

<    1   2   3   4   5   6   7   8   9   10   >