On Wed, 2014-06-11 at 05:01 -0700, Christoph Hellwig wrote:
After this first pull for the 3.16 merge window it seems like this
worked out fairly well - we got a large number of patches in, and all
reviewed by a second pair of eyes.
How should we go on from this? The drivers-for-3.16-2
On Thu, 2014-06-05 at 09:26 +0200, Hannes Reinecke wrote:
REPORT_LUN_SCAN does not report any outstanding unit attention
condition as per SAM. However, the target might not be fully
initialized at that time, so we might end up getting a
default entry (or even a partially filled one).
But as
On Wed, 2014-06-11 at 16:33 +0200, Hannes Reinecke wrote:
On 06/11/2014 04:24 PM, James Bottomley wrote:
On Thu, 2014-06-05 at 09:26 +0200, Hannes Reinecke wrote:
REPORT_LUN_SCAN does not report any outstanding unit attention
condition as per SAM. However, the target might not be fully
On Fri, 2014-06-13 at 15:39 +0200, Christoph Hellwig wrote:
On Thu, Jun 12, 2014 at 02:05:16PM -0700, Nicholas A. Bellinger wrote:
The first is with virtio-scsi between what has been merged in scsi.git
for virtio_scsi: use cmd_size, and the virtio-scsi: Enable DIF/DIX
modes in SCSI host LLD
On Fri, 2014-06-13 at 10:30 -0500, Brian King wrote:
On 05/27/2014 08:55 AM, Nathan Fontenot wrote:
On 05/23/2014 10:52 AM, Brian King wrote:
If a CRQ reset is triggered for some reason while in the middle
of performing VSCSI adapter initialization, we don't want to
call the done function
something with the command before we know block has
relinquished it. That's actually why this bug was so serious:
commit d555a2abf3481f81303d835046a5ec2c4fb3ca8e
Author: James Bottomley jbottom...@parallels.com
Date: Fri Mar 28 10:50:17 2014 -0700
[SCSI] Fix spurious request sense in error
On Fri, 2014-06-13 at 11:52 -0700, Christoph Hellwig wrote:
On Fri, Jun 13, 2014 at 10:58:22AM -0700, Venkatesh Srinivas wrote:
CC-ing stable as 3.14 and 3.15 are affected; a conservative fix is to
enable no_async_abort until the problem is better-understood.
No patch attached. Nevermind
On Fri, 2014-06-13 at 12:15 -0700, Venkatesh Srinivas wrote:
On Fri, Jun 13, 2014 at 12:09 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Fri, 2014-06-13 at 11:52 -0700, Christoph Hellwig wrote:
On Fri, Jun 13, 2014 at 10:58:22AM -0700, Venkatesh Srinivas wrote:
CC
On Fri, 2014-06-13 at 12:31 -0700, Greg KH wrote:
On Fri, Jun 13, 2014 at 12:18:25PM -0700, James Bottomley wrote:
On Fri, 2014-06-13 at 12:15 -0700, Venkatesh Srinivas wrote:
On Fri, Jun 13, 2014 at 12:09 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Fri, 2014
This is just a couple of drivers (hpsa and lpfc) that got left out for
further testing in linux-next. We also have one fix to a prior
submission (qla2xxx sparse).
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-for-linus
The short changelog is:
On Fri, 2014-06-13 at 19:50 -0700, Venkatesh Srinivas wrote:
On 6/13/14, James Bottomley james.bottom...@hansenpartnership.com wrote:
...
OK, I've no idea what's in distro kernels, so you're looking for this
fix:
commit d555a2abf3481f81303d835046a5ec2c4fb3ca8e
Author: James Bottomley
On Mon, 2014-06-16 at 15:30 -0400, bradley.gr...@gmail.com wrote:
From: Bradley Grove bgr...@attotech.com
During hibernation, the HBA firmware may lose power and forget the device
id info. This causes the HBA to reject IO upon resume. The fix is
to call the libsas power management
On Wed, 2014-06-11 at 06:37 -0700, Christoph Hellwig wrote:
On Mon, Jun 09, 2014 at 10:29:06AM -0700, James Bottomley wrote:
I'll do it as a bug fix, but I do need Jens to make sure nothing else
breaks first. Best I can tell, the state model for compound commands
like flush doesn't expect
On Sun, 2014-06-22 at 00:49 +0100, Al Viro wrote:
On Sat, Jun 21, 2014 at 07:09:22PM -0400, Theodore Ts'o wrote:
On Sat, Jun 21, 2014 at 06:53:07AM +0100, Al Viro wrote:
ed include/linux/uio.h EOF
/iov_iter_truncate/s/size_t/u64/
w
q
EOF
Could you check if that fixes
On Sun, 2014-06-22 at 01:26 +0100, Al Viro wrote:
On Sat, Jun 21, 2014 at 05:03:20PM -0700, James Bottomley wrote:
Anyway, does the following alone fix the problem you are seeing?
diff --git a/include/linux/uio.h b/include/linux/uio.h
index ddfdb53..dbb02d4 100644
--- a/include
On Sun, 2014-06-22 at 01:53 +0100, Al Viro wrote:
On Sat, Jun 21, 2014 at 05:32:44PM -0700, James Bottomley wrote:
No, we are not. Look:
* comparison promotes both operands to u64 here, so its result is
accurate, no matter how large count is. They are compared as natural
numbers
On Wed, 2014-06-25 at 06:13 -0700, Christoph Hellwig wrote:
On Thu, Jun 19, 2014 at 11:05:59AM -0700, James Bottomley wrote:
That's not really a good idea either ... I did think of it. We'll end
up with a cmd_type of REQ_TYPE_FS which because of REQ_FLUSH (or REQ_FUA
or REQ_DISCARD or any
On Thu, 2014-06-26 at 16:53 +0200, Bart Van Assche wrote:
On 06/11/14 11:09, Sagi Grimberg wrote:
+ return xfer_len + (xfer_len ilog2(sector_size)) * 8;
Sorry that I just noticed this now, but why is a shift-right and ilog2()
used in the above expression instead of just dividing the
On Thu, 2014-06-26 at 08:00 -0700, Christoph Hellwig wrote:
On Thu, Jun 26, 2014 at 10:02:47AM -0400, James Bottomley wrote:
Yes, but think what you're proposing. Every block command with a
special setup goes via scsi_setup_blk_pc_cmnd() because they usually
have to translate to something
On June 26, 2014 11:41:48 AM EDT, Atchley, Scott atchle...@ornl.gov wrote:
On Jun 26, 2014, at 10:55 AM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Thu, 2014-06-26 at 16:53 +0200, Bart Van Assche wrote:
On 06/11/14 11:09, Sagi Grimberg wrote:
+ return xfer_len
On Thu, 2014-06-26 at 08:08 -0700, Christoph Hellwig wrote:
On Thu, Jun 26, 2014 at 11:04:56AM -0400, James Bottomley wrote:
Right, but look what we do for the specials. The only difference is the
ULD has a hook to generate the CDB. For everything else we follow the
BLOCK_PC path
On Thu, 2014-06-26 at 08:02 -0700, Christoph Hellwig wrote:
Hi Steven,
can you test the patch below?
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index f7e3163..9b56e48 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -733,6 +733,14 @@ void
On Thu, 2014-06-26 at 21:06 -0400, Steven Rostedt wrote:
As this patch is in my 3.17 queue and it touches the kvm and scsi
tracepoint code, I figured I should at least do the courtesy of
notifying the maintainers of those subsystems.
Do you have any issues with this going through my tree? If
On Fri, 2014-06-27 at 17:34 +0200, Michael Büsch wrote:
I tried the following patch:
Index: linux/drivers/scsi/sd.c
===
--- linux.orig/drivers/scsi/sd.c 2014-06-26 18:40:39.214696552 +0200
+++ linux/drivers/scsi/sd.c
On Fri, 2014-06-27 at 15:23 -0400, Alan Stern wrote:
On Fri, 27 Jun 2014, Michael Büsch wrote:
On Fri, 27 Jun 2014 14:42:01 -0400 (EDT)
Alan Stern st...@rowland.harvard.edu wrote:
Michael, can you post the lsusb -v output for this device? I see it
is made by JMicron; they are
On Wed, 2014-07-02 at 17:44 -0500, Mike Christie wrote:
On 07/02/2014 05:15 PM, Alex Williamson wrote:
On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote:
3.15-stable review patch. If anyone has any objections, please let me
know.
--
From: Sagi
On Wed, 2014-07-02 at 23:05 -0700, Christoph Hellwig wrote:
On Wed, Jul 02, 2014 at 03:52:35PM -0700, James Bottomley wrote:
In which case it's not marked for stable backport ... I assume it should
be?
Only if the patch that regression went to stable, which it shouldn't,
Well it did
On Thu, 2014-07-03 at 09:33 -0700, Christoph Hellwig wrote:
On Thu, Jul 03, 2014 at 09:27:48AM -0700, Greg Kroah-Hartman wrote:
I copy everyone on the patch. You were not on that patch as it doesn't
look like it went through your tree at all.
It went through the target tree despite
This is a set of 13 fixes, a MAINTAINERS update and a sparse update.
The fixes are mostly correct value initialisations, avoiding NULL derefs
and some uninitialised pointer avoidance.
All the patches have been incubated in -next for a few days. The final
patch (use the scsi data buffer length to
On Wed, 2014-06-25 at 18:51 +0200, Christoph Hellwig wrote:
Avoid taking the queue_lock to check the per-device queue limit. Instead
we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Unlike the host and target busy
On Wed, 2014-07-09 at 19:52 +, KY Srinivasan wrote:
-Original Message-
From: Christoph Hellwig [mailto:h...@infradead.org]
Sent: Wednesday, July 9, 2014 1:43 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
oher...@suse.com;
On Wed, 2014-07-09 at 21:14 +, KY Srinivasan wrote:
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Wednesday, July 9, 2014 12:57 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; h...@infradead.org;
de...@linuxdriverproject.org
and a proper changelog.
James, can I get your signoff for this one? I'll throw it into the
core-for-3.16 tree then.
OK, here it is. I tweaked the comment to be accurate.
James
---
From 66aba46049037b55c5c77b45974a639f8f48b58b Mon Sep 17 00:00:00 2001
From: James Bottomley jbottom...@parallels.com
On Thu, 2014-07-10 at 21:02 +, KY Srinivasan wrote:
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Wednesday, July 9, 2014 3:27 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; m...@mkp.net; h...@infradead.org;
de
On Mon, 2014-07-14 at 11:22 +0200, Hannes Reinecke wrote:
On 07/14/2014 10:35 AM, Christoph Hellwig wrote:
Back when the mpt3sas driver was first posted I suggested that it should
be merged into mpt2sas, but my proposal didn't get much traction.
Illumos has now produced a shared driver
On Mon, 2014-07-14 at 16:39 +0200, Hannes Reinecke wrote:
On 07/14/2014 04:17 PM, James Bottomley wrote:
On Mon, 2014-07-14 at 11:22 +0200, Hannes Reinecke wrote:
On 07/14/2014 10:35 AM, Christoph Hellwig wrote:
Back when the mpt3sas driver was first posted I suggested that it should
On Wed, 2014-07-16 at 04:01 -0700, h...@infradead.org wrote:
On Sun, Jul 13, 2014 at 08:58:34AM -0400, Martin K. Petersen wrote:
KY == KY Srinivasan k...@microsoft.com writes:
KY Windows hosts do support UNMAP and set the field in the
KY EVPD. However, since the host advertises SPC-2
On Wed, 2014-07-16 at 13:47 -0400, Martin K. Petersen wrote:
Christoph == hch@infradead org h...@infradead.org writes:
Christoph Oh, we actually have devices that support WRITE SAME with
Christoph unmap, but not without? That's defintively a little strange.
Yep :(
There were several
On Wed, 2014-07-16 at 14:45 -0400, Martin K. Petersen wrote:
James == James Bottomley jbottom...@parallels.com writes:
I don't have a problem with a BLIST_PREFER_UNMAP flag or something
like that. But BLIST_TRY_VPD_PAGES seems more generally useful and it
does fix the problem at hand
On Wed, 2014-07-16 at 15:08 -0400, Martin K. Petersen wrote:
James == James Bottomley jbottom...@parallels.com writes:
James It's the code we identified in sd.c:read_capacity_16():
That's there to support devices that implement thin provisioning but
which predate the LBP VPD page
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
In sd_sync_cache:
rq-timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER;
Regardless of the baseline for the multiplication, a magic
number of 2 is too arbitrary. That might work for an
individual drive, but could be far
On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
What kernel coding style? checkpatch isn't the arbiter of style, if
that's the
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style
On Fri, 2014-07-18 at 16:44 +, KY Srinivasan wrote:
-Original Message-
From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org]
Sent: Friday, July 18, 2014 8:11 AM
To: KY Srinivasan
Cc: Jens Axboe; James Bottomley; micha...@cs.wisc.edu; Christoph Hellwig
to you?
Yes:
Reviewed-by: James Bottomley jbottom...@parallels.com
James
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage)
wrote:
From: James Bottomley [mailto:jbottom...@parallels.com]
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
...
Also, in both sd_setup_flush_cmnd and sd_sync_cache:
cmd
On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine
On Fri, 2014-07-18 at 22:01 +0200, poma wrote:
On 18.07.2014 16:17, Christoph Hellwig wrote:
On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote:
Slab warns, because the name of the cache being created contains spaces.
The bad cache is created by scsi_get_host_cmd_pool. Its
On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote:
Microsoft Hyper-V targets currently only claim SPC-2 compliance / no
compliance indicated even though they implement post SPC-2 features
which means those features are not tested for. Add a blacklist flag to
Hyper-V devices that forces
On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote:
The host devices without a parent were forcefully adopted
by platform bus. This patch removes this assignment. In
effect the dev_dev may be NULL now, which means ISA.
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc:
On Fri, 2014-07-25 at 16:47 +, KY Srinivasan wrote:
-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
Sent: Thursday, July 24, 2014 8:54 AM
To: Sitsofe Wheeler
Cc: Martin K. Petersen; Christoph Hellwig; KY Srinivasan;
On Sat, 2014-07-26 at 13:11 -0700, Greg Kroah-Hartman wrote:
On Fri, Jul 25, 2014 at 07:46:56AM -0700, James Bottomley wrote:
On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote:
The host devices without a parent were forcefully adopted
by platform bus. This patch removes this assignment
On Sat, 2014-07-26 at 18:21 +0200, Christoph Hellwig wrote:
Here's a formal one.
James, can I get your signoff for it?
Sure:
Signed-off-by: James Bottomley jbottom...@parallels.com
Vladimir, can I get a reviewed-by from you (or anyone else)?
---
From
On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote:
-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
Sent: Monday, July 28, 2014 12:03 PM
To: KY Srinivasan
Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig;
On Wed, 2014-07-30 at 17:33 +0530, Suresh Thiagarajan wrote:
From: Suresh Thiagarajan suresh.thiagara...@pmcs.com
The current implementation may mix the negative value returned
from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted
as bytes programmed, this patch fixes it.
On Wed, 2014-07-30 at 17:37 +0530, Suresh Thiagarajan wrote:
From: Suresh Thiagarajan suresh.thiagara...@pmcs.com
Update pmcs mail list for pm8001 driver support
Signed-off-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com
---
MAINTAINERS |1 +
1 files changed, 1 insertions(+), 0
On Wed, 2014-07-30 at 16:52 +0200, Christoph Hellwig wrote:
On Wed, Jul 30, 2014 at 08:21:35AM -0400, Josh Boyer wrote:
Thanks, I've update the author, added a Cc to ћtable and pushed it out to
the core-for-3.17 branch.
This fixes a bug in the 3.16 kernel. Why wouldn't it be sent to
On Thu, 2014-07-31 at 12:10 +0300, Dan Carpenter wrote:
[ This is not really a new bug, it's just that renaming the function
made it show up as a new bug and I figured maybe you know what's going
on since you are working with related code. -dan ]
Hello Douglas Gilbert,
This is a
On Wed, 2014-07-30 at 19:59 +0200, Christoph Hellwig wrote:
On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote:
Some drivers like qla2xxx do not set proc_name. I think if 2 drivers
like that are loaded then you will hit some other warns/bugs in the kmem
cache setup code right?
on failed barriers.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
James Bottomley (1):
scsi: handle flush errors properly
And the diffstat:
drivers/scsi/scsi_lib.c | 8
1 file changed, 8 insertions(+)
Full
On Fri, 2014-08-01 at 08:02 +0200, Juergen Gross wrote:
On 08/01/2014 07:41 AM, Juergen Gross wrote:
During test of Xen pvSCSI frontend module I found the following issue:
When unplugging a passed-through SCSI-device the SCSI Host is removed.
When calling the final scsi_host_put() from
On Fri, 2014-08-01 at 05:03 -0700, Christoph Hellwig wrote:
On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote:
From: Juergen Gross jgr...@suse.com
If a scsi host driver specifies .cmd_len in it's scsi_host_template, a
driver's
private command pool is needed.
On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote:
I've pushed out updates to both the core-for-3.17 and drivers-for-3.17
branches.
So I'm afraid we missed the last -next build on these, so they can't go
in with the early SCSI pull. I'm open to doing one mid merge window,
but Linus
On Fri, 2014-08-01 at 22:48 +0200, Jan Kara wrote:
Hello,
when debugging one bug, I've noticed one strangeness in
scsi_request_fn(). We enter it with interrupts disabled and queue_lock
held. In the function we do stuff like:
spin_unlock_irq(shost-host_lock);
On Mon, 2014-08-04 at 04:11 -0700, Christoph Hellwig wrote:
On Fri, Aug 01, 2014 at 04:32:01PM -0400, James Bottomley wrote:
On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote:
I've pushed out updates to both the core-for-3.17 and drivers-for-3.17
branches.
So I'm afraid we
On Mon, 2014-08-04 at 04:03 -0700, Christoph Hellwig wrote:
On Mon, Aug 04, 2014 at 06:22:59AM +0200, Juergen Gross wrote:
OTOH it would be possible to just delete .cmd_pool in the template when
deleting the pool. I'll send a patch doing this and you can decide
whether to take it or to use
: Restrict sequential scan to 256 LUNs
scsi: Remove CONFIG_SCSI_MULTI_LUN
Himangi Saraogi (1):
aic7xxx: Use kstrdup
James Bottomley (1):
scsi: use short driver name for per-driver cmd slab caches
Janusz Dziemidowicz (1):
scsi: do not issue SCSI RSOC command to Promise Vtrak
On Wed, 2014-08-06 at 12:39 +0200, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Delete NULL test on array (always false).
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@r@
type T;
T [] e;
On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote:
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 67283ef..62e276b 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1169,11 +1169,6 @@ static struct adpt_device*
On Thu, 2014-08-14 at 05:54 -0700, Christoph Hellwig wrote:
On Mon, Aug 04, 2014 at 07:20:04AM -0700, James Bottomley wrote:
The drivers side are a bunch of smaller fixes for iscsi and pm8001 which
never have been a problem to put in near the end of the merge window,
especially
On Fri, 2014-08-15 at 12:25 -0700, Christoph Hellwig wrote:
On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote:
So this is a bit late to get through linux-next and into a pull request.
I was planning on sending the final pull tomorrow (in case Linus planned
a surprise early
Just a note, we do have a couple of bug fixes coming under separate
cover, but they don't have to be part of the merge window
This is a small set of updates which missed the first pull. It's more
msix updates, some iscsi and qla4xxx fixes, we also have some string
null termination fixes a return
On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote:
3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test
machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc
53c1010 and all behave the same. Any ideas whre to dig deeper? bisection
might be nontrivial,
On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote:
On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote:
3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test
machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc
53c1010 and all behave the same. Any
On Tue, 2014-08-19 at 10:30 -0500, scame...@beardog.cce.hp.com wrote:
Is it permitted for a LLD to call scsi_done() for a command which
has been or is attempting to be aborted via the LLD abort error handler
function?
I am looking at the scsi mid layer code, and I'm a bit confused.
Hannes
These are the two bug fixes I mentioned in the final merge window pull.
One is a reversed logic check in the device busy tests which can cause a
nasty hang and another crash seen in the new SCSI pool support if the
use count ever goes to zero.
The patch is available here:
On Tue, 2014-08-19 at 23:17 +0300, Aaro Koskinen wrote:
Hi,
On Tue, Aug 19, 2014 at 09:47:35AM -0500, James Bottomley wrote:
On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote:
On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote:
3.16 scsi worked fine, 3.17-rc1 misbehaves on 3
On Wed, 2014-08-20 at 16:18 -0400, Dale R. Worley wrote:
I don't know if this is the correct place for this problem, but you
people can probably tell me the correct place.
linux-usb can probably also help (cc'd).
I have two USB to SATA adapter dongles. In general, they work fine.
However
On Fri, 2014-08-22 at 10:53 -0400, Alan Stern wrote:
On Thu, 21 Aug 2014, Christoph Hellwig wrote:
On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote:
Alan Okay, here's a patch that implements the suggestion, except that I
Alan put the flag in the Scsi_Host structure
. This is what I used to test our
submission and resubmission routines, but I haven't run it for a year or
so.
The final suggestion is that you need to make sure this patch is in
their environment:
commit c69e6f812bab0d5442b40e2f1bfbca48d40bc50b
Author: James Bottomley jbottom...@parallels.com
Date
On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote:
Il 25/08/2014 13:26, Hans de Goede ha scritto:
Thanks Bart and Paolo, your insights into this are greatly appreciated.
So with uas there are separate usb transaction for cmd, data in, data out
and sense for each tag. At the time of
On Mon, 2014-08-25 at 18:48 +, Alfredo Dal Ava Junior wrote:
On Mon, 25 Aug 2014, Alan Stern wrote:
Don't forget that lots of disks go crazy if you try to read from a
nonexistent
block, that is, one beyond the end of the disk.
IMO, this bug cannot be worked around in any
On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote:
James, can you explain how the INQUIRY command in scsi_probe_lun()
managed to work back in the days when multi-lun SCSI-2 devices were
common? sdev-scsi_level doesn't get set when sdev is allocated, so it
initially contains 0, so the LUN
On Mon, 2014-08-25 at 17:19 -0400, Alan Stern wrote:
On Mon, 25 Aug 2014, Alan Stern wrote:
On Mon, 25 Aug 2014, James Bottomley wrote:
On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote:
James, can you explain how the INQUIRY command in scsi_probe_lun()
managed to work
On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote:
On 08/26/2014 04:14 PM, David Vrabel wrote:
On 18/08/14 10:31, jgr...@suse.com wrote:
From: Juergen Gross jgr...@suse.com
Add myself as maintainer for the Xen pvSCSI stuff.
Signed-off-by: Juergen Gross jgr...@suse.com
---
On Tue, 2014-08-26 at 10:13 +0200, Hans de Goede wrote:
Hi,
On 08/25/2014 05:41 PM, James Bottomley wrote:
On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote:
Il 25/08/2014 13:26, Hans de Goede ha scritto:
Thanks Bart and Paolo, your insights into this are greatly appreciated.
So
On Tue, 2014-08-26 at 15:39 -0400, Dale R. Worley wrote:
This is almost certainly a form of the problem reported in
AS2105-based enclosure size issues with 2TB HDDs. I'm repeating my
original message here so linux-usb can see it, and so it can be
connected to the older thread. I'll address
On Wed, 2014-08-27 at 15:21 -0400, Dale R. Worley wrote:
From: James Bottomley james.bottom...@hansenpartnership.com
Did you try read capacity 16 on it? What happened? (the AS2105 rejects
read capacity 16, so there's no reliable way to deduce the capacity of
drives over 2TB).
OK, I
On Thu, 2014-08-28 at 14:37 +0200, Hans de Goede wrote:
Hi,
On 08/28/2014 02:33 PM, Paolo Bonzini wrote:
Il 28/08/2014 14:26, Hans de Goede ha scritto:
Then, blk_complete_request will do nothing because its call to
blk_mark_rq_complete returns true.
All this, of course, as long as
On Thu, 2014-08-28 at 14:21 +0200, Hans de Goede wrote:
Hi,
On 08/28/2014 02:04 PM, Hannes Reinecke wrote:
On 08/25/2014 01:15 PM, Paolo Bonzini wrote:
Il 25/08/2014 12:28, Bart Van Assche ha scritto:
From SPC-4: 7.5.8 Control mode page [ ... ] A task aborted status (TAS)
bit set to
On Fri, 2014-08-29 at 10:13 +0200, Hannes Reinecke wrote:
On 08/29/2014 09:39 AM, Bart Van Assche wrote:
On 08/29/14 08:19, Hannes Reinecke wrote:
On 08/29/2014 04:42 AM, Mike Christie wrote:
How are distros handling 0x6/0x3f/0x0e (report luns changed) when it
gets passed to userspace? Is
On Wed, 2014-09-03 at 16:30 -0400, Alan Stern wrote:
On Wed, 3 Sep 2014, James Bottomley wrote:
Before we embark on elaborate hacks, why don't we just make the capacity
writeable (by root) in sysfs from userspace (will require block change)?
We can then encode all the nasty heuristics
On Fri, 2014-09-05 at 09:31 -0400, James Smart wrote:
On 9/5/2014 1:35 AM, Christoph Hellwig wrote:
- patches that you send on with your maintainer hat on should be
signed off by you, not just reviewed.
ok - but I guess I had a different interpretation of the meaning for
signed-by.
On Mon, 2014-09-08 at 10:51 -0400, Alan Stern wrote:
On Sun, 7 Sep 2014, Shirish Pargaonkar wrote:
I think the problem is, when a gendisk is detached, its request queue
is not put in bypass mode
cause when it is re-attached, code tries to put it out of bypass mode,
hence the warning.
On Tue, 2014-09-09 at 10:10 +0900, Tejun Heo wrote:
Hello, Luis.
On Mon, Sep 08, 2014 at 06:04:23PM -0700, Luis R. Rodriguez wrote:
I have no idea how the selection should be. It could be per-insmod or
maybe just a system-wide flag with explicit exceptions marked on
drivers is good
On Tue, 2014-09-09 at 12:16 -0700, Luis R. Rodriguez wrote:
On Mon, Sep 8, 2014 at 10:38 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
If we want to sort out some sync/async mechanism for probing devices, as
an agreement between the init systems and the kernel, that's fine
On Wed, 2014-09-10 at 06:42 +0900, Tejun Heo wrote:
Hey, James.
On Tue, Sep 09, 2014 at 12:35:46PM -0700, James Bottomley wrote:
I don't have very strong views on this one. However, I've got to say
from a systems point of view that if the desire is to flag when the
module is having
On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo wrote:
Hello,
On Tue, Sep 09, 2014 at 03:26:02PM -0700, James Bottomley wrote:
We no longer report back error on probe failure on module load.
Yes, we do; for every probe failure of a device on a driver we'll print
a warning (see drivers
On Wed, 2014-09-10 at 12:07 +0200, Ceriel Jacobs wrote:
Tom Gundersen schreef op 10-09-14 om 08:46:
Indeed. What I proposed with a multiplier for the timeout for the
different types of built in commands was deemed complex but saw no
alternatives proposed despite my interest to work on one
On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote:
On Tuesday, September 09, 2014 03:46:23 PM James Bottomley wrote:
On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo wrote:
The thing is that we have to have dynamic mechanism to listen for
device attachments no matter what
301 - 400 of 2722 matches
Mail list logo
